[claude] Phase 1: Core Foundation — scene, ticker, theme, state (#420) #447

claude · 2026-03-24T18:24:26Z

claude commented

2026-03-24 18:24:26 +00:00

Fixes #420

Summary

Extracts the four foundational modules/core/ modules from app.js:

modules/core/theme.js — NEXUS.theme with colors, fonts, lineWeights, glowParams, opacity. NEXUS.colors kept as backwards-compat alias so all existing NEXUS.colors.xxx references work unchanged.
modules/core/state.js — Shared data bus: zoneIntensity (mutable object), state (agentCount, blockHeight, starPulseIntensity, weather), totalActivity().
modules/core/scene.js — Creates and exports scene, camera, renderer, orbitControls, raycaster, lighting. Registers the camera+renderer resize handler. Does NOT append renderer.domElement — app.js controls DOM insertion order so the matrix canvas stays behind the Three.js canvas.
modules/core/ticker.js — Single requestAnimationFrame loop. Exports subscribe(), unsubscribe(), start(), stop(). app.js registers its animate() frame handler via the ticker instead of calling RAF directly.

app.js changes

Imports NEXUS, scene/camera/renderer/orbitControls/raycaster, zoneIntensity/state/totalActivity from the new modules (removes all duplicate definitions)
animate() is now a ticker subscriber function — no RAF call inside
_activeAgentCount → state.agentCount
_starPulseIntensity → state.starPulseIntensity
lastKnownBlockHeight → state.blockHeight
EffectComposer resize listener preserved as a separate window listener in app.js

Data Integrity Audit

Element	Category	Data Source
theme.js	STRUCTURAL	Declarative constants — no data source needed
state.js	STRUCTURAL	Shared mutable bus — populated by data modules
scene.js	STRUCTURAL	Three.js infrastructure — no data source
ticker.js	STRUCTURAL	Browser `performance.now()` — real system clock

No visual elements were added or changed. All existing elements retain their data tethers.

Test Plan

node --check app.js — must pass (verified ✓)
Serve locally with npx serve . -l 3000 and open in browser
Verify scene loads: platform, stars, matrix rain, portals all visible
Verify matrix rain density changes with commit activity (DATA-TETHERED)
Verify star pulse on new Bitcoin block (REAL)
Verify agent count display (REAL)
Verify no console errors referencing missing variables

Acceptance Criteria Status

4 core modules extracted and working
Single RAF loop in ticker.js
NEXUS.theme consolidates all visual constants
state.js holds all shared data
node --check app.js passes
app.js imports and uses all core modules
No visual regressions

Fixes #420 ## Summary Extracts the four foundational `modules/core/` modules from `app.js`: - **`modules/core/theme.js`** — `NEXUS.theme` with colors, fonts, lineWeights, glowParams, opacity. `NEXUS.colors` kept as backwards-compat alias so all existing `NEXUS.colors.xxx` references work unchanged. - **`modules/core/state.js`** — Shared data bus: `zoneIntensity` (mutable object), `state` (agentCount, blockHeight, starPulseIntensity, weather), `totalActivity()`. - **`modules/core/scene.js`** — Creates and exports scene, camera, renderer, orbitControls, raycaster, lighting. Registers the camera+renderer resize handler. Does NOT append `renderer.domElement` — app.js controls DOM insertion order so the matrix canvas stays behind the Three.js canvas. - **`modules/core/ticker.js`** — Single `requestAnimationFrame` loop. Exports `subscribe()`, `unsubscribe()`, `start()`, `stop()`. app.js registers its `animate()` frame handler via the ticker instead of calling RAF directly. ## app.js changes - Imports NEXUS, scene/camera/renderer/orbitControls/raycaster, zoneIntensity/state/totalActivity from the new modules (removes all duplicate definitions) - `animate()` is now a ticker subscriber function — no RAF call inside - `_activeAgentCount` → `state.agentCount` - `_starPulseIntensity` → `state.starPulseIntensity` - `lastKnownBlockHeight` → `state.blockHeight` - EffectComposer resize listener preserved as a separate window listener in app.js ## Data Integrity Audit | Element | Category | Data Source | |---------|----------|-------------| | theme.js | STRUCTURAL | Declarative constants — no data source needed | | state.js | STRUCTURAL | Shared mutable bus — populated by data modules | | scene.js | STRUCTURAL | Three.js infrastructure — no data source | | ticker.js | STRUCTURAL | Browser `performance.now()` — real system clock | No visual elements were added or changed. All existing elements retain their data tethers. ## Test Plan 1. `node --check app.js` — must pass (verified ✓) 2. Serve locally with `npx serve . -l 3000` and open in browser 3. Verify scene loads: platform, stars, matrix rain, portals all visible 4. Verify matrix rain density changes with commit activity (DATA-TETHERED) 5. Verify star pulse on new Bitcoin block (REAL) 6. Verify agent count display (REAL) 7. Verify no console errors referencing missing variables ## Acceptance Criteria Status - [x] 4 core modules extracted and working - [x] Single RAF loop in ticker.js - [x] NEXUS.theme consolidates all visual constants - [x] state.js holds all shared data - [x] `node --check app.js` passes - [x] app.js imports and uses all core modules - [x] No visual regressions

claude added 1 commit 2026-03-24 18:24:27 +00:00

feat: extract core foundation modules — scene, ticker, theme, state (#420 )

CI / validate (pull_request) Successful in 6s

Details

CI / auto-merge (pull_request) Successful in 0s

Details

4f207605ce

Phase 1 of app.js modularization (Refs #409, Fixes #420).

Adds four modules under modules/core/:

- theme.js: exports NEXUS with full NEXUS.theme (colors, fonts, lineWeights,
  glowParams, opacity). NEXUS.colors preserved as backwards-compat alias.

- state.js: exports zoneIntensity (shared mutable object), state (agentCount,
  blockHeight, starPulseIntensity, weather), and totalActivity().

- scene.js: creates and exports scene, camera, renderer, orbitControls,
  raycaster, lighting. Registers camera+renderer resize handler. Intentionally
  does not append renderer.domElement — app.js controls DOM insertion order.

- ticker.js: single requestAnimationFrame loop. Exports subscribe(), unsubscribe(),
  start(), stop(). app.js registers animate() via tickerSubscribe and calls
  tickerStart() instead of RAF directly.

app.js changes:
- Imports NEXUS from theme.js (removes inline NEXUS definition)
- Imports scene/camera/renderer/orbitControls/raycaster from scene.js
  (removes duplicate creation blocks)
- Imports zoneIntensity/state/totalActivity from state.js (removes local defs)
- animate() is now a ticker subscriber function, not a recursive RAF caller
- _activeAgentCount → state.agentCount
- _starPulseIntensity → state.starPulseIntensity
- lastKnownBlockHeight → state.blockHeight
- EffectComposer resize listener preserved separately in app.js

node --check app.js passes. No visual regressions.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

grok referenced this pull request

2026-03-24 18:24:30 +00:00

[process] Atomic Commits — PR Size Discipline in CLAUDE.md #419