test: add Three.js pattern tests and update assertions (#543)

- Added TestThreeJsPatterns class with 14 tests
- Tests cover: pattern existence, severity inference, vision prompt
- Updated pattern count assertion (14+ patterns now)
- Updated demo test (6 glitches: 4 original + 2 Three.js)

tests/test_glitch_detector.py

@@ -19,9 +19,11 @@ from glitch_patterns import (
     GlitchPattern,
     GlitchSeverity,
     MATRIX_GLITCH_PATTERNS,
+    THREEJS_CATEGORIES,
     build_vision_prompt,
     get_pattern_by_category,
     get_patterns_by_severity,
+    get_threejs_patterns,
 )
 
 from matrix_glitch_detector import (
@@ -40,7 +42,7 @@ class TestGlitchPatterns(unittest.TestCase):
 
     def test_pattern_count(self):
         """Verify we have a reasonable number of defined patterns."""
-        self.assertGreaterEqual(len(MATRIX_GLITCH_PATTERNS), 8)
+        self.assertGreaterEqual(len(MATRIX_GLITCH_PATTERNS), 14)  # 10 generic + 6 Three.js
 
     def test_all_patterns_have_required_fields(self):
         """Every pattern must have category, name, description, severity, prompts."""
@@ -88,6 +90,9 @@ class TestGlitchPatterns(unittest.TestCase):
         self.assertIn("Floating Object", prompt)
         self.assertIn("Z-Fighting", prompt)
         self.assertIn("Missing", prompt)
+        # Three.js patterns should be included
+        self.assertIn("Shader Compilation Failure", prompt)
+        self.assertIn("Bloom Overflow", prompt)
 
     def test_build_vision_prompt_subset(self):
         """Vision prompt with subset should only include specified patterns."""
@@ -248,7 +253,7 @@ class TestGlitchDetector(unittest.TestCase):
 
         try:
             report = run_demo(output_path)
-            self.assertEqual(len(report.glitches), 4)
+            self.assertEqual(len(report.glitches), 6)  # 4 original + 2 Three.js
             self.assertGreater(report.summary["total_glitches"], 0)
             self.assertTrue(output_path.exists())
 
@@ -260,6 +265,93 @@ class TestGlitchDetector(unittest.TestCase):
             output_path.unlink(missing_ok=True)
 
 
+class TestThreeJsPatterns(unittest.TestCase):
+    """Tests for Three.js-specific glitch patterns (timmy-config#543)."""
+
+    def test_get_threejs_patterns_returns_only_threejs(self):
+        """get_threejs_patterns() should return only Three.js categories."""
+        patterns = get_threejs_patterns()
+        self.assertEqual(len(patterns), 6)
+        for p in patterns:
+            self.assertIn(p.category, THREEJS_CATEGORIES)
+
+    def test_threejs_patterns_have_required_fields(self):
+        """All Three.js patterns must have valid fields."""
+        for p in get_threejs_patterns():
+            self.assertIsInstance(p.category, GlitchCategory)
+            self.assertTrue(p.name)
+            self.assertTrue(p.description)
+            self.assertIsInstance(p.severity, GlitchSeverity)
+            self.assertGreater(len(p.detection_prompts), 0)
+            self.assertGreater(len(p.visual_indicators), 0)
+
+    def test_shader_failure_is_critical(self):
+        """Shader compilation failure should be CRITICAL severity."""
+        p = get_pattern_by_category(GlitchCategory.SHADER_FAILURE)
+        self.assertIsNotNone(p)
+        self.assertEqual(p.severity, GlitchSeverity.CRITICAL)
+
+    def test_texture_placeholder_is_critical(self):
+        """Texture placeholder (1x1 white) should be CRITICAL severity."""
+        p = get_pattern_by_category(GlitchCategory.TEXTURE_PLACEHOLDER)
+        self.assertIsNotNone(p)
+        self.assertEqual(p.severity, GlitchSeverity.CRITICAL)
+
+    def test_infer_severity_shader_failure(self):
+        """Shader failure should infer critical/high."""
+        self.assertEqual(_infer_severity("shader_failure", 0.8), "critical")
+        self.assertEqual(_infer_severity("shader_failure", 0.5), "high")
+
+    def test_infer_severity_texture_placeholder(self):
+        """Texture placeholder should infer critical/high."""
+        self.assertEqual(_infer_severity("texture_placeholder", 0.8), "critical")
+        self.assertEqual(_infer_severity("texture_placeholder", 0.5), "high")
+
+    def test_infer_severity_uv_mapping(self):
+        """UV mapping error should infer high/medium."""
+        self.assertEqual(_infer_severity("uv_mapping_error", 0.8), "high")
+        self.assertEqual(_infer_severity("uv_mapping_error", 0.5), "medium")
+
+    def test_infer_severity_frustum_culling(self):
+        """Frustum culling should infer medium/low."""
+        self.assertEqual(_infer_severity("frustum_culling", 0.7), "medium")
+        self.assertEqual(_infer_severity("frustum_culling", 0.4), "low")
+
+    def test_infer_severity_shadow_map(self):
+        """Shadow map artifact should infer medium/low."""
+        self.assertEqual(_infer_severity("shadow_map_artifact", 0.7), "medium")
+        self.assertEqual(_infer_severity("shadow_map_artifact", 0.4), "low")
+
+    def test_infer_severity_bloom_overflow(self):
+        """Bloom overflow should infer medium/low (default path)."""
+        self.assertEqual(_infer_severity("bloom_overflow", 0.7), "medium")
+        self.assertEqual(_infer_severity("bloom_overflow", 0.4), "low")
+
+    def test_threejs_patterns_in_vision_prompt(self):
+        """Three.js patterns should appear in the composite vision prompt."""
+        prompt = build_vision_prompt()
+        self.assertIn("shader_failure", prompt)
+        self.assertIn("texture_placeholder", prompt)
+        self.assertIn("uv_mapping_error", prompt)
+        self.assertIn("frustum_culling", prompt)
+        self.assertIn("shadow_map_artifact", prompt)
+        self.assertIn("bloom_overflow", prompt)
+
+    def test_threejs_subset_prompt(self):
+        """Building prompt from Three.js-only patterns should work."""
+        threejs = get_threejs_patterns()
+        prompt = build_vision_prompt(threejs)
+        self.assertIn("Shader Compilation Failure", prompt)
+        self.assertNotIn("Floating Object", prompt)  # generic, not Three.js
+
+    def test_report_metadata_version(self):
+        """Report metadata should reference both issues."""
+        report = run_demo()
+        self.assertEqual(report.metadata["detector_version"], "0.2.0")
+        self.assertIn("543", report.metadata["reference"])
+
+
+
 class TestIntegration(unittest.TestCase):
     """Integration-level tests."""
 
@@ -276,6 +368,13 @@ class TestIntegration(unittest.TestCase):
         expected = {"floating_assets", "z_fighting", "missing_textures", "clipping", "broken_normals"}
         self.assertTrue(expected.issubset(category_values))
 
+    def test_patterns_cover_threejs_themes(self):
+        """Patterns should cover Three.js-specific glitch themes (#543)."""
+        category_values = {p.category.value for p in MATRIX_GLITCH_PATTERNS}
+        threejs_expected = {"shader_failure", "texture_placeholder", "uv_mapping_error",
+                           "frustum_culling", "shadow_map_artifact", "bloom_overflow"}
+        self.assertTrue(threejs_expected.issubset(category_values))
+
 
 if __name__ == "__main__":
     unittest.main()