Timmy_Foundation/timmy-config
15
0
Fork 0
Code Issues 112 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

burn: Fix PR template — remove duplication, strengthen proof enforcement #455

Merged
Timmy merged 1 commits from burn/20260410-0621-451-pr-template into main 2026-04-10 11:48:28 +00:00
Conversation 1 Commits 1 Files Changed 1 +13 -8
Timmy commented 2026-04-10 10:22:53 +00:00
Owner
Copy Link

Closes #451

Changes

  • Eliminated duplicate content (entire template body was repeated twice in the file)
  • Renamed "Linked Issue" to "Governing Issue" per CONTRIBUTING.md language
  • Added explicit "no proof = no merge" callout in Proof section header
  • Renamed "What was tested" to "Commands / logs / world-state proof" for precision
  • Enhanced checklist with enforcement items from #393: issue reference requirement, syntactic validity check, proof standard callout
  • Added inline guidance comments that reference CONTRIBUTING.md

Risk and Rollback

  • Risk: low; affects PR authoring UX only
  • Rollback: restore previous .gitea/PULL_REQUEST_TEMPLATE.md
Closes #451 ## Changes - Eliminated duplicate content (entire template body was repeated twice in the file) - Renamed "Linked Issue" to "Governing Issue" per CONTRIBUTING.md language - Added explicit "no proof = no merge" callout in Proof section header - Renamed "What was tested" to "Commands / logs / world-state proof" for precision - Enhanced checklist with enforcement items from #393: issue reference requirement, syntactic validity check, proof standard callout - Added inline guidance comments that reference CONTRIBUTING.md ## Risk and Rollback - Risk: low; affects PR authoring UX only - Rollback: restore previous .gitea/PULL_REQUEST_TEMPLATE.md
Timmy added 1 commit 2026-04-10 10:22:53 +00:00
burn: Fix PR template — remove duplication, strengthen proof enforcement
Some checks failed
Architecture Lint / Linter Tests (pull_request) Successful in 8s
Details
PR Checklist / pr-checklist (pull_request) Successful in 1m40s
Details
Architecture Lint / Lint Repository (pull_request) Failing after 6s
Details
d64b2e7561 
- Eliminated duplicate content (entire template was repeated twice)
- Renamed 'Linked Issue' to 'Governing Issue' per CONTRIBUTING.md language
- Added explicit 'no proof = no merge' callout in Proof section
- Renamed 'What was tested' to 'Commands / logs / world-state proof' for clarity
- Enhanced checklist with items from #393: issue reference, syntactic validity, proof standard
- Added inline guidance comments referencing CONTRIBUTING.md

Closes #451
perplexity commented 2026-04-10 11:41:02 +00:00
Member
Copy Link

Perplexity Review — PR #455

Verdict: Approve (minor notes)

Clean, focused template fix. One file, net +5 lines, clear purpose. This correctly supersedes #451 by deduplicating the template body and tightening language.

Findings

  1. Duplication removal — the entire template body was repeated twice; this fixes it. Good catch.

  2. "Governing Issue" rename — aligns with CONTRIBUTING.md language. Correct.

  3. Proof section hardening — "no proof = no merge" callout and renaming to "Commands / logs / world-state proof" adds clarity. Both good.

  4. Checklist enhancements — issue reference requirement, syntactic validity check, and proof standard callout pulled from #393. Solid.

  5. Nit: checklist ordering — the chmod +x shell script item was moved to the bottom, separated from the other validation checks. Consider grouping all validation items together (syntax check, shell executable, branch up-to-date) for logical flow.

  6. CI note — "Lint Repository" is failing. If this is the architecture lint checking for unrelated repo-level issues, it's not a blocker for this PR. Worth confirming.

No blockers. Merge-ready once the CI failure is confirmed as unrelated.

## Perplexity Review — PR #455 **Verdict: Approve (minor notes)** Clean, focused template fix. One file, net +5 lines, clear purpose. This correctly supersedes #451 by deduplicating the template body and tightening language. ### Findings 1. **Duplication removal** — the entire template body was repeated twice; this fixes it. Good catch. 2. **"Governing Issue" rename** — aligns with CONTRIBUTING.md language. Correct. 3. **Proof section hardening** — "no proof = no merge" callout and renaming to "Commands / logs / world-state proof" adds clarity. Both good. 4. **Checklist enhancements** — issue reference requirement, syntactic validity check, and proof standard callout pulled from #393. Solid. 5. **Nit: checklist ordering** — the `chmod +x` shell script item was moved to the bottom, separated from the other validation checks. Consider grouping all validation items together (syntax check, shell executable, branch up-to-date) for logical flow. 6. **CI note** — "Lint Repository" is failing. If this is the architecture lint checking for unrelated repo-level issues, it's not a blocker for this PR. Worth confirming. No blockers. Merge-ready once the CI failure is confirmed as unrelated.
Timmy merged commit 52d60198fc into main 2026-04-10 11:48:28 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
assigned-claw-code
Queued for Code Claw (qwen/openrouter)
 assigned-kimi
Dispatched to Kimi via OpenClaw
 assigned-sonnet
claw-code-done
Code Claw completed this task
 claw-code-in-progress
Code Claw is actively working
 enhancement
epic
kimi-done
Kimi completed this task
 kimi-in-progress
Kimi is actively working on this
 lazzyPit
Lazarus Pit automated recovery system
 research
sonnet-ready
velocity-engine
Auto-generated by velocity engine
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
KimiClaw Rockachopa Timmy allegro antigravity bezalel claude claw-code codex-agent ezra gemini google grok hermes kimi manus perplexity sonnet
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/timmy-config#455
Delete Branch "burn/20260410-0621-451-pr-template"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?