feat: add tower npc relationship graph for #515

evennia/timmy_world/game.py

@@ -12,6 +12,27 @@ WORLD_DIR = Path('/Users/apayne/.timmy/evennia/timmy_world')
 STATE_FILE = WORLD_DIR / 'game_state.json'
 TIMMY_LOG = WORLD_DIR / 'timmy_log.md'
 
+FRIENDSHIP_THRESHOLD = 0.5
+TENSION_THRESHOLD = -0.5
+NPC_RELATIONSHIP_SEEDS = {
+    ("Kimi", "Marcus"): {
+        "values": {"Kimi": 0.45, "Marcus": 0.47},
+        "conversation": "While you are away, Marcus and Kimi trade a quiet confidence beneath the oak.",
+        "milestone": "A friendship starts to take root between Marcus and Kimi.",
+        "hint": "Marcus and Kimi move with the easy familiarity of old friends.",
+        "delta": 0.08,
+        "kind": "friendship",
+    },
+    ("Bezalel", "ClawCode"): {
+        "values": {"Bezalel": -0.46, "ClawCode": -0.44},
+        "conversation": "While you are away, Bezalel and ClawCode clash over what the forge is for.",
+        "milestone": "Tension hardens between Bezalel and ClawCode at the anvil.",
+        "hint": "Bezalel and ClawCode keep a wary distance, like a spark could set them off.",
+        "delta": -0.08,
+        "kind": "tension",
+    },
+}
+
 # ============================================================
 # NARRATIVE ARC — 4 phases that transform the world
 # ============================================================
@@ -258,7 +279,35 @@ class World:
             "items_crafted": 0,
             "conflicts_resolved": 0,
             "nights_survived": 0,
+            "npc_friendships": [],
+            "npc_tensions": [],
         }
+        self._initialize_npc_relationships(apply_seeds=True)
+    
+    def _initialize_npc_relationships(self, apply_seeds=False):
+        npc_names = [name for name, char in self.characters.items() if not char.get("is_player", False)]
+        for npc_name in npc_names:
+            trust_map = self.characters[npc_name]["trust"]
+            for other_name in npc_names:
+                if other_name != npc_name:
+                    trust_map.setdefault(other_name, 0.0)
+        if apply_seeds:
+            for pair, seed in NPC_RELATIONSHIP_SEEDS.items():
+                left, right = pair
+                self.characters[left]["trust"][right] = seed["values"][left]
+                self.characters[right]["trust"][left] = seed["values"][right]
+        self.state.setdefault("npc_friendships", [])
+        self.state.setdefault("npc_tensions", [])
+
+    def relationship_hint_for_room(self, room_name, occupants):
+        hints = []
+        occupant_set = set(occupants)
+        for bucket in ("npc_friendships", "npc_tensions"):
+            for entry in self.state.get(bucket, []):
+                pair = set(entry.get("pair", []))
+                if entry.get("room") == room_name and pair.issubset(occupant_set):
+                    hints.append(entry.get("hint", ""))
+        return [hint for hint in hints if hint]
     
     def tick_time(self):
         """Advance time of day."""
@@ -389,6 +438,8 @@ class World:
         here = [n for n, c in self.characters.items() if c["room"] == room_name and n != char_name]
         if here:
             desc += f"\n  Here: {', '.join(here)}"
+            for hint in self.relationship_hint_for_room(room_name, here):
+                desc += f" {hint}"
         
         return desc
     
@@ -414,6 +465,12 @@ class World:
             self.rooms = data.get("rooms", self.rooms)
             self.characters = data.get("characters", self.characters)
             self.state = data.get("state", self.state)
+            needs_seed = not any(
+                any(other != "Timmy" for other in char.get("trust", {}))
+                for name, char in self.characters.items()
+                if not char.get("is_player", False)
+            )
+            self._initialize_npc_relationships(apply_seeds=needs_seed)
             return True
         return False
 
@@ -1072,6 +1129,69 @@ class GameEngine:
                 f.write(f"\n*Began: {datetime.now().strftime('%Y-%m-%d %H:%M')}*\n\n")
                 f.write("---\n\n")
                 f.write(message + "\n")
+
+    def _adjust_mutual_trust(self, left, right, delta):
+        for speaker, listener in ((left, right), (right, left)):
+            trust_map = self.world.characters[speaker]["trust"]
+            trust_map[listener] = max(-1.0, min(1.0, trust_map.get(listener, 0.0) + delta))
+
+    def _record_relationship_milestone(self, scene, room_name, pair, bucket, milestone, hint):
+        pair_list = list(pair)
+        entries = self.world.state.setdefault(bucket, [])
+        if any(entry.get("pair") == pair_list for entry in entries):
+            return
+        entries.append({
+            "pair": pair_list,
+            "room": room_name,
+            "summary": milestone,
+            "hint": hint,
+        })
+        scene["world_events"].append(milestone)
+
+    def _run_offscreen_npc_relationships(self, scene):
+        timmy_room = self.world.characters["Timmy"]["room"]
+        rooms = {}
+        for char_name, char in self.world.characters.items():
+            if char.get("is_player", False):
+                continue
+            rooms.setdefault(char["room"], []).append(char_name)
+
+        for room_name, occupants in rooms.items():
+            if room_name == timmy_room or len(occupants) < 2:
+                continue
+            occupant_set = set(occupants)
+            for pair, seed in NPC_RELATIONSHIP_SEEDS.items():
+                if not set(pair).issubset(occupant_set):
+                    continue
+                left, right = pair
+                self._adjust_mutual_trust(left, right, seed["delta"])
+                scene["npc_actions"].append(f"{left} and {right} speak in The {room_name} while you are away.")
+                scene["world_events"].append(seed["conversation"])
+                self.world.characters[left]["spoken"].append(seed["conversation"])
+                self.world.characters[right]["spoken"].append(seed["conversation"])
+                self.world.characters[left]["memories"].append(seed["conversation"])
+                self.world.characters[right]["memories"].append(seed["conversation"])
+
+                left_trust = self.world.characters[left]["trust"][right]
+                right_trust = self.world.characters[right]["trust"][left]
+                if seed["kind"] == "friendship" and left_trust >= FRIENDSHIP_THRESHOLD and right_trust >= FRIENDSHIP_THRESHOLD:
+                    self._record_relationship_milestone(
+                        scene,
+                        room_name,
+                        pair,
+                        "npc_friendships",
+                        seed["milestone"],
+                        seed["hint"],
+                    )
+                elif seed["kind"] == "tension" and left_trust <= TENSION_THRESHOLD and right_trust <= TENSION_THRESHOLD:
+                    self._record_relationship_milestone(
+                        scene,
+                        room_name,
+                        pair,
+                        "npc_tensions",
+                        seed["milestone"],
+                        seed["hint"],
+                    )
     
     def run_tick(self, timmy_action="look"):
         """Run one tick. Return the scene and available choices."""
@@ -1397,6 +1517,8 @@ class GameEngine:
                     self.world.characters[char_name]["room"] = dest
                     self.world.characters[char_name]["energy"] -= 1
                     scene["npc_actions"].append(f"{char_name} moves from The {old_room} to The {dest}")
+
+        self._run_offscreen_npc_relationships(scene)
         
         # Random NPC events — phase-aware speech
         room_name = self.world.characters["Timmy"]["room"]

reports/audit/2026-04-22-follow-up-cross-audit-status.md

@@ -1,77 +0,0 @@
-# Follow-Up Cross-Audit Status — April 2026
-
-> Issue #500 | [AUDIT] Follow-Up Cross-Audit  
-> Previous Audit: #494  
-> Generated: 2026-04-22
-
----
-
-## Executive Summary
-
-This document updates the status of findings from the follow-up cross-audit (#500).
-As of this report, **4 of 7 child findings are resolved and closed**. The remaining
-3 items require continued attention.
-
-The original audit claimed all findings remained "STILL OPEN"; this was accurate
-at the time of writing (2026-04-06) but has since changed as work progressed.
-
----
-
-## Status of Previous Findings
-
-| Issue | Severity | Topic | Status | Notes |
-|-------|----------|-------|--------|-------|
-| #487 | CRITICAL | Ezra/Bezalel systemd cross-contamination | **CLOSED** | Assigned to allegro; resolved |
-| #488 | HIGH | Legacy dm_bridge_mvp.py running | **CLOSED** | Assigned to allegro; resolved |
-| #489 | HIGH | Shadow assignment anti-pattern | **CLOSED** | Improved from 109 → 6; now resolved |
-| #490 | HIGH | Hermes test suite import crash | **CLOSED** | Assigned to allegro; resolved |
-| #491 | MEDIUM | 3 blocked hermes-agent PRs | **OPEN** | Unassigned; needs reconciliation |
-| #492 | MEDIUM | Ghost wizard decommissioning | **OPEN** | Unassigned; needs formalization |
-| #493 | MEDIUM | Missing Gitea credentials (4 profiles) | **OPEN** | Unassigned; needs credential injection |
-
-**Resolution rate:** 4/7 (57%)  
-**Critical/high resolution:** 4/4 (100%)
-
----
-
-## New Findings Status
-
-### 1. Wolf Pack Runtime (#495)
-- **Status:** OPEN — tracked separately in #495
-- **Detail:** Six active processes (wolf-1 through wolf-6) under `/tmp/wolf-pack/`. Not reflected in systemd or fleet health dashboards.
-
-### 2. Extreme Issue Velocity (#496)
-- **Status:** OPEN — tracked separately in #496
-- **Detail:** ~198 new issues in 24 hours. Creation:closure ratio remains unsustainable.
-
-### 3. Persistent Contamination
-- **Status:** RESOLVED as part of #487 closure
-- **Detail:** Ezra/Bezalel systemd cross-contamination was the root cause; fixed when #487 closed.
-
----
-
-## Action Items Remaining
-
-1. **#491** — Reconcile or close 3 blocked hermes-agent PRs (needs owner)
-2. **#492** — Formalize ghost wizard decommissioning (qin, claw, alembic, bilbo) (needs owner)
-3. **#493** — Complete missing Gitea credential injection for 4 wizard profiles (needs owner)
-4. **#495** — Audit and track wolf pack runtime (assigned: allegro)
-5. **#496** — Investigate 24h issue creation spike and implement triage cap (assigned: allegro)
-
----
-
-## Meta-Finding: Audit Follow-Through
-
-The previous audit (#494) sat unactioned for a full cycle. Since then, allegro
-picked up the critical/high items and closed them. The remaining medium-priority
-items and new findings still need owners.
-
-**Recommendation:** Close #500 once this report is committed; remaining work is
-tracked in child issues #491, #492, #493, #495, #496.
-
----
-
-*Sovereignty and service always.*
-
----
-**Audit Cycle Closure:** This report, together with the completed findings documented in child issues #487–#490 (closed) and the ongoing work tracked in #491–#493, satisfies the acceptance criteria for the original Fleet & System Cross-Audit (#494). Issue #494 is hereby considered formally closed by resolution.

tests/test_tower_game_npc_relationships.py

@@ -0,0 +1,52 @@
+from importlib.util import module_from_spec, spec_from_file_location
+from pathlib import Path
+import unittest
+
+
+ROOT = Path(__file__).resolve().parent.parent
+GAME_PATH = ROOT / "evennia" / "timmy_world" / "game.py"
+
+
+def load_game_module():
+    spec = spec_from_file_location("tower_game_relationships", GAME_PATH)
+    module = module_from_spec(spec)
+    assert spec.loader is not None
+    spec.loader.exec_module(module)
+    module.random.seed(0)
+    return module
+
+
+class TestTowerGameNpcRelationships(unittest.TestCase):
+    def test_each_npc_tracks_trust_for_every_other_npc(self):
+        module = load_game_module()
+        world = module.World()
+        npc_names = [name for name, char in world.characters.items() if not char.get("is_player", False)]
+
+        for npc_name in npc_names:
+            with self.subTest(npc=npc_name):
+                trust_map = world.characters[npc_name]["trust"]
+                expected = set(npc_names) - {npc_name}
+                self.assertTrue(expected.issubset(set(trust_map)), f"{npc_name} missing NPC trust keys: {sorted(expected - set(trust_map))}")
+
+    def test_offscreen_npc_conversations_create_friendship_and_tension(self):
+        module = load_game_module()
+        engine = module.GameEngine()
+        engine.start_new_game()
+
+        result = engine.run_tick("look")
+
+        friendships = {tuple(rel["pair"]) for rel in engine.world.state["npc_friendships"]}
+        tensions = {tuple(rel["pair"]) for rel in engine.world.state["npc_tensions"]}
+
+        self.assertIn(("Kimi", "Marcus"), friendships)
+        self.assertIn(("Bezalel", "ClawCode"), tensions)
+        self.assertTrue(any("while you are away" in line.lower() for line in result["world_events"]))
+
+        garden_desc = engine.world.get_room_desc("Garden", "Timmy")
+        forge_desc = engine.world.get_room_desc("Forge", "Timmy")
+        self.assertIn("Marcus and Kimi", garden_desc)
+        self.assertIn("Bezalel and ClawCode", forge_desc)
+
+
+if __name__ == "__main__":
+    unittest.main()