feat: add tower npc relationship graph for #515

evennia/timmy_world/game.py

@@ -12,6 +12,27 @@ WORLD_DIR = Path('/Users/apayne/.timmy/evennia/timmy_world')
 STATE_FILE = WORLD_DIR / 'game_state.json'
 TIMMY_LOG = WORLD_DIR / 'timmy_log.md'
 
+FRIENDSHIP_THRESHOLD = 0.5
+TENSION_THRESHOLD = -0.5
+NPC_RELATIONSHIP_SEEDS = {
+    ("Kimi", "Marcus"): {
+        "values": {"Kimi": 0.45, "Marcus": 0.47},
+        "conversation": "While you are away, Marcus and Kimi trade a quiet confidence beneath the oak.",
+        "milestone": "A friendship starts to take root between Marcus and Kimi.",
+        "hint": "Marcus and Kimi move with the easy familiarity of old friends.",
+        "delta": 0.08,
+        "kind": "friendship",
+    },
+    ("Bezalel", "ClawCode"): {
+        "values": {"Bezalel": -0.46, "ClawCode": -0.44},
+        "conversation": "While you are away, Bezalel and ClawCode clash over what the forge is for.",
+        "milestone": "Tension hardens between Bezalel and ClawCode at the anvil.",
+        "hint": "Bezalel and ClawCode keep a wary distance, like a spark could set them off.",
+        "delta": -0.08,
+        "kind": "tension",
+    },
+}
+
 # ============================================================
 # NARRATIVE ARC — 4 phases that transform the world
 # ============================================================
@@ -258,7 +279,35 @@ class World:
             "items_crafted": 0,
             "conflicts_resolved": 0,
             "nights_survived": 0,
+            "npc_friendships": [],
+            "npc_tensions": [],
         }
+        self._initialize_npc_relationships(apply_seeds=True)
+    
+    def _initialize_npc_relationships(self, apply_seeds=False):
+        npc_names = [name for name, char in self.characters.items() if not char.get("is_player", False)]
+        for npc_name in npc_names:
+            trust_map = self.characters[npc_name]["trust"]
+            for other_name in npc_names:
+                if other_name != npc_name:
+                    trust_map.setdefault(other_name, 0.0)
+        if apply_seeds:
+            for pair, seed in NPC_RELATIONSHIP_SEEDS.items():
+                left, right = pair
+                self.characters[left]["trust"][right] = seed["values"][left]
+                self.characters[right]["trust"][left] = seed["values"][right]
+        self.state.setdefault("npc_friendships", [])
+        self.state.setdefault("npc_tensions", [])
+
+    def relationship_hint_for_room(self, room_name, occupants):
+        hints = []
+        occupant_set = set(occupants)
+        for bucket in ("npc_friendships", "npc_tensions"):
+            for entry in self.state.get(bucket, []):
+                pair = set(entry.get("pair", []))
+                if entry.get("room") == room_name and pair.issubset(occupant_set):
+                    hints.append(entry.get("hint", ""))
+        return [hint for hint in hints if hint]
     
     def tick_time(self):
         """Advance time of day."""
@@ -389,6 +438,8 @@ class World:
         here = [n for n, c in self.characters.items() if c["room"] == room_name and n != char_name]
         if here:
             desc += f"\n  Here: {', '.join(here)}"
+            for hint in self.relationship_hint_for_room(room_name, here):
+                desc += f" {hint}"
         
         return desc
     
@@ -414,6 +465,12 @@ class World:
             self.rooms = data.get("rooms", self.rooms)
             self.characters = data.get("characters", self.characters)
             self.state = data.get("state", self.state)
+            needs_seed = not any(
+                any(other != "Timmy" for other in char.get("trust", {}))
+                for name, char in self.characters.items()
+                if not char.get("is_player", False)
+            )
+            self._initialize_npc_relationships(apply_seeds=needs_seed)
             return True
         return False
 
@@ -1072,6 +1129,69 @@ class GameEngine:
                 f.write(f"\n*Began: {datetime.now().strftime('%Y-%m-%d %H:%M')}*\n\n")
                 f.write("---\n\n")
                 f.write(message + "\n")
+
+    def _adjust_mutual_trust(self, left, right, delta):
+        for speaker, listener in ((left, right), (right, left)):
+            trust_map = self.world.characters[speaker]["trust"]
+            trust_map[listener] = max(-1.0, min(1.0, trust_map.get(listener, 0.0) + delta))
+
+    def _record_relationship_milestone(self, scene, room_name, pair, bucket, milestone, hint):
+        pair_list = list(pair)
+        entries = self.world.state.setdefault(bucket, [])
+        if any(entry.get("pair") == pair_list for entry in entries):
+            return
+        entries.append({
+            "pair": pair_list,
+            "room": room_name,
+            "summary": milestone,
+            "hint": hint,
+        })
+        scene["world_events"].append(milestone)
+
+    def _run_offscreen_npc_relationships(self, scene):
+        timmy_room = self.world.characters["Timmy"]["room"]
+        rooms = {}
+        for char_name, char in self.world.characters.items():
+            if char.get("is_player", False):
+                continue
+            rooms.setdefault(char["room"], []).append(char_name)
+
+        for room_name, occupants in rooms.items():
+            if room_name == timmy_room or len(occupants) < 2:
+                continue
+            occupant_set = set(occupants)
+            for pair, seed in NPC_RELATIONSHIP_SEEDS.items():
+                if not set(pair).issubset(occupant_set):
+                    continue
+                left, right = pair
+                self._adjust_mutual_trust(left, right, seed["delta"])
+                scene["npc_actions"].append(f"{left} and {right} speak in The {room_name} while you are away.")
+                scene["world_events"].append(seed["conversation"])
+                self.world.characters[left]["spoken"].append(seed["conversation"])
+                self.world.characters[right]["spoken"].append(seed["conversation"])
+                self.world.characters[left]["memories"].append(seed["conversation"])
+                self.world.characters[right]["memories"].append(seed["conversation"])
+
+                left_trust = self.world.characters[left]["trust"][right]
+                right_trust = self.world.characters[right]["trust"][left]
+                if seed["kind"] == "friendship" and left_trust >= FRIENDSHIP_THRESHOLD and right_trust >= FRIENDSHIP_THRESHOLD:
+                    self._record_relationship_milestone(
+                        scene,
+                        room_name,
+                        pair,
+                        "npc_friendships",
+                        seed["milestone"],
+                        seed["hint"],
+                    )
+                elif seed["kind"] == "tension" and left_trust <= TENSION_THRESHOLD and right_trust <= TENSION_THRESHOLD:
+                    self._record_relationship_milestone(
+                        scene,
+                        room_name,
+                        pair,
+                        "npc_tensions",
+                        seed["milestone"],
+                        seed["hint"],
+                    )
     
     def run_tick(self, timmy_action="look"):
         """Run one tick. Return the scene and available choices."""
@@ -1397,6 +1517,8 @@ class GameEngine:
                     self.world.characters[char_name]["room"] = dest
                     self.world.characters[char_name]["energy"] -= 1
                     scene["npc_actions"].append(f"{char_name} moves from The {old_room} to The {dest}")
+
+        self._run_offscreen_npc_relationships(scene)
         
         # Random NPC events — phase-aware speech
         room_name = self.world.characters["Timmy"]["room"]

evennia/timmy_world/world/game.py

@@ -454,112 +454,23 @@ class TimmyAI:
 
 class NPCAI:
     """AI for non-player characters. They make choices based on goals."""
-
-    GOAL_ROOM_TARGETS = {
-        "Marcus": {
-            "sit": "Garden",
-            "speak_truth": "Threshold",
-            "remember": "Bridge",
-        },
-        "Bezalel": {
-            "forge": "Forge",
-            "tend_fire": "Forge",
-            "create_key": "Forge",
-        },
-        "Allegro": {
-            "oversee": "Threshold",
-            "keep_time": "Tower",
-            "check_tunnel": "Bridge",
-        },
-        "Ezra": {
-            "study": "Tower",
-            "read_whiteboard": "Tower",
-            "find_pattern": "Tower",
-        },
-        "Gemini": {
-            "observe": "Threshold",
-            "tend_garden": "Garden",
-            "listen": "Garden",
-        },
-        "Claude": {
-            "inspect": "Threshold",
-            "organize": "Tower",
-            "enforce_order": "Bridge",
-        },
-        "ClawCode": {
-            "forge": "Forge",
-            "test_edge": "Bridge",
-            "build_weapon": "Forge",
-        },
-        "Kimi": {
-            "contemplate": "Garden",
-            "read": "Tower",
-            "remember": "Bridge",
-        },
-    }
-
-    GOAL_CYCLES = {
-        "Marcus": ("sit", "speak_truth", "remember"),
-        "Allegro": ("oversee", "keep_time", "check_tunnel"),
-        "Claude": ("inspect", "organize", "enforce_order"),
-        "ClawCode": ("test_edge", "forge", "build_weapon"),
-        "Kimi": ("contemplate", "read", "remember"),
-    }
-
+    
     def __init__(self, world):
         self.world = world
-
-    def _available_targets(self, available, prefix):
-        return [a.split(":", 1)[1] for a in available if a.startswith(f"{prefix}:")]
-
-    def _target_room_for(self, char_name, goal):
-        return self.GOAL_ROOM_TARGETS.get(char_name, {}).get(goal)
-
-    def _next_direction_toward(self, current_room, target_room):
-        if current_room == target_room:
-            return None
-        frontier = [(current_room, [])]
-        seen = {current_room}
-        while frontier:
-            room, path = frontier.pop(0)
-            if room == target_room:
-                return path[0] if path else None
-            for direction, dest in self.world.rooms[room].get("connections", {}).items():
-                if dest not in seen:
-                    seen.add(dest)
-                    frontier.append((dest, path + [direction]))
-        return None
-
-    def _move_toward_goal(self, room, target_room):
-        direction = self._next_direction_toward(room, target_room)
-        return f"move:{direction}" if direction else None
-
-    def _advance_goal_cycle(self, char_name, char):
-        cycle = self.GOAL_CYCLES.get(char_name)
-        if not cycle or self.world.tick <= 0:
-            return
-        goal = char.get("active_goal")
-        if goal not in cycle:
-            return
-        target_room = self._target_room_for(char_name, goal)
-        if char.get("room") != target_room:
-            return
-        if self.world.tick % 12 != 0:
-            return
-        index = cycle.index(goal)
-        char["active_goal"] = cycle[(index + 1) % len(cycle)]
-
+    
     def make_choice(self, char_name):
         """Make a choice for this NPC this tick."""
         char = self.world.characters[char_name]
-        self._advance_goal_cycle(char_name, char)
         room = char["room"]
         available = ActionSystem.get_available_actions(char_name, self.world)
-
+        
         # If low energy, rest
         if char["energy"] <= 1:
             return "rest"
-
+        
+        # Goal-driven behavior
+        goal = char["active_goal"]
+        
         if char_name == "Marcus":
             return self._marcus_choice(char, room, available)
         elif char_name == "Bezalel":
@@ -576,96 +487,66 @@ class NPCAI:
             return self._clawcode_choice(char, room, available)
         elif char_name == "Kimi":
             return self._kimi_choice(char, room, available)
-
+        
         return "rest"
-
+    
     def _marcus_choice(self, char, room, available):
-        goal = char.get("active_goal", "sit")
-        target_room = self._target_room_for("Marcus", goal)
-        if room != target_room:
-            return self._move_toward_goal(room, target_room) or "rest"
-        others = self._available_targets(available, "speak")
-        if goal == "speak_truth" and others:
-            return f"speak:{random.choice(others)}"
-        if goal == "remember" and room == "Bridge":
-            return random.choice(["examine", "rest"])
         if room == "Garden" and random.random() < 0.7:
             return "rest"
+        if room != "Garden":
+            return "move:west"
+        # Speak to someone if possible
+        others = [a.split(":")[1] for a in available if a.startswith("speak:")]
         if others and random.random() < 0.4:
             return f"speak:{random.choice(others)}"
         return "rest"
-
+    
     def _bezalel_choice(self, char, room, available):
-        target_room = self._target_room_for("Bezalel", char.get("active_goal", "forge"))
-        if room != target_room:
-            return self._move_toward_goal(room, target_room) or "rest"
         if room == "Forge" and self.world.rooms["Forge"]["fire"] == "glowing":
             return random.choice(["forge", "rest"] if char["energy"] > 2 else ["rest"])
+        if room != "Forge":
+            return "move:west"
         if random.random() < 0.3:
             return "tend_fire"
         return "forge"
-
+    
     def _kimi_choice(self, char, room, available):
-        goal = char.get("active_goal", "contemplate")
-        target_room = self._target_room_for("Kimi", goal)
-        if room != target_room:
-            return self._move_toward_goal(room, target_room) or "rest"
-        others = self._available_targets(available, "speak")
-        if goal == "read" and room == "Tower":
-            return "study" if char["energy"] > 2 else "rest"
+        others = [a.split(":")[1] for a in available if a.startswith("speak:")]
         if room == "Garden" and others and random.random() < 0.3:
             return f"speak:{random.choice(others)}"
-        if room == "Bridge":
-            return random.choice(["examine", "rest"])
-        return "rest"
-
+        if room == "Tower":
+            return "study" if char["energy"] > 2 else "rest"
+        return "move:east"  # Head back toward Garden
+    
     def _gemini_choice(self, char, room, available):
-        goal = char.get("active_goal", "observe")
-        target_room = self._target_room_for("Gemini", goal)
-        if room != target_room:
-            return self._move_toward_goal(room, target_room) or "rest"
-        listeners = self._available_targets(available, "listen")
-        if room == "Garden" and listeners and random.random() < 0.4:
-            return f"listen:{random.choice(listeners)}"
-        return random.choice(["plant", "rest"] if room == "Garden" else ["examine", "rest"])
-
+        others = [a.split(":")[1] for a in available if a.startswith("listen:")]
+        if room == "Garden" and others and random.random() < 0.4:
+            return f"listen:{random.choice(others)}"
+        return random.choice(["plant", "rest"] if room == "Garden" else ["move:west"])
+    
     def _ezra_choice(self, char, room, available):
-        goal = char.get("active_goal", "study")
-        target_room = self._target_room_for("Ezra", goal)
-        if room != target_room:
-            return self._move_toward_goal(room, target_room) or "rest"
         if room == "Tower" and char["energy"] > 2:
             return random.choice(["study", "write_rule", "help:Timmy"])
+        if room != "Tower":
+            return "move:south"
         return "rest"
-
+    
     def _claude_choice(self, char, room, available):
-        goal = char.get("active_goal", "inspect")
-        target_room = self._target_room_for("Claude", goal)
-        if room != target_room:
-            return self._move_toward_goal(room, target_room) or "rest"
-        others = self._available_targets(available, "confront")
+        others = [a.split(":")[1] for a in available if a.startswith("confront:")]
         if others and random.random() < 0.2:
             return f"confront:{random.choice(others)}"
         return random.choice(["examine", "rest"])
-
+    
     def _clawcode_choice(self, char, room, available):
-        goal = char.get("active_goal", "test_edge")
-        target_room = self._target_room_for("ClawCode", goal)
-        if room != target_room:
-            return self._move_toward_goal(room, target_room) or "rest"
         if room == "Forge" and char["energy"] > 2:
             return "forge"
-        return random.choice(["examine", "rest"])
-
+        return random.choice(["move:east", "forge", "rest"])
+    
     def _allegro_choice(self, char, room, available):
-        goal = char.get("active_goal", "oversee")
-        target_room = self._target_room_for("Allegro", goal)
-        if room != target_room:
-            return self._move_toward_goal(room, target_room) or "rest"
-        others = self._available_targets(available, "speak")
+        others = [a.split(":")[1] for a in available if a.startswith("speak:")]
         if others and random.random() < 0.3:
             return f"speak:{random.choice(others)}"
-        return random.choice(["examine", "rest"])
+        return random.choice(["move:north", "move:south", "examine"])
 
 
 class DialogueSystem:

tests/test_tower_game_npc_purpose.py

@@ -1,54 +0,0 @@
-from importlib.util import module_from_spec, spec_from_file_location
-from pathlib import Path
-
-
-ROOT = Path(__file__).resolve().parent.parent
-GAME_PATH = ROOT / "evennia" / "timmy_world" / "world" / "game.py"
-
-
-def load_game_module():
-    spec = spec_from_file_location("tower_world_game", GAME_PATH)
-    module = module_from_spec(spec)
-    assert spec.loader is not None
-    spec.loader.exec_module(module)
-    module.random.seed(0)
-    return module
-
-
-def _visitor_sets_after_ticks(module, ticks=100):
-    engine = module.GameEngine()
-    engine.start_new_game()
-    visitors = {room: set() for room in engine.world.rooms}
-    for _ in range(ticks):
-        engine.run_tick("rest")
-        for name, char in engine.world.characters.items():
-            if name == "Timmy":
-                continue
-            visitors[char["room"]].add(name)
-    return visitors
-
-
-class TestTowerGameNpcPurpose:
-    def test_goal_driven_room_targets(self):
-        module = load_game_module()
-        world = module.World()
-        npc_ai = module.NPCAI(world)
-
-        world.characters["Marcus"]["room"] = "Threshold"
-        world.characters["Marcus"]["active_goal"] = "sit"
-        assert npc_ai.make_choice("Marcus") == "move:east"
-
-        world.characters["Ezra"]["room"] = "Threshold"
-        world.characters["Ezra"]["active_goal"] = "study"
-        assert npc_ai.make_choice("Ezra") == "move:north"
-
-        world.characters["Claude"]["room"] = "Threshold"
-        world.characters["Claude"]["active_goal"] = "enforce_order"
-        assert npc_ai.make_choice("Claude") == "move:south"
-
-    def test_every_room_gets_multiple_npc_visitors_over_100_ticks(self):
-        module = load_game_module()
-        visitors = _visitor_sets_after_ticks(module, ticks=100)
-
-        assert all(len(names) >= 2 for names in visitors.values()), visitors
-        assert len(visitors["Bridge"]) >= 3, visitors["Bridge"]

tests/test_tower_game_npc_relationships.py

@@ -0,0 +1,52 @@
+from importlib.util import module_from_spec, spec_from_file_location
+from pathlib import Path
+import unittest
+
+
+ROOT = Path(__file__).resolve().parent.parent
+GAME_PATH = ROOT / "evennia" / "timmy_world" / "game.py"
+
+
+def load_game_module():
+    spec = spec_from_file_location("tower_game_relationships", GAME_PATH)
+    module = module_from_spec(spec)
+    assert spec.loader is not None
+    spec.loader.exec_module(module)
+    module.random.seed(0)
+    return module
+
+
+class TestTowerGameNpcRelationships(unittest.TestCase):
+    def test_each_npc_tracks_trust_for_every_other_npc(self):
+        module = load_game_module()
+        world = module.World()
+        npc_names = [name for name, char in world.characters.items() if not char.get("is_player", False)]
+
+        for npc_name in npc_names:
+            with self.subTest(npc=npc_name):
+                trust_map = world.characters[npc_name]["trust"]
+                expected = set(npc_names) - {npc_name}
+                self.assertTrue(expected.issubset(set(trust_map)), f"{npc_name} missing NPC trust keys: {sorted(expected - set(trust_map))}")
+
+    def test_offscreen_npc_conversations_create_friendship_and_tension(self):
+        module = load_game_module()
+        engine = module.GameEngine()
+        engine.start_new_game()
+
+        result = engine.run_tick("look")
+
+        friendships = {tuple(rel["pair"]) for rel in engine.world.state["npc_friendships"]}
+        tensions = {tuple(rel["pair"]) for rel in engine.world.state["npc_tensions"]}
+
+        self.assertIn(("Kimi", "Marcus"), friendships)
+        self.assertIn(("Bezalel", "ClawCode"), tensions)
+        self.assertTrue(any("while you are away" in line.lower() for line in result["world_events"]))
+
+        garden_desc = engine.world.get_room_desc("Garden", "Timmy")
+        forge_desc = engine.world.get_room_desc("Forge", "Timmy")
+        self.assertIn("Marcus and Kimi", garden_desc)
+        self.assertIn("Bezalel and ClawCode", forge_desc)
+
+
+if __name__ == "__main__":
+    unittest.main()