Compare commits
1 Commits
fix/528
...
sprint/iss
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
5a7ee7a5f2 |
@@ -1,74 +0,0 @@
|
||||
# LAB-003 — Truck Battery Disconnect Install Packet
|
||||
|
||||
No battery disconnect switch has been purchased or installed yet.
|
||||
This packet turns the issue into a field-ready purchase / install / validation checklist while preserving what still requires live work.
|
||||
|
||||
## Candidate Store Run
|
||||
|
||||
- AutoZone — Newport or Claremont
|
||||
- Advance Auto Parts — Newport or Claremont
|
||||
- O'Reilly Auto Parts — Newport or Claremont
|
||||
|
||||
## Required Items
|
||||
|
||||
- battery terminal disconnect switch
|
||||
- terminal shim/post riser if needed
|
||||
|
||||
## Selection Criteria
|
||||
|
||||
- Fits the truck battery post without forcing the clamp
|
||||
- Mounts on the negative battery terminal
|
||||
- Physically secure once tightened
|
||||
- no special tools required to operate
|
||||
|
||||
## Live Purchase State
|
||||
|
||||
- Store selected: pending
|
||||
- Part selected: pending
|
||||
- Part cost: pending purchase
|
||||
|
||||
## Installation Target
|
||||
|
||||
- Install location: negative battery terminal
|
||||
- Ready to operate without tools: yes
|
||||
|
||||
## Install Checklist
|
||||
|
||||
- [ ] Verify the truck is off and keys are removed before touching the battery
|
||||
- [ ] Confirm the disconnect fits the negative battery terminal before final tightening
|
||||
- [ ] Install the disconnect on the negative battery terminal
|
||||
- [ ] Tighten until physically secure with no terminal wobble
|
||||
- [ ] Verify the disconnect can be opened and closed by hand
|
||||
|
||||
## Validation Checklist
|
||||
|
||||
- [ ] Leave the truck parked with the disconnect opened for at least 24 hours
|
||||
- [ ] Reconnect the switch by hand the next day
|
||||
- [ ] Truck starts reliably after sitting 24+ hours with switch disconnected
|
||||
- [ ] Receipt or photo of installed switch uploaded to this issue
|
||||
|
||||
## Overnight Verification Log
|
||||
|
||||
- Install completed: False
|
||||
- Physically secure: False
|
||||
- Overnight disconnect duration: pending
|
||||
- Truck started after disconnect: pending
|
||||
- Receipt / photo path: pending
|
||||
|
||||
## Battery Replacement Fallback
|
||||
|
||||
If the truck still fails the overnight test after the disconnect install, replace battery and re-run the 24-hour validation.
|
||||
|
||||
## Missing Live Fields
|
||||
|
||||
- store_selected
|
||||
- part_name
|
||||
- install_completed
|
||||
- physically_secure
|
||||
- overnight_test_hours
|
||||
- truck_started_after_disconnect
|
||||
- receipt_or_photo_path
|
||||
|
||||
## Honest next step
|
||||
|
||||
Buy the disconnect switch, install it on the negative battery terminal, leave the truck disconnected for 24+ hours, and only close the issue after receipt/photo evidence and the overnight start result are attached.
|
||||
51
docs/issue-680-verification.md
Normal file
51
docs/issue-680-verification.md
Normal file
@@ -0,0 +1,51 @@
|
||||
# Issue #680 Verification — Fleet-Ops Genome Already Implemented
|
||||
|
||||
**Date:** 2026-04-14
|
||||
**Verified by:** Sprint auto-implementation (issue #807)
|
||||
**Status:** ✅ Already implemented on `main`
|
||||
|
||||
## Summary
|
||||
|
||||
The fleet-ops genome deliverable requested in issue #680 already exists on `main`.
|
||||
This document records the verification evidence and closes the stale issue.
|
||||
|
||||
## Existing Artifact
|
||||
|
||||
- **Genome document:** `genomes/fleet-ops-GENOME.md`
|
||||
- **Regression test:** `tests/test_fleet_ops_genome.py`
|
||||
|
||||
The genome document contains:
|
||||
- Project overview grounded in a fresh clone of `fleet-ops` at commit `38c4eab`
|
||||
- Mermaid architecture diagram
|
||||
- Structural analysis of Ansible playbooks, Python microservices, cron jobs, and docker-compose sandbox
|
||||
- Key abstractions, API surface, test coverage gaps, security considerations, and deployment notes
|
||||
- Concrete metrics: 97 source files, 12 test files, 29 config files, 16,658 lines
|
||||
- Test results: 158 passed, 1 failed, 2 errors
|
||||
|
||||
## Prior PR Trail (Closed Unmerged)
|
||||
|
||||
The issue remained open because earlier linking PRs were closed without merging:
|
||||
|
||||
- **PR #697** — closed unmerged
|
||||
- **PR #770** — closed unmerged
|
||||
|
||||
Since the artifact landed on `main` through other means, those PRs became stale.
|
||||
|
||||
## Verification Commands
|
||||
|
||||
```bash
|
||||
# Confirm artifact exists
|
||||
ls -la genomes/fleet-ops-GENOME.md
|
||||
ls -la tests/test_fleet_ops_genome.py
|
||||
|
||||
# Run regression tests
|
||||
python3 -m pytest -q tests/test_fleet_ops_genome.py
|
||||
|
||||
# Syntax check
|
||||
python3 -m py_compile tests/test_fleet_ops_genome.py
|
||||
```
|
||||
|
||||
## Conclusion
|
||||
|
||||
No new content is needed. Issue #680 is resolved by the existing implementation.
|
||||
This PR adds the verification doc and a test to lock the evidence trail.
|
||||
@@ -1,267 +0,0 @@
|
||||
#!/usr/bin/env python3
|
||||
"""Prepare a field-ready install packet for LAB-003 truck battery disconnect work."""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import argparse
|
||||
import json
|
||||
from pathlib import Path
|
||||
from typing import Any
|
||||
|
||||
|
||||
CANDIDATE_STORES = [
|
||||
"AutoZone — Newport or Claremont",
|
||||
"Advance Auto Parts — Newport or Claremont",
|
||||
"O'Reilly Auto Parts — Newport or Claremont",
|
||||
]
|
||||
|
||||
REQUIRED_ITEMS = [
|
||||
"battery terminal disconnect switch",
|
||||
"terminal shim/post riser if needed",
|
||||
]
|
||||
|
||||
SELECTION_CRITERIA = [
|
||||
"Fits the truck battery post without forcing the clamp",
|
||||
"Mounts on the negative battery terminal",
|
||||
"Physically secure once tightened",
|
||||
"no special tools required to operate",
|
||||
]
|
||||
|
||||
INSTALL_CHECKLIST = [
|
||||
"Verify the truck is off and keys are removed before touching the battery",
|
||||
"Confirm the disconnect fits the negative battery terminal before final tightening",
|
||||
"Install the disconnect on the negative battery terminal",
|
||||
"Tighten until physically secure with no terminal wobble",
|
||||
"Verify the disconnect can be opened and closed by hand",
|
||||
]
|
||||
|
||||
VALIDATION_CHECKLIST = [
|
||||
"Leave the truck parked with the disconnect opened for at least 24 hours",
|
||||
"Reconnect the switch by hand the next day",
|
||||
"Truck starts reliably after sitting 24+ hours with switch disconnected",
|
||||
"Receipt or photo of installed switch uploaded to this issue",
|
||||
]
|
||||
|
||||
BATTERY_REPLACEMENT_FOLLOWUP = (
|
||||
"If the truck still fails the overnight test after the disconnect install, "
|
||||
"replace battery and re-run the 24-hour validation."
|
||||
)
|
||||
|
||||
|
||||
def _as_bool(value: Any) -> bool | None:
|
||||
if value is None:
|
||||
return None
|
||||
if isinstance(value, bool):
|
||||
return value
|
||||
text = str(value).strip().lower()
|
||||
if text in {"1", "true", "yes", "y"}:
|
||||
return True
|
||||
if text in {"0", "false", "no", "n"}:
|
||||
return False
|
||||
return None
|
||||
|
||||
|
||||
def build_packet(details: dict[str, Any]) -> dict[str, Any]:
|
||||
store_selected = (details.get("store_selected") or "").strip()
|
||||
part_name = (details.get("part_name") or "").strip()
|
||||
receipt_or_photo_path = (details.get("receipt_or_photo_path") or "").strip()
|
||||
install_completed = _as_bool(details.get("install_completed"))
|
||||
physically_secure = _as_bool(details.get("physically_secure"))
|
||||
truck_started = _as_bool(details.get("truck_started_after_disconnect"))
|
||||
replacement_needed = _as_bool(details.get("replacement_battery_needed"))
|
||||
overnight_test_hours = details.get("overnight_test_hours")
|
||||
part_cost_usd = details.get("part_cost_usd")
|
||||
|
||||
try:
|
||||
overnight_test_hours = int(overnight_test_hours) if overnight_test_hours is not None else None
|
||||
except (TypeError, ValueError):
|
||||
overnight_test_hours = None
|
||||
|
||||
try:
|
||||
part_cost_usd = float(part_cost_usd) if part_cost_usd is not None else None
|
||||
except (TypeError, ValueError):
|
||||
part_cost_usd = None
|
||||
|
||||
missing_fields: list[str] = []
|
||||
if not store_selected:
|
||||
missing_fields.append("store_selected")
|
||||
if not part_name:
|
||||
missing_fields.append("part_name")
|
||||
if install_completed is not True:
|
||||
missing_fields.append("install_completed")
|
||||
if physically_secure is not True:
|
||||
missing_fields.append("physically_secure")
|
||||
if overnight_test_hours is None:
|
||||
missing_fields.append("overnight_test_hours")
|
||||
if truck_started is None:
|
||||
missing_fields.append("truck_started_after_disconnect")
|
||||
if not receipt_or_photo_path:
|
||||
missing_fields.append("receipt_or_photo_path")
|
||||
|
||||
ready_to_operate_without_tools = True
|
||||
|
||||
if replacement_needed is True or truck_started is False:
|
||||
status = "battery_replace_candidate"
|
||||
elif not store_selected or not part_name:
|
||||
status = "pending_parts_run"
|
||||
elif install_completed is not True:
|
||||
status = "pending_install"
|
||||
elif physically_secure is not True or overnight_test_hours is None or truck_started is None or not receipt_or_photo_path:
|
||||
status = "overnight_validation"
|
||||
elif overnight_test_hours >= 24 and truck_started is True:
|
||||
status = "verified"
|
||||
else:
|
||||
status = "overnight_validation"
|
||||
|
||||
return {
|
||||
"candidate_stores": list(CANDIDATE_STORES),
|
||||
"required_items": list(REQUIRED_ITEMS),
|
||||
"selection_criteria": list(SELECTION_CRITERIA),
|
||||
"install_target": "negative battery terminal",
|
||||
"install_checklist": list(INSTALL_CHECKLIST),
|
||||
"validation_checklist": list(VALIDATION_CHECKLIST),
|
||||
"store_selected": store_selected,
|
||||
"part_name": part_name,
|
||||
"part_cost_usd": part_cost_usd,
|
||||
"install_completed": install_completed,
|
||||
"physically_secure": physically_secure,
|
||||
"overnight_test_hours": overnight_test_hours,
|
||||
"truck_started_after_disconnect": truck_started,
|
||||
"receipt_or_photo_path": receipt_or_photo_path,
|
||||
"ready_to_operate_without_tools": ready_to_operate_without_tools,
|
||||
"missing_fields": missing_fields,
|
||||
"battery_replacement_followup": BATTERY_REPLACEMENT_FOLLOWUP,
|
||||
"status": status,
|
||||
}
|
||||
|
||||
|
||||
def render_markdown(packet: dict[str, Any]) -> str:
|
||||
part_cost = packet["part_cost_usd"]
|
||||
cost_line = f"${part_cost:.2f}" if isinstance(part_cost, (int, float)) else "pending purchase"
|
||||
overnight = packet["overnight_test_hours"]
|
||||
overnight_line = f"{overnight} hours" if overnight is not None else "pending"
|
||||
started = packet["truck_started_after_disconnect"]
|
||||
if started is True:
|
||||
started_line = "yes"
|
||||
elif started is False:
|
||||
started_line = "no"
|
||||
else:
|
||||
started_line = "pending"
|
||||
|
||||
lines = [
|
||||
"# LAB-003 — Truck Battery Disconnect Install Packet",
|
||||
"",
|
||||
"No battery disconnect switch has been purchased or installed yet.",
|
||||
"This packet turns the issue into a field-ready purchase / install / validation checklist while preserving what still requires live work.",
|
||||
"",
|
||||
"## Candidate Store Run",
|
||||
"",
|
||||
]
|
||||
lines.extend(f"- {store}" for store in packet["candidate_stores"])
|
||||
lines.extend([
|
||||
"",
|
||||
"## Required Items",
|
||||
"",
|
||||
])
|
||||
lines.extend(f"- {item}" for item in packet["required_items"])
|
||||
lines.extend([
|
||||
"",
|
||||
"## Selection Criteria",
|
||||
"",
|
||||
])
|
||||
lines.extend(f"- {item}" for item in packet["selection_criteria"])
|
||||
lines.extend([
|
||||
"",
|
||||
"## Live Purchase State",
|
||||
"",
|
||||
f"- Store selected: {packet['store_selected'] or 'pending'}",
|
||||
f"- Part selected: {packet['part_name'] or 'pending'}",
|
||||
f"- Part cost: {cost_line}",
|
||||
"",
|
||||
"## Installation Target",
|
||||
"",
|
||||
f"- Install location: {packet['install_target']}",
|
||||
f"- Ready to operate without tools: {'yes' if packet['ready_to_operate_without_tools'] else 'no'}",
|
||||
"",
|
||||
"## Install Checklist",
|
||||
"",
|
||||
])
|
||||
lines.extend(f"- [ ] {item}" for item in packet["install_checklist"])
|
||||
lines.extend([
|
||||
"",
|
||||
"## Validation Checklist",
|
||||
"",
|
||||
])
|
||||
lines.extend(f"- [ ] {item}" for item in packet["validation_checklist"])
|
||||
lines.extend([
|
||||
"",
|
||||
"## Overnight Verification Log",
|
||||
"",
|
||||
f"- Install completed: {packet['install_completed'] if packet['install_completed'] is not None else 'pending'}",
|
||||
f"- Physically secure: {packet['physically_secure'] if packet['physically_secure'] is not None else 'pending'}",
|
||||
f"- Overnight disconnect duration: {overnight_line}",
|
||||
f"- Truck started after disconnect: {started_line}",
|
||||
f"- Receipt / photo path: {packet['receipt_or_photo_path'] or 'pending'}",
|
||||
"",
|
||||
"## Battery Replacement Fallback",
|
||||
"",
|
||||
packet['battery_replacement_followup'],
|
||||
"",
|
||||
"## Missing Live Fields",
|
||||
"",
|
||||
])
|
||||
if packet["missing_fields"]:
|
||||
lines.extend(f"- {field}" for field in packet["missing_fields"])
|
||||
else:
|
||||
lines.append("- none")
|
||||
lines.extend([
|
||||
"",
|
||||
"## Honest next step",
|
||||
"",
|
||||
"Buy the disconnect switch, install it on the negative battery terminal, leave the truck disconnected for 24+ hours, and only close the issue after receipt/photo evidence and the overnight start result are attached.",
|
||||
"",
|
||||
])
|
||||
return "\n".join(lines)
|
||||
|
||||
|
||||
def main() -> None:
|
||||
parser = argparse.ArgumentParser(description="Prepare the LAB-003 battery disconnect install packet")
|
||||
parser.add_argument("--store-selected", default="")
|
||||
parser.add_argument("--part-name", default="")
|
||||
parser.add_argument("--part-cost-usd", type=float, default=None)
|
||||
parser.add_argument("--install-completed", action="store_true")
|
||||
parser.add_argument("--physically-secure", action="store_true")
|
||||
parser.add_argument("--overnight-test-hours", type=int, default=None)
|
||||
parser.add_argument("--truck-started-after-disconnect", choices=["yes", "no"], default=None)
|
||||
parser.add_argument("--receipt-or-photo-path", default="")
|
||||
parser.add_argument("--replacement-battery-needed", action="store_true")
|
||||
parser.add_argument("--output", default=None)
|
||||
parser.add_argument("--json", action="store_true")
|
||||
args = parser.parse_args()
|
||||
|
||||
packet = build_packet(
|
||||
{
|
||||
"store_selected": args.store_selected,
|
||||
"part_name": args.part_name,
|
||||
"part_cost_usd": args.part_cost_usd,
|
||||
"install_completed": args.install_completed,
|
||||
"physically_secure": args.physically_secure,
|
||||
"overnight_test_hours": args.overnight_test_hours,
|
||||
"truck_started_after_disconnect": args.truck_started_after_disconnect,
|
||||
"receipt_or_photo_path": args.receipt_or_photo_path,
|
||||
"replacement_battery_needed": args.replacement_battery_needed,
|
||||
}
|
||||
)
|
||||
rendered = json.dumps(packet, indent=2) if args.json else render_markdown(packet)
|
||||
|
||||
if args.output:
|
||||
output_path = Path(args.output).expanduser()
|
||||
output_path.parent.mkdir(parents=True, exist_ok=True)
|
||||
output_path.write_text(rendered, encoding="utf-8")
|
||||
print(f"Battery disconnect packet written to {output_path}")
|
||||
else:
|
||||
print(rendered)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
main()
|
||||
52
tests/test_issue_680_verification.py
Normal file
52
tests/test_issue_680_verification.py
Normal file
@@ -0,0 +1,52 @@
|
||||
"""
|
||||
Verification test for issue #680 — fleet-ops genome deliverable.
|
||||
|
||||
Locks the evidence trail proving the genome document and its
|
||||
regression test already exist on main.
|
||||
"""
|
||||
|
||||
import unittest
|
||||
from pathlib import Path
|
||||
|
||||
ROOT = Path(__file__).resolve().parent.parent
|
||||
GENOME_PATH = ROOT / "genomes" / "fleet-ops-GENOME.md"
|
||||
REGRESSION_TEST = ROOT / "tests" / "test_fleet_ops_genome.py"
|
||||
VERIFICATION_DOC = ROOT / "docs" / "issue-680-verification.md"
|
||||
|
||||
|
||||
class TestIssue680Verification(unittest.TestCase):
|
||||
"""Confirm the #680 deliverable is present on main."""
|
||||
|
||||
def test_genome_document_exists(self):
|
||||
self.assertTrue(
|
||||
GENOME_PATH.exists(),
|
||||
"genomes/fleet-ops-GENOME.md must exist (issue #680 deliverable)",
|
||||
)
|
||||
|
||||
def test_genome_document_is_substantial(self):
|
||||
text = GENOME_PATH.read_text(encoding="utf-8")
|
||||
self.assertIn("# GENOME.md — fleet-ops", text)
|
||||
self.assertIn("## Project Overview", text)
|
||||
self.assertIn("## Architecture", text)
|
||||
self.assertGreaterEqual(len(text), 7000, "genome should be >= 7000 chars")
|
||||
|
||||
def test_regression_test_exists(self):
|
||||
self.assertTrue(
|
||||
REGRESSION_TEST.exists(),
|
||||
"tests/test_fleet_ops_genome.py must exist as regression guard",
|
||||
)
|
||||
|
||||
def test_verification_doc_exists(self):
|
||||
self.assertTrue(
|
||||
VERIFICATION_DOC.exists(),
|
||||
"docs/issue-680-verification.md must exist",
|
||||
)
|
||||
|
||||
def test_verification_doc_mentions_prior_prs(self):
|
||||
text = VERIFICATION_DOC.read_text(encoding="utf-8")
|
||||
self.assertIn("#697", text, "should reference PR #697")
|
||||
self.assertIn("#770", text, "should reference PR #770")
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
@@ -1,88 +0,0 @@
|
||||
from pathlib import Path
|
||||
import importlib.util
|
||||
import unittest
|
||||
|
||||
|
||||
ROOT = Path(__file__).resolve().parent.parent
|
||||
SCRIPT_PATH = ROOT / "scripts" / "lab_003_battery_disconnect_packet.py"
|
||||
DOC_PATH = ROOT / "docs" / "LAB_003_BATTERY_DISCONNECT_PACKET.md"
|
||||
|
||||
|
||||
def load_module(path: Path, name: str):
|
||||
assert path.exists(), f"missing {path.relative_to(ROOT)}"
|
||||
spec = importlib.util.spec_from_file_location(name, path)
|
||||
assert spec and spec.loader
|
||||
module = importlib.util.module_from_spec(spec)
|
||||
spec.loader.exec_module(module)
|
||||
return module
|
||||
|
||||
|
||||
class TestLab003BatteryDisconnectPacket(unittest.TestCase):
|
||||
def test_packet_defaults_to_parts_run_and_tracks_issue_specific_requirements(self):
|
||||
mod = load_module(SCRIPT_PATH, "lab_003_battery_disconnect_packet")
|
||||
packet = mod.build_packet({})
|
||||
|
||||
self.assertEqual(packet["status"], "pending_parts_run")
|
||||
self.assertEqual(packet["install_target"], "negative battery terminal")
|
||||
self.assertIn("battery terminal disconnect switch", packet["required_items"])
|
||||
self.assertIn("terminal shim/post riser if needed", packet["required_items"])
|
||||
self.assertIn("AutoZone", packet["candidate_stores"][0])
|
||||
self.assertIn("no special tools required to operate", packet["selection_criteria"])
|
||||
self.assertIn("overnight_test_hours", packet["missing_fields"])
|
||||
self.assertIn("receipt_or_photo_path", packet["missing_fields"])
|
||||
|
||||
def test_packet_marks_verified_after_successful_24h_validation_with_proof(self):
|
||||
mod = load_module(SCRIPT_PATH, "lab_003_battery_disconnect_packet")
|
||||
packet = mod.build_packet(
|
||||
{
|
||||
"store_selected": "AutoZone - Newport",
|
||||
"part_name": "Knob-style battery disconnect switch",
|
||||
"part_cost_usd": 24.99,
|
||||
"install_completed": True,
|
||||
"physically_secure": True,
|
||||
"overnight_test_hours": 26,
|
||||
"truck_started_after_disconnect": True,
|
||||
"receipt_or_photo_path": "evidence/lab-003-installed-switch.jpg",
|
||||
}
|
||||
)
|
||||
|
||||
self.assertEqual(packet["status"], "verified")
|
||||
self.assertEqual(packet["missing_fields"], [])
|
||||
self.assertTrue(packet["ready_to_operate_without_tools"])
|
||||
|
||||
def test_packet_flags_battery_replace_candidate_when_overnight_test_fails(self):
|
||||
mod = load_module(SCRIPT_PATH, "lab_003_battery_disconnect_packet")
|
||||
packet = mod.build_packet(
|
||||
{
|
||||
"store_selected": "O'Reilly - Claremont",
|
||||
"part_name": "Knob-style battery disconnect switch",
|
||||
"install_completed": True,
|
||||
"physically_secure": True,
|
||||
"overnight_test_hours": 24,
|
||||
"truck_started_after_disconnect": False,
|
||||
}
|
||||
)
|
||||
|
||||
self.assertEqual(packet["status"], "battery_replace_candidate")
|
||||
self.assertIn("battery_replacement_followup", packet)
|
||||
self.assertIn("replace battery", packet["battery_replacement_followup"].lower())
|
||||
|
||||
def test_repo_contains_grounded_lab_003_packet_doc(self):
|
||||
self.assertTrue(DOC_PATH.exists(), "missing committed LAB-003 packet doc")
|
||||
text = DOC_PATH.read_text(encoding="utf-8")
|
||||
for snippet in (
|
||||
"# LAB-003 — Truck Battery Disconnect Install Packet",
|
||||
"No battery disconnect switch has been purchased or installed yet.",
|
||||
"negative battery terminal",
|
||||
"AutoZone",
|
||||
"Advance",
|
||||
"O'Reilly",
|
||||
"terminal shim/post riser if needed",
|
||||
"Truck starts reliably after sitting 24+ hours with switch disconnected",
|
||||
"Receipt or photo of installed switch uploaded to this issue",
|
||||
):
|
||||
self.assertIn(snippet, text)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
Reference in New Issue
Block a user