Compare commits
1 Commits
fix/693
...
sprint/iss
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
5a7ee7a5f2 |
51
docs/issue-680-verification.md
Normal file
51
docs/issue-680-verification.md
Normal file
@@ -0,0 +1,51 @@
|
||||
# Issue #680 Verification — Fleet-Ops Genome Already Implemented
|
||||
|
||||
**Date:** 2026-04-14
|
||||
**Verified by:** Sprint auto-implementation (issue #807)
|
||||
**Status:** ✅ Already implemented on `main`
|
||||
|
||||
## Summary
|
||||
|
||||
The fleet-ops genome deliverable requested in issue #680 already exists on `main`.
|
||||
This document records the verification evidence and closes the stale issue.
|
||||
|
||||
## Existing Artifact
|
||||
|
||||
- **Genome document:** `genomes/fleet-ops-GENOME.md`
|
||||
- **Regression test:** `tests/test_fleet_ops_genome.py`
|
||||
|
||||
The genome document contains:
|
||||
- Project overview grounded in a fresh clone of `fleet-ops` at commit `38c4eab`
|
||||
- Mermaid architecture diagram
|
||||
- Structural analysis of Ansible playbooks, Python microservices, cron jobs, and docker-compose sandbox
|
||||
- Key abstractions, API surface, test coverage gaps, security considerations, and deployment notes
|
||||
- Concrete metrics: 97 source files, 12 test files, 29 config files, 16,658 lines
|
||||
- Test results: 158 passed, 1 failed, 2 errors
|
||||
|
||||
## Prior PR Trail (Closed Unmerged)
|
||||
|
||||
The issue remained open because earlier linking PRs were closed without merging:
|
||||
|
||||
- **PR #697** — closed unmerged
|
||||
- **PR #770** — closed unmerged
|
||||
|
||||
Since the artifact landed on `main` through other means, those PRs became stale.
|
||||
|
||||
## Verification Commands
|
||||
|
||||
```bash
|
||||
# Confirm artifact exists
|
||||
ls -la genomes/fleet-ops-GENOME.md
|
||||
ls -la tests/test_fleet_ops_genome.py
|
||||
|
||||
# Run regression tests
|
||||
python3 -m pytest -q tests/test_fleet_ops_genome.py
|
||||
|
||||
# Syntax check
|
||||
python3 -m py_compile tests/test_fleet_ops_genome.py
|
||||
```
|
||||
|
||||
## Conclusion
|
||||
|
||||
No new content is needed. Issue #680 is resolved by the existing implementation.
|
||||
This PR adds the verification doc and a test to lock the evidence trail.
|
||||
@@ -1,57 +0,0 @@
|
||||
# Issue #693 Verification
|
||||
|
||||
## Status: ✅ ALREADY IMPLEMENTED ON MAIN
|
||||
|
||||
Issue #693 asked for an encrypted backup pipeline for fleet state with three acceptance criteria:
|
||||
- Nightly backup of ~/.hermes to encrypted archive
|
||||
- Upload to S3-compatible storage (or local NAS)
|
||||
- Restore playbook tested end-to-end
|
||||
|
||||
All three are already satisfied on `main` in a fresh clone of `timmy-home`.
|
||||
|
||||
## Mainline evidence
|
||||
|
||||
Repo artifacts already present on `main`:
|
||||
- `scripts/backup_pipeline.sh`
|
||||
- `scripts/restore_backup.sh`
|
||||
- `tests/test_backup_pipeline.py`
|
||||
|
||||
What those artifacts already prove:
|
||||
- `scripts/backup_pipeline.sh` archives `~/.hermes` by default via `BACKUP_SOURCE_DIR="${BACKUP_SOURCE_DIR:-${HOME}/.hermes}"`
|
||||
- the backup archive is encrypted with `openssl enc -aes-256-cbc -salt -pbkdf2 -iter 200000`
|
||||
- uploads are supported to either `BACKUP_S3_URI` or `BACKUP_NAS_TARGET`
|
||||
- the script refuses to run without a remote target, preventing fake-local-only success
|
||||
- `scripts/restore_backup.sh` verifies the archive SHA256 against the manifest when present, decrypts the archive, and restores it to a caller-provided root
|
||||
- `tests/test_backup_pipeline.py` exercises the backup + restore round-trip and asserts plaintext tarballs do not leak into backup destinations
|
||||
|
||||
## Acceptance criteria check
|
||||
|
||||
1. ✅ Nightly backup of ~/.hermes to encrypted archive
|
||||
- the pipeline targets `~/.hermes` by default and is explicitly described as a nightly encrypted Hermes backup pipeline
|
||||
2. ✅ Upload to S3-compatible storage (or local NAS)
|
||||
- the script supports `BACKUP_S3_URI` and `BACKUP_NAS_TARGET`
|
||||
3. ✅ Restore playbook tested end-to-end
|
||||
- `tests/test_backup_pipeline.py` performs a full encrypted backup then restore round-trip and compares restored contents byte-for-byte
|
||||
|
||||
## Historical trail
|
||||
|
||||
- PR #707 first shipped the encrypted backup pipeline on branch `fix/693`
|
||||
- PR #768 later re-shipped the same feature on branch `fix/693-backup-pipeline`
|
||||
- both PRs are now closed unmerged, but the requested backup pipeline is present on `main` today and passes targeted verification from a fresh clone
|
||||
- issue comment history already contains a pointer to PR #707
|
||||
|
||||
## Verification run from fresh clone
|
||||
|
||||
Commands executed:
|
||||
- `python3 -m unittest discover -s tests -p 'test_backup_pipeline.py' -v`
|
||||
- `bash -n scripts/backup_pipeline.sh scripts/restore_backup.sh`
|
||||
|
||||
Observed result:
|
||||
- both backup pipeline unit/integration tests pass
|
||||
- both shell scripts parse cleanly
|
||||
- the repo already contains the encrypted backup pipeline, restore script, and tested round-trip coverage requested by issue #693
|
||||
|
||||
## Recommendation
|
||||
|
||||
Close issue #693 as already implemented on `main`.
|
||||
This verification PR exists only to preserve the evidence trail cleanly and close the stale issue without rebuilding the backup pipeline again.
|
||||
52
tests/test_issue_680_verification.py
Normal file
52
tests/test_issue_680_verification.py
Normal file
@@ -0,0 +1,52 @@
|
||||
"""
|
||||
Verification test for issue #680 — fleet-ops genome deliverable.
|
||||
|
||||
Locks the evidence trail proving the genome document and its
|
||||
regression test already exist on main.
|
||||
"""
|
||||
|
||||
import unittest
|
||||
from pathlib import Path
|
||||
|
||||
ROOT = Path(__file__).resolve().parent.parent
|
||||
GENOME_PATH = ROOT / "genomes" / "fleet-ops-GENOME.md"
|
||||
REGRESSION_TEST = ROOT / "tests" / "test_fleet_ops_genome.py"
|
||||
VERIFICATION_DOC = ROOT / "docs" / "issue-680-verification.md"
|
||||
|
||||
|
||||
class TestIssue680Verification(unittest.TestCase):
|
||||
"""Confirm the #680 deliverable is present on main."""
|
||||
|
||||
def test_genome_document_exists(self):
|
||||
self.assertTrue(
|
||||
GENOME_PATH.exists(),
|
||||
"genomes/fleet-ops-GENOME.md must exist (issue #680 deliverable)",
|
||||
)
|
||||
|
||||
def test_genome_document_is_substantial(self):
|
||||
text = GENOME_PATH.read_text(encoding="utf-8")
|
||||
self.assertIn("# GENOME.md — fleet-ops", text)
|
||||
self.assertIn("## Project Overview", text)
|
||||
self.assertIn("## Architecture", text)
|
||||
self.assertGreaterEqual(len(text), 7000, "genome should be >= 7000 chars")
|
||||
|
||||
def test_regression_test_exists(self):
|
||||
self.assertTrue(
|
||||
REGRESSION_TEST.exists(),
|
||||
"tests/test_fleet_ops_genome.py must exist as regression guard",
|
||||
)
|
||||
|
||||
def test_verification_doc_exists(self):
|
||||
self.assertTrue(
|
||||
VERIFICATION_DOC.exists(),
|
||||
"docs/issue-680-verification.md must exist",
|
||||
)
|
||||
|
||||
def test_verification_doc_mentions_prior_prs(self):
|
||||
text = VERIFICATION_DOC.read_text(encoding="utf-8")
|
||||
self.assertIn("#697", text, "should reference PR #697")
|
||||
self.assertIn("#770", text, "should reference PR #770")
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
@@ -1,23 +0,0 @@
|
||||
from pathlib import Path
|
||||
|
||||
|
||||
def test_issue_693_verification_doc_exists_with_mainline_backup_evidence() -> None:
|
||||
text = Path("docs/issue-693-verification.md").read_text(encoding="utf-8")
|
||||
|
||||
required_snippets = [
|
||||
"# Issue #693 Verification",
|
||||
"## Status: ✅ ALREADY IMPLEMENTED ON MAIN",
|
||||
"scripts/backup_pipeline.sh",
|
||||
"scripts/restore_backup.sh",
|
||||
"tests/test_backup_pipeline.py",
|
||||
"Nightly backup of ~/.hermes to encrypted archive",
|
||||
"Upload to S3-compatible storage (or local NAS)",
|
||||
"Restore playbook tested end-to-end",
|
||||
"PR #707",
|
||||
"PR #768",
|
||||
"python3 -m unittest discover -s tests -p 'test_backup_pipeline.py' -v",
|
||||
"bash -n scripts/backup_pipeline.sh scripts/restore_backup.sh",
|
||||
]
|
||||
|
||||
missing = [snippet for snippet in required_snippets if snippet not in text]
|
||||
assert not missing, missing
|
||||
Reference in New Issue
Block a user