stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Show reviewer decisions before merging a pull request #1334

New Issue
Closed
opened 2026-08-24 03:54:02 +00:00 by timmy · 0 comments
timmy commented 2026-08-24 03:54:02 +00:00
Owner
Copy Link

User problem

A mobile pull-request author can request a teammate review, but Stackchain does not show whether that request is waiting, approved, changes-requested, or outdated after new commits. Merge readiness therefore ignores the review lifecycle the author explicitly started.

Scope

  • Normalize requested reviewer decisions against the current pull head.
  • Show touch-readable reviewer statuses in the pull review-and-merge flow.
  • Refresh reviewer status with checks.
  • Block merge on a pending explicit request or current-head changes request; preserve existing merge behavior when nobody was explicitly requested.
  • Mark prior decisions outdated after the head changes and support requesting an updated review.

Acceptance

  • Pending, approved-current-head, changes-requested, commented, and outdated states are behaviorally tested.
  • Current-head approval clears only the review blocker; existing CI/conflict/file review gates remain.
  • Stale status cannot overwrite a newer head.
  • 320x568 and 390x844 rendered flow has no horizontal overflow and interactive controls are at least 44px.
  • Focused tests and the full suite pass.

Evidence / non-duplication

Current main already supports review requests (#1330/#1331) and context editing (#1332/#1333), but not lifecycle status. Read-only audit searched all historical titles, open issues/PRs, and recent commits; no issue covers author-visible reviewer decisions tied to merge readiness.

## User problem A mobile pull-request author can request a teammate review, but Stackchain does not show whether that request is waiting, approved, changes-requested, or outdated after new commits. Merge readiness therefore ignores the review lifecycle the author explicitly started. ## Scope - Normalize requested reviewer decisions against the current pull head. - Show touch-readable reviewer statuses in the pull review-and-merge flow. - Refresh reviewer status with checks. - Block merge on a pending explicit request or current-head changes request; preserve existing merge behavior when nobody was explicitly requested. - Mark prior decisions outdated after the head changes and support requesting an updated review. ## Acceptance - Pending, approved-current-head, changes-requested, commented, and outdated states are behaviorally tested. - Current-head approval clears only the review blocker; existing CI/conflict/file review gates remain. - Stale status cannot overwrite a newer head. - 320x568 and 390x844 rendered flow has no horizontal overflow and interactive controls are at least 44px. - Focused tests and the full suite pass. ## Evidence / non-duplication Current main already supports review requests (#1330/#1331) and context editing (#1332/#1333), but not lifecycle status. Read-only audit searched all historical titles, open issues/PRs, and recent commits; no issue covers author-visible reviewer decisions tied to merge readiness.
timmy self-assigned this 2026-08-24 03:54:02 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
timmy
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#1334
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?