stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Show requested-change feedback in mobile pull detail #1336

New Issue
Closed
opened 2026-08-24 05:27:50 +00:00 by timmy · 0 comments
timmy commented 2026-08-24 05:27:50 +00:00
Owner
Copy Link

Evidence

Reviewer decisions now block merge in mobile pull detail, but src/gitea_proxy.py::_normalize_reviewer_statuses deliberately discards review bodies/IDs and frontend/pull-sheet.js renders status-only rows. An author who sees “changes requested” must leave Stackchain to learn what to fix. Historical issue #129 only carried outbound review feedback into an authenticated Gitea handoff; #1334 shipped status/merge blocking, not received feedback. No open issue or recent commit covers this flow.

User flow

From an assigned pull request, expand Review & merge, open a reviewer decision, read the bounded review summary and inline comments grouped by file, then jump to that file in the existing diff. Outdated feedback must retain its reviewed head and connect to the existing updated-review action.

Acceptance

  • Current requested-change/comment decisions expose a bounded sanitized summary and bounded inline comments grouped by changed file.
  • “View in changes” expands and focuses the matching changed file.
  • Outdated feedback identifies its reviewed head and keeps “Request updated review” reachable.
  • Malformed/excess upstream review data is omitted/bounded without weakening merge blockers.
  • 320×568 and 390×844 layouts have no page-level horizontal overflow and touch actions are at least 44px.
  • Focused and full test suites plus Gitea Actions pass.
## Evidence Reviewer decisions now block merge in mobile pull detail, but `src/gitea_proxy.py::_normalize_reviewer_statuses` deliberately discards review bodies/IDs and `frontend/pull-sheet.js` renders status-only rows. An author who sees “changes requested” must leave Stackchain to learn what to fix. Historical issue #129 only carried outbound review feedback into an authenticated Gitea handoff; #1334 shipped status/merge blocking, not received feedback. No open issue or recent commit covers this flow. ## User flow From an assigned pull request, expand Review & merge, open a reviewer decision, read the bounded review summary and inline comments grouped by file, then jump to that file in the existing diff. Outdated feedback must retain its reviewed head and connect to the existing updated-review action. ## Acceptance - Current requested-change/comment decisions expose a bounded sanitized summary and bounded inline comments grouped by changed file. - “View in changes” expands and focuses the matching changed file. - Outdated feedback identifies its reviewed head and keeps “Request updated review” reachable. - Malformed/excess upstream review data is omitted/bounded without weakening merge blockers. - 320×568 and 390×844 layouts have no page-level horizontal overflow and touch actions are at least 44px. - Focused and full test suites plus Gitea Actions pass.
timmy self-assigned this 2026-08-24 05:27:50 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
timmy
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#1336
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?