stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Show requested-change feedback in mobile pull detail #1337

Merged
rockachopa merged 1 commits from timmy/1336-review-feedback into main 2026-08-24 05:48:24 +00:00
Conversation 0 Commits 1 Files Changed 8 +340 -12
timmy commented 2026-08-24 05:38:46 +00:00
Owner
Copy Link

Closes #1336

What changed

  • retain bounded review summaries and latest inline feedback from Gitea
  • group received comments by changed file in mobile pull detail
  • jump from feedback to the expanded matching diff while preserving outdated-review guidance
  • gate the flow at 320×568 and 390×844 in the packaged browser journey

Verification

  • pytest -q tests/test_pull_api.py tests/test_my_work.py tests/test_ci_workflow.py tests/e2e/test_mobile_pull_reviewer_status_release.py tests/e2e/test_mobile_pull_reviewer_feedback_release.py → 361 passed
  • pytest -q tests/ → 2513 passed, 14 skipped
  • live Gitea review-comments endpoint verified HTTP 200 on PR #1282
Closes #1336 ## What changed - retain bounded review summaries and latest inline feedback from Gitea - group received comments by changed file in mobile pull detail - jump from feedback to the expanded matching diff while preserving outdated-review guidance - gate the flow at 320×568 and 390×844 in the packaged browser journey ## Verification - `pytest -q tests/test_pull_api.py tests/test_my_work.py tests/test_ci_workflow.py tests/e2e/test_mobile_pull_reviewer_status_release.py tests/e2e/test_mobile_pull_reviewer_feedback_release.py` → 361 passed - `pytest -q tests/` → 2513 passed, 14 skipped - live Gitea review-comments endpoint verified HTTP 200 on PR #1282
timmy added 1 commit 2026-08-24 05:38:47 +00:00
feat: show requested-change feedback (Closes #1336)
All checks were successful
CI / lint (pull_request) Successful in 3m30s
Details
CI / build-release (pull_request) Successful in 7s
Details
CI / browser-journey (pull_request) Successful in 5m24s
Details
CI / release-candidate (pull_request) Has been skipped
Details
c4bb2f5eba
rockachopa merged commit bad14d1b94 into main 2026-08-24 05:48:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#1337
No description provided.
Delete Branch "timmy/1336-review-feedback"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?