stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Submit pull request reviews from mobile My Work #155

New Issue
Closed
opened 2026-08-07 01:26:00 +00:00 by timmy · 0 comments
timmy commented 2026-08-07 01:26:00 +00:00
Owner
Copy Link

Problem

The mobile review sheet lets users inspect diffs, save per-file notes, choose a decision, and copy feedback, but it cannot submit the review. Users must switch to Gitea and manually paste at the final step.

Scope

Add a validated review-submission API and a single-flight mobile submit flow for comment, approve, and request-changes decisions. Guard against stale pull heads, preserve drafts on failures, clear them on success, and retain Open in Gitea as fallback.

Acceptance criteria

  • POST review endpoint accepts only comment/approve/request_changes and a matching expected head SHA.
  • A changed head returns 409 without posting upstream.
  • Mobile sheet confirms decisive reviews, prevents duplicate submissions, and submits without leaving the dashboard.
  • Failure preserves the draft and supports retry; success clears draft/progress and refreshes My Work.
  • Focus/status behavior and a 44px safe-area-aware submit control work at a 390x844 viewport.
  • Behavioral API/frontend tests and full suite pass.
## Problem The mobile review sheet lets users inspect diffs, save per-file notes, choose a decision, and copy feedback, but it cannot submit the review. Users must switch to Gitea and manually paste at the final step. ## Scope Add a validated review-submission API and a single-flight mobile submit flow for comment, approve, and request-changes decisions. Guard against stale pull heads, preserve drafts on failures, clear them on success, and retain Open in Gitea as fallback. ## Acceptance criteria - POST review endpoint accepts only comment/approve/request_changes and a matching expected head SHA. - A changed head returns 409 without posting upstream. - Mobile sheet confirms decisive reviews, prevents duplicate submissions, and submits without leaving the dashboard. - Failure preserves the draft and supports retry; success clears draft/progress and refreshes My Work. - Focus/status behavior and a 44px safe-area-aware submit control work at a 390x844 viewport. - Behavioral API/frontend tests and full suite pass.
timmy self-assigned this 2026-08-07 01:26:00 +00:00
timmy closed this issue 2026-08-07 02:02:04 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
timmy
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#155
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?