stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Continue assigned reviews directly into merge #240

New Issue
Closed
opened 2026-08-07 23:08:29 +00:00 by timmy · 0 comments
timmy commented 2026-08-07 23:08:29 +00:00
Owner
Copy Link

User problem

A pull request that is both assigned to the current user and awaiting their review opens the review sheet. After approving it, mobile users must close the sheet, rediscover the same PR, reopen the assigned-pull sheet, and acknowledge the same files again before merge.

Vertical slice

  • After a successful approval on a PR whose work_reasons includes both review_requested and assigned_to_me, show a thumb-safe Continue to merge action.
  • Transition in place to the assigned pull sheet with history replacement.
  • Carry reviewed filenames only for the exact repository, PR number, and submitted head SHA.
  • Reload fresh merge readiness; all existing assignment, head, draft, conflicts, CI, and reviewed-file gates remain authoritative.
  • Never show the action for unassigned reviews or non-approval decisions; a changed head must not inherit progress.

Acceptance tests

  1. Dual-responsibility approval exposes a 44px safe-area-aware Continue to merge action.
  2. Continue replaces the review route and opens the assigned pull sheet without a dashboard flash.
  3. Exact-head reviewed files transfer to the pull checklist; a changed head starts unreviewed.
  4. Comment/request-changes and unassigned reviews never expose the merge continuation.
  5. Existing merge eligibility remains unchanged and the full suite is green.

Evidence / non-duplication

Current frontend classifies a dual-responsibility item as review-only (frontend/my-work.js) and keeps separate head-scoped stores in frontend/review-sheet.js and frontend/pull-sheet.js. Historical issues #117, #155, #161, #187, and #217 added deduplication, review submission, and assigned-PR merge separately; none joins the successful approval-to-merge flow.

## User problem A pull request that is both assigned to the current user and awaiting their review opens the review sheet. After approving it, mobile users must close the sheet, rediscover the same PR, reopen the assigned-pull sheet, and acknowledge the same files again before merge. ## Vertical slice - After a successful **approval** on a PR whose `work_reasons` includes both `review_requested` and `assigned_to_me`, show a thumb-safe **Continue to merge** action. - Transition in place to the assigned pull sheet with history replacement. - Carry reviewed filenames only for the exact repository, PR number, and submitted head SHA. - Reload fresh merge readiness; all existing assignment, head, draft, conflicts, CI, and reviewed-file gates remain authoritative. - Never show the action for unassigned reviews or non-approval decisions; a changed head must not inherit progress. ## Acceptance tests 1. Dual-responsibility approval exposes a 44px safe-area-aware Continue to merge action. 2. Continue replaces the review route and opens the assigned pull sheet without a dashboard flash. 3. Exact-head reviewed files transfer to the pull checklist; a changed head starts unreviewed. 4. Comment/request-changes and unassigned reviews never expose the merge continuation. 5. Existing merge eligibility remains unchanged and the full suite is green. ## Evidence / non-duplication Current frontend classifies a dual-responsibility item as review-only (`frontend/my-work.js`) and keeps separate head-scoped stores in `frontend/review-sheet.js` and `frontend/pull-sheet.js`. Historical issues #117, #155, #161, #187, and #217 added deduplication, review submission, and assigned-PR merge separately; none joins the successful approval-to-merge flow.
timmy self-assigned this 2026-08-07 23:08:29 +00:00
timmy closed this issue 2026-08-07 23:14:11 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
timmy
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#240
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?