stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Review assigned pull diffs before mobile merge #187

New Issue
Closed
opened 2026-08-07 10:18:23 +00:00 by rockachopa · 0 comments
rockachopa commented 2026-08-07 10:18:23 +00:00
Member
Copy Link

Problem

The assigned pull-request completion sheet shows only filenames and line counts before enabling Merge. Mobile users can therefore merge without inspecting the patch, even though the requested-review flow already exposes bounded diff previews.

Vertical slice

Add bounded per-file diff previews to assigned pull details, persist a reviewed-files checklist by repository/PR/head SHA, provide Next unreviewed navigation, and require every changed file to be acknowledged in addition to existing CI/mergeability checks. A new head must reset review progress. Binary, unavailable, and truncated previews must be explicit and link to the full Gitea pull.

Acceptance tests

  • Assigned pull detail returns bounded normalized diff preview metadata for every changed file.
  • Mobile review progress persists for the same head SHA and resets when the head changes.
  • Merge remains disabled until all files are acknowledged and technical eligibility passes.
  • Binary/unavailable/truncated previews remain acknowledgeable and expose the Gitea fallback.
  • Next unreviewed identifies the next unchecked file.
  • Full test suite remains green.
## Problem The assigned pull-request completion sheet shows only filenames and line counts before enabling Merge. Mobile users can therefore merge without inspecting the patch, even though the requested-review flow already exposes bounded diff previews. ## Vertical slice Add bounded per-file diff previews to assigned pull details, persist a reviewed-files checklist by repository/PR/head SHA, provide Next unreviewed navigation, and require every changed file to be acknowledged in addition to existing CI/mergeability checks. A new head must reset review progress. Binary, unavailable, and truncated previews must be explicit and link to the full Gitea pull. ## Acceptance tests - Assigned pull detail returns bounded normalized diff preview metadata for every changed file. - Mobile review progress persists for the same head SHA and resets when the head changes. - Merge remains disabled until all files are acknowledged and technical eligibility passes. - Binary/unavailable/truncated previews remain acknowledgeable and expose the Gitea fallback. - Next unreviewed identifies the next unchecked file. - Full test suite remains green.
timmy was assigned by rockachopa 2026-08-07 10:18:23 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
timmy
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#187
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?