Review saved pull request diffs and draft feedback offline #355

Closed
opened 2026-08-09 00:09:59 +00:00 by timmy · 0 comments
Owner

Product gap

Requested reviews can be prioritized in Today and fully reviewed on mobile while online, but the offline path rejects them even when private offline work is enabled. This breaks the highest-value read-and-draft flow during commutes and unreliable connectivity.

Scope

  • Warm an account-bound, bounded review record for requested-review Today items, including head SHA, sanitized diff previews, CI state, and prior review context.
  • Open the existing review sheet from a cold offline launch.
  • Preserve SHA-scoped file progress, summary, decision, notes, and inline-comment drafts offline.
  • Never queue or submit a review offline. Require reconnect validation; if the head changed, preserve the prior-head draft and start review state for the new head.

Acceptance

  • A saved Today review opens offline with bounded files/diffs and prior review context.
  • Offline review drafting survives close/reload and remains scoped by repository, pull number, and head SHA.
  • Submit is disabled offline with explicit reconnect guidance; no mutation is queued.
  • Reconnect reloads current review detail. Same-head drafts remain submit-ready; changed-head drafts remain retained under the old SHA and new-head review state starts clean.
  • Opt-out, expiry, account mismatch, and clear-offline-data continue to deny/remove saved review detail.
  • Focused behavioral tests prove storage allowlisting/bounds, review-aware warming, offline opening, and reconnect validation; the full suite remains green.

Non-duplication

Historical issue and recent commit review found online review work (#117–#165, #187, #217, #240), read-only offline My Work (#228), saved Today details (#345), and automatic Today warming (#349), but no issue joins cached diffs and SHA-scoped drafts into an offline review journey.

## Product gap Requested reviews can be prioritized in Today and fully reviewed on mobile while online, but the offline path rejects them even when private offline work is enabled. This breaks the highest-value read-and-draft flow during commutes and unreliable connectivity. ## Scope - Warm an account-bound, bounded review record for requested-review Today items, including head SHA, sanitized diff previews, CI state, and prior review context. - Open the existing review sheet from a cold offline launch. - Preserve SHA-scoped file progress, summary, decision, notes, and inline-comment drafts offline. - Never queue or submit a review offline. Require reconnect validation; if the head changed, preserve the prior-head draft and start review state for the new head. ## Acceptance - A saved Today review opens offline with bounded files/diffs and prior review context. - Offline review drafting survives close/reload and remains scoped by repository, pull number, and head SHA. - Submit is disabled offline with explicit reconnect guidance; no mutation is queued. - Reconnect reloads current review detail. Same-head drafts remain submit-ready; changed-head drafts remain retained under the old SHA and new-head review state starts clean. - Opt-out, expiry, account mismatch, and clear-offline-data continue to deny/remove saved review detail. - Focused behavioral tests prove storage allowlisting/bounds, review-aware warming, offline opening, and reconnect validation; the full suite remains green. ## Non-duplication Historical issue and recent commit review found online review work (#117–#165, #187, #217, #240), read-only offline My Work (#228), saved Today details (#345), and automatic Today warming (#349), but no issue joins cached diffs and SHA-scoped drafts into an offline review journey.
timmy self-assigned this 2026-08-09 00:09:59 +00:00
timmy closed this issue 2026-08-09 00:22:08 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#355
No description provided.