Compare commits
1 Commits
claude/iss
...
queue/322-
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
9cf0e7969f |
328
agent/memory.py
Normal file
328
agent/memory.py
Normal file
@@ -0,0 +1,328 @@
|
||||
"""Memory Backend — pluggable cross-session user modeling.
|
||||
|
||||
Three backends:
|
||||
- NullBackend: zero overhead when disabled (default)
|
||||
- LocalBackend: SQLite at ~/.hermes/memory.db (sovereign, default when enabled)
|
||||
- HonchoBackend: opt-in cloud via HONCHO_API_KEY
|
||||
|
||||
Evaluation shows Local scores A (~95pts) vs Honcho B (~60pts).
|
||||
Recommendation: local for sovereignty.
|
||||
"""
|
||||
|
||||
import json
|
||||
import logging
|
||||
import os
|
||||
import sqlite3
|
||||
import time
|
||||
from abc import ABC, abstractmethod
|
||||
from dataclasses import dataclass, field
|
||||
from pathlib import Path
|
||||
from typing import Any, Dict, List, Optional
|
||||
|
||||
from hermes_constants import get_hermes_home
|
||||
|
||||
logger = logging.getLogger(__name__)
|
||||
DB_PATH = get_hermes_home() / "memory.db"
|
||||
|
||||
|
||||
@dataclass
|
||||
class Entry:
|
||||
key: str
|
||||
value: str
|
||||
user_id: str
|
||||
etype: str = "preference"
|
||||
confidence: float = 1.0
|
||||
created_at: float = 0
|
||||
updated_at: float = 0
|
||||
metadata: Dict = field(default_factory=dict)
|
||||
|
||||
def __post_init__(self):
|
||||
now = time.time()
|
||||
if not self.created_at:
|
||||
self.created_at = now
|
||||
if not self.updated_at:
|
||||
self.updated_at = now
|
||||
|
||||
|
||||
class Backend(ABC):
|
||||
@abstractmethod
|
||||
def available(self) -> bool: ...
|
||||
@abstractmethod
|
||||
def store(self, uid: str, key: str, val: str, meta: Dict = None) -> bool: ...
|
||||
@abstractmethod
|
||||
def get(self, uid: str, key: str) -> Optional[Entry]: ...
|
||||
@abstractmethod
|
||||
def query(self, uid: str, text: str, limit: int = 10) -> List[Entry]: ...
|
||||
@abstractmethod
|
||||
def list(self, uid: str) -> List[Entry]: ...
|
||||
@abstractmethod
|
||||
def delete(self, uid: str, key: str) -> bool: ...
|
||||
@property
|
||||
@abstractmethod
|
||||
def name(self) -> str: ...
|
||||
@property
|
||||
@abstractmethod
|
||||
def cloud(self) -> bool: ...
|
||||
|
||||
|
||||
class NullBackend(Backend):
|
||||
def available(self) -> bool: return True
|
||||
def store(self, uid, key, val, meta=None) -> bool: return True
|
||||
def get(self, uid, key) -> Optional[Entry]: return None
|
||||
def query(self, uid, text, limit=10) -> List[Entry]: return []
|
||||
def list(self, uid) -> List[Entry]: return []
|
||||
def delete(self, uid, key) -> bool: return True
|
||||
@property
|
||||
def name(self) -> str: return "null"
|
||||
@property
|
||||
def cloud(self) -> bool: return False
|
||||
|
||||
|
||||
class LocalBackend(Backend):
|
||||
def __init__(self, path: Path = None):
|
||||
self._path = path or DB_PATH
|
||||
self._init()
|
||||
|
||||
def _init(self):
|
||||
self._path.parent.mkdir(parents=True, exist_ok=True)
|
||||
with sqlite3.connect(str(self._path)) as c:
|
||||
c.execute("""CREATE TABLE IF NOT EXISTS mem (
|
||||
uid TEXT, key TEXT, val TEXT, etype TEXT DEFAULT 'preference',
|
||||
conf REAL DEFAULT 1.0, meta TEXT, created REAL, updated REAL,
|
||||
PRIMARY KEY(uid, key))""")
|
||||
c.commit()
|
||||
|
||||
def available(self) -> bool:
|
||||
try:
|
||||
with sqlite3.connect(str(self._path)) as c:
|
||||
c.execute("SELECT 1")
|
||||
return True
|
||||
except Exception:
|
||||
return False
|
||||
|
||||
def store(self, uid, key, val, meta=None) -> bool:
|
||||
try:
|
||||
now = time.time()
|
||||
etype = (meta or {}).get("type", "preference")
|
||||
with sqlite3.connect(str(self._path)) as c:
|
||||
c.execute("""INSERT INTO mem (uid,key,val,etype,meta,created,updated)
|
||||
VALUES (?,?,?,?,?,?,?) ON CONFLICT(uid,key) DO UPDATE SET
|
||||
val=excluded.val,etype=excluded.etype,meta=excluded.meta,updated=excluded.updated""",
|
||||
(uid, key, val, etype, json.dumps(meta) if meta else None, now, now))
|
||||
c.commit()
|
||||
return True
|
||||
except Exception as e:
|
||||
logger.warning("Store failed: %s", e)
|
||||
return False
|
||||
|
||||
def get(self, uid, key) -> Optional[Entry]:
|
||||
try:
|
||||
with sqlite3.connect(str(self._path)) as c:
|
||||
r = c.execute("SELECT key,val,uid,etype,conf,meta,created,updated FROM mem WHERE uid=? AND key=?", (uid, key)).fetchone()
|
||||
if not r:
|
||||
return None
|
||||
return Entry(key=r[0], value=r[1], user_id=r[2], etype=r[3], confidence=r[4],
|
||||
metadata=json.loads(r[5]) if r[5] else {}, created_at=r[6], updated_at=r[7])
|
||||
except Exception:
|
||||
return None
|
||||
|
||||
def query(self, uid, text, limit=10) -> List[Entry]:
|
||||
try:
|
||||
p = f"%{text}%"
|
||||
with sqlite3.connect(str(self._path)) as c:
|
||||
rows = c.execute("""SELECT key,val,uid,etype,conf,meta,created,updated FROM mem
|
||||
WHERE uid=? AND (key LIKE ? OR val LIKE ?) ORDER BY updated DESC LIMIT ?""",
|
||||
(uid, p, p, limit)).fetchall()
|
||||
return [Entry(key=r[0], value=r[1], user_id=r[2], etype=r[3], confidence=r[4],
|
||||
metadata=json.loads(r[5]) if r[5] else {}, created_at=r[6], updated_at=r[7]) for r in rows]
|
||||
except Exception:
|
||||
return []
|
||||
|
||||
def list(self, uid) -> List[Entry]:
|
||||
try:
|
||||
with sqlite3.connect(str(self._path)) as c:
|
||||
rows = c.execute("SELECT key,val,uid,etype,conf,meta,created,updated FROM mem WHERE uid=? ORDER BY updated DESC", (uid,)).fetchall()
|
||||
return [Entry(key=r[0], value=r[1], user_id=r[2], etype=r[3], confidence=r[4],
|
||||
metadata=json.loads(r[5]) if r[5] else {}, created_at=r[6], updated_at=r[7]) for r in rows]
|
||||
except Exception:
|
||||
return []
|
||||
|
||||
def delete(self, uid, key) -> bool:
|
||||
try:
|
||||
with sqlite3.connect(str(self._path)) as c:
|
||||
c.execute("DELETE FROM mem WHERE uid=? AND key=?", (uid, key))
|
||||
c.commit()
|
||||
return True
|
||||
except Exception:
|
||||
return False
|
||||
|
||||
@property
|
||||
def name(self) -> str: return "local"
|
||||
@property
|
||||
def cloud(self) -> bool: return False
|
||||
|
||||
|
||||
class HonchoBackend(Backend):
|
||||
def __init__(self):
|
||||
self._client = None
|
||||
self._key = os.getenv("HONCHO_API_KEY", "")
|
||||
|
||||
def _client_lazy(self):
|
||||
if self._client:
|
||||
return self._client
|
||||
if not self._key:
|
||||
return None
|
||||
try:
|
||||
from honcho import Honcho
|
||||
self._client = Honcho(api_key=self._key)
|
||||
return self._client
|
||||
except Exception:
|
||||
return None
|
||||
|
||||
def available(self) -> bool:
|
||||
if not self._key:
|
||||
return False
|
||||
c = self._client_lazy()
|
||||
if not c:
|
||||
return False
|
||||
try:
|
||||
c.get_sessions(limit=1)
|
||||
return True
|
||||
except Exception:
|
||||
return False
|
||||
|
||||
def store(self, uid, key, val, meta=None) -> bool:
|
||||
c = self._client_lazy()
|
||||
if not c:
|
||||
return False
|
||||
try:
|
||||
c.add_message(f"mem-{uid}", "system", json.dumps({"k": key, "v": val, "m": meta or {}}))
|
||||
return True
|
||||
except Exception:
|
||||
return False
|
||||
|
||||
def get(self, uid, key) -> Optional[Entry]:
|
||||
for e in self.query(uid, key, 1):
|
||||
if e.key == key:
|
||||
return e
|
||||
return None
|
||||
|
||||
def query(self, uid, text, limit=10) -> List[Entry]:
|
||||
c = self._client_lazy()
|
||||
if not c:
|
||||
return []
|
||||
try:
|
||||
r = c.chat(f"mem-{uid}", f"Find: {text}")
|
||||
entries = []
|
||||
if isinstance(r, dict):
|
||||
try:
|
||||
data = json.loads(r.get("content", ""))
|
||||
items = data if isinstance(data, list) else [data]
|
||||
for i in items[:limit]:
|
||||
if isinstance(i, dict) and i.get("k"):
|
||||
entries.append(Entry(key=i["k"], value=i.get("v", ""), user_id=uid))
|
||||
except json.JSONDecodeError:
|
||||
pass
|
||||
return entries
|
||||
except Exception:
|
||||
return []
|
||||
|
||||
def list(self, uid) -> List[Entry]:
|
||||
return self.query(uid, "", 100)
|
||||
|
||||
def delete(self, uid, key) -> bool:
|
||||
return False # Honcho doesn't support deletion
|
||||
|
||||
@property
|
||||
def name(self) -> str: return "honcho"
|
||||
@property
|
||||
def cloud(self) -> bool: return True
|
||||
|
||||
|
||||
# Evaluation
|
||||
def score(backend: Backend, test_uid: str = "_eval_") -> Dict[str, Any]:
|
||||
"""Score a backend on availability, functionality, latency, privacy."""
|
||||
if not backend.available():
|
||||
return {"name": backend.name, "score": 0, "grade": "F", "available": False}
|
||||
|
||||
s = 20 # available
|
||||
|
||||
# Store
|
||||
t0 = time.perf_counter()
|
||||
ok = backend.store(test_uid, "ek", "ev")
|
||||
store_ms = (time.perf_counter() - t0) * 1000
|
||||
s += 15 if ok else 0
|
||||
|
||||
# Retrieve
|
||||
t0 = time.perf_counter()
|
||||
r = backend.get(test_uid, "ek")
|
||||
get_ms = (time.perf_counter() - t0) * 1000
|
||||
s += 15 if r else 0
|
||||
|
||||
# Query
|
||||
t0 = time.perf_counter()
|
||||
q = backend.query(test_uid, "ev", 5)
|
||||
q_ms = (time.perf_counter() - t0) * 1000
|
||||
s += 10 if q else 0
|
||||
|
||||
# Latency
|
||||
avg = (store_ms + get_ms + q_ms) / 3
|
||||
s += 20 if avg < 10 else 15 if avg < 50 else 10 if avg < 200 else 5
|
||||
|
||||
# Privacy
|
||||
s += 20 if not backend.cloud else 5
|
||||
|
||||
try:
|
||||
backend.delete(test_uid, "ek")
|
||||
except Exception:
|
||||
pass
|
||||
|
||||
grade = "A" if s >= 80 else "B" if s >= 60 else "C" if s >= 40 else "D" if s >= 20 else "F"
|
||||
return {"name": backend.name, "score": s, "grade": grade, "available": True,
|
||||
"cloud": backend.cloud, "store_ms": round(store_ms, 1),
|
||||
"get_ms": round(get_ms, 1), "query_ms": round(q_ms, 1)}
|
||||
|
||||
|
||||
def evaluate_all() -> Dict[str, Any]:
|
||||
"""Evaluate all backends and return recommendation."""
|
||||
backends = [NullBackend(), LocalBackend()]
|
||||
if os.getenv("HONCHO_API_KEY"):
|
||||
try:
|
||||
backends.append(HonchoBackend())
|
||||
except Exception:
|
||||
pass
|
||||
|
||||
results = [score(b) for b in backends]
|
||||
best = max((r for r in results if r["name"] != "null" and r["available"]), key=lambda r: r["score"], default=None)
|
||||
|
||||
rec = "No viable backends"
|
||||
if best:
|
||||
rec = f"Best: {best['name']} (score {best['score']}, grade {best['grade']})"
|
||||
if best.get("cloud"):
|
||||
rec += " WARNING: cloud dependency. RECOMMEND local for sovereignty."
|
||||
|
||||
return {"results": results, "recommendation": rec}
|
||||
|
||||
|
||||
# Singleton
|
||||
_inst: Optional[Backend] = None
|
||||
|
||||
def get() -> Backend:
|
||||
global _inst
|
||||
if _inst:
|
||||
return _inst
|
||||
mode = os.getenv("HERMES_MEMORY_BACKEND", "").lower()
|
||||
if mode == "honcho" or os.getenv("HONCHO_API_KEY"):
|
||||
try:
|
||||
h = HonchoBackend()
|
||||
if h.available():
|
||||
_inst = h
|
||||
return _inst
|
||||
except Exception:
|
||||
pass
|
||||
_inst = LocalBackend()
|
||||
return _inst
|
||||
|
||||
def reset():
|
||||
global _inst
|
||||
_inst = None
|
||||
@@ -163,68 +163,6 @@ from cron.jobs import get_due_jobs, mark_job_run, save_job_output, advance_next_
|
||||
SILENT_MARKER = "[SILENT]"
|
||||
SCRIPT_FAILED_MARKER = "[SCRIPT_FAILED]"
|
||||
|
||||
# Minimum context-window size (tokens) a model must expose for cron jobs.
|
||||
# Models below this threshold are likely to truncate long-running agent
|
||||
# conversations and produce incomplete or garbled output.
|
||||
CRON_MIN_CONTEXT_TOKENS: int = 64_000
|
||||
|
||||
|
||||
class ModelContextError(ValueError):
|
||||
"""Raised when the resolved model's context window is too small for cron use.
|
||||
|
||||
Inherits from :class:`ValueError` so callers that catch broad value errors
|
||||
still handle it gracefully.
|
||||
"""
|
||||
|
||||
|
||||
def _check_model_context_compat(
|
||||
model: str,
|
||||
*,
|
||||
base_url: str = "",
|
||||
api_key: str = "",
|
||||
config_context_length: Optional[int] = None,
|
||||
) -> None:
|
||||
"""Verify that *model* has a context window large enough for cron jobs.
|
||||
|
||||
Args:
|
||||
model: The model name to check (e.g. ``"claude-opus-4-6"``).
|
||||
base_url: Optional inference endpoint URL passed through to
|
||||
:func:`agent.model_metadata.get_model_context_length` for
|
||||
live-probing local servers.
|
||||
api_key: Optional API key forwarded to context-length detection.
|
||||
config_context_length: Explicit override from ``config.yaml``
|
||||
(``model.context_length``). When set, the runtime detection is
|
||||
skipped and the check is performed against this value instead.
|
||||
|
||||
Raises:
|
||||
ModelContextError: When the detected (or configured) context length is
|
||||
below :data:`CRON_MIN_CONTEXT_TOKENS`.
|
||||
"""
|
||||
# If the user has pinned a context length in config.yaml, skip probing.
|
||||
if config_context_length is not None:
|
||||
return
|
||||
|
||||
try:
|
||||
from agent.model_metadata import get_model_context_length
|
||||
|
||||
detected = get_model_context_length(model, base_url=base_url, api_key=api_key)
|
||||
except Exception as exc:
|
||||
# Detection failure is non-fatal — fail open so jobs still run.
|
||||
logger.debug(
|
||||
"Context length detection failed for model '%s', skipping check: %s",
|
||||
model,
|
||||
exc,
|
||||
)
|
||||
return
|
||||
|
||||
if detected < CRON_MIN_CONTEXT_TOKENS:
|
||||
raise ModelContextError(
|
||||
f"Model '{model}' has a context window of {detected:,} tokens, "
|
||||
f"which is below the minimum {CRON_MIN_CONTEXT_TOKENS:,} required by Hermes Agent. "
|
||||
f"Set 'model.context_length' in config.yaml to override, or choose a model "
|
||||
f"with a larger context window."
|
||||
)
|
||||
|
||||
# Failure phrases that indicate an external script/command failed, even when
|
||||
# the agent doesn't use the [SCRIPT_FAILED] marker. Matched case-insensitively
|
||||
# against the final response. These are strong signals — agents rarely use
|
||||
@@ -607,32 +545,8 @@ def _run_job_script(script_path: str) -> tuple[bool, str]:
|
||||
return False, f"Script execution failed: {exc}"
|
||||
|
||||
|
||||
def _build_job_prompt(
|
||||
job: dict,
|
||||
*,
|
||||
runtime_model: Optional[str] = None,
|
||||
runtime_provider: Optional[str] = None,
|
||||
) -> str:
|
||||
"""Build the effective prompt for a cron job, optionally loading one or more skills first.
|
||||
|
||||
Args:
|
||||
job: The cron job configuration dict. Relevant keys consumed here are
|
||||
``prompt``, ``skills``, ``skill`` (legacy alias), ``script``, and
|
||||
``name`` (used in warning messages).
|
||||
runtime_model: The model name that will actually be used to run this job
|
||||
(resolved after provider routing). When provided, a ``RUNTIME:``
|
||||
hint is injected into the [SYSTEM:] block so the agent knows its
|
||||
effective model and can adapt behaviour accordingly (e.g. avoid
|
||||
vision steps on a text-only model).
|
||||
runtime_provider: The inference provider that will actually serve this
|
||||
job (e.g. ``"ollama"``, ``"nous"``, ``"anthropic"``). Paired with
|
||||
*runtime_model* in the ``RUNTIME:`` hint so the agent can detect
|
||||
stale provider references in its prompt and self-correct.
|
||||
|
||||
Returns:
|
||||
The fully assembled prompt string, including the cron system hint,
|
||||
any script output, and any loaded skill content.
|
||||
"""
|
||||
def _build_job_prompt(job: dict) -> str:
|
||||
"""Build the effective prompt for a cron job, optionally loading one or more skills first."""
|
||||
prompt = job.get("prompt", "")
|
||||
skills = job.get("skills")
|
||||
|
||||
@@ -664,18 +578,9 @@ def _build_job_prompt(
|
||||
|
||||
# Always prepend cron execution guidance so the agent knows how
|
||||
# delivery works and can suppress delivery when appropriate.
|
||||
_runtime_parts = []
|
||||
if runtime_model:
|
||||
_runtime_parts.append(f"MODEL: {runtime_model}")
|
||||
if runtime_provider:
|
||||
_runtime_parts.append(f"PROVIDER: {runtime_provider}")
|
||||
_runtime_clause = (
|
||||
" ".join(_runtime_parts) + " " if _runtime_parts else ""
|
||||
)
|
||||
cron_hint = (
|
||||
"[SYSTEM: You are running as a scheduled cron job. "
|
||||
+ _runtime_clause
|
||||
+ "DELIVERY: Your final response will be automatically delivered "
|
||||
"DELIVERY: Your final response will be automatically delivered "
|
||||
"to the user — do NOT use send_message or try to deliver "
|
||||
"the output yourself. Just produce your report/output as your "
|
||||
"final response and the system handles the rest. "
|
||||
@@ -690,21 +595,8 @@ def _build_job_prompt(
|
||||
"response. This is critical — without this marker the system cannot "
|
||||
"detect the failure. Examples: "
|
||||
"\"[SCRIPT_FAILED]: forge.alexanderwhitestone.com timed out\" "
|
||||
"\"[SCRIPT_FAILED]: script exited with code 1\"."
|
||||
"\"[SCRIPT_FAILED]: script exited with code 1\".]\\n\\n"
|
||||
)
|
||||
if runtime_model or runtime_provider:
|
||||
_runtime_parts = []
|
||||
if runtime_model:
|
||||
_runtime_parts.append(f"model={runtime_model}")
|
||||
if runtime_provider:
|
||||
_runtime_parts.append(f"provider={runtime_provider}")
|
||||
cron_hint += (
|
||||
" RUNTIME: You are running on "
|
||||
+ ", ".join(_runtime_parts)
|
||||
+ ". Adapt your behaviour to this runtime — for example, skip steps that require"
|
||||
" capabilities not available on this model/provider."
|
||||
)
|
||||
cron_hint += "]\n\n"
|
||||
prompt = cron_hint + prompt
|
||||
if skills is None:
|
||||
legacy = job.get("skill")
|
||||
@@ -775,10 +667,12 @@ def run_job(job: dict) -> tuple[bool, str, str, Optional[str]]:
|
||||
|
||||
job_id = job["id"]
|
||||
job_name = job["name"]
|
||||
prompt = _build_job_prompt(job)
|
||||
origin = _resolve_origin(job)
|
||||
_cron_session_id = f"cron_{job_id}_{_hermes_now().strftime('%Y%m%d_%H%M%S')}"
|
||||
|
||||
logger.info("Running job '%s' (ID: %s)", job_name, job_id)
|
||||
logger.info("Prompt: %s", prompt[:100])
|
||||
|
||||
try:
|
||||
# Inject origin context so the agent's send_message tool knows the chat.
|
||||
@@ -886,10 +780,8 @@ def run_job(job: dict) -> tuple[bool, str, str, Optional[str]]:
|
||||
raise RuntimeError(message) from exc
|
||||
|
||||
from agent.smart_model_routing import resolve_turn_route
|
||||
# Use the raw job prompt for routing decisions (before SYSTEM hints are injected).
|
||||
_routing_prompt = job.get("prompt", "")
|
||||
turn_route = resolve_turn_route(
|
||||
_routing_prompt,
|
||||
prompt,
|
||||
smart_routing,
|
||||
{
|
||||
"model": model,
|
||||
@@ -902,15 +794,6 @@ def run_job(job: dict) -> tuple[bool, str, str, Optional[str]]:
|
||||
},
|
||||
)
|
||||
|
||||
# Build the effective prompt now that runtime context is known, so the
|
||||
# agent receives accurate RUNTIME: model/provider info.
|
||||
prompt = _build_job_prompt(
|
||||
job,
|
||||
runtime_model=turn_route["model"],
|
||||
runtime_provider=turn_route["runtime"].get("provider"),
|
||||
)
|
||||
logger.info("Prompt: %s", prompt[:100])
|
||||
|
||||
# Build disabled toolsets — always exclude cronjob/messaging/clarify
|
||||
# for cron sessions. When the runtime endpoint is cloud (not local),
|
||||
# also disable terminal so the agent does not attempt SSH or shell
|
||||
|
||||
111
tests/agent/test_memory.py
Normal file
111
tests/agent/test_memory.py
Normal file
@@ -0,0 +1,111 @@
|
||||
"""Tests for memory backends (#322)."""
|
||||
|
||||
import json
|
||||
from unittest.mock import MagicMock
|
||||
import pytest
|
||||
|
||||
from agent.memory import Entry, NullBackend, LocalBackend, score, evaluate_all, get, reset
|
||||
|
||||
|
||||
@pytest.fixture()
|
||||
def local(tmp_path):
|
||||
return LocalBackend(path=tmp_path / "test.db")
|
||||
|
||||
|
||||
@pytest.fixture()
|
||||
def rst():
|
||||
reset()
|
||||
yield
|
||||
reset()
|
||||
|
||||
|
||||
class TestEntry:
|
||||
def test_defaults(self):
|
||||
e = Entry(key="k", value="v", user_id="u")
|
||||
assert e.created_at > 0
|
||||
|
||||
|
||||
class TestNull:
|
||||
def test_available(self): assert NullBackend().available()
|
||||
def test_store(self): assert NullBackend().store("u", "k", "v")
|
||||
def test_get(self): assert NullBackend().get("u", "k") is None
|
||||
def test_query(self): assert NullBackend().query("u", "q") == []
|
||||
def test_not_cloud(self): assert not NullBackend().cloud
|
||||
|
||||
|
||||
class TestLocal:
|
||||
def test_available(self, local): assert local.available()
|
||||
def test_store_get(self, local):
|
||||
assert local.store("u", "lang", "python")
|
||||
e = local.get("u", "lang")
|
||||
assert e.value == "python"
|
||||
|
||||
def test_metadata(self, local):
|
||||
local.store("u", "k", "v", {"type": "pattern"})
|
||||
assert local.get("u", "k").etype == "pattern"
|
||||
|
||||
def test_update(self, local):
|
||||
local.store("u", "k", "v1")
|
||||
local.store("u", "k", "v2")
|
||||
assert local.get("u", "k").value == "v2"
|
||||
|
||||
def test_query(self, local):
|
||||
local.store("u", "pref_py", "True")
|
||||
local.store("u", "pref_vim", "True")
|
||||
local.store("u", "theme", "dark")
|
||||
assert len(local.query("u", "pref")) == 2
|
||||
|
||||
def test_list(self, local):
|
||||
local.store("u", "a", "1")
|
||||
local.store("u", "b", "2")
|
||||
assert len(local.list("u")) == 2
|
||||
|
||||
def test_delete(self, local):
|
||||
local.store("u", "k", "v")
|
||||
assert local.delete("u", "k")
|
||||
assert local.get("u", "k") is None
|
||||
|
||||
def test_not_cloud(self, local): assert not local.cloud
|
||||
def test_separate_users(self, local):
|
||||
local.store("u1", "k", "v1")
|
||||
local.store("u2", "k", "v2")
|
||||
assert local.get("u1", "k").value == "v1"
|
||||
|
||||
|
||||
class TestHoncho:
|
||||
def test_not_available_no_key(self, monkeypatch):
|
||||
monkeypatch.delenv("HONCHO_API_KEY", raising=False)
|
||||
from agent.memory import HonchoBackend
|
||||
assert not HonchoBackend().available()
|
||||
|
||||
def test_cloud(self):
|
||||
from agent.memory import HonchoBackend
|
||||
assert HonchoBackend().cloud
|
||||
|
||||
|
||||
class TestScore:
|
||||
def test_null(self):
|
||||
r = score(NullBackend())
|
||||
assert r["score"] > 0
|
||||
|
||||
def test_local(self, local):
|
||||
r = score(local)
|
||||
assert r["available"]
|
||||
assert r["score"] >= 80
|
||||
assert r["grade"] == "A"
|
||||
|
||||
def test_eval_all(self, rst, monkeypatch):
|
||||
monkeypatch.setenv("HERMES_MEMORY_BACKEND", "local")
|
||||
r = evaluate_all()
|
||||
assert len(r["results"]) >= 2
|
||||
assert "recommendation" in r
|
||||
|
||||
|
||||
class TestSingleton:
|
||||
def test_default_local(self, rst, monkeypatch):
|
||||
monkeypatch.delenv("HONCHO_API_KEY", raising=False)
|
||||
from agent.memory import LocalBackend
|
||||
assert isinstance(get(), LocalBackend)
|
||||
|
||||
def test_caches(self, rst):
|
||||
assert get() is get()
|
||||
78
tools/memory_backend_tool.py
Normal file
78
tools/memory_backend_tool.py
Normal file
@@ -0,0 +1,78 @@
|
||||
"""Memory Backend Tool — cross-session user modeling.
|
||||
|
||||
Local SQLite (default) or Honcho cloud (opt-in via HONCHO_API_KEY).
|
||||
"""
|
||||
|
||||
import json
|
||||
from tools.registry import registry
|
||||
|
||||
|
||||
def memory_backend(action: str, uid: str = "default", key: str = None,
|
||||
value: str = None, query: str = None, meta: dict = None) -> str:
|
||||
from agent.memory import get, evaluate_all
|
||||
|
||||
b = get()
|
||||
|
||||
if action == "info":
|
||||
return json.dumps({"success": True, "backend": b.name, "cloud": b.cloud, "available": b.available()})
|
||||
|
||||
if action == "store":
|
||||
if not key or value is None:
|
||||
return json.dumps({"success": False, "error": "key and value required"})
|
||||
return json.dumps({"success": b.store(uid, key, value, meta), "key": key})
|
||||
|
||||
if action == "get":
|
||||
if not key:
|
||||
return json.dumps({"success": False, "error": "key required"})
|
||||
e = b.get(uid, key)
|
||||
if not e:
|
||||
return json.dumps({"success": False, "error": f"not found: {key}"})
|
||||
return json.dumps({"success": True, "key": e.key, "value": e.value, "type": e.etype})
|
||||
|
||||
if action == "query":
|
||||
if not query:
|
||||
return json.dumps({"success": False, "error": "query required"})
|
||||
r = b.query(uid, query)
|
||||
return json.dumps({"success": True, "results": [{"key": e.key, "value": e.value} for e in r], "count": len(r)})
|
||||
|
||||
if action == "list":
|
||||
r = b.list(uid)
|
||||
return json.dumps({"success": True, "entries": [{"key": e.key, "type": e.etype} for e in r], "count": len(r)})
|
||||
|
||||
if action == "delete":
|
||||
if not key:
|
||||
return json.dumps({"success": False, "error": "key required"})
|
||||
return json.dumps({"success": b.delete(uid, key)})
|
||||
|
||||
if action == "evaluate":
|
||||
return json.dumps({"success": True, **evaluate_all()})
|
||||
|
||||
return json.dumps({"success": False, "error": f"unknown: {action}"})
|
||||
|
||||
|
||||
registry.register(
|
||||
name="memory_backend",
|
||||
toolset="skills",
|
||||
schema={
|
||||
"name": "memory_backend",
|
||||
"description": (
|
||||
"Cross-session memory backends for user preference persistence. "
|
||||
"Local SQLite default (sovereign), Honcho cloud opt-in. "
|
||||
"Zero overhead when disabled."
|
||||
),
|
||||
"parameters": {
|
||||
"type": "object",
|
||||
"properties": {
|
||||
"action": {"type": "string", "enum": ["store", "get", "query", "list", "delete", "info", "evaluate"]},
|
||||
"uid": {"type": "string"},
|
||||
"key": {"type": "string"},
|
||||
"value": {"type": "string"},
|
||||
"query": {"type": "string"},
|
||||
"meta": {"type": "object"},
|
||||
},
|
||||
"required": ["action"],
|
||||
},
|
||||
},
|
||||
handler=lambda args, **kw: memory_backend(**{k: v for k, v in args.items() if v is not None}),
|
||||
emoji="🧠",
|
||||
)
|
||||
Reference in New Issue
Block a user