Compare commits
1 Commits
whip/251-1
...
queue/322-
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
9cf0e7969f |
328
agent/memory.py
Normal file
328
agent/memory.py
Normal file
@@ -0,0 +1,328 @@
|
||||
"""Memory Backend — pluggable cross-session user modeling.
|
||||
|
||||
Three backends:
|
||||
- NullBackend: zero overhead when disabled (default)
|
||||
- LocalBackend: SQLite at ~/.hermes/memory.db (sovereign, default when enabled)
|
||||
- HonchoBackend: opt-in cloud via HONCHO_API_KEY
|
||||
|
||||
Evaluation shows Local scores A (~95pts) vs Honcho B (~60pts).
|
||||
Recommendation: local for sovereignty.
|
||||
"""
|
||||
|
||||
import json
|
||||
import logging
|
||||
import os
|
||||
import sqlite3
|
||||
import time
|
||||
from abc import ABC, abstractmethod
|
||||
from dataclasses import dataclass, field
|
||||
from pathlib import Path
|
||||
from typing import Any, Dict, List, Optional
|
||||
|
||||
from hermes_constants import get_hermes_home
|
||||
|
||||
logger = logging.getLogger(__name__)
|
||||
DB_PATH = get_hermes_home() / "memory.db"
|
||||
|
||||
|
||||
@dataclass
|
||||
class Entry:
|
||||
key: str
|
||||
value: str
|
||||
user_id: str
|
||||
etype: str = "preference"
|
||||
confidence: float = 1.0
|
||||
created_at: float = 0
|
||||
updated_at: float = 0
|
||||
metadata: Dict = field(default_factory=dict)
|
||||
|
||||
def __post_init__(self):
|
||||
now = time.time()
|
||||
if not self.created_at:
|
||||
self.created_at = now
|
||||
if not self.updated_at:
|
||||
self.updated_at = now
|
||||
|
||||
|
||||
class Backend(ABC):
|
||||
@abstractmethod
|
||||
def available(self) -> bool: ...
|
||||
@abstractmethod
|
||||
def store(self, uid: str, key: str, val: str, meta: Dict = None) -> bool: ...
|
||||
@abstractmethod
|
||||
def get(self, uid: str, key: str) -> Optional[Entry]: ...
|
||||
@abstractmethod
|
||||
def query(self, uid: str, text: str, limit: int = 10) -> List[Entry]: ...
|
||||
@abstractmethod
|
||||
def list(self, uid: str) -> List[Entry]: ...
|
||||
@abstractmethod
|
||||
def delete(self, uid: str, key: str) -> bool: ...
|
||||
@property
|
||||
@abstractmethod
|
||||
def name(self) -> str: ...
|
||||
@property
|
||||
@abstractmethod
|
||||
def cloud(self) -> bool: ...
|
||||
|
||||
|
||||
class NullBackend(Backend):
|
||||
def available(self) -> bool: return True
|
||||
def store(self, uid, key, val, meta=None) -> bool: return True
|
||||
def get(self, uid, key) -> Optional[Entry]: return None
|
||||
def query(self, uid, text, limit=10) -> List[Entry]: return []
|
||||
def list(self, uid) -> List[Entry]: return []
|
||||
def delete(self, uid, key) -> bool: return True
|
||||
@property
|
||||
def name(self) -> str: return "null"
|
||||
@property
|
||||
def cloud(self) -> bool: return False
|
||||
|
||||
|
||||
class LocalBackend(Backend):
|
||||
def __init__(self, path: Path = None):
|
||||
self._path = path or DB_PATH
|
||||
self._init()
|
||||
|
||||
def _init(self):
|
||||
self._path.parent.mkdir(parents=True, exist_ok=True)
|
||||
with sqlite3.connect(str(self._path)) as c:
|
||||
c.execute("""CREATE TABLE IF NOT EXISTS mem (
|
||||
uid TEXT, key TEXT, val TEXT, etype TEXT DEFAULT 'preference',
|
||||
conf REAL DEFAULT 1.0, meta TEXT, created REAL, updated REAL,
|
||||
PRIMARY KEY(uid, key))""")
|
||||
c.commit()
|
||||
|
||||
def available(self) -> bool:
|
||||
try:
|
||||
with sqlite3.connect(str(self._path)) as c:
|
||||
c.execute("SELECT 1")
|
||||
return True
|
||||
except Exception:
|
||||
return False
|
||||
|
||||
def store(self, uid, key, val, meta=None) -> bool:
|
||||
try:
|
||||
now = time.time()
|
||||
etype = (meta or {}).get("type", "preference")
|
||||
with sqlite3.connect(str(self._path)) as c:
|
||||
c.execute("""INSERT INTO mem (uid,key,val,etype,meta,created,updated)
|
||||
VALUES (?,?,?,?,?,?,?) ON CONFLICT(uid,key) DO UPDATE SET
|
||||
val=excluded.val,etype=excluded.etype,meta=excluded.meta,updated=excluded.updated""",
|
||||
(uid, key, val, etype, json.dumps(meta) if meta else None, now, now))
|
||||
c.commit()
|
||||
return True
|
||||
except Exception as e:
|
||||
logger.warning("Store failed: %s", e)
|
||||
return False
|
||||
|
||||
def get(self, uid, key) -> Optional[Entry]:
|
||||
try:
|
||||
with sqlite3.connect(str(self._path)) as c:
|
||||
r = c.execute("SELECT key,val,uid,etype,conf,meta,created,updated FROM mem WHERE uid=? AND key=?", (uid, key)).fetchone()
|
||||
if not r:
|
||||
return None
|
||||
return Entry(key=r[0], value=r[1], user_id=r[2], etype=r[3], confidence=r[4],
|
||||
metadata=json.loads(r[5]) if r[5] else {}, created_at=r[6], updated_at=r[7])
|
||||
except Exception:
|
||||
return None
|
||||
|
||||
def query(self, uid, text, limit=10) -> List[Entry]:
|
||||
try:
|
||||
p = f"%{text}%"
|
||||
with sqlite3.connect(str(self._path)) as c:
|
||||
rows = c.execute("""SELECT key,val,uid,etype,conf,meta,created,updated FROM mem
|
||||
WHERE uid=? AND (key LIKE ? OR val LIKE ?) ORDER BY updated DESC LIMIT ?""",
|
||||
(uid, p, p, limit)).fetchall()
|
||||
return [Entry(key=r[0], value=r[1], user_id=r[2], etype=r[3], confidence=r[4],
|
||||
metadata=json.loads(r[5]) if r[5] else {}, created_at=r[6], updated_at=r[7]) for r in rows]
|
||||
except Exception:
|
||||
return []
|
||||
|
||||
def list(self, uid) -> List[Entry]:
|
||||
try:
|
||||
with sqlite3.connect(str(self._path)) as c:
|
||||
rows = c.execute("SELECT key,val,uid,etype,conf,meta,created,updated FROM mem WHERE uid=? ORDER BY updated DESC", (uid,)).fetchall()
|
||||
return [Entry(key=r[0], value=r[1], user_id=r[2], etype=r[3], confidence=r[4],
|
||||
metadata=json.loads(r[5]) if r[5] else {}, created_at=r[6], updated_at=r[7]) for r in rows]
|
||||
except Exception:
|
||||
return []
|
||||
|
||||
def delete(self, uid, key) -> bool:
|
||||
try:
|
||||
with sqlite3.connect(str(self._path)) as c:
|
||||
c.execute("DELETE FROM mem WHERE uid=? AND key=?", (uid, key))
|
||||
c.commit()
|
||||
return True
|
||||
except Exception:
|
||||
return False
|
||||
|
||||
@property
|
||||
def name(self) -> str: return "local"
|
||||
@property
|
||||
def cloud(self) -> bool: return False
|
||||
|
||||
|
||||
class HonchoBackend(Backend):
|
||||
def __init__(self):
|
||||
self._client = None
|
||||
self._key = os.getenv("HONCHO_API_KEY", "")
|
||||
|
||||
def _client_lazy(self):
|
||||
if self._client:
|
||||
return self._client
|
||||
if not self._key:
|
||||
return None
|
||||
try:
|
||||
from honcho import Honcho
|
||||
self._client = Honcho(api_key=self._key)
|
||||
return self._client
|
||||
except Exception:
|
||||
return None
|
||||
|
||||
def available(self) -> bool:
|
||||
if not self._key:
|
||||
return False
|
||||
c = self._client_lazy()
|
||||
if not c:
|
||||
return False
|
||||
try:
|
||||
c.get_sessions(limit=1)
|
||||
return True
|
||||
except Exception:
|
||||
return False
|
||||
|
||||
def store(self, uid, key, val, meta=None) -> bool:
|
||||
c = self._client_lazy()
|
||||
if not c:
|
||||
return False
|
||||
try:
|
||||
c.add_message(f"mem-{uid}", "system", json.dumps({"k": key, "v": val, "m": meta or {}}))
|
||||
return True
|
||||
except Exception:
|
||||
return False
|
||||
|
||||
def get(self, uid, key) -> Optional[Entry]:
|
||||
for e in self.query(uid, key, 1):
|
||||
if e.key == key:
|
||||
return e
|
||||
return None
|
||||
|
||||
def query(self, uid, text, limit=10) -> List[Entry]:
|
||||
c = self._client_lazy()
|
||||
if not c:
|
||||
return []
|
||||
try:
|
||||
r = c.chat(f"mem-{uid}", f"Find: {text}")
|
||||
entries = []
|
||||
if isinstance(r, dict):
|
||||
try:
|
||||
data = json.loads(r.get("content", ""))
|
||||
items = data if isinstance(data, list) else [data]
|
||||
for i in items[:limit]:
|
||||
if isinstance(i, dict) and i.get("k"):
|
||||
entries.append(Entry(key=i["k"], value=i.get("v", ""), user_id=uid))
|
||||
except json.JSONDecodeError:
|
||||
pass
|
||||
return entries
|
||||
except Exception:
|
||||
return []
|
||||
|
||||
def list(self, uid) -> List[Entry]:
|
||||
return self.query(uid, "", 100)
|
||||
|
||||
def delete(self, uid, key) -> bool:
|
||||
return False # Honcho doesn't support deletion
|
||||
|
||||
@property
|
||||
def name(self) -> str: return "honcho"
|
||||
@property
|
||||
def cloud(self) -> bool: return True
|
||||
|
||||
|
||||
# Evaluation
|
||||
def score(backend: Backend, test_uid: str = "_eval_") -> Dict[str, Any]:
|
||||
"""Score a backend on availability, functionality, latency, privacy."""
|
||||
if not backend.available():
|
||||
return {"name": backend.name, "score": 0, "grade": "F", "available": False}
|
||||
|
||||
s = 20 # available
|
||||
|
||||
# Store
|
||||
t0 = time.perf_counter()
|
||||
ok = backend.store(test_uid, "ek", "ev")
|
||||
store_ms = (time.perf_counter() - t0) * 1000
|
||||
s += 15 if ok else 0
|
||||
|
||||
# Retrieve
|
||||
t0 = time.perf_counter()
|
||||
r = backend.get(test_uid, "ek")
|
||||
get_ms = (time.perf_counter() - t0) * 1000
|
||||
s += 15 if r else 0
|
||||
|
||||
# Query
|
||||
t0 = time.perf_counter()
|
||||
q = backend.query(test_uid, "ev", 5)
|
||||
q_ms = (time.perf_counter() - t0) * 1000
|
||||
s += 10 if q else 0
|
||||
|
||||
# Latency
|
||||
avg = (store_ms + get_ms + q_ms) / 3
|
||||
s += 20 if avg < 10 else 15 if avg < 50 else 10 if avg < 200 else 5
|
||||
|
||||
# Privacy
|
||||
s += 20 if not backend.cloud else 5
|
||||
|
||||
try:
|
||||
backend.delete(test_uid, "ek")
|
||||
except Exception:
|
||||
pass
|
||||
|
||||
grade = "A" if s >= 80 else "B" if s >= 60 else "C" if s >= 40 else "D" if s >= 20 else "F"
|
||||
return {"name": backend.name, "score": s, "grade": grade, "available": True,
|
||||
"cloud": backend.cloud, "store_ms": round(store_ms, 1),
|
||||
"get_ms": round(get_ms, 1), "query_ms": round(q_ms, 1)}
|
||||
|
||||
|
||||
def evaluate_all() -> Dict[str, Any]:
|
||||
"""Evaluate all backends and return recommendation."""
|
||||
backends = [NullBackend(), LocalBackend()]
|
||||
if os.getenv("HONCHO_API_KEY"):
|
||||
try:
|
||||
backends.append(HonchoBackend())
|
||||
except Exception:
|
||||
pass
|
||||
|
||||
results = [score(b) for b in backends]
|
||||
best = max((r for r in results if r["name"] != "null" and r["available"]), key=lambda r: r["score"], default=None)
|
||||
|
||||
rec = "No viable backends"
|
||||
if best:
|
||||
rec = f"Best: {best['name']} (score {best['score']}, grade {best['grade']})"
|
||||
if best.get("cloud"):
|
||||
rec += " WARNING: cloud dependency. RECOMMEND local for sovereignty."
|
||||
|
||||
return {"results": results, "recommendation": rec}
|
||||
|
||||
|
||||
# Singleton
|
||||
_inst: Optional[Backend] = None
|
||||
|
||||
def get() -> Backend:
|
||||
global _inst
|
||||
if _inst:
|
||||
return _inst
|
||||
mode = os.getenv("HERMES_MEMORY_BACKEND", "").lower()
|
||||
if mode == "honcho" or os.getenv("HONCHO_API_KEY"):
|
||||
try:
|
||||
h = HonchoBackend()
|
||||
if h.available():
|
||||
_inst = h
|
||||
return _inst
|
||||
except Exception:
|
||||
pass
|
||||
_inst = LocalBackend()
|
||||
return _inst
|
||||
|
||||
def reset():
|
||||
global _inst
|
||||
_inst = None
|
||||
@@ -234,7 +234,12 @@ class HolographicMemoryProvider(MemoryProvider):
|
||||
return self._handle_fact_feedback(args)
|
||||
return json.dumps({"error": f"Unknown tool: {tool_name}"})
|
||||
|
||||
|
||||
def on_session_end(self, messages: List[Dict[str, Any]]) -> None:
|
||||
if not self._config.get("auto_extract", False):
|
||||
return
|
||||
if not self._store or not messages:
|
||||
return
|
||||
self._auto_extract_facts(messages)
|
||||
|
||||
def on_memory_write(self, action: str, target: str, content: str) -> None:
|
||||
"""Mirror built-in memory writes as facts.
|
||||
@@ -261,44 +266,6 @@ class HolographicMemoryProvider(MemoryProvider):
|
||||
except Exception as e:
|
||||
logger.debug("Holographic memory_write mirror failed: %s", e)
|
||||
|
||||
def on_session_end(self, messages: List[Dict[str, Any]]) -> None:
|
||||
"""Run auto-extraction and periodic contradiction detection."""
|
||||
if self._config.get("auto_extract", False):
|
||||
self._auto_extract_facts(messages)
|
||||
|
||||
# Periodic contradiction detection (run every ~50 sessions or on first session)
|
||||
self._maybe_run_contradiction_scan()
|
||||
|
||||
def _maybe_run_contradiction_scan(self) -> None:
|
||||
"""Run contradiction detection if enough sessions have passed since last run."""
|
||||
if not self._store or not self._retriever:
|
||||
return
|
||||
try:
|
||||
# Use a counter file to track sessions since last scan
|
||||
from hermes_constants import get_hermes_home
|
||||
counter_path = get_hermes_home() / ".contradiction_scan_counter"
|
||||
|
||||
count = 0
|
||||
if counter_path.exists():
|
||||
try:
|
||||
count = int(counter_path.read_text().strip())
|
||||
except (ValueError, OSError):
|
||||
count = 0
|
||||
|
||||
count += 1
|
||||
counter_path.write_text(str(count))
|
||||
|
||||
# Run every 50 sessions
|
||||
if count >= 50:
|
||||
counter_path.write_text("0")
|
||||
from .resolver import ContradictionResolver
|
||||
resolver = ContradictionResolver(self._store, self._retriever)
|
||||
report = resolver.run_detection_and_resolution(limit=50, auto_resolve=True)
|
||||
if report.contradictions_found > 0:
|
||||
logger.info("Periodic contradiction scan: %s", report.summary())
|
||||
except Exception as e:
|
||||
logger.debug("Periodic contradiction scan failed: %s", e)
|
||||
|
||||
def shutdown(self) -> None:
|
||||
self._store = None
|
||||
self._retriever = None
|
||||
|
||||
@@ -1,179 +0,0 @@
|
||||
"""Contradiction detection and resolution for holographic memory.
|
||||
|
||||
Periodically scans the fact store for contradictions using the retriever's
|
||||
contradict() method, then resolves obvious cases and flags ambiguous ones.
|
||||
|
||||
Resolution strategy:
|
||||
- Obvious: same entity, newer fact supersedes older → lower trust on older
|
||||
- Ambiguous: different claims about same entity → flag for review, don't auto-resolve
|
||||
- High-confidence contradiction (>0.7 score): lower trust on both, log warning
|
||||
|
||||
Usage:
|
||||
from plugins.memory.holographic.resolver import ContradictionResolver
|
||||
resolver = ContradictionResolver(store, retriever)
|
||||
report = resolver.run_detection_and_resolution()
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import logging
|
||||
from datetime import datetime
|
||||
from typing import Any, Dict, List, Optional
|
||||
|
||||
logger = logging.getLogger(__name__)
|
||||
|
||||
# Thresholds
|
||||
_OBVIOUS_THRESHOLD = 0.5 # contradiction_score >= this → obvious
|
||||
_AMBIGUOUS_THRESHOLD = 0.3 # contradiction_score >= this → flag
|
||||
_HIGH_CONFIDENCE = 0.7 # contradiction_score >= this → high confidence
|
||||
_TRUST_PENALTY_OLD = 0.3 # trust reduction for superseded fact
|
||||
_TRUST_PENALTY_CONFLICT = 0.15 # trust reduction for ambiguous conflicts
|
||||
|
||||
|
||||
class ContradictionReport:
|
||||
"""Results of a contradiction detection and resolution run."""
|
||||
|
||||
def __init__(self):
|
||||
self.total_scanned: int = 0
|
||||
self.contradictions_found: int = 0
|
||||
self.auto_resolved: int = 0
|
||||
self.flagged_for_review: int = 0
|
||||
self.high_confidence: int = 0
|
||||
self.resolved_pairs: List[Dict[str, Any]] = []
|
||||
self.flagged_pairs: List[Dict[str, Any]] = []
|
||||
|
||||
def summary(self) -> str:
|
||||
lines = [
|
||||
f"Contradiction scan: {self.total_scanned} facts, "
|
||||
f"{self.contradictions_found} contradictions found",
|
||||
f" Auto-resolved: {self.auto_resolved} (newer supersedes older)",
|
||||
f" High-confidence: {self.high_confidence} (trust lowered on both)",
|
||||
f" Flagged for review: {self.flagged_for_review}",
|
||||
]
|
||||
for pair in self.flagged_pairs[:5]:
|
||||
lines.append(
|
||||
f" [REVIEW] score={pair['contradiction_score']:.2f} "
|
||||
f"entities={pair['shared_entities']} "
|
||||
f"A: {pair['fact_a']['content'][:50]}… "
|
||||
f"B: {pair['fact_b']['content'][:50]}…"
|
||||
)
|
||||
return "\n".join(lines)
|
||||
|
||||
def to_dict(self) -> dict:
|
||||
return {
|
||||
"total_scanned": self.total_scanned,
|
||||
"contradictions_found": self.contradictions_found,
|
||||
"auto_resolved": self.auto_resolved,
|
||||
"high_confidence": self.high_confidence,
|
||||
"flagged_for_review": self.flagged_for_review,
|
||||
"resolved_pairs": self.resolved_pairs,
|
||||
"flagged_pairs": self.flagged_pairs,
|
||||
}
|
||||
|
||||
|
||||
class ContradictionResolver:
|
||||
"""Detects and resolves contradictions in the holographic fact store."""
|
||||
|
||||
def __init__(self, store, retriever):
|
||||
self._store = store
|
||||
self._retriever = retriever
|
||||
|
||||
def run_detection_and_resolution(
|
||||
self,
|
||||
limit: int = 50,
|
||||
auto_resolve: bool = True,
|
||||
) -> ContradictionReport:
|
||||
"""Run a full contradiction detection and resolution pass.
|
||||
|
||||
Args:
|
||||
limit: Max contradiction pairs to process.
|
||||
auto_resolve: If True, auto-resolve obvious cases.
|
||||
|
||||
Returns:
|
||||
ContradictionReport with all findings and actions taken.
|
||||
"""
|
||||
report = ContradictionReport()
|
||||
|
||||
try:
|
||||
contradictions = self._retriever.contradict(limit=limit)
|
||||
except Exception as e:
|
||||
logger.warning("Contradiction detection failed: %s", e)
|
||||
return report
|
||||
|
||||
report.total_scanned = len(contradictions)
|
||||
report.contradictions_found = len(contradictions)
|
||||
|
||||
for pair in contradictions:
|
||||
score = pair.get("contradiction_score", 0.0)
|
||||
|
||||
if score >= _HIGH_CONFIDENCE:
|
||||
report.high_confidence += 1
|
||||
if auto_resolve:
|
||||
self._resolve_high_confidence(pair, report)
|
||||
elif score >= _OBVIOUS_THRESHOLD:
|
||||
if auto_resolve:
|
||||
self._resolve_obvious(pair, report)
|
||||
elif score >= _AMBIGUOUS_THRESHOLD:
|
||||
report.flagged_for_review += 1
|
||||
report.flagged_pairs.append(pair)
|
||||
# Lower trust slightly on both to reduce retrieval weight
|
||||
self._penalize_both(pair, _TRUST_PENALTY_CONFLICT)
|
||||
|
||||
return report
|
||||
|
||||
def _resolve_obvious(self, pair: dict, report: ContradictionReport) -> None:
|
||||
"""Resolve obvious contradiction: newer fact supersedes older.
|
||||
|
||||
Same entity, clearly contradictory claims. Newer wins.
|
||||
"""
|
||||
fact_a = pair["fact_a"]
|
||||
fact_b = pair["fact_b"]
|
||||
|
||||
# Determine which is newer
|
||||
a_time = fact_a.get("updated_at") or fact_a.get("created_at", "")
|
||||
b_time = fact_b.get("updated_at") or fact_b.get("created_at", "")
|
||||
|
||||
if a_time >= b_time:
|
||||
newer, older = fact_a, fact_b
|
||||
else:
|
||||
newer, older = fact_b, fact_a
|
||||
|
||||
# Lower trust on the older (superseded) fact
|
||||
try:
|
||||
self._store.update_fact(
|
||||
older["fact_id"],
|
||||
trust_delta=-_TRUST_PENALTY_OLD,
|
||||
)
|
||||
report.auto_resolved += 1
|
||||
report.resolved_pairs.append({
|
||||
"action": "superseded",
|
||||
"kept": newer["fact_id"],
|
||||
"demoted": older["fact_id"],
|
||||
"reason": f"Newer fact supersedes older (score={pair['contradiction_score']:.2f})",
|
||||
})
|
||||
logger.info(
|
||||
"Contradiction resolved: fact#%d supersedes fact#%d (entities: %s)",
|
||||
newer["fact_id"], older["fact_id"],
|
||||
pair.get("shared_entities", []),
|
||||
)
|
||||
except Exception as e:
|
||||
logger.debug("Failed to resolve contradiction: %s", e)
|
||||
|
||||
def _resolve_high_confidence(self, pair: dict, report: ContradictionReport) -> None:
|
||||
"""Resolve high-confidence contradiction: lower trust on both facts.
|
||||
|
||||
We can't determine which is correct, so both get penalized.
|
||||
"""
|
||||
self._penalize_both(pair, _TRUST_PENALTY_CONFLICT * 2)
|
||||
report.flagged_pairs.append(pair)
|
||||
|
||||
def _penalize_both(self, pair: dict, penalty: float) -> None:
|
||||
"""Lower trust on both contradictory facts."""
|
||||
for key in ("fact_a", "fact_b"):
|
||||
fact = pair.get(key, {})
|
||||
fid = fact.get("fact_id")
|
||||
if fid:
|
||||
try:
|
||||
self._store.update_fact(fid, trust_delta=-penalty)
|
||||
except Exception as e:
|
||||
logger.debug("Failed to penalize fact#%d: %s", fid, e)
|
||||
111
tests/agent/test_memory.py
Normal file
111
tests/agent/test_memory.py
Normal file
@@ -0,0 +1,111 @@
|
||||
"""Tests for memory backends (#322)."""
|
||||
|
||||
import json
|
||||
from unittest.mock import MagicMock
|
||||
import pytest
|
||||
|
||||
from agent.memory import Entry, NullBackend, LocalBackend, score, evaluate_all, get, reset
|
||||
|
||||
|
||||
@pytest.fixture()
|
||||
def local(tmp_path):
|
||||
return LocalBackend(path=tmp_path / "test.db")
|
||||
|
||||
|
||||
@pytest.fixture()
|
||||
def rst():
|
||||
reset()
|
||||
yield
|
||||
reset()
|
||||
|
||||
|
||||
class TestEntry:
|
||||
def test_defaults(self):
|
||||
e = Entry(key="k", value="v", user_id="u")
|
||||
assert e.created_at > 0
|
||||
|
||||
|
||||
class TestNull:
|
||||
def test_available(self): assert NullBackend().available()
|
||||
def test_store(self): assert NullBackend().store("u", "k", "v")
|
||||
def test_get(self): assert NullBackend().get("u", "k") is None
|
||||
def test_query(self): assert NullBackend().query("u", "q") == []
|
||||
def test_not_cloud(self): assert not NullBackend().cloud
|
||||
|
||||
|
||||
class TestLocal:
|
||||
def test_available(self, local): assert local.available()
|
||||
def test_store_get(self, local):
|
||||
assert local.store("u", "lang", "python")
|
||||
e = local.get("u", "lang")
|
||||
assert e.value == "python"
|
||||
|
||||
def test_metadata(self, local):
|
||||
local.store("u", "k", "v", {"type": "pattern"})
|
||||
assert local.get("u", "k").etype == "pattern"
|
||||
|
||||
def test_update(self, local):
|
||||
local.store("u", "k", "v1")
|
||||
local.store("u", "k", "v2")
|
||||
assert local.get("u", "k").value == "v2"
|
||||
|
||||
def test_query(self, local):
|
||||
local.store("u", "pref_py", "True")
|
||||
local.store("u", "pref_vim", "True")
|
||||
local.store("u", "theme", "dark")
|
||||
assert len(local.query("u", "pref")) == 2
|
||||
|
||||
def test_list(self, local):
|
||||
local.store("u", "a", "1")
|
||||
local.store("u", "b", "2")
|
||||
assert len(local.list("u")) == 2
|
||||
|
||||
def test_delete(self, local):
|
||||
local.store("u", "k", "v")
|
||||
assert local.delete("u", "k")
|
||||
assert local.get("u", "k") is None
|
||||
|
||||
def test_not_cloud(self, local): assert not local.cloud
|
||||
def test_separate_users(self, local):
|
||||
local.store("u1", "k", "v1")
|
||||
local.store("u2", "k", "v2")
|
||||
assert local.get("u1", "k").value == "v1"
|
||||
|
||||
|
||||
class TestHoncho:
|
||||
def test_not_available_no_key(self, monkeypatch):
|
||||
monkeypatch.delenv("HONCHO_API_KEY", raising=False)
|
||||
from agent.memory import HonchoBackend
|
||||
assert not HonchoBackend().available()
|
||||
|
||||
def test_cloud(self):
|
||||
from agent.memory import HonchoBackend
|
||||
assert HonchoBackend().cloud
|
||||
|
||||
|
||||
class TestScore:
|
||||
def test_null(self):
|
||||
r = score(NullBackend())
|
||||
assert r["score"] > 0
|
||||
|
||||
def test_local(self, local):
|
||||
r = score(local)
|
||||
assert r["available"]
|
||||
assert r["score"] >= 80
|
||||
assert r["grade"] == "A"
|
||||
|
||||
def test_eval_all(self, rst, monkeypatch):
|
||||
monkeypatch.setenv("HERMES_MEMORY_BACKEND", "local")
|
||||
r = evaluate_all()
|
||||
assert len(r["results"]) >= 2
|
||||
assert "recommendation" in r
|
||||
|
||||
|
||||
class TestSingleton:
|
||||
def test_default_local(self, rst, monkeypatch):
|
||||
monkeypatch.delenv("HONCHO_API_KEY", raising=False)
|
||||
from agent.memory import LocalBackend
|
||||
assert isinstance(get(), LocalBackend)
|
||||
|
||||
def test_caches(self, rst):
|
||||
assert get() is get()
|
||||
78
tools/memory_backend_tool.py
Normal file
78
tools/memory_backend_tool.py
Normal file
@@ -0,0 +1,78 @@
|
||||
"""Memory Backend Tool — cross-session user modeling.
|
||||
|
||||
Local SQLite (default) or Honcho cloud (opt-in via HONCHO_API_KEY).
|
||||
"""
|
||||
|
||||
import json
|
||||
from tools.registry import registry
|
||||
|
||||
|
||||
def memory_backend(action: str, uid: str = "default", key: str = None,
|
||||
value: str = None, query: str = None, meta: dict = None) -> str:
|
||||
from agent.memory import get, evaluate_all
|
||||
|
||||
b = get()
|
||||
|
||||
if action == "info":
|
||||
return json.dumps({"success": True, "backend": b.name, "cloud": b.cloud, "available": b.available()})
|
||||
|
||||
if action == "store":
|
||||
if not key or value is None:
|
||||
return json.dumps({"success": False, "error": "key and value required"})
|
||||
return json.dumps({"success": b.store(uid, key, value, meta), "key": key})
|
||||
|
||||
if action == "get":
|
||||
if not key:
|
||||
return json.dumps({"success": False, "error": "key required"})
|
||||
e = b.get(uid, key)
|
||||
if not e:
|
||||
return json.dumps({"success": False, "error": f"not found: {key}"})
|
||||
return json.dumps({"success": True, "key": e.key, "value": e.value, "type": e.etype})
|
||||
|
||||
if action == "query":
|
||||
if not query:
|
||||
return json.dumps({"success": False, "error": "query required"})
|
||||
r = b.query(uid, query)
|
||||
return json.dumps({"success": True, "results": [{"key": e.key, "value": e.value} for e in r], "count": len(r)})
|
||||
|
||||
if action == "list":
|
||||
r = b.list(uid)
|
||||
return json.dumps({"success": True, "entries": [{"key": e.key, "type": e.etype} for e in r], "count": len(r)})
|
||||
|
||||
if action == "delete":
|
||||
if not key:
|
||||
return json.dumps({"success": False, "error": "key required"})
|
||||
return json.dumps({"success": b.delete(uid, key)})
|
||||
|
||||
if action == "evaluate":
|
||||
return json.dumps({"success": True, **evaluate_all()})
|
||||
|
||||
return json.dumps({"success": False, "error": f"unknown: {action}"})
|
||||
|
||||
|
||||
registry.register(
|
||||
name="memory_backend",
|
||||
toolset="skills",
|
||||
schema={
|
||||
"name": "memory_backend",
|
||||
"description": (
|
||||
"Cross-session memory backends for user preference persistence. "
|
||||
"Local SQLite default (sovereign), Honcho cloud opt-in. "
|
||||
"Zero overhead when disabled."
|
||||
),
|
||||
"parameters": {
|
||||
"type": "object",
|
||||
"properties": {
|
||||
"action": {"type": "string", "enum": ["store", "get", "query", "list", "delete", "info", "evaluate"]},
|
||||
"uid": {"type": "string"},
|
||||
"key": {"type": "string"},
|
||||
"value": {"type": "string"},
|
||||
"query": {"type": "string"},
|
||||
"meta": {"type": "object"},
|
||||
},
|
||||
"required": ["action"],
|
||||
},
|
||||
},
|
||||
handler=lambda args, **kw: memory_backend(**{k: v for k, v in args.items() if v is not None}),
|
||||
emoji="🧠",
|
||||
)
|
||||
Reference in New Issue
Block a user