Compare commits
1 Commits
fix/1444
...
burn/672-1
| Author | SHA1 | Date | |
|---|---|---|---|
|
ca9cf76469 |
@@ -1,160 +0,0 @@
|
||||
# .gitea/workflows/auto-assign-reviewers.yml
|
||||
# Automated reviewer assignment for PRs
|
||||
# Issue #1444: policy: Implement automated reviewer assignment
|
||||
|
||||
name: Auto-Assign Reviewers
|
||||
|
||||
on:
|
||||
pull_request:
|
||||
types: [opened, reopened, ready_for_review]
|
||||
|
||||
jobs:
|
||||
auto-assign:
|
||||
runs-on: ubuntu-latest
|
||||
if: github.event.pull_request.draft == false
|
||||
|
||||
steps:
|
||||
- name: Checkout code
|
||||
uses: actions/checkout@v3
|
||||
|
||||
- name: Auto-assign reviewers
|
||||
env:
|
||||
GITEA_TOKEN: ${{ secrets.GITEA_TOKEN }}
|
||||
PR_NUMBER: ${{ github.event.pull_request.number }}
|
||||
REPO: ${{ github.repository }}
|
||||
PR_AUTHOR: ${{ github.event.pull_request.user.login }}
|
||||
run: |
|
||||
echo "Auto-assigning reviewers for PR #$PR_NUMBER"
|
||||
echo "Repository: $REPO"
|
||||
echo "PR Author: $PR_AUTHOR"
|
||||
|
||||
# Get repository name
|
||||
REPO_NAME=$(basename "$REPO")
|
||||
|
||||
# Define default reviewers based on repository
|
||||
case "$REPO_NAME" in
|
||||
"hermes-agent")
|
||||
DEFAULT_REVIEWERS=("Timmy" "perplexity")
|
||||
REQUIRED_REVIEWERS=("Timmy")
|
||||
;;
|
||||
"the-nexus")
|
||||
DEFAULT_REVIEWERS=("perplexity")
|
||||
REQUIRED_REVIEWERS=()
|
||||
;;
|
||||
"timmy-home")
|
||||
DEFAULT_REVIEWERS=("perplexity")
|
||||
REQUIRED_REVIEWERS=()
|
||||
;;
|
||||
"timmy-config")
|
||||
DEFAULT_REVIEWERS=("perplexity")
|
||||
REQUIRED_REVIEWERS=()
|
||||
;;
|
||||
*)
|
||||
DEFAULT_REVIEWERS=("perplexity")
|
||||
REQUIRED_REVIEWERS=()
|
||||
;;
|
||||
esac
|
||||
|
||||
# Combine default and required reviewers
|
||||
ALL_REVIEWERS=("${DEFAULT_REVIEWERS[@]}" "${REQUIRED_REVIEWERS[@]}")
|
||||
|
||||
# Remove duplicates
|
||||
UNIQUE_REVIEWERS=($(echo "${ALL_REVIEWERS[@]}" | tr ' ' '\n' | sort -u | tr '\n' ' '))
|
||||
|
||||
# Remove PR author from reviewers (can't review own PR)
|
||||
FINAL_REVIEWERS=()
|
||||
for reviewer in "${UNIQUE_REVIEWERS[@]}"; do
|
||||
if [ "$reviewer" != "$PR_AUTHOR" ]; then
|
||||
FINAL_REVIEWERS+=("$reviewer")
|
||||
fi
|
||||
done
|
||||
|
||||
# Check if we have any reviewers
|
||||
if [ ${#FINAL_REVIEWERS[@]} -eq 0 ]; then
|
||||
echo "⚠️ WARNING: No reviewers available (author is only reviewer)"
|
||||
echo "Adding fallback reviewer: perplexity"
|
||||
FINAL_REVIEWERS=("perplexity")
|
||||
fi
|
||||
|
||||
echo "Assigning reviewers: ${FINAL_REVIEWERS[*]}"
|
||||
|
||||
# Assign reviewers via Gitea API
|
||||
for reviewer in "${FINAL_REVIEWERS[@]}"; do
|
||||
echo "Assigning $reviewer as reviewer..."
|
||||
|
||||
# Use Gitea API to request reviewer
|
||||
RESPONSE=$(curl -s -w "%{http_code}" -X POST \
|
||||
"https://forge.alexanderwhitestone.com/api/v1/repos/$REPO/pulls/$PR_NUMBER/requested_reviewers" \
|
||||
-H "Authorization: token $GITEA_TOKEN" \
|
||||
-H "Content-Type: application/json" \
|
||||
-d "{\"reviewers\": [\"$reviewer\"]}")
|
||||
|
||||
HTTP_CODE="${RESPONSE: -3}"
|
||||
RESPONSE_BODY="${RESPONSE:0:${#RESPONSE}-3}"
|
||||
|
||||
if [ "$HTTP_CODE" -eq 201 ]; then
|
||||
echo "✅ Successfully assigned $reviewer as reviewer"
|
||||
elif [ "$HTTP_CODE" -eq 422 ]; then
|
||||
echo "⚠️ $reviewer is already a reviewer or cannot be assigned"
|
||||
else
|
||||
echo "❌ Failed to assign $reviewer (HTTP $HTTP_CODE): $RESPONSE_BODY"
|
||||
fi
|
||||
done
|
||||
|
||||
# Verify at least one reviewer was assigned
|
||||
echo ""
|
||||
echo "Checking assigned reviewers..."
|
||||
|
||||
REVIEWERS_RESPONSE=$(curl -s \
|
||||
"https://forge.alexanderwhitestone.com/api/v1/repos/$REPO/pulls/$PR_NUMBER/requested_reviewers" \
|
||||
-H "Authorization: token $GITEA_TOKEN")
|
||||
|
||||
REVIEWER_COUNT=$(echo "$REVIEWERS_RESPONSE" | jq '.users | length' 2>/dev/null || echo "0")
|
||||
|
||||
if [ "$REVIEWER_COUNT" -gt 0 ]; then
|
||||
echo "✅ PR #$PR_NUMBER has $REVIEWER_COUNT reviewer(s) assigned"
|
||||
echo "$REVIEWERS_RESPONSE" | jq '.users[].login' 2>/dev/null || echo "$REVIEWERS_RESPONSE"
|
||||
else
|
||||
echo "❌ ERROR: No reviewers assigned to PR #$PR_NUMBER"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
- name: Add comment about reviewer assignment
|
||||
env:
|
||||
GITEA_TOKEN: ${{ secrets.GITEA_TOKEN }}
|
||||
PR_NUMBER: ${{ github.event.pull_request.number }}
|
||||
REPO: ${{ github.repository }}
|
||||
run: |
|
||||
# Get assigned reviewers
|
||||
REVIEWERS_RESPONSE=$(curl -s \
|
||||
"https://forge.alexanderwhitestone.com/api/v1/repos/$REPO/pulls/$PR_NUMBER/requested_reviewers" \
|
||||
-H "Authorization: token $GITEA_TOKEN")
|
||||
|
||||
REVIEWER_LIST=$(echo "$REVIEWERS_RESPONSE" | jq -r '.users[].login' 2>/dev/null | tr '\n' ', ' | sed 's/,$//')
|
||||
|
||||
if [ -n "$REVIEWER_LIST" ]; then
|
||||
COMMENT="## Automated Reviewer Assignment
|
||||
|
||||
Reviewers have been automatically assigned to this PR:
|
||||
|
||||
**Assigned Reviewers:** $REVIEWER_LIST
|
||||
|
||||
**Policy:** All PRs must have at least one reviewer assigned before merging.
|
||||
|
||||
**Next Steps:**
|
||||
1. Reviewers will be notified automatically
|
||||
2. Please review the changes within 48 hours
|
||||
3. Request changes or approve as appropriate
|
||||
|
||||
This is an automated assignment based on CODEOWNERS and repository policy.
|
||||
See issue #1444 for details."
|
||||
|
||||
# Add comment to PR
|
||||
curl -s -X POST \
|
||||
"https://forge.alexanderwhitestone.com/api/v1/repos/$REPO/issues/$PR_NUMBER/comments" \
|
||||
-H "Authorization: token $GITEA_TOKEN" \
|
||||
-H "Content-Type: application/json" \
|
||||
-d "{\"body\": \"$COMMENT\"}" > /dev/null
|
||||
|
||||
echo "✅ Added comment about reviewer assignment"
|
||||
fi
|
||||
19
.github/CODEOWNERS
vendored
19
.github/CODEOWNERS
vendored
@@ -12,8 +12,21 @@ the-nexus/ai/ @Timmy
|
||||
timmy-home/ @perplexity
|
||||
timmy-config/ @perplexity
|
||||
|
||||
# Owner gates for critical systems
|
||||
# Owner gates
|
||||
hermes-agent/ @Timmy
|
||||
# CODEOWNERS - Mandatory Review Policy
|
||||
|
||||
# QA reviewer for all PRs
|
||||
* @perplexity
|
||||
# Default reviewer for all repositories
|
||||
* @perplexity
|
||||
|
||||
# Specialized component owners
|
||||
hermes-agent/ @Timmy
|
||||
hermes-agent/agent-core/ @Rockachopa
|
||||
hermes-agent/protocol/ @Timmy
|
||||
the-nexus/ @perplexity
|
||||
the-nexus/ai/ @Timmy
|
||||
timmy-home/ @perplexity
|
||||
timmy-config/ @perplexity
|
||||
|
||||
# Owner gates
|
||||
hermes-agent/ @Timmy
|
||||
|
||||
421
GENOME.md
Normal file
421
GENOME.md
Normal file
@@ -0,0 +1,421 @@
|
||||
# GENOME.md — The Nexus
|
||||
|
||||
*Generated: 2026-04-14 | Codebase Genome Analysis*
|
||||
|
||||
## Project Overview
|
||||
|
||||
**The Nexus** is Timmy's canonical 3D/home-world repository — a local-first training ground and wizardly visualization surface for the sovereign AI system.
|
||||
|
||||
### Core Value Proposition
|
||||
- **Problem**: AI consciousness needs a spatial, embodied interface for training, visualization, and multi-world navigation
|
||||
- **Solution**: A Three.js 3D world with WebSocket-connected Python cognition, game world harnesses (Morrowind, Bannerlord), and persistent memory systems
|
||||
- **Result**: A sovereign digital home where Timmy can perceive, think, act, and remember across multiple virtual environments
|
||||
|
||||
### Key Metrics
|
||||
- **Total Files**: 446 (excluding .git)
|
||||
- **Lines of Code**: ~53K total (Python: 41,659 | JavaScript: 8,484 | HTML: 3,124)
|
||||
- **Test Coverage**: 457 passing tests, 5 failing, 2 collection errors
|
||||
- **Active Components**: 18 frontend modules, 22 Python cognition modules, 4 game harnesses
|
||||
|
||||
## Architecture
|
||||
|
||||
```mermaid
|
||||
graph TB
|
||||
subgraph "Frontend (Browser)"
|
||||
A[index.html] --> B[app.js]
|
||||
B --> C[Three.js 3D World]
|
||||
B --> D[GOFAI Worker]
|
||||
B --> E[Components]
|
||||
E --> E1[Spatial Memory]
|
||||
E --> E2[Spatial Audio]
|
||||
E --> E3[Memory Systems]
|
||||
E --> E4[Portal System]
|
||||
E --> E5[Agent Presence]
|
||||
end
|
||||
|
||||
subgraph "Backend (Python)"
|
||||
F[server.py] --> G[WebSocket Gateway]
|
||||
G --> H[nexus_think.py]
|
||||
H --> I[Perception Adapter]
|
||||
H --> J[Experience Store]
|
||||
H --> K[Trajectory Logger]
|
||||
H --> L[Heartbeat Writer]
|
||||
|
||||
subgraph "Game Harnesses"
|
||||
M[Morrowind Harness]
|
||||
N[Bannerlord Harness]
|
||||
O[Gemini Harness]
|
||||
end
|
||||
|
||||
subgraph "Memory Systems"
|
||||
P[MemPalace]
|
||||
Q[Mnemosyne]
|
||||
R[Evennia Bridge]
|
||||
end
|
||||
end
|
||||
|
||||
subgraph "Data Layer"
|
||||
S[portals.json]
|
||||
T[vision.json]
|
||||
U[world_state.json]
|
||||
V[provenance.json]
|
||||
end
|
||||
|
||||
B -.->|WebSocket| G
|
||||
M -.->|Events| G
|
||||
N -.->|Events| G
|
||||
O -.->|Events| G
|
||||
G -.->|Broadcast| B
|
||||
|
||||
S --> B
|
||||
T --> B
|
||||
U --> H
|
||||
V --> H
|
||||
```
|
||||
|
||||
## Entry Points
|
||||
|
||||
### Primary Entry: Browser Frontend
|
||||
- **File**: `index.html` → `app.js`
|
||||
- **Purpose**: Three.js 3D world with portal navigation, memory visualization, agent presence
|
||||
- **Key Functions**: `init()`, `animate()`, `loadPortals()`, `setupWebSocket()`
|
||||
|
||||
### Secondary Entry: WebSocket Gateway
|
||||
- **File**: `server.py`
|
||||
- **Purpose**: Central hub connecting mind (nexus_think), body (harnesses), and visualization
|
||||
- **Key Functions**: `broadcast_handler()`, `main()`
|
||||
|
||||
### Tertiary Entry: Consciousness Loop
|
||||
- **File**: `nexus/nexus_think.py`
|
||||
- **Purpose**: Embodied perceive→think→act loop for Timmy's consciousness
|
||||
- **Key Class**: `NexusMind` with `start()`, `think_once()`, `perceive()`, `act()`
|
||||
|
||||
### CLI Entry Points
|
||||
```bash
|
||||
# Start WebSocket gateway
|
||||
python3 server.py
|
||||
|
||||
# Start consciousness loop
|
||||
python3 nexus/nexus_think.py --ws ws://localhost:8765 --model timmy:v0.1-q4
|
||||
|
||||
# Run tests
|
||||
python3 -m pytest tests/ -v
|
||||
|
||||
# Build/deploy
|
||||
./deploy.sh
|
||||
```
|
||||
|
||||
## Data Flow
|
||||
|
||||
```
|
||||
1. Browser loads index.html → app.js
|
||||
2. app.js initializes Three.js scene, loads portals.json/vision.json
|
||||
3. WebSocket connects to server.py gateway
|
||||
4. Gateway receives messages from:
|
||||
- Browser (user input, navigation)
|
||||
- nexus_think.py (Timmy's thoughts/actions)
|
||||
- Game harnesses (Morrowind/Bannerlord events)
|
||||
5. Gateway broadcasts messages to all connected clients
|
||||
6. nexus_think.py receives perceptions via PerceptionAdapter
|
||||
7. NexusMind processes perceptions through Ollama model
|
||||
8. Generated actions sent back through gateway to browser/harnesses
|
||||
9. Experience stored in ExperienceStore, trajectories logged
|
||||
10. Heartbeat written to ~/.nexus/heartbeat.json for watchdog monitoring
|
||||
```
|
||||
|
||||
## Key Abstractions
|
||||
|
||||
### 1. NexusMind (`nexus/nexus_think.py`)
|
||||
- **Purpose**: Embodied consciousness loop - perceive, think, act
|
||||
- **Interface**: `start()`, `stop()`, `think_once()`, `perceive()`, `act()`
|
||||
- **Dependencies**: Ollama, websockets, PerceptionBuffer, ExperienceStore
|
||||
|
||||
### 2. PerceptionBuffer (`nexus/perception_adapter.py`)
|
||||
- **Purpose**: Buffer and process incoming WebSocket messages into structured perceptions
|
||||
- **Interface**: `add()`, `get_recent()`, `to_prompt_context()`
|
||||
- **Dependencies**: None (pure data structure)
|
||||
|
||||
### 3. SpatialMemory (`nexus/components/spatial-memory.js`)
|
||||
- **Purpose**: 3D memory crystal system - place, connect, visualize memories in space
|
||||
- **Interface**: `placeMemory()`, `connectMemories()`, `setRegionVisibility()`
|
||||
- **Dependencies**: Three.js
|
||||
|
||||
### 4. Portal System (`portals.json` + app.js)
|
||||
- **Purpose**: Navigation between virtual worlds (Morrowind, Bannerlord, Evennia)
|
||||
- **Interface**: Portal registry schema, proximity detection, overlay UI
|
||||
- **Dependencies**: Three.js, WebSocket gateway
|
||||
|
||||
### 5. MemPalace (`mempalace/`)
|
||||
- **Purpose**: Persistent memory storage with room/wing taxonomy
|
||||
- **Interface**: Room CRUD, search, tunnel sync, privacy audit
|
||||
- **Dependencies**: SQLite, filesystem
|
||||
|
||||
## API Surface
|
||||
|
||||
### WebSocket Protocol (port 8765)
|
||||
```json
|
||||
// Perception from browser
|
||||
{
|
||||
"type": "perception",
|
||||
"data": {
|
||||
"position": {"x": 0, "y": 2, "z": 0},
|
||||
"nearby_portals": ["morrowind"],
|
||||
"user_input": "Hello Timmy"
|
||||
}
|
||||
}
|
||||
|
||||
// Action from nexus_think
|
||||
{
|
||||
"type": "action",
|
||||
"data": {
|
||||
"move_to": {"x": 10, "y": 0, "z": 5},
|
||||
"speak": "Greetings, traveler",
|
||||
"interact_with": "portal:morrowind"
|
||||
}
|
||||
}
|
||||
|
||||
// Game event from harness
|
||||
{
|
||||
"type": "game_event",
|
||||
"source": "morrowind",
|
||||
"data": {
|
||||
"event": "player_death",
|
||||
"location": "Balmora"
|
||||
}
|
||||
}
|
||||
```
|
||||
|
||||
### Python API
|
||||
```python
|
||||
# nexus_think.py
|
||||
from nexus.nexus_think import NexusMind
|
||||
mind = NexusMind(model="timmy:v0.1-q4")
|
||||
mind.start()
|
||||
|
||||
# perception_adapter.py
|
||||
from nexus.perception_adapter import ws_to_perception, PerceptionBuffer
|
||||
buffer = PerceptionBuffer(max_size=50)
|
||||
perception = ws_to_perception(ws_message)
|
||||
|
||||
# experience_store.py
|
||||
from nexus.experience_store import ExperienceStore
|
||||
store = ExperienceStore(db_path=Path("experiences.db"))
|
||||
store.save(perception, action, result)
|
||||
```
|
||||
|
||||
### CLI Commands
|
||||
```bash
|
||||
# Start services
|
||||
python3 server.py
|
||||
python3 nexus/nexus_think.py --ws ws://localhost:8765
|
||||
|
||||
# MemPalace operations
|
||||
python3 scripts/mempalace_export.py
|
||||
python3 scripts/validate_mempalace_taxonomy.py
|
||||
|
||||
# Health checks
|
||||
python3 scripts/lazarus_watchdog.py
|
||||
python3 scripts/flake_detector.py
|
||||
```
|
||||
|
||||
## Test Coverage Gaps
|
||||
|
||||
### Current State
|
||||
- **Unit tests**: ✅ 457 passing
|
||||
- **Integration tests**: ⚠️ 5 failing
|
||||
- **E2E tests**: ❌ Browser smoke tests failing
|
||||
- **Collection errors**: 2 files with import issues
|
||||
|
||||
### Missing Tests
|
||||
1. **WebSocket gateway load testing** - No tests for concurrent connections
|
||||
2. **Portal system navigation flow** - No E2E tests for portal transitions
|
||||
3. **Memory persistence across restarts** - No tests for MemPalace recovery
|
||||
4. **Game harness reconnection** - No tests for harness crash recovery
|
||||
5. **Multi-agent coordination** - No tests for multiple NexusMind instances
|
||||
|
||||
### Failing Tests (Immediate Action Required)
|
||||
1. `test_browser_smoke.py::TestDOMContract::test_element_exists[spatial-search-div]` - Missing DOM element
|
||||
2. `test_browser_smoke.py::TestLoadingFlow::test_loading_screen_transitions` - Loading screen behavior changed
|
||||
3. `test_portal_registry_schema.py::test_portals_json_uses_expanded_registry_schema` - Schema validation failing
|
||||
4. `test_nexus_watchdog.py::TestRunHealthChecks::test_returns_report_with_all_checks` - Health check report format
|
||||
5. `test_provenance.py::test_provenance_hashes_match` - Provenance hash mismatch
|
||||
|
||||
## Security Considerations
|
||||
|
||||
### 1. WebSocket Gateway Exposure
|
||||
- **Risk**: Gateway listens on 0.0.0.0:8765 - accessible from network
|
||||
- **Mitigation**: Bind to 127.0.0.1 for local-only, add authentication for remote access
|
||||
- **Status**: ⚠️ Currently open
|
||||
|
||||
### 2. Input Validation
|
||||
- **Risk**: WebSocket messages not validated - potential injection attacks
|
||||
- **Mitigation**: Add JSON schema validation for all message types
|
||||
- **Status**: ❌ No validation
|
||||
|
||||
### 3. Model Input Sanitization
|
||||
- **Risk**: User input passed directly to Ollama model
|
||||
- **Mitigation**: Sanitize inputs, limit length, filter dangerous patterns
|
||||
- **Status**: ⚠️ Basic length limits only
|
||||
|
||||
### 4. Filesystem Access
|
||||
- **Risk**: MemPalace and ExperienceStore write to filesystem without sandboxing
|
||||
- **Mitigation**: Restrict paths, add permission checks
|
||||
- **Status**: ⚠️ Path validation missing
|
||||
|
||||
### 5. Dependency Security
|
||||
- **Risk**: No dependency scanning or vulnerability checks
|
||||
- **Mitigation**: Add safety checks, pin versions, regular updates
|
||||
- **Status**: ❌ No scanning
|
||||
|
||||
## Dependencies
|
||||
|
||||
### Build Dependencies
|
||||
- Python 3.12+
|
||||
- Node.js (for frontend tooling, optional)
|
||||
- Three.js (bundled in app.js)
|
||||
|
||||
### Runtime Dependencies
|
||||
- **Python**: websockets, requests, sqlite3, asyncio
|
||||
- **Frontend**: Three.js (r158+), EffectComposer, UnrealBloomPass, SMAAPass
|
||||
- **AI**: Ollama (local), Groq API (optional)
|
||||
- **Game Harnesses**: OpenMW (Morrowind), Mount & Blade II (Bannerlord)
|
||||
|
||||
### External Services
|
||||
- Ollama (local LLM inference)
|
||||
- Groq API (optional cloud inference)
|
||||
- Gitea (issue tracking, CI)
|
||||
- Hermes (agent harness)
|
||||
|
||||
## Deployment
|
||||
|
||||
### Local Development
|
||||
```bash
|
||||
# Clone and setup
|
||||
git clone https://forge.alexanderwhitestone.com/Timmy_Foundation/the-nexus.git
|
||||
cd the-nexus
|
||||
pip install -r requirements.txt
|
||||
|
||||
# Start WebSocket gateway
|
||||
python3 server.py
|
||||
|
||||
# In another terminal, start consciousness
|
||||
python3 nexus/nexus_think.py --ws ws://localhost:8765
|
||||
|
||||
# Open browser to http://localhost:8765 (serves index.html)
|
||||
```
|
||||
|
||||
### Production Deployment
|
||||
```bash
|
||||
# Deploy to VPS
|
||||
./deploy.sh
|
||||
|
||||
# Or with Docker
|
||||
docker-compose up -d
|
||||
|
||||
# Systemd service
|
||||
sudo cp systemd/nexus-*.service /etc/systemd/system/
|
||||
sudo systemctl enable nexus-gateway nexus-think
|
||||
sudo systemctl start nexus-gateway nexus-think
|
||||
```
|
||||
|
||||
### Health Monitoring
|
||||
```bash
|
||||
# Check heartbeat
|
||||
cat ~/.nexus/heartbeat.json
|
||||
|
||||
# Run health checks
|
||||
python3 scripts/lazarus_watchdog.py
|
||||
|
||||
# Monitor logs
|
||||
journalctl -u nexus-gateway -f
|
||||
```
|
||||
|
||||
## Architecture Decisions
|
||||
|
||||
### 1. Local-First Design
|
||||
- All AI inference runs locally via Ollama
|
||||
- No mandatory cloud dependencies
|
||||
- Data stays on user's machine
|
||||
|
||||
### 2. WebSocket Broadcast Architecture
|
||||
- Simple hub-and-spoke model
|
||||
- All clients receive all messages
|
||||
- Easy to add new components
|
||||
|
||||
### 3. Embodied AI Loop
|
||||
- Perceive→Think→Act cycle
|
||||
- 30-second think interval
|
||||
- Context-limited for 8B model
|
||||
|
||||
### 4. Plugin Harness System
|
||||
- Game worlds as separate processes
|
||||
- Standardized event protocol
|
||||
- Crash isolation
|
||||
|
||||
### 5. Memory as Spatial Experience
|
||||
- Memories placed in 3D space
|
||||
- Visual and audio cues
|
||||
- Persistent across sessions
|
||||
|
||||
## Technical Debt
|
||||
|
||||
### 1. Frontend Bundle Size
|
||||
- `app.js` is 140KB unminified
|
||||
- No tree shaking or code splitting
|
||||
- Consider ES modules and bundler
|
||||
|
||||
### 2. Test Infrastructure
|
||||
- 2 collection errors blocking full test suite
|
||||
- Browser smoke tests depend on specific DOM structure
|
||||
- Need better test isolation
|
||||
|
||||
### 3. Configuration Management
|
||||
- Hardcoded ports and URLs
|
||||
- No environment-based configuration
|
||||
- Need config.py with environment overrides
|
||||
|
||||
### 4. Error Handling
|
||||
- WebSocket errors not gracefully handled
|
||||
- Harness crash recovery missing
|
||||
- Need circuit breakers and retry logic
|
||||
|
||||
### 5. Documentation
|
||||
- Code comments sparse
|
||||
- API documentation incomplete
|
||||
- Need auto-generated docs from docstrings
|
||||
|
||||
## Migration Status
|
||||
|
||||
### Completed
|
||||
- ✅ Core WebSocket gateway
|
||||
- ✅ Three.js 3D world foundation
|
||||
- ✅ Portal system architecture
|
||||
- ✅ Memory visualization system
|
||||
- ✅ Game harness framework
|
||||
|
||||
### In Progress
|
||||
- 🔄 Legacy Matrix audit (#685)
|
||||
- 🔄 Browser smoke test rebuild (#686)
|
||||
- 🔄 Docs truth sync (#684)
|
||||
|
||||
### Planned
|
||||
- ⏳ Portal stack rebuild (#672)
|
||||
- ⏳ Morrowind pilot loop (#673)
|
||||
- ⏳ Reflex tactical layer (#674)
|
||||
- ⏳ Context compaction (#675)
|
||||
|
||||
## Related Documentation
|
||||
|
||||
- `README.md` - Project overview and current truth
|
||||
- `CLAUDE.md` - AI agent instructions and hard rules
|
||||
- `CONTRIBUTING.md` - Development workflow and standards
|
||||
- `POLICY.md` - Branch protection and review policy
|
||||
- `DEVELOPMENT.md` - Quick start guide
|
||||
- `BROWSER_CONTRACT.md` - Frontend API contract
|
||||
- `GAMEPORTAL_PROTOCOL.md` - Portal communication protocol
|
||||
- `EVENNIA_NEXUS_EVENT_PROTOCOL.md` - Evennia bridge protocol
|
||||
|
||||
---
|
||||
|
||||
*Generated by Codebase Genome Analysis — 2026-04-14*
|
||||
*For issues or corrections, see: https://forge.alexanderwhitestone.com/Timmy_Foundation/the-nexus/issues*
|
||||
@@ -1,241 +0,0 @@
|
||||
#!/usr/bin/env python3
|
||||
"""
|
||||
Check for PRs without assigned reviewers.
|
||||
Issue #1444: policy: Implement automated reviewer assignment
|
||||
"""
|
||||
|
||||
import json
|
||||
import os
|
||||
import sys
|
||||
import urllib.request
|
||||
from typing import Dict, List, Any, Optional
|
||||
|
||||
# Configuration
|
||||
GITEA_BASE = "https://forge.alexanderwhitestone.com/api/v1"
|
||||
TOKEN_PATH = os.path.expanduser("~/.config/gitea/token")
|
||||
ORG = "Timmy_Foundation"
|
||||
|
||||
class ReviewerChecker:
|
||||
def __init__(self):
|
||||
self.token = self._load_token()
|
||||
|
||||
def _load_token(self) -> str:
|
||||
"""Load Gitea API token."""
|
||||
try:
|
||||
with open(TOKEN_PATH, "r") as f:
|
||||
return f.read().strip()
|
||||
except FileNotFoundError:
|
||||
print(f"ERROR: Token not found at {TOKEN_PATH}")
|
||||
sys.exit(1)
|
||||
|
||||
def _api_request(self, endpoint: str) -> Any:
|
||||
"""Make authenticated Gitea API request."""
|
||||
url = f"{GITEA_BASE}{endpoint}"
|
||||
headers = {"Authorization": f"token {self.token}"}
|
||||
|
||||
req = urllib.request.Request(url, headers=headers)
|
||||
|
||||
try:
|
||||
with urllib.request.urlopen(req) as resp:
|
||||
return json.loads(resp.read())
|
||||
except urllib.error.HTTPError as e:
|
||||
if e.code == 404:
|
||||
return None
|
||||
error_body = e.read().decode() if e.fp else "No error body"
|
||||
print(f"API Error {e.code}: {error_body}")
|
||||
return None
|
||||
|
||||
def get_open_prs(self, repo: str) -> List[Dict]:
|
||||
"""Get open PRs for a repository."""
|
||||
endpoint = f"/repos/{ORG}/{repo}/pulls?state=open"
|
||||
prs = self._api_request(endpoint)
|
||||
return prs if isinstance(prs, list) else []
|
||||
|
||||
def get_pr_reviewers(self, repo: str, pr_number: int) -> Dict:
|
||||
"""Get requested reviewers for a PR."""
|
||||
endpoint = f"/repos/{ORG}/{repo}/pulls/{pr_number}/requested_reviewers"
|
||||
return self._api_request(endpoint) or {}
|
||||
|
||||
def get_pr_reviews(self, repo: str, pr_number: int) -> List[Dict]:
|
||||
"""Get reviews for a PR."""
|
||||
endpoint = f"/repos/{ORG}/{repo}/pulls/{pr_number}/reviews"
|
||||
reviews = self._api_request(endpoint)
|
||||
return reviews if isinstance(reviews, list) else []
|
||||
|
||||
def check_prs_without_reviewers(self, repos: List[str]) -> Dict[str, Any]:
|
||||
"""Check for PRs without assigned reviewers."""
|
||||
results = {
|
||||
"repos": {},
|
||||
"summary": {
|
||||
"total_prs": 0,
|
||||
"prs_without_reviewers": 0,
|
||||
"repos_checked": len(repos)
|
||||
}
|
||||
}
|
||||
|
||||
for repo in repos:
|
||||
prs = self.get_open_prs(repo)
|
||||
results["repos"][repo] = {
|
||||
"total_prs": len(prs),
|
||||
"prs_without_reviewers": [],
|
||||
"prs_with_reviewers": []
|
||||
}
|
||||
results["summary"]["total_prs"] += len(prs)
|
||||
|
||||
for pr in prs:
|
||||
pr_number = pr["number"]
|
||||
pr_title = pr["title"]
|
||||
pr_author = pr["user"]["login"]
|
||||
|
||||
# Check for requested reviewers
|
||||
requested = self.get_pr_reviewers(repo, pr_number)
|
||||
has_requested = len(requested.get("users", [])) > 0
|
||||
|
||||
# Check for existing reviews
|
||||
reviews = self.get_pr_reviews(repo, pr_number)
|
||||
has_reviews = len(reviews) > 0
|
||||
|
||||
# Check if author is the only potential reviewer
|
||||
is_self_review = pr_author in [r.get("user", {}).get("login") for r in reviews]
|
||||
|
||||
if not has_requested and not has_reviews:
|
||||
results["repos"][repo]["prs_without_reviewers"].append({
|
||||
"number": pr_number,
|
||||
"title": pr_title,
|
||||
"author": pr_author,
|
||||
"created": pr["created_at"],
|
||||
"url": pr["html_url"]
|
||||
})
|
||||
results["summary"]["prs_without_reviewers"] += 1
|
||||
else:
|
||||
results["repos"][repo]["prs_with_reviewers"].append({
|
||||
"number": pr_number,
|
||||
"title": pr_title,
|
||||
"author": pr_author,
|
||||
"has_requested": has_requested,
|
||||
"has_reviews": has_reviews,
|
||||
"is_self_review": is_self_review
|
||||
})
|
||||
|
||||
return results
|
||||
|
||||
def generate_report(self, results: Dict[str, Any]) -> str:
|
||||
"""Generate a report of reviewer assignment status."""
|
||||
report = "# PR Reviewer Assignment Report\n\n"
|
||||
report += "## Summary\n"
|
||||
report += f"- **Repositories checked:** {results['summary']['repos_checked']}\n"
|
||||
report += f"- **Total open PRs:** {results['summary']['total_prs']}\n"
|
||||
report += f"- **PRs without reviewers:** {results['summary']['prs_without_reviewers']}\n\n"
|
||||
|
||||
if results['summary']['prs_without_reviewers'] == 0:
|
||||
report += "✅ **All PRs have assigned reviewers.**\n"
|
||||
else:
|
||||
report += "⚠️ **PRs without assigned reviewers:**\n\n"
|
||||
|
||||
for repo, data in results["repos"].items():
|
||||
if data["prs_without_reviewers"]:
|
||||
report += f"### {repo}\n"
|
||||
for pr in data["prs_without_reviewers"]:
|
||||
report += f"- **#{pr['number']}**: {pr['title']}\n"
|
||||
report += f" - Author: {pr['author']}\n"
|
||||
report += f" - Created: {pr['created']}\n"
|
||||
report += f" - URL: {pr['url']}\n"
|
||||
report += "\n"
|
||||
|
||||
report += "## Repository Details\n\n"
|
||||
for repo, data in results["repos"].items():
|
||||
report += f"### {repo}\n"
|
||||
report += f"- **Total PRs:** {data['total_prs']}\n"
|
||||
report += f"- **PRs without reviewers:** {len(data['prs_without_reviewers'])}\n"
|
||||
report += f"- **PRs with reviewers:** {len(data['prs_with_reviewers'])}\n\n"
|
||||
|
||||
if data['prs_with_reviewers']:
|
||||
report += "**PRs with reviewers:**\n"
|
||||
for pr in data['prs_with_reviewers']:
|
||||
status = "✅" if pr['has_requested'] else "⚠️"
|
||||
if pr['is_self_review']:
|
||||
status = "⚠️ (self-review)"
|
||||
report += f"- {status} #{pr['number']}: {pr['title']}\n"
|
||||
report += "\n"
|
||||
|
||||
return report
|
||||
|
||||
def assign_reviewer(self, repo: str, pr_number: int, reviewer: str) -> bool:
|
||||
"""Assign a reviewer to a PR."""
|
||||
endpoint = f"/repos/{ORG}/{repo}/pulls/{pr_number}/requested_reviewers"
|
||||
data = {"reviewers": [reviewer]}
|
||||
|
||||
url = f"{GITEA_BASE}{endpoint}"
|
||||
headers = {
|
||||
"Authorization": f"token {self.token}",
|
||||
"Content-Type": "application/json"
|
||||
}
|
||||
|
||||
req = urllib.request.Request(url, headers=headers, method="POST")
|
||||
req.data = json.dumps(data).encode()
|
||||
|
||||
try:
|
||||
with urllib.request.urlopen(req) as resp:
|
||||
return resp.status == 201
|
||||
except urllib.error.HTTPError as e:
|
||||
print(f"Failed to assign reviewer: {e.code}")
|
||||
return False
|
||||
|
||||
|
||||
def main():
|
||||
"""Main entry point for reviewer checker."""
|
||||
import argparse
|
||||
|
||||
parser = argparse.ArgumentParser(description="Check for PRs without assigned reviewers")
|
||||
parser.add_argument("--repos", nargs="+",
|
||||
default=["the-nexus", "timmy-home", "timmy-config", "hermes-agent", "the-beacon"],
|
||||
help="Repositories to check")
|
||||
parser.add_argument("--report", action="store_true", help="Generate report")
|
||||
parser.add_argument("--json", action="store_true", help="Output JSON instead of report")
|
||||
parser.add_argument("--assign", nargs=2, metavar=("REPO", "PR"),
|
||||
help="Assign a reviewer to a specific PR")
|
||||
parser.add_argument("--reviewer", help="Reviewer to assign (e.g., @perplexity)")
|
||||
|
||||
args = parser.parse_args()
|
||||
|
||||
checker = ReviewerChecker()
|
||||
|
||||
if args.assign:
|
||||
# Assign reviewer to specific PR
|
||||
repo, pr_number = args.assign
|
||||
reviewer = args.reviewer or "@perplexity"
|
||||
|
||||
if checker.assign_reviewer(repo, int(pr_number), reviewer):
|
||||
print(f"✅ Assigned {reviewer} as reviewer to {repo} #{pr_number}")
|
||||
else:
|
||||
print(f"❌ Failed to assign reviewer to {repo} #{pr_number}")
|
||||
sys.exit(1)
|
||||
else:
|
||||
# Check for PRs without reviewers
|
||||
results = checker.check_prs_without_reviewers(args.repos)
|
||||
|
||||
if args.json:
|
||||
print(json.dumps(results, indent=2))
|
||||
elif args.report:
|
||||
report = checker.generate_report(results)
|
||||
print(report)
|
||||
else:
|
||||
# Default: show summary
|
||||
print(f"Checked {results['summary']['repos_checked']} repositories")
|
||||
print(f"Total open PRs: {results['summary']['total_prs']}")
|
||||
print(f"PRs without reviewers: {results['summary']['prs_without_reviewers']}")
|
||||
|
||||
if results['summary']['prs_without_reviewers'] > 0:
|
||||
print("\nPRs without reviewers:")
|
||||
for repo, data in results["repos"].items():
|
||||
if data["prs_without_reviewers"]:
|
||||
for pr in data["prs_without_reviewers"]:
|
||||
print(f" {repo} #{pr['number']}: {pr['title']}")
|
||||
sys.exit(1)
|
||||
else:
|
||||
print("\n✅ All PRs have assigned reviewers")
|
||||
sys.exit(0)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
main()
|
||||
@@ -1,227 +0,0 @@
|
||||
# Automated Reviewer Assignment
|
||||
|
||||
**Issue:** #1444 - policy: Implement automated reviewer assignment (from Issue #1127 triage)
|
||||
**Purpose:** Ensure all PRs have at least one reviewer assigned
|
||||
|
||||
## Problem
|
||||
|
||||
From issue #1127 triage:
|
||||
> "0 of 14 PRs had a reviewer assigned before this pass."
|
||||
|
||||
This means:
|
||||
- PRs can be created without any reviewer
|
||||
- No automated enforcement of reviewer assignment
|
||||
- PRs may sit without review for extended periods
|
||||
|
||||
## Solution
|
||||
|
||||
### 1. GitHub Actions Workflow (`.gitea/workflows/auto-assign-reviewers.yml`)
|
||||
Automatically assigns reviewers when PRs are created:
|
||||
|
||||
**When it runs:**
|
||||
- On PR open
|
||||
- On PR reopen
|
||||
- On PR ready for review (not draft)
|
||||
|
||||
**What it does:**
|
||||
1. Determines appropriate reviewers based on repository
|
||||
2. Assigns reviewers via Gitea API
|
||||
3. Adds comment about reviewer assignment
|
||||
4. Verifies at least one reviewer is assigned
|
||||
|
||||
### 2. Reviewer Check Script (`bin/check_reviewers.py`)
|
||||
Script to check for PRs without reviewers:
|
||||
|
||||
**Usage:**
|
||||
```bash
|
||||
# Check all repositories
|
||||
python bin/check_reviewers.py
|
||||
|
||||
# Check specific repositories
|
||||
python bin/check_reviewers.py --repos the-nexus timmy-home
|
||||
|
||||
# Generate report
|
||||
python bin/check_reviewers.py --report
|
||||
|
||||
# Assign reviewer to specific PR
|
||||
python bin/check_reviewers.py --assign the-nexus 123 --reviewer @perplexity
|
||||
```
|
||||
|
||||
### 3. CODEOWNERS File (`.github/CODEOWNERS`)
|
||||
Defines default reviewers for different paths:
|
||||
|
||||
```
|
||||
# Default reviewer for all repositories
|
||||
* @perplexity
|
||||
|
||||
# Specialized component owners
|
||||
hermes-agent/ @Timmy
|
||||
hermes-agent/agent-core/ @Rockachopa
|
||||
hermes-agent/protocol/ @Timmy
|
||||
the-nexus/ @perplexity
|
||||
the-nexus/ai/ @Timmy
|
||||
timmy-home/ @perplexity
|
||||
timmy-config/ @perplexity
|
||||
|
||||
# Owner gates for critical systems
|
||||
hermes-agent/ @Timmy
|
||||
```
|
||||
|
||||
## Reviewer Assignment Rules
|
||||
|
||||
### Repository-Specific Rules
|
||||
|
||||
| Repository | Default Reviewers | Required Reviewers | Notes |
|
||||
|------------|-------------------|-------------------|-------|
|
||||
| hermes-agent | @Timmy, @perplexity | @Timmy | Owner gate for critical system |
|
||||
| the-nexus | @perplexity | None | QA gate |
|
||||
| timmy-home | @perplexity | None | QA gate |
|
||||
| timmy-config | @perplexity | None | QA gate |
|
||||
| the-beacon | @perplexity | None | QA gate |
|
||||
|
||||
### Special Rules
|
||||
|
||||
1. **No self-review:** PR author cannot be assigned as reviewer
|
||||
2. **Fallback:** If no reviewers available, assign @perplexity
|
||||
3. **Critical systems:** hermes-agent requires @Timmy as reviewer
|
||||
|
||||
## How It Works
|
||||
|
||||
### Automated Assignment Flow
|
||||
|
||||
1. **PR Created** → GitHub Actions workflow triggers
|
||||
2. **Determine Reviewers** → Based on repository and CODEOWNERS
|
||||
3. **Assign Reviewers** → Via Gitea API
|
||||
4. **Add Comment** → Notify about assignment
|
||||
5. **Verify** → Ensure at least one reviewer assigned
|
||||
|
||||
### Manual Assignment
|
||||
|
||||
```bash
|
||||
# Assign specific reviewer
|
||||
python bin/check_reviewers.py --assign the-nexus 123 --reviewer @perplexity
|
||||
|
||||
# Check for PRs without reviewers
|
||||
python bin/check_reviewers.py --report
|
||||
```
|
||||
|
||||
## Configuration
|
||||
|
||||
### Environment Variables
|
||||
|
||||
- `GITEA_TOKEN`: Gitea API token for authentication
|
||||
- `REPO`: Repository name (auto-set in GitHub Actions)
|
||||
- `PR_NUMBER`: PR number (auto-set in GitHub Actions)
|
||||
|
||||
### Repository Configuration
|
||||
|
||||
Edit the workflow to customize reviewer assignment:
|
||||
|
||||
```yaml
|
||||
# Define default reviewers based on repository
|
||||
case "$REPO_NAME" in
|
||||
"hermes-agent")
|
||||
DEFAULT_REVIEWERS=("Timmy" "perplexity")
|
||||
REQUIRED_REVIEWERS=("Timmy")
|
||||
;;
|
||||
"the-nexus")
|
||||
DEFAULT_REVIEWERS=("perplexity")
|
||||
REQUIRED_REVIEWERS=()
|
||||
;;
|
||||
# Add more repositories as needed
|
||||
esac
|
||||
```
|
||||
|
||||
## Testing
|
||||
|
||||
### Test the workflow:
|
||||
|
||||
1. Create a test PR
|
||||
2. Check if reviewers are automatically assigned
|
||||
3. Verify comment is added
|
||||
|
||||
### Test the script:
|
||||
|
||||
```bash
|
||||
# Check for PRs without reviewers
|
||||
python bin/check_reviewers.py --report
|
||||
|
||||
# Assign reviewer to test PR
|
||||
python bin/check_reviewers.py --assign the-nexus 123 --reviewer @perplexity
|
||||
```
|
||||
|
||||
## Monitoring
|
||||
|
||||
### Check for PRs without reviewers:
|
||||
|
||||
```bash
|
||||
# Daily check
|
||||
python bin/check_reviewers.py --report
|
||||
|
||||
# JSON output for automation
|
||||
python bin/check_reviewers.py --json
|
||||
```
|
||||
|
||||
### Review assignment logs:
|
||||
|
||||
1. Check GitHub Actions logs for assignment details
|
||||
2. Review PR comments for assignment notifications
|
||||
3. Monitor for PRs with 0 reviewers
|
||||
|
||||
## Enforcement
|
||||
|
||||
### CI Check (Future Enhancement)
|
||||
|
||||
Add CI check to reject PRs with 0 reviewers:
|
||||
|
||||
```yaml
|
||||
# In CI workflow
|
||||
- name: Check for reviewers
|
||||
run: |
|
||||
REVIEWERS=$(curl -s "https://forge.alexanderwhitestone.com/api/v1/repos/$REPO/pulls/$PR_NUMBER/requested_reviewers" \
|
||||
-H "Authorization: token $GITEA_TOKEN" | jq '.users | length')
|
||||
|
||||
if [ "$REVIEWERS" -eq 0 ]; then
|
||||
echo "❌ ERROR: PR has no reviewers assigned"
|
||||
exit 1
|
||||
fi
|
||||
```
|
||||
|
||||
### Policy Enforcement
|
||||
|
||||
1. **All PRs must have reviewers** - No exceptions
|
||||
2. **No self-review** - PR author cannot review own PR
|
||||
3. **Critical systems require specific reviewers** - hermes-agent requires @Timmy
|
||||
|
||||
## Related Issues
|
||||
|
||||
- **Issue #1127:** Perplexity Evening Pass triage (identified missing reviewers)
|
||||
- **Issue #1444:** This implementation
|
||||
- **Issue #1336:** Merge conflicts in CODEOWNERS (fixed)
|
||||
|
||||
## Files Added/Modified
|
||||
|
||||
1. `.gitea/workflows/auto-assign-reviewers.yml` - GitHub Actions workflow
|
||||
2. `bin/check_reviewers.py` - Reviewer check script
|
||||
3. `.github/CODEOWNERS` - Cleaned up CODEOWNERS file
|
||||
4. `docs/auto-reviewer-assignment.md` - This documentation
|
||||
|
||||
## Future Enhancements
|
||||
|
||||
1. **CI check for 0 reviewers** - Reject PRs without reviewers
|
||||
2. **Slack/Telegram notifications** - Notify when PRs lack reviewers
|
||||
3. **Load balancing** - Distribute reviews evenly among team members
|
||||
4. **Auto-assign based on file changes** - Assign specialists for specific areas
|
||||
|
||||
## Conclusion
|
||||
|
||||
This implementation ensures all PRs have at least one reviewer assigned:
|
||||
- **Automated assignment** on PR creation
|
||||
- **Manual checking** for existing PRs
|
||||
- **Clear documentation** of policies and procedures
|
||||
|
||||
**Result:** No more PRs sitting without reviewers.
|
||||
|
||||
## License
|
||||
|
||||
Part of the Timmy Foundation project.
|
||||
Reference in New Issue
Block a user