Compare commits
2 Commits
fix/562-ci
...
fix/567
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
3d57f42adc | ||
|
|
bb24a9ab4c |
@@ -1,34 +0,0 @@
|
||||
# CI Pipeline for Agent PRs
|
||||
|
||||
Implements #562: [FLEET-009] Build CI Pipeline for Agent PRs.
|
||||
|
||||
## Overview
|
||||
|
||||
The agent PR gate (`.gitea/workflows/agent-pr-gate.yml`) automatically validates agent-created PRs before merge.
|
||||
|
||||
## Pipeline Steps
|
||||
|
||||
1. **Risk Classification** — Classifies PR risk (low/medium/high) based on files changed
|
||||
2. **Syntax Check** — Validates YAML, JSON, Python, and Bash syntax
|
||||
3. **Test Suite** — Runs pytest
|
||||
4. **Criteria Verification** — Validates PR against acceptance criteria
|
||||
5. **Report** — Posts results as PR comment
|
||||
6. **Auto-Merge** — Merges low-risk PRs automatically if all checks pass
|
||||
|
||||
## Risk Levels
|
||||
|
||||
- **Low**: Safe files only (docs, tests, non-critical scripts). Auto-merges on pass.
|
||||
- **Medium**: Config or infrastructure changes. Requires human review.
|
||||
- **High**: Core system files (SOUL.md, deploy scripts, security code). Always requires human.
|
||||
|
||||
## Failure Handling
|
||||
|
||||
If any check fails:
|
||||
- Gate job fails (PR blocked from merge)
|
||||
- Report job posts comment with failure details
|
||||
- Author sees exactly what failed and why
|
||||
|
||||
## Related
|
||||
|
||||
- Auto-merge script: `scripts/auto_merge.sh` (excludes the-door per #183)
|
||||
- PR safety labeler: `scripts/pr-safety-labeler.sh` (labels crisis-critical repos)
|
||||
47
docs/issue-567-verification.md
Normal file
47
docs/issue-567-verification.md
Normal file
@@ -0,0 +1,47 @@
|
||||
# Issue #567 Verification
|
||||
|
||||
## Status: ✅ ALREADY IMPLEMENTED ON MAIN
|
||||
|
||||
Issue #567 asked for four things:
|
||||
1. an architecture doc at `evennia-mind-palace.md`
|
||||
2. a mapping of the 16 tracked Evennia issues to the mind-palace layers
|
||||
3. Milestone 1 proof: one room, one object, one mutable fact wired to Timmy's burn cycle
|
||||
4. a comment on the issue with proof of room entry injecting context
|
||||
|
||||
All four are already present on `main` in a fresh clone of `timmy-home`.
|
||||
|
||||
## Mainline Evidence
|
||||
|
||||
### Repo artifacts already on main
|
||||
- `evennia-mind-palace.md`
|
||||
- `evennia_tools/mind_palace.py`
|
||||
- `scripts/evennia/render_mind_palace_entry_proof.py`
|
||||
- `tests/test_evennia_mind_palace.py`
|
||||
- `tests/test_evennia_mind_palace_doc.py`
|
||||
|
||||
### Acceptance criteria check
|
||||
- Architecture doc exists at `evennia-mind-palace.md`
|
||||
- The 16 tracked Evennia issues are mapped in the issue-to-layer table inside `evennia-mind-palace.md`
|
||||
- Milestone 1 is implemented in `evennia_tools/mind_palace.py` with `Hall of Knowledge`, `The Ledger`, `MutableFact`, `BurnCycleSnapshot`, and deterministic room-entry rendering
|
||||
- The proof comment already exists on the issue as issue comment #56965
|
||||
|
||||
## Historical trail
|
||||
- PR #711 attempted the issue and posted the room-entry proof comment
|
||||
- PR #711 was later closed unmerged, but the requested deliverables are present on `main` today and pass targeted verification from a fresh clone
|
||||
|
||||
## Verification run from fresh clone
|
||||
|
||||
Commands executed:
|
||||
- `python3 -m pytest tests/test_evennia_layout.py tests/test_evennia_telemetry.py tests/test_evennia_training.py tests/test_evennia_mind_palace.py tests/test_evennia_mind_palace_doc.py -q`
|
||||
- `python3 -m py_compile evennia_tools/mind_palace.py scripts/evennia/render_mind_palace_entry_proof.py`
|
||||
- `python3 scripts/evennia/render_mind_palace_entry_proof.py`
|
||||
|
||||
Observed result:
|
||||
- all targeted Evennia mind-palace tests passed
|
||||
- the Python modules compiled cleanly
|
||||
- the proof script emitted the expected `ENTER Hall of Knowledge` packet with room context, ledger fact, and Timmy burn-cycle focus
|
||||
|
||||
## Recommendation
|
||||
|
||||
Close issue #567 as already implemented on `main`.
|
||||
This verification PR exists only to document the evidence trail cleanly and close the stale issue without re-implementing the already-landed architecture.
|
||||
21
tests/test_issue_567_verification.py
Normal file
21
tests/test_issue_567_verification.py
Normal file
@@ -0,0 +1,21 @@
|
||||
from pathlib import Path
|
||||
|
||||
|
||||
def test_issue_567_verification_doc_exists_with_mainline_evidence() -> None:
|
||||
text = Path("docs/issue-567-verification.md").read_text(encoding="utf-8")
|
||||
|
||||
required_snippets = [
|
||||
"# Issue #567 Verification",
|
||||
"## Status: ✅ ALREADY IMPLEMENTED ON MAIN",
|
||||
"evennia-mind-palace.md",
|
||||
"evennia_tools/mind_palace.py",
|
||||
"scripts/evennia/render_mind_palace_entry_proof.py",
|
||||
"tests/test_evennia_mind_palace.py",
|
||||
"tests/test_evennia_mind_palace_doc.py",
|
||||
"PR #711",
|
||||
"issue comment #56965",
|
||||
"python3 -m pytest tests/test_evennia_layout.py tests/test_evennia_telemetry.py tests/test_evennia_training.py tests/test_evennia_mind_palace.py tests/test_evennia_mind_palace_doc.py -q",
|
||||
]
|
||||
|
||||
missing = [snippet for snippet in required_snippets if snippet not in text]
|
||||
assert not missing, missing
|
||||
Reference in New Issue
Block a user