Compare commits
2 Commits
sprint/iss
...
fix/567
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
3d57f42adc | ||
|
|
bb24a9ab4c |
47
docs/issue-567-verification.md
Normal file
47
docs/issue-567-verification.md
Normal file
@@ -0,0 +1,47 @@
|
||||
# Issue #567 Verification
|
||||
|
||||
## Status: ✅ ALREADY IMPLEMENTED ON MAIN
|
||||
|
||||
Issue #567 asked for four things:
|
||||
1. an architecture doc at `evennia-mind-palace.md`
|
||||
2. a mapping of the 16 tracked Evennia issues to the mind-palace layers
|
||||
3. Milestone 1 proof: one room, one object, one mutable fact wired to Timmy's burn cycle
|
||||
4. a comment on the issue with proof of room entry injecting context
|
||||
|
||||
All four are already present on `main` in a fresh clone of `timmy-home`.
|
||||
|
||||
## Mainline Evidence
|
||||
|
||||
### Repo artifacts already on main
|
||||
- `evennia-mind-palace.md`
|
||||
- `evennia_tools/mind_palace.py`
|
||||
- `scripts/evennia/render_mind_palace_entry_proof.py`
|
||||
- `tests/test_evennia_mind_palace.py`
|
||||
- `tests/test_evennia_mind_palace_doc.py`
|
||||
|
||||
### Acceptance criteria check
|
||||
- Architecture doc exists at `evennia-mind-palace.md`
|
||||
- The 16 tracked Evennia issues are mapped in the issue-to-layer table inside `evennia-mind-palace.md`
|
||||
- Milestone 1 is implemented in `evennia_tools/mind_palace.py` with `Hall of Knowledge`, `The Ledger`, `MutableFact`, `BurnCycleSnapshot`, and deterministic room-entry rendering
|
||||
- The proof comment already exists on the issue as issue comment #56965
|
||||
|
||||
## Historical trail
|
||||
- PR #711 attempted the issue and posted the room-entry proof comment
|
||||
- PR #711 was later closed unmerged, but the requested deliverables are present on `main` today and pass targeted verification from a fresh clone
|
||||
|
||||
## Verification run from fresh clone
|
||||
|
||||
Commands executed:
|
||||
- `python3 -m pytest tests/test_evennia_layout.py tests/test_evennia_telemetry.py tests/test_evennia_training.py tests/test_evennia_mind_palace.py tests/test_evennia_mind_palace_doc.py -q`
|
||||
- `python3 -m py_compile evennia_tools/mind_palace.py scripts/evennia/render_mind_palace_entry_proof.py`
|
||||
- `python3 scripts/evennia/render_mind_palace_entry_proof.py`
|
||||
|
||||
Observed result:
|
||||
- all targeted Evennia mind-palace tests passed
|
||||
- the Python modules compiled cleanly
|
||||
- the proof script emitted the expected `ENTER Hall of Knowledge` packet with room context, ledger fact, and Timmy burn-cycle focus
|
||||
|
||||
## Recommendation
|
||||
|
||||
Close issue #567 as already implemented on `main`.
|
||||
This verification PR exists only to document the evidence trail cleanly and close the stale issue without re-implementing the already-landed architecture.
|
||||
@@ -1,58 +0,0 @@
|
||||
# Issue #582 — Epic Slice Verification
|
||||
|
||||
Refs #582
|
||||
|
||||
## Status: COMPLETE ON MAIN
|
||||
|
||||
The parent-epic orchestration slice for the Know Thy Father multimodal pipeline is already merged and functional on `main`.
|
||||
|
||||
## Mainline Evidence
|
||||
|
||||
### Core implementation files
|
||||
- `scripts/know_thy_father/epic_pipeline.py` — orchestrator that chains all phases
|
||||
- `docs/KNOW_THY_FATHER_MULTIMODAL_PIPELINE.md` — pipeline documentation
|
||||
- `tests/test_know_thy_father_pipeline.py` — orchestrator tests
|
||||
|
||||
### Phase implementation (all on main)
|
||||
| Phase | Description | Script |
|
||||
|-------|-------------|--------|
|
||||
| phase1_media_indexing | Scan archive for media | `scripts/know_thy_father/index_media.py` |
|
||||
| phase2_multimodal_analysis | Process media entries | `scripts/twitter_archive/analyze_media.py` |
|
||||
| phase3_holographic_synthesis | Kernel synthesis | `scripts/know_thy_father/synthesize_kernels.py` |
|
||||
| phase4_cross_reference_audit | Cross-ref audit | `scripts/know_thy_father/crossref_audit.py` |
|
||||
|
||||
### Merged PRs (chronological)
|
||||
- PR #630 — Phase 1: Media indexing
|
||||
- PR #631 — Phase 2: Multimodal analysis
|
||||
- PR #637 — Phase 3: Holographic synthesis
|
||||
- PR #639 — Phase 4: Cross-reference audit
|
||||
- PR #641 — Orchestrator pipeline integration
|
||||
- PR #738 — Prior parent-epic slice (closed)
|
||||
|
||||
### Test coverage
|
||||
- `tests/test_know_thy_father_pipeline.py` — orchestrator
|
||||
- `tests/test_know_thy_father_index.py` — phase 1
|
||||
- `tests/test_know_thy_father_synthesis.py` — phase 3
|
||||
- `tests/test_know_thy_father_crossref.py` — phase 4
|
||||
- `tests/twitter_archive/test_ktf_tracker.py` — tracker
|
||||
- `tests/twitter_archive/test_analyze_media.py` — phase 2
|
||||
|
||||
## Why Refs, Not Closes
|
||||
|
||||
The repo-side parent-epic operational slice is fully implemented on `main`. However, the epic (#582) itself remains open because:
|
||||
|
||||
1. Full archive consumption is not yet complete
|
||||
2. Downstream memory integration is pending
|
||||
3. The orchestrator is functional but not yet exercised against the complete archive
|
||||
|
||||
This verification document provides the proof trail that the orchestrator slice is done, preventing duplicate reimplementation.
|
||||
|
||||
## Verification Commands
|
||||
|
||||
```bash
|
||||
# Verify this issue's test
|
||||
python3 -m pytest tests/test_issue_582_verification.py -q
|
||||
|
||||
# Verify all Know Thy Father tests pass
|
||||
python3 -m pytest tests/test_know_thy_father_pipeline.py tests/test_know_thy_father_index.py tests/test_know_thy_father_synthesis.py tests/test_know_thy_father_crossref.py tests/twitter_archive/test_ktf_tracker.py tests/twitter_archive/test_analyze_media.py -q
|
||||
```
|
||||
21
tests/test_issue_567_verification.py
Normal file
21
tests/test_issue_567_verification.py
Normal file
@@ -0,0 +1,21 @@
|
||||
from pathlib import Path
|
||||
|
||||
|
||||
def test_issue_567_verification_doc_exists_with_mainline_evidence() -> None:
|
||||
text = Path("docs/issue-567-verification.md").read_text(encoding="utf-8")
|
||||
|
||||
required_snippets = [
|
||||
"# Issue #567 Verification",
|
||||
"## Status: ✅ ALREADY IMPLEMENTED ON MAIN",
|
||||
"evennia-mind-palace.md",
|
||||
"evennia_tools/mind_palace.py",
|
||||
"scripts/evennia/render_mind_palace_entry_proof.py",
|
||||
"tests/test_evennia_mind_palace.py",
|
||||
"tests/test_evennia_mind_palace_doc.py",
|
||||
"PR #711",
|
||||
"issue comment #56965",
|
||||
"python3 -m pytest tests/test_evennia_layout.py tests/test_evennia_telemetry.py tests/test_evennia_training.py tests/test_evennia_mind_palace.py tests/test_evennia_mind_palace_doc.py -q",
|
||||
]
|
||||
|
||||
missing = [snippet for snippet in required_snippets if snippet not in text]
|
||||
assert not missing, missing
|
||||
@@ -1,109 +0,0 @@
|
||||
"""Verification that the Issue #582 epic orchestration slice exists on main.
|
||||
|
||||
Refs #582 — this test provides durable evidence that the parent-epic
|
||||
orchestrator and all phase scripts are present and importable.
|
||||
"""
|
||||
|
||||
import importlib.util
|
||||
from pathlib import Path
|
||||
import unittest
|
||||
|
||||
|
||||
ROOT = Path(__file__).resolve().parent.parent
|
||||
|
||||
|
||||
class TestIssue582Verification(unittest.TestCase):
|
||||
"""Confirm the Know Thy Father epic slice is on main."""
|
||||
|
||||
def _load_module(self, path: Path, name: str):
|
||||
self.assertTrue(path.exists(), f"missing {path.relative_to(ROOT)}")
|
||||
spec = importlib.util.spec_from_file_location(name, path)
|
||||
self.assertIsNotNone(spec)
|
||||
self.assertIsNotNone(spec.loader)
|
||||
module = importlib.util.module_from_spec(spec)
|
||||
spec.loader.exec_module(module)
|
||||
return module
|
||||
|
||||
# --- core orchestrator ---
|
||||
|
||||
def test_epic_pipeline_exists(self):
|
||||
path = ROOT / "scripts" / "know_thy_father" / "epic_pipeline.py"
|
||||
self.assertTrue(path.exists(), "epic_pipeline.py must exist on main")
|
||||
|
||||
def test_epic_pipeline_has_phases(self):
|
||||
mod = self._load_module(
|
||||
ROOT / "scripts" / "know_thy_father" / "epic_pipeline.py",
|
||||
"ktf_epic_pipeline",
|
||||
)
|
||||
self.assertTrue(hasattr(mod, "PHASES"), "PHASES list must be defined")
|
||||
self.assertGreaterEqual(len(mod.PHASES), 4, "at least 4 phases required")
|
||||
|
||||
# --- phase scripts ---
|
||||
|
||||
def test_phase1_media_indexing_exists(self):
|
||||
self.assertTrue(
|
||||
(ROOT / "scripts" / "know_thy_father" / "index_media.py").exists(),
|
||||
"phase1 script index_media.py must exist",
|
||||
)
|
||||
|
||||
def test_phase2_analyze_media_exists(self):
|
||||
self.assertTrue(
|
||||
(ROOT / "scripts" / "twitter_archive" / "analyze_media.py").exists(),
|
||||
"phase2 script analyze_media.py must exist",
|
||||
)
|
||||
|
||||
def test_phase3_synthesize_kernels_exists(self):
|
||||
self.assertTrue(
|
||||
(ROOT / "scripts" / "know_thy_father" / "synthesize_kernels.py").exists(),
|
||||
"phase3 script synthesize_kernels.py must exist",
|
||||
)
|
||||
|
||||
def test_phase4_crossref_audit_exists(self):
|
||||
self.assertTrue(
|
||||
(ROOT / "scripts" / "know_thy_father" / "crossref_audit.py").exists(),
|
||||
"phase4 script crossref_audit.py must exist",
|
||||
)
|
||||
|
||||
# --- documentation ---
|
||||
|
||||
def test_pipeline_docs_exist(self):
|
||||
self.assertTrue(
|
||||
(ROOT / "docs" / "KNOW_THY_FATHER_MULTIMODAL_PIPELINE.md").exists(),
|
||||
"pipeline documentation must exist",
|
||||
)
|
||||
|
||||
def test_verification_doc_exists(self):
|
||||
self.assertTrue(
|
||||
(ROOT / "docs" / "issue-582-verification.md").exists(),
|
||||
"issue-582-verification.md must exist",
|
||||
)
|
||||
|
||||
# --- test coverage ---
|
||||
|
||||
def test_pipeline_tests_exist(self):
|
||||
tests = [
|
||||
"test_know_thy_father_pipeline.py",
|
||||
"test_know_thy_father_index.py",
|
||||
"test_know_thy_father_synthesis.py",
|
||||
"test_know_thy_father_crossref.py",
|
||||
]
|
||||
for name in tests:
|
||||
self.assertTrue(
|
||||
(ROOT / "tests" / name).exists(),
|
||||
f"test file {name} must exist",
|
||||
)
|
||||
|
||||
def test_archive_tests_exist(self):
|
||||
archive_dir = ROOT / "tests" / "twitter_archive"
|
||||
self.assertTrue(
|
||||
(archive_dir / "test_ktf_tracker.py").exists(),
|
||||
"test_ktf_tracker.py must exist",
|
||||
)
|
||||
self.assertTrue(
|
||||
(archive_dir / "test_analyze_media.py").exists(),
|
||||
"test_analyze_media.py must exist",
|
||||
)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
Reference in New Issue
Block a user