Compare commits

..

2 Commits

Author SHA1 Message Date
Alexander Whitestone
3d57f42adc docs: verify #567 already implemented on main
Some checks failed
Self-Healing Smoke / self-healing-smoke (pull_request) Failing after 14s
Agent PR Gate / gate (pull_request) Failing after 27s
Smoke Test / smoke (pull_request) Failing after 10s
Agent PR Gate / report (pull_request) Has been cancelled
2026-04-16 23:50:54 -04:00
Alexander Whitestone
bb24a9ab4c test: define verification evidence for #567 2026-04-16 23:50:01 -04:00
4 changed files with 76 additions and 95 deletions

View File

@@ -0,0 +1,47 @@
# Issue #567 Verification
## Status: ✅ ALREADY IMPLEMENTED ON MAIN
Issue #567 asked for four things:
1. an architecture doc at `evennia-mind-palace.md`
2. a mapping of the 16 tracked Evennia issues to the mind-palace layers
3. Milestone 1 proof: one room, one object, one mutable fact wired to Timmy's burn cycle
4. a comment on the issue with proof of room entry injecting context
All four are already present on `main` in a fresh clone of `timmy-home`.
## Mainline Evidence
### Repo artifacts already on main
- `evennia-mind-palace.md`
- `evennia_tools/mind_palace.py`
- `scripts/evennia/render_mind_palace_entry_proof.py`
- `tests/test_evennia_mind_palace.py`
- `tests/test_evennia_mind_palace_doc.py`
### Acceptance criteria check
- Architecture doc exists at `evennia-mind-palace.md`
- The 16 tracked Evennia issues are mapped in the issue-to-layer table inside `evennia-mind-palace.md`
- Milestone 1 is implemented in `evennia_tools/mind_palace.py` with `Hall of Knowledge`, `The Ledger`, `MutableFact`, `BurnCycleSnapshot`, and deterministic room-entry rendering
- The proof comment already exists on the issue as issue comment #56965
## Historical trail
- PR #711 attempted the issue and posted the room-entry proof comment
- PR #711 was later closed unmerged, but the requested deliverables are present on `main` today and pass targeted verification from a fresh clone
## Verification run from fresh clone
Commands executed:
- `python3 -m pytest tests/test_evennia_layout.py tests/test_evennia_telemetry.py tests/test_evennia_training.py tests/test_evennia_mind_palace.py tests/test_evennia_mind_palace_doc.py -q`
- `python3 -m py_compile evennia_tools/mind_palace.py scripts/evennia/render_mind_palace_entry_proof.py`
- `python3 scripts/evennia/render_mind_palace_entry_proof.py`
Observed result:
- all targeted Evennia mind-palace tests passed
- the Python modules compiled cleanly
- the proof script emitted the expected `ENTER Hall of Knowledge` packet with room context, ledger fact, and Timmy burn-cycle focus
## Recommendation
Close issue #567 as already implemented on `main`.
This verification PR exists only to document the evidence trail cleanly and close the stale issue without re-implementing the already-landed architecture.

View File

@@ -0,0 +1,21 @@
from pathlib import Path
def test_issue_567_verification_doc_exists_with_mainline_evidence() -> None:
text = Path("docs/issue-567-verification.md").read_text(encoding="utf-8")
required_snippets = [
"# Issue #567 Verification",
"## Status: ✅ ALREADY IMPLEMENTED ON MAIN",
"evennia-mind-palace.md",
"evennia_tools/mind_palace.py",
"scripts/evennia/render_mind_palace_entry_proof.py",
"tests/test_evennia_mind_palace.py",
"tests/test_evennia_mind_palace_doc.py",
"PR #711",
"issue comment #56965",
"python3 -m pytest tests/test_evennia_layout.py tests/test_evennia_telemetry.py tests/test_evennia_training.py tests/test_evennia_mind_palace.py tests/test_evennia_mind_palace_doc.py -q",
]
missing = [snippet for snippet in required_snippets if snippet not in text]
assert not missing, missing

View File

@@ -1,15 +1,15 @@
from pathlib import Path
GENOME = Path('timmy-config-GENOME.md')
GENOME = Path('GENOME.md')
def read_genome() -> str:
assert GENOME.exists(), 'timmy-config-GENOME.md must exist at repo root'
assert GENOME.exists(), 'GENOME.md must exist at repo root'
return GENOME.read_text(encoding='utf-8')
def test_genome_exists():
assert GENOME.exists(), 'timmy-config-GENOME.md must exist at repo root'
assert GENOME.exists(), 'GENOME.md must exist at repo root'
def test_genome_has_required_sections():
@@ -17,7 +17,7 @@ def test_genome_has_required_sections():
for heading in [
'# GENOME.md — timmy-config',
'## Project Overview',
'## Architecture',
'## Architecture Diagram',
'## Entry Points and Data Flow',
'## Key Abstractions',
'## API Surface',
@@ -42,6 +42,9 @@ def test_genome_mentions_core_timmy_config_files():
'gitea_client.py',
'orchestration.py',
'tasks.py',
'bin/',
'playbooks/',
'training/',
]:
assert token in text
@@ -55,9 +58,4 @@ def test_genome_explains_sidecar_boundary():
def test_genome_is_substantial():
text = read_genome()
assert len(text) >= 2000
def test_genome_references_upstream_issue():
text = read_genome()
assert 'timmy-config #823' in text or '#823' in text
assert len(text) >= 5000

View File

@@ -1,85 +0,0 @@
# GENOME.md — timmy-config
Generated: 2026-04-18 15:00:00 EDT
Analyzed repo: Timmy_Foundation/timmy-config
Analyzed commit: 04ecad3
Host issue: timmy-home #814
Upstream issue: timmy-config #823
## Project Overview
`timmy-config` is a sidecar overlay repository for the Timmy ecosystem. It is **not** a Hermes-agent fork. It provides configuration, deployment automation, and orchestration tooling that wraps around the core Timmy services.
The repo ships its own `GENOME.md` on `main`, making this host-repo artifact a cross-repo genome lane entry that documents `timmy-config`'s role relative to `timmy-home` and the broader fleet.
Current target-repo test health: `python3 -m pytest -q` stops at **7 collection errors** on `main`. This is documented and tracked in upstream issue timmy-config #823.
## Architecture
```mermaid
graph TD
DEPLOY[deploy.sh] --> PLAY[playbooks/]
DEPLOY --> BIN[bin/]
CONFIG[config.yaml] --> ORCH[orchestration.py]
CONFIG --> GITEA[gitea_client.py]
ORCH --> TASKS[tasks.py]
GITEA --> API[Gitea API]
TASKS --> TRAINING[training/]
DOCS[README.md] --> BOUNDARY{timmy-config vs timmy-home\narchitectural boundary}
BOUNDARY --> SIDECAR[Sidecar overlay pattern]
SIDECAR --> HERMES[Hermes ecosystem integration]
```
## Entry Points and Data Flow
### `deploy.sh`
Primary deployment entry point. Orchestrates the rollout of configuration and sidecar services.
### `config.yaml`
Central configuration surface. Feeds into orchestration and task scheduling.
### `gitea_client.py`
Gitea API client. Handles communication with the Forge for issue and PR operations.
### `orchestration.py`
Orchestration engine. Coordinates task execution and deployment workflows.
### `tasks.py`
Task definitions. Contains the concrete work units dispatched by the orchestrator.
## Key Abstractions
- **Sidecar overlay**: `timmy-config` layers on top of core Timmy services without forking the Hermes-agent pattern
- **Control-plane surfaces**: `deploy.sh`, `config.yaml`, `gitea_client.py`, `orchestration.py`, `tasks.py` form the clearest control-plane surfaces
- **Architectural boundary**: The README boundary between `timmy-config` and `timmy-home` is architecturally important
## API Surface
- Gitea client API via `gitea_client.py`
- Task scheduling via `tasks.py`
- Deployment automation via `deploy.sh` and playbooks
## Test Coverage Gaps
- **7 collection errors** on `main` prevent pytest from running any tests
- Upstream issue timmy-config #823 filed to track broken pytest collection
- `bin/`, `playbooks/`, and `training/` directories referenced but test coverage status unknown
## Security Considerations
- `config.yaml` likely contains deployment credentials and service endpoints
- `gitea_client.py` handles API authentication tokens
- Playbooks execute system-level changes; audit trail important
## Performance Characteristics
- Cron-driven or manually triggered deployment cycles
- Lightweight Python sidecar; no heavy computation expected
- Gitea API rate limits are the primary bottleneck
## Cross-References
- Host repo: `Timmy_Foundation/timmy-home`
- Target repo: `Timmy_Foundation/timmy-config`
- Upstream follow-up: timmy-config #823 (broken pytest collection)
- Related genome: target repo ships its own `GENOME.md` on main