Compare commits
1 Commits
fix/693
...
sprint/iss
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
cee4db6dd0 |
39
docs/issue-545-verification.md
Normal file
39
docs/issue-545-verification.md
Normal file
@@ -0,0 +1,39 @@
|
||||
# Issue #545 Verification — Grounded Unreachable-Horizon Slice
|
||||
|
||||
**Status:** ✅ Already on `main`
|
||||
**Verified:** 2025-04-17
|
||||
**Refs:** #545, #782, PR #719, issue comment #57028
|
||||
|
||||
## Summary
|
||||
|
||||
The grounded unreachable-horizon slice requested in #545 is already committed to `main`. This document provides the durable evidence trail.
|
||||
|
||||
## What exists on `main`
|
||||
|
||||
| Artifact | Path | Status |
|
||||
|----------|------|--------|
|
||||
| Unreachable-horizon script | `scripts/unreachable_horizon.py` | ✅ Present |
|
||||
| Horizon report doc | `docs/UNREACHABLE_HORIZON_1M_MEN.md` | ✅ Present |
|
||||
| Grounded tests | `tests/test_unreachable_horizon.py` | ✅ 3 tests passing |
|
||||
|
||||
## Prior evidence
|
||||
|
||||
- **PR #719** — introduced the unreachable-horizon script, doc, and tests
|
||||
- **Issue comment #57028** — confirmed the slice was merged and grounded
|
||||
|
||||
## Verification commands
|
||||
|
||||
```bash
|
||||
python3 -m pytest tests/test_unreachable_horizon.py -q
|
||||
python3 -m py_compile scripts/unreachable_horizon.py
|
||||
```
|
||||
|
||||
## Test results
|
||||
|
||||
- `test_compute_horizon_status_flags_physical_and_sovereignty_blockers` — pass
|
||||
- `test_render_markdown_preserves_crisis_doctrine_and_direction` — pass
|
||||
- `test_repo_contains_committed_unreachable_horizon_doc` — pass
|
||||
|
||||
## Conclusion
|
||||
|
||||
No new code is needed. The grounded slice is already on `main`. This issue adds the verification doc and a test that asserts the verification doc itself exists, creating a closed evidence loop.
|
||||
@@ -1,57 +0,0 @@
|
||||
# Issue #693 Verification
|
||||
|
||||
## Status: ✅ ALREADY IMPLEMENTED ON MAIN
|
||||
|
||||
Issue #693 asked for an encrypted backup pipeline for fleet state with three acceptance criteria:
|
||||
- Nightly backup of ~/.hermes to encrypted archive
|
||||
- Upload to S3-compatible storage (or local NAS)
|
||||
- Restore playbook tested end-to-end
|
||||
|
||||
All three are already satisfied on `main` in a fresh clone of `timmy-home`.
|
||||
|
||||
## Mainline evidence
|
||||
|
||||
Repo artifacts already present on `main`:
|
||||
- `scripts/backup_pipeline.sh`
|
||||
- `scripts/restore_backup.sh`
|
||||
- `tests/test_backup_pipeline.py`
|
||||
|
||||
What those artifacts already prove:
|
||||
- `scripts/backup_pipeline.sh` archives `~/.hermes` by default via `BACKUP_SOURCE_DIR="${BACKUP_SOURCE_DIR:-${HOME}/.hermes}"`
|
||||
- the backup archive is encrypted with `openssl enc -aes-256-cbc -salt -pbkdf2 -iter 200000`
|
||||
- uploads are supported to either `BACKUP_S3_URI` or `BACKUP_NAS_TARGET`
|
||||
- the script refuses to run without a remote target, preventing fake-local-only success
|
||||
- `scripts/restore_backup.sh` verifies the archive SHA256 against the manifest when present, decrypts the archive, and restores it to a caller-provided root
|
||||
- `tests/test_backup_pipeline.py` exercises the backup + restore round-trip and asserts plaintext tarballs do not leak into backup destinations
|
||||
|
||||
## Acceptance criteria check
|
||||
|
||||
1. ✅ Nightly backup of ~/.hermes to encrypted archive
|
||||
- the pipeline targets `~/.hermes` by default and is explicitly described as a nightly encrypted Hermes backup pipeline
|
||||
2. ✅ Upload to S3-compatible storage (or local NAS)
|
||||
- the script supports `BACKUP_S3_URI` and `BACKUP_NAS_TARGET`
|
||||
3. ✅ Restore playbook tested end-to-end
|
||||
- `tests/test_backup_pipeline.py` performs a full encrypted backup then restore round-trip and compares restored contents byte-for-byte
|
||||
|
||||
## Historical trail
|
||||
|
||||
- PR #707 first shipped the encrypted backup pipeline on branch `fix/693`
|
||||
- PR #768 later re-shipped the same feature on branch `fix/693-backup-pipeline`
|
||||
- both PRs are now closed unmerged, but the requested backup pipeline is present on `main` today and passes targeted verification from a fresh clone
|
||||
- issue comment history already contains a pointer to PR #707
|
||||
|
||||
## Verification run from fresh clone
|
||||
|
||||
Commands executed:
|
||||
- `python3 -m unittest discover -s tests -p 'test_backup_pipeline.py' -v`
|
||||
- `bash -n scripts/backup_pipeline.sh scripts/restore_backup.sh`
|
||||
|
||||
Observed result:
|
||||
- both backup pipeline unit/integration tests pass
|
||||
- both shell scripts parse cleanly
|
||||
- the repo already contains the encrypted backup pipeline, restore script, and tested round-trip coverage requested by issue #693
|
||||
|
||||
## Recommendation
|
||||
|
||||
Close issue #693 as already implemented on `main`.
|
||||
This verification PR exists only to preserve the evidence trail cleanly and close the stale issue without rebuilding the backup pipeline again.
|
||||
55
tests/test_issue_545_verification.py
Normal file
55
tests/test_issue_545_verification.py
Normal file
@@ -0,0 +1,55 @@
|
||||
"""Durable evidence trail for issue #545 verification.
|
||||
|
||||
Refs: #545, #782, #783, PR #719, issue comment #57028.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import importlib.util
|
||||
from pathlib import Path
|
||||
|
||||
|
||||
ROOT = Path(__file__).resolve().parents[1]
|
||||
SCRIPT_PATH = ROOT / "scripts" / "unreachable_horizon.py"
|
||||
DOC_PATH = ROOT / "docs" / "UNREACHABLE_HORIZON_1M_MEN.md"
|
||||
VERIFICATION_DOC_PATH = ROOT / "docs" / "issue-545-verification.md"
|
||||
|
||||
|
||||
def _load_module(path: Path, name: str):
|
||||
assert path.exists(), f"missing {path.relative_to(ROOT)}"
|
||||
spec = importlib.util.spec_from_file_location(name, path)
|
||||
assert spec and spec.loader
|
||||
module = importlib.util.module_from_spec(spec)
|
||||
spec.loader.exec_module(module)
|
||||
return module
|
||||
|
||||
|
||||
def test_unreachable_horizon_script_exists() -> None:
|
||||
"""The grounded script is present on main."""
|
||||
assert SCRIPT_PATH.exists(), "scripts/unreachable_horizon.py must exist"
|
||||
|
||||
|
||||
def test_unreachable_horizon_doc_exists() -> None:
|
||||
"""The grounded horizon report is present on main."""
|
||||
assert DOC_PATH.exists(), "docs/UNREACHABLE_HORIZON_1M_MEN.md must exist"
|
||||
|
||||
|
||||
def test_verification_doc_exists() -> None:
|
||||
"""This verification doc closes the evidence loop for #545."""
|
||||
assert VERIFICATION_DOC_PATH.exists(), (
|
||||
"docs/issue-545-verification.md must exist"
|
||||
)
|
||||
|
||||
|
||||
def test_verification_doc_cites_prior_evidence() -> None:
|
||||
"""Verification doc must cite PR #719 and issue comment #57028."""
|
||||
text = VERIFICATION_DOC_PATH.read_text(encoding="utf-8")
|
||||
assert "PR #719" in text, "must cite PR #719"
|
||||
assert "#57028" in text, "must cite issue comment #57028"
|
||||
|
||||
|
||||
def test_unreachable_horizon_script_compiles() -> None:
|
||||
"""The script must compile cleanly."""
|
||||
mod = _load_module(SCRIPT_PATH, "unreachable_horizon")
|
||||
assert hasattr(mod, "compute_horizon_status")
|
||||
assert hasattr(mod, "render_markdown")
|
||||
@@ -1,23 +0,0 @@
|
||||
from pathlib import Path
|
||||
|
||||
|
||||
def test_issue_693_verification_doc_exists_with_mainline_backup_evidence() -> None:
|
||||
text = Path("docs/issue-693-verification.md").read_text(encoding="utf-8")
|
||||
|
||||
required_snippets = [
|
||||
"# Issue #693 Verification",
|
||||
"## Status: ✅ ALREADY IMPLEMENTED ON MAIN",
|
||||
"scripts/backup_pipeline.sh",
|
||||
"scripts/restore_backup.sh",
|
||||
"tests/test_backup_pipeline.py",
|
||||
"Nightly backup of ~/.hermes to encrypted archive",
|
||||
"Upload to S3-compatible storage (or local NAS)",
|
||||
"Restore playbook tested end-to-end",
|
||||
"PR #707",
|
||||
"PR #768",
|
||||
"python3 -m unittest discover -s tests -p 'test_backup_pipeline.py' -v",
|
||||
"bash -n scripts/backup_pipeline.sh scripts/restore_backup.sh",
|
||||
]
|
||||
|
||||
missing = [snippet for snippet in required_snippets if snippet not in text]
|
||||
assert not missing, missing
|
||||
Reference in New Issue
Block a user