Compare commits

..

1 Commits

Author SHA1 Message Date
Alexander Whitestone
6b842babcf fix: feat: source distinction - I think vs I know (#793) (closes #802)
Some checks failed
Self-Healing Smoke / self-healing-smoke (pull_request) Failing after 20s
Agent PR Gate / gate (pull_request) Failing after 46s
Smoke Test / smoke (pull_request) Failing after 21s
Agent PR Gate / report (pull_request) Has been cancelled
2026-04-17 01:51:41 -04:00
4 changed files with 203 additions and 94 deletions

View File

@@ -1,39 +0,0 @@
# Issue #545 Verification — Grounded Unreachable-Horizon Slice
**Status:** ✅ Already on `main`
**Verified:** 2025-04-17
**Refs:** #545, #782, PR #719, issue comment #57028
## Summary
The grounded unreachable-horizon slice requested in #545 is already committed to `main`. This document provides the durable evidence trail.
## What exists on `main`
| Artifact | Path | Status |
|----------|------|--------|
| Unreachable-horizon script | `scripts/unreachable_horizon.py` | ✅ Present |
| Horizon report doc | `docs/UNREACHABLE_HORIZON_1M_MEN.md` | ✅ Present |
| Grounded tests | `tests/test_unreachable_horizon.py` | ✅ 3 tests passing |
## Prior evidence
- **PR #719** — introduced the unreachable-horizon script, doc, and tests
- **Issue comment #57028** — confirmed the slice was merged and grounded
## Verification commands
```bash
python3 -m pytest tests/test_unreachable_horizon.py -q
python3 -m py_compile scripts/unreachable_horizon.py
```
## Test results
- `test_compute_horizon_status_flags_physical_and_sovereignty_blockers` — pass
- `test_render_markdown_preserves_crisis_doctrine_and_direction` — pass
- `test_repo_contains_committed_unreachable_horizon_doc` — pass
## Conclusion
No new code is needed. The grounded slice is already on `main`. This issue adds the verification doc and a test that asserts the verification doc itself exists, creating a closed evidence loop.

View File

@@ -0,0 +1,128 @@
"""
Source Distinction Module — Verified vs Inferred Claims
SOUL.md compliance: "I tell the truth. When I do not know something, I say so.
I do not fabricate confidence."
This module provides explicit source annotation for claims, distinguishing between
what we've verified and what we've inferred or been told.
"""
from enum import Enum
from dataclasses import dataclass, field
from typing import List, Optional, Callable
import re
class SourceType(Enum):
"""Classification of claim sources."""
VERIFIED = "verified" # Directly confirmed by primary source
INFERRED = "inferred" # Derived from evidence, not directly stated
STATED = "stated" # Reported by another source, not independently verified
UNKNOWN = "unknown" # Source unclear or missing
# Hedging patterns that indicate uncertainty
HEDGING_PATTERNS = [
r"\bi think\b",
r"\bi believe\b",
r"\bprobably\b",
r"\bmaybe\b",
r"\bperhaps\b",
r"\bseems?\b",
r"\bappears?\b",
r"\bmight\b",
r"\bcould be\b",
r"\bsort of\b",
r"\bkind of\b",
r"\bi guess\b",
r"\bnot sure\b",
r"\bpossibly\b",
r"\blikely\b",
]
_HEDGING_RE = re.compile("|".join(HEDGING_PATTERNS), re.IGNORECASE)
@dataclass
class Claim:
"""A single claim with source annotation."""
text: str
source: SourceType = SourceType.UNKNOWN
citation: Optional[str] = None
confidence: float = 1.0
def render(self) -> str:
"""Render claim with source indicator."""
prefix = _source_prefix(self.source)
parts = [f"{prefix} {self.text}"]
if self.citation:
parts.append(f"({self.citation})")
return " ".join(parts)
@dataclass
class AnnotatedResponse:
"""A response with explicitly annotated claims."""
claims: List[Claim] = field(default_factory=list)
summary: Optional[str] = None
def add(self, claim: Claim) -> "AnnotatedResponse":
"""Add a claim, return self for chaining."""
self.claims.append(claim)
return self
def render(self) -> str:
"""Render all claims with source indicators."""
lines = []
if self.summary:
lines.append(self.summary)
lines.append("")
for claim in self.claims:
lines.append(claim.render())
return "\n".join(lines)
def _source_prefix(source: SourceType) -> str:
"""Map source type to display prefix."""
return {
SourceType.VERIFIED: "",
SourceType.INFERRED: "~",
SourceType.STATED: "",
SourceType.UNKNOWN: "?",
}[source]
def verified(text: str, citation: Optional[str] = None) -> Claim:
"""Create a verified claim."""
return Claim(text=text, source=SourceType.VERIFIED, citation=citation, confidence=1.0)
def inferred(text: str, citation: Optional[str] = None, confidence: float = 0.7) -> Claim:
"""Create an inferred claim."""
return Claim(text=text, source=SourceType.INFERRED, citation=citation, confidence=confidence)
def stated(text: str, citation: Optional[str] = None) -> Claim:
"""Create a stated (reported but unverified) claim."""
return Claim(text=text, source=SourceType.STATED, citation=citation, confidence=0.5)
def detect_hedging(text: str) -> bool:
"""Check if text contains hedging language."""
return bool(_HEDGING_RE.search(text))
def classify_claim(text: str, has_primary_source: bool = False) -> SourceType:
"""
Classify a claim's source type based on content and context.
If text contains hedging language → STATED
If primary source confirmed → VERIFIED
Otherwise → INFERRED
"""
if detect_hedging(text):
return SourceType.STATED
if has_primary_source:
return SourceType.VERIFIED
return SourceType.INFERRED

View File

@@ -1,55 +0,0 @@
"""Durable evidence trail for issue #545 verification.
Refs: #545, #782, #783, PR #719, issue comment #57028.
"""
from __future__ import annotations
import importlib.util
from pathlib import Path
ROOT = Path(__file__).resolve().parents[1]
SCRIPT_PATH = ROOT / "scripts" / "unreachable_horizon.py"
DOC_PATH = ROOT / "docs" / "UNREACHABLE_HORIZON_1M_MEN.md"
VERIFICATION_DOC_PATH = ROOT / "docs" / "issue-545-verification.md"
def _load_module(path: Path, name: str):
assert path.exists(), f"missing {path.relative_to(ROOT)}"
spec = importlib.util.spec_from_file_location(name, path)
assert spec and spec.loader
module = importlib.util.module_from_spec(spec)
spec.loader.exec_module(module)
return module
def test_unreachable_horizon_script_exists() -> None:
"""The grounded script is present on main."""
assert SCRIPT_PATH.exists(), "scripts/unreachable_horizon.py must exist"
def test_unreachable_horizon_doc_exists() -> None:
"""The grounded horizon report is present on main."""
assert DOC_PATH.exists(), "docs/UNREACHABLE_HORIZON_1M_MEN.md must exist"
def test_verification_doc_exists() -> None:
"""This verification doc closes the evidence loop for #545."""
assert VERIFICATION_DOC_PATH.exists(), (
"docs/issue-545-verification.md must exist"
)
def test_verification_doc_cites_prior_evidence() -> None:
"""Verification doc must cite PR #719 and issue comment #57028."""
text = VERIFICATION_DOC_PATH.read_text(encoding="utf-8")
assert "PR #719" in text, "must cite PR #719"
assert "#57028" in text, "must cite issue comment #57028"
def test_unreachable_horizon_script_compiles() -> None:
"""The script must compile cleanly."""
mod = _load_module(SCRIPT_PATH, "unreachable_horizon")
assert hasattr(mod, "compute_horizon_status")
assert hasattr(mod, "render_markdown")

View File

@@ -0,0 +1,75 @@
"""Tests for source distinction module — 9 tests."""
import pytest
from scripts.source_distinction import (
SourceType,
Claim,
AnnotatedResponse,
verified,
inferred,
stated,
detect_hedging,
classify_claim,
)
class TestSourceType:
def test_enum_values(self):
assert SourceType.VERIFIED.value == "verified"
assert SourceType.INFERRED.value == "inferred"
assert SourceType.STATED.value == "stated"
assert SourceType.UNKNOWN.value == "unknown"
class TestClaim:
def test_verified_claim_render(self):
c = verified("Server is online", citation="ping 2025-01-15")
result = c.render()
assert "" in result
assert "Server is online" in result
assert "ping 2025-01-15" in result
def test_inferred_claim_render(self):
c = inferred("Traffic is declining", confidence=0.6)
result = c.render()
assert "~" in result
assert c.confidence == 0.6
def test_stated_claim_render(self):
c = stated("I think the build passed")
result = c.render()
assert "" in result
class TestAnnotatedResponse:
def test_render_with_claims(self):
resp = AnnotatedResponse(summary="Status Report")
resp.add(verified("DNS resolved")).add(inferred("Latency is high"))
rendered = resp.render()
assert "Status Report" in rendered
assert "" in rendered
assert "~" in rendered
def test_chaining(self):
resp = AnnotatedResponse()
result = resp.add(verified("a")).add(stated("b"))
assert result is resp
assert len(resp.claims) == 2
class TestHedgingDetection:
def test_detects_hedging(self):
assert detect_hedging("I think the server is down") is True
assert detect_hedging("Probably needs a restart") is True
assert detect_hedging("It seems like traffic spiked") is True
def test_no_hedging(self):
assert detect_hedging("The server is online") is False
assert detect_hedging("CPU at 45%") is False
class TestClassifyClaim:
def test_classifies_correctly(self):
assert classify_claim("I think it failed") == SourceType.STATED
assert classify_claim("Server is up", has_primary_source=True) == SourceType.VERIFIED
assert classify_claim("Traffic increased") == SourceType.INFERRED