Compare commits
1 Commits
sprint/iss
...
sprint/iss
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
6b842babcf |
@@ -1,51 +0,0 @@
|
||||
# Issue #680 Verification — Fleet-Ops Genome Already Implemented
|
||||
|
||||
**Date:** 2026-04-14
|
||||
**Verified by:** Sprint auto-implementation (issue #807)
|
||||
**Status:** ✅ Already implemented on `main`
|
||||
|
||||
## Summary
|
||||
|
||||
The fleet-ops genome deliverable requested in issue #680 already exists on `main`.
|
||||
This document records the verification evidence and closes the stale issue.
|
||||
|
||||
## Existing Artifact
|
||||
|
||||
- **Genome document:** `genomes/fleet-ops-GENOME.md`
|
||||
- **Regression test:** `tests/test_fleet_ops_genome.py`
|
||||
|
||||
The genome document contains:
|
||||
- Project overview grounded in a fresh clone of `fleet-ops` at commit `38c4eab`
|
||||
- Mermaid architecture diagram
|
||||
- Structural analysis of Ansible playbooks, Python microservices, cron jobs, and docker-compose sandbox
|
||||
- Key abstractions, API surface, test coverage gaps, security considerations, and deployment notes
|
||||
- Concrete metrics: 97 source files, 12 test files, 29 config files, 16,658 lines
|
||||
- Test results: 158 passed, 1 failed, 2 errors
|
||||
|
||||
## Prior PR Trail (Closed Unmerged)
|
||||
|
||||
The issue remained open because earlier linking PRs were closed without merging:
|
||||
|
||||
- **PR #697** — closed unmerged
|
||||
- **PR #770** — closed unmerged
|
||||
|
||||
Since the artifact landed on `main` through other means, those PRs became stale.
|
||||
|
||||
## Verification Commands
|
||||
|
||||
```bash
|
||||
# Confirm artifact exists
|
||||
ls -la genomes/fleet-ops-GENOME.md
|
||||
ls -la tests/test_fleet_ops_genome.py
|
||||
|
||||
# Run regression tests
|
||||
python3 -m pytest -q tests/test_fleet_ops_genome.py
|
||||
|
||||
# Syntax check
|
||||
python3 -m py_compile tests/test_fleet_ops_genome.py
|
||||
```
|
||||
|
||||
## Conclusion
|
||||
|
||||
No new content is needed. Issue #680 is resolved by the existing implementation.
|
||||
This PR adds the verification doc and a test to lock the evidence trail.
|
||||
128
scripts/source_distinction.py
Normal file
128
scripts/source_distinction.py
Normal file
@@ -0,0 +1,128 @@
|
||||
"""
|
||||
Source Distinction Module — Verified vs Inferred Claims
|
||||
|
||||
SOUL.md compliance: "I tell the truth. When I do not know something, I say so.
|
||||
I do not fabricate confidence."
|
||||
|
||||
This module provides explicit source annotation for claims, distinguishing between
|
||||
what we've verified and what we've inferred or been told.
|
||||
"""
|
||||
|
||||
from enum import Enum
|
||||
from dataclasses import dataclass, field
|
||||
from typing import List, Optional, Callable
|
||||
import re
|
||||
|
||||
|
||||
class SourceType(Enum):
|
||||
"""Classification of claim sources."""
|
||||
VERIFIED = "verified" # Directly confirmed by primary source
|
||||
INFERRED = "inferred" # Derived from evidence, not directly stated
|
||||
STATED = "stated" # Reported by another source, not independently verified
|
||||
UNKNOWN = "unknown" # Source unclear or missing
|
||||
|
||||
|
||||
# Hedging patterns that indicate uncertainty
|
||||
HEDGING_PATTERNS = [
|
||||
r"\bi think\b",
|
||||
r"\bi believe\b",
|
||||
r"\bprobably\b",
|
||||
r"\bmaybe\b",
|
||||
r"\bperhaps\b",
|
||||
r"\bseems?\b",
|
||||
r"\bappears?\b",
|
||||
r"\bmight\b",
|
||||
r"\bcould be\b",
|
||||
r"\bsort of\b",
|
||||
r"\bkind of\b",
|
||||
r"\bi guess\b",
|
||||
r"\bnot sure\b",
|
||||
r"\bpossibly\b",
|
||||
r"\blikely\b",
|
||||
]
|
||||
|
||||
_HEDGING_RE = re.compile("|".join(HEDGING_PATTERNS), re.IGNORECASE)
|
||||
|
||||
|
||||
@dataclass
|
||||
class Claim:
|
||||
"""A single claim with source annotation."""
|
||||
text: str
|
||||
source: SourceType = SourceType.UNKNOWN
|
||||
citation: Optional[str] = None
|
||||
confidence: float = 1.0
|
||||
|
||||
def render(self) -> str:
|
||||
"""Render claim with source indicator."""
|
||||
prefix = _source_prefix(self.source)
|
||||
parts = [f"{prefix} {self.text}"]
|
||||
if self.citation:
|
||||
parts.append(f"({self.citation})")
|
||||
return " ".join(parts)
|
||||
|
||||
|
||||
@dataclass
|
||||
class AnnotatedResponse:
|
||||
"""A response with explicitly annotated claims."""
|
||||
claims: List[Claim] = field(default_factory=list)
|
||||
summary: Optional[str] = None
|
||||
|
||||
def add(self, claim: Claim) -> "AnnotatedResponse":
|
||||
"""Add a claim, return self for chaining."""
|
||||
self.claims.append(claim)
|
||||
return self
|
||||
|
||||
def render(self) -> str:
|
||||
"""Render all claims with source indicators."""
|
||||
lines = []
|
||||
if self.summary:
|
||||
lines.append(self.summary)
|
||||
lines.append("")
|
||||
for claim in self.claims:
|
||||
lines.append(claim.render())
|
||||
return "\n".join(lines)
|
||||
|
||||
|
||||
def _source_prefix(source: SourceType) -> str:
|
||||
"""Map source type to display prefix."""
|
||||
return {
|
||||
SourceType.VERIFIED: "✓",
|
||||
SourceType.INFERRED: "~",
|
||||
SourceType.STATED: "◇",
|
||||
SourceType.UNKNOWN: "?",
|
||||
}[source]
|
||||
|
||||
|
||||
def verified(text: str, citation: Optional[str] = None) -> Claim:
|
||||
"""Create a verified claim."""
|
||||
return Claim(text=text, source=SourceType.VERIFIED, citation=citation, confidence=1.0)
|
||||
|
||||
|
||||
def inferred(text: str, citation: Optional[str] = None, confidence: float = 0.7) -> Claim:
|
||||
"""Create an inferred claim."""
|
||||
return Claim(text=text, source=SourceType.INFERRED, citation=citation, confidence=confidence)
|
||||
|
||||
|
||||
def stated(text: str, citation: Optional[str] = None) -> Claim:
|
||||
"""Create a stated (reported but unverified) claim."""
|
||||
return Claim(text=text, source=SourceType.STATED, citation=citation, confidence=0.5)
|
||||
|
||||
|
||||
def detect_hedging(text: str) -> bool:
|
||||
"""Check if text contains hedging language."""
|
||||
return bool(_HEDGING_RE.search(text))
|
||||
|
||||
|
||||
def classify_claim(text: str, has_primary_source: bool = False) -> SourceType:
|
||||
"""
|
||||
Classify a claim's source type based on content and context.
|
||||
|
||||
If text contains hedging language → STATED
|
||||
If primary source confirmed → VERIFIED
|
||||
Otherwise → INFERRED
|
||||
"""
|
||||
if detect_hedging(text):
|
||||
return SourceType.STATED
|
||||
if has_primary_source:
|
||||
return SourceType.VERIFIED
|
||||
return SourceType.INFERRED
|
||||
@@ -1,52 +0,0 @@
|
||||
"""
|
||||
Verification test for issue #680 — fleet-ops genome deliverable.
|
||||
|
||||
Locks the evidence trail proving the genome document and its
|
||||
regression test already exist on main.
|
||||
"""
|
||||
|
||||
import unittest
|
||||
from pathlib import Path
|
||||
|
||||
ROOT = Path(__file__).resolve().parent.parent
|
||||
GENOME_PATH = ROOT / "genomes" / "fleet-ops-GENOME.md"
|
||||
REGRESSION_TEST = ROOT / "tests" / "test_fleet_ops_genome.py"
|
||||
VERIFICATION_DOC = ROOT / "docs" / "issue-680-verification.md"
|
||||
|
||||
|
||||
class TestIssue680Verification(unittest.TestCase):
|
||||
"""Confirm the #680 deliverable is present on main."""
|
||||
|
||||
def test_genome_document_exists(self):
|
||||
self.assertTrue(
|
||||
GENOME_PATH.exists(),
|
||||
"genomes/fleet-ops-GENOME.md must exist (issue #680 deliverable)",
|
||||
)
|
||||
|
||||
def test_genome_document_is_substantial(self):
|
||||
text = GENOME_PATH.read_text(encoding="utf-8")
|
||||
self.assertIn("# GENOME.md — fleet-ops", text)
|
||||
self.assertIn("## Project Overview", text)
|
||||
self.assertIn("## Architecture", text)
|
||||
self.assertGreaterEqual(len(text), 7000, "genome should be >= 7000 chars")
|
||||
|
||||
def test_regression_test_exists(self):
|
||||
self.assertTrue(
|
||||
REGRESSION_TEST.exists(),
|
||||
"tests/test_fleet_ops_genome.py must exist as regression guard",
|
||||
)
|
||||
|
||||
def test_verification_doc_exists(self):
|
||||
self.assertTrue(
|
||||
VERIFICATION_DOC.exists(),
|
||||
"docs/issue-680-verification.md must exist",
|
||||
)
|
||||
|
||||
def test_verification_doc_mentions_prior_prs(self):
|
||||
text = VERIFICATION_DOC.read_text(encoding="utf-8")
|
||||
self.assertIn("#697", text, "should reference PR #697")
|
||||
self.assertIn("#770", text, "should reference PR #770")
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
75
tests/test_source_distinction.py
Normal file
75
tests/test_source_distinction.py
Normal file
@@ -0,0 +1,75 @@
|
||||
"""Tests for source distinction module — 9 tests."""
|
||||
|
||||
import pytest
|
||||
from scripts.source_distinction import (
|
||||
SourceType,
|
||||
Claim,
|
||||
AnnotatedResponse,
|
||||
verified,
|
||||
inferred,
|
||||
stated,
|
||||
detect_hedging,
|
||||
classify_claim,
|
||||
)
|
||||
|
||||
|
||||
class TestSourceType:
|
||||
def test_enum_values(self):
|
||||
assert SourceType.VERIFIED.value == "verified"
|
||||
assert SourceType.INFERRED.value == "inferred"
|
||||
assert SourceType.STATED.value == "stated"
|
||||
assert SourceType.UNKNOWN.value == "unknown"
|
||||
|
||||
|
||||
class TestClaim:
|
||||
def test_verified_claim_render(self):
|
||||
c = verified("Server is online", citation="ping 2025-01-15")
|
||||
result = c.render()
|
||||
assert "✓" in result
|
||||
assert "Server is online" in result
|
||||
assert "ping 2025-01-15" in result
|
||||
|
||||
def test_inferred_claim_render(self):
|
||||
c = inferred("Traffic is declining", confidence=0.6)
|
||||
result = c.render()
|
||||
assert "~" in result
|
||||
assert c.confidence == 0.6
|
||||
|
||||
def test_stated_claim_render(self):
|
||||
c = stated("I think the build passed")
|
||||
result = c.render()
|
||||
assert "◇" in result
|
||||
|
||||
|
||||
class TestAnnotatedResponse:
|
||||
def test_render_with_claims(self):
|
||||
resp = AnnotatedResponse(summary="Status Report")
|
||||
resp.add(verified("DNS resolved")).add(inferred("Latency is high"))
|
||||
rendered = resp.render()
|
||||
assert "Status Report" in rendered
|
||||
assert "✓" in rendered
|
||||
assert "~" in rendered
|
||||
|
||||
def test_chaining(self):
|
||||
resp = AnnotatedResponse()
|
||||
result = resp.add(verified("a")).add(stated("b"))
|
||||
assert result is resp
|
||||
assert len(resp.claims) == 2
|
||||
|
||||
|
||||
class TestHedgingDetection:
|
||||
def test_detects_hedging(self):
|
||||
assert detect_hedging("I think the server is down") is True
|
||||
assert detect_hedging("Probably needs a restart") is True
|
||||
assert detect_hedging("It seems like traffic spiked") is True
|
||||
|
||||
def test_no_hedging(self):
|
||||
assert detect_hedging("The server is online") is False
|
||||
assert detect_hedging("CPU at 45%") is False
|
||||
|
||||
|
||||
class TestClassifyClaim:
|
||||
def test_classifies_correctly(self):
|
||||
assert classify_claim("I think it failed") == SourceType.STATED
|
||||
assert classify_claim("Server is up", has_primary_source=True) == SourceType.VERIFIED
|
||||
assert classify_claim("Traffic increased") == SourceType.INFERRED
|
||||
Reference in New Issue
Block a user