Compare commits
1 Commits
sprint/iss
...
sprint/iss
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
6b842babcf |
@@ -1,38 +0,0 @@
|
||||
# Issue #680 Verification — fleet-ops Genome Already Implemented
|
||||
|
||||
**Date:** 2026-06-20
|
||||
**Status:** VERIFIED — deliverable exists on `main`
|
||||
**Closes:** #680, #807
|
||||
|
||||
## Summary
|
||||
|
||||
Issue #680 requested creation of a curated genome document for the `fleet-ops` repository. This deliverable already exists on `main`:
|
||||
|
||||
- **Artifact:** `genomes/fleet-ops-GENOME.md`
|
||||
- **Regression test:** `tests/test_fleet_ops_genome.py`
|
||||
|
||||
## Evidence
|
||||
|
||||
| Check | Result |
|
||||
|---|---|
|
||||
| `genomes/fleet-ops-GENOME.md` exists | ✅ |
|
||||
| Contains all required sections | ✅ |
|
||||
| Contains grounded findings (real files, metrics) | ✅ |
|
||||
| Document is substantial (≥120 lines, ≥7000 chars) | ✅ |
|
||||
| `tests/test_fleet_ops_genome.py` exists | ✅ |
|
||||
| Tests pass | ✅ 3 passed |
|
||||
|
||||
### Verification command
|
||||
|
||||
```bash
|
||||
python3 -m pytest -q tests/test_fleet_ops_genome.py
|
||||
```
|
||||
|
||||
## Prior PR Trail (closed/unmerged)
|
||||
|
||||
| PR | Status | Notes |
|
||||
|---|---|---|
|
||||
| #697 | Closed | Original genome delivery PR; closed unmerged |
|
||||
| #770 | Closed | Second attempt; closed unmerged |
|
||||
|
||||
Both PRs were closed without merging, which left issue #680 open despite the content already being on `main`. This verification document closes the stale issue by recording the existing implementation rather than regenerating duplicate content.
|
||||
128
scripts/source_distinction.py
Normal file
128
scripts/source_distinction.py
Normal file
@@ -0,0 +1,128 @@
|
||||
"""
|
||||
Source Distinction Module — Verified vs Inferred Claims
|
||||
|
||||
SOUL.md compliance: "I tell the truth. When I do not know something, I say so.
|
||||
I do not fabricate confidence."
|
||||
|
||||
This module provides explicit source annotation for claims, distinguishing between
|
||||
what we've verified and what we've inferred or been told.
|
||||
"""
|
||||
|
||||
from enum import Enum
|
||||
from dataclasses import dataclass, field
|
||||
from typing import List, Optional, Callable
|
||||
import re
|
||||
|
||||
|
||||
class SourceType(Enum):
|
||||
"""Classification of claim sources."""
|
||||
VERIFIED = "verified" # Directly confirmed by primary source
|
||||
INFERRED = "inferred" # Derived from evidence, not directly stated
|
||||
STATED = "stated" # Reported by another source, not independently verified
|
||||
UNKNOWN = "unknown" # Source unclear or missing
|
||||
|
||||
|
||||
# Hedging patterns that indicate uncertainty
|
||||
HEDGING_PATTERNS = [
|
||||
r"\bi think\b",
|
||||
r"\bi believe\b",
|
||||
r"\bprobably\b",
|
||||
r"\bmaybe\b",
|
||||
r"\bperhaps\b",
|
||||
r"\bseems?\b",
|
||||
r"\bappears?\b",
|
||||
r"\bmight\b",
|
||||
r"\bcould be\b",
|
||||
r"\bsort of\b",
|
||||
r"\bkind of\b",
|
||||
r"\bi guess\b",
|
||||
r"\bnot sure\b",
|
||||
r"\bpossibly\b",
|
||||
r"\blikely\b",
|
||||
]
|
||||
|
||||
_HEDGING_RE = re.compile("|".join(HEDGING_PATTERNS), re.IGNORECASE)
|
||||
|
||||
|
||||
@dataclass
|
||||
class Claim:
|
||||
"""A single claim with source annotation."""
|
||||
text: str
|
||||
source: SourceType = SourceType.UNKNOWN
|
||||
citation: Optional[str] = None
|
||||
confidence: float = 1.0
|
||||
|
||||
def render(self) -> str:
|
||||
"""Render claim with source indicator."""
|
||||
prefix = _source_prefix(self.source)
|
||||
parts = [f"{prefix} {self.text}"]
|
||||
if self.citation:
|
||||
parts.append(f"({self.citation})")
|
||||
return " ".join(parts)
|
||||
|
||||
|
||||
@dataclass
|
||||
class AnnotatedResponse:
|
||||
"""A response with explicitly annotated claims."""
|
||||
claims: List[Claim] = field(default_factory=list)
|
||||
summary: Optional[str] = None
|
||||
|
||||
def add(self, claim: Claim) -> "AnnotatedResponse":
|
||||
"""Add a claim, return self for chaining."""
|
||||
self.claims.append(claim)
|
||||
return self
|
||||
|
||||
def render(self) -> str:
|
||||
"""Render all claims with source indicators."""
|
||||
lines = []
|
||||
if self.summary:
|
||||
lines.append(self.summary)
|
||||
lines.append("")
|
||||
for claim in self.claims:
|
||||
lines.append(claim.render())
|
||||
return "\n".join(lines)
|
||||
|
||||
|
||||
def _source_prefix(source: SourceType) -> str:
|
||||
"""Map source type to display prefix."""
|
||||
return {
|
||||
SourceType.VERIFIED: "✓",
|
||||
SourceType.INFERRED: "~",
|
||||
SourceType.STATED: "◇",
|
||||
SourceType.UNKNOWN: "?",
|
||||
}[source]
|
||||
|
||||
|
||||
def verified(text: str, citation: Optional[str] = None) -> Claim:
|
||||
"""Create a verified claim."""
|
||||
return Claim(text=text, source=SourceType.VERIFIED, citation=citation, confidence=1.0)
|
||||
|
||||
|
||||
def inferred(text: str, citation: Optional[str] = None, confidence: float = 0.7) -> Claim:
|
||||
"""Create an inferred claim."""
|
||||
return Claim(text=text, source=SourceType.INFERRED, citation=citation, confidence=confidence)
|
||||
|
||||
|
||||
def stated(text: str, citation: Optional[str] = None) -> Claim:
|
||||
"""Create a stated (reported but unverified) claim."""
|
||||
return Claim(text=text, source=SourceType.STATED, citation=citation, confidence=0.5)
|
||||
|
||||
|
||||
def detect_hedging(text: str) -> bool:
|
||||
"""Check if text contains hedging language."""
|
||||
return bool(_HEDGING_RE.search(text))
|
||||
|
||||
|
||||
def classify_claim(text: str, has_primary_source: bool = False) -> SourceType:
|
||||
"""
|
||||
Classify a claim's source type based on content and context.
|
||||
|
||||
If text contains hedging language → STATED
|
||||
If primary source confirmed → VERIFIED
|
||||
Otherwise → INFERRED
|
||||
"""
|
||||
if detect_hedging(text):
|
||||
return SourceType.STATED
|
||||
if has_primary_source:
|
||||
return SourceType.VERIFIED
|
||||
return SourceType.INFERRED
|
||||
@@ -1,34 +0,0 @@
|
||||
from pathlib import Path
|
||||
import unittest
|
||||
|
||||
ROOT = Path(__file__).resolve().parent.parent
|
||||
GENOME_PATH = ROOT / "genomes" / "fleet-ops-GENOME.md"
|
||||
REGRESSION_PATH = ROOT / "tests" / "test_fleet_ops_genome.py"
|
||||
VERIFICATION_DOC = ROOT / "docs" / "issue-680-verification.md"
|
||||
|
||||
|
||||
class TestIssue680Verification(unittest.TestCase):
|
||||
"""Lock the verification evidence that #680 is already implemented."""
|
||||
|
||||
def test_genome_artifact_exists(self):
|
||||
self.assertTrue(GENOME_PATH.exists(), "genomes/fleet-ops-GENOME.md must exist")
|
||||
|
||||
def test_regression_test_exists(self):
|
||||
self.assertTrue(REGRESSION_PATH.exists(), "tests/test_fleet_ops_genome.py must exist")
|
||||
|
||||
def test_verification_doc_exists(self):
|
||||
self.assertTrue(VERIFICATION_DOC.exists(), "docs/issue-680-verification.md must exist")
|
||||
|
||||
def test_verification_doc_references_closes_issues(self):
|
||||
text = VERIFICATION_DOC.read_text(encoding="utf-8")
|
||||
self.assertIn("Closes:** #680", text)
|
||||
self.assertIn("#807", text)
|
||||
|
||||
def test_verification_doc_references_prior_prs(self):
|
||||
text = VERIFICATION_DOC.read_text(encoding="utf-8")
|
||||
self.assertIn("#697", text)
|
||||
self.assertIn("#770", text)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
75
tests/test_source_distinction.py
Normal file
75
tests/test_source_distinction.py
Normal file
@@ -0,0 +1,75 @@
|
||||
"""Tests for source distinction module — 9 tests."""
|
||||
|
||||
import pytest
|
||||
from scripts.source_distinction import (
|
||||
SourceType,
|
||||
Claim,
|
||||
AnnotatedResponse,
|
||||
verified,
|
||||
inferred,
|
||||
stated,
|
||||
detect_hedging,
|
||||
classify_claim,
|
||||
)
|
||||
|
||||
|
||||
class TestSourceType:
|
||||
def test_enum_values(self):
|
||||
assert SourceType.VERIFIED.value == "verified"
|
||||
assert SourceType.INFERRED.value == "inferred"
|
||||
assert SourceType.STATED.value == "stated"
|
||||
assert SourceType.UNKNOWN.value == "unknown"
|
||||
|
||||
|
||||
class TestClaim:
|
||||
def test_verified_claim_render(self):
|
||||
c = verified("Server is online", citation="ping 2025-01-15")
|
||||
result = c.render()
|
||||
assert "✓" in result
|
||||
assert "Server is online" in result
|
||||
assert "ping 2025-01-15" in result
|
||||
|
||||
def test_inferred_claim_render(self):
|
||||
c = inferred("Traffic is declining", confidence=0.6)
|
||||
result = c.render()
|
||||
assert "~" in result
|
||||
assert c.confidence == 0.6
|
||||
|
||||
def test_stated_claim_render(self):
|
||||
c = stated("I think the build passed")
|
||||
result = c.render()
|
||||
assert "◇" in result
|
||||
|
||||
|
||||
class TestAnnotatedResponse:
|
||||
def test_render_with_claims(self):
|
||||
resp = AnnotatedResponse(summary="Status Report")
|
||||
resp.add(verified("DNS resolved")).add(inferred("Latency is high"))
|
||||
rendered = resp.render()
|
||||
assert "Status Report" in rendered
|
||||
assert "✓" in rendered
|
||||
assert "~" in rendered
|
||||
|
||||
def test_chaining(self):
|
||||
resp = AnnotatedResponse()
|
||||
result = resp.add(verified("a")).add(stated("b"))
|
||||
assert result is resp
|
||||
assert len(resp.claims) == 2
|
||||
|
||||
|
||||
class TestHedgingDetection:
|
||||
def test_detects_hedging(self):
|
||||
assert detect_hedging("I think the server is down") is True
|
||||
assert detect_hedging("Probably needs a restart") is True
|
||||
assert detect_hedging("It seems like traffic spiked") is True
|
||||
|
||||
def test_no_hedging(self):
|
||||
assert detect_hedging("The server is online") is False
|
||||
assert detect_hedging("CPU at 45%") is False
|
||||
|
||||
|
||||
class TestClassifyClaim:
|
||||
def test_classifies_correctly(self):
|
||||
assert classify_claim("I think it failed") == SourceType.STATED
|
||||
assert classify_claim("Server is up", has_primary_source=True) == SourceType.VERIFIED
|
||||
assert classify_claim("Traffic increased") == SourceType.INFERRED
|
||||
Reference in New Issue
Block a user