Compare commits

..

2 Commits

Author SHA1 Message Date
Alexander Whitestone
0716234d00 feat: add truck battery disconnect install packet (#528)
Some checks failed
Agent PR Gate / gate (pull_request) Failing after 32s
Self-Healing Smoke / self-healing-smoke (pull_request) Failing after 12s
Smoke Test / smoke (pull_request) Failing after 8s
Agent PR Gate / report (pull_request) Has been cancelled
2026-04-16 22:17:42 -04:00
Alexander Whitestone
a8121aa4e9 test: define battery disconnect packet acceptance for #528 2026-04-16 22:10:35 -04:00
5 changed files with 429 additions and 219 deletions

View File

@@ -0,0 +1,74 @@
# LAB-003 — Truck Battery Disconnect Install Packet
No battery disconnect switch has been purchased or installed yet.
This packet turns the issue into a field-ready purchase / install / validation checklist while preserving what still requires live work.
## Candidate Store Run
- AutoZone — Newport or Claremont
- Advance Auto Parts — Newport or Claremont
- O'Reilly Auto Parts — Newport or Claremont
## Required Items
- battery terminal disconnect switch
- terminal shim/post riser if needed
## Selection Criteria
- Fits the truck battery post without forcing the clamp
- Mounts on the negative battery terminal
- Physically secure once tightened
- no special tools required to operate
## Live Purchase State
- Store selected: pending
- Part selected: pending
- Part cost: pending purchase
## Installation Target
- Install location: negative battery terminal
- Ready to operate without tools: yes
## Install Checklist
- [ ] Verify the truck is off and keys are removed before touching the battery
- [ ] Confirm the disconnect fits the negative battery terminal before final tightening
- [ ] Install the disconnect on the negative battery terminal
- [ ] Tighten until physically secure with no terminal wobble
- [ ] Verify the disconnect can be opened and closed by hand
## Validation Checklist
- [ ] Leave the truck parked with the disconnect opened for at least 24 hours
- [ ] Reconnect the switch by hand the next day
- [ ] Truck starts reliably after sitting 24+ hours with switch disconnected
- [ ] Receipt or photo of installed switch uploaded to this issue
## Overnight Verification Log
- Install completed: False
- Physically secure: False
- Overnight disconnect duration: pending
- Truck started after disconnect: pending
- Receipt / photo path: pending
## Battery Replacement Fallback
If the truck still fails the overnight test after the disconnect install, replace battery and re-run the 24-hour validation.
## Missing Live Fields
- store_selected
- part_name
- install_completed
- physically_secure
- overnight_test_hours
- truck_started_after_disconnect
- receipt_or_photo_path
## Honest next step
Buy the disconnect switch, install it on the negative battery terminal, leave the truck disconnected for 24+ hours, and only close the issue after receipt/photo evidence and the overnight start result are attached.

View File

@@ -1,73 +0,0 @@
# Issue #582 Verification — Parent-Epic Orchestration Slice
**Date:** 2026-04-20
**Status:** Slice already present on `main`; epic remains open for full archive consumption.
## What #582 asked for
A single orchestration script that stitches the five Know Thy Father phases together
into one reviewable plan — not a replacement for individual scripts, but a spine
that future passes can run, resume, and verify.
## What exists on `main`
| Artifact | Path | Present |
|----------|------|---------|
| Epic pipeline runner | `scripts/know_thy_father/epic_pipeline.py` | ✅ |
| Pipeline documentation | `docs/KNOW_THY_FATHER_MULTIMODAL_PIPELINE.md` | ✅ |
| Phase 1 — Media Indexing | `scripts/know_thy_father/index_media.py` | ✅ |
| Phase 2 — Multimodal Analysis | `scripts/twitter_archive/analyze_media.py` | ✅ |
| Phase 3 — Holographic Synthesis | `scripts/know_thy_father/synthesize_kernels.py` | ✅ |
| Phase 4 — Cross-Reference Audit | `scripts/know_thy_father/crossref_audit.py` | ✅ |
| Phase 5 — Processing Log | `twitter-archive/know-thy-father/tracker.py` | ✅ |
## Runner capabilities (all implemented)
```bash
# Print the orchestrated plan
python3 scripts/know_thy_father/epic_pipeline.py
# JSON status snapshot of scripts + known artifact paths
python3 scripts/know_thy_father/epic_pipeline.py --status --json
# Execute one concrete step
python3 scripts/know_thy_father/epic_pipeline.py --run-step phase2_multimodal_analysis --batch-size 10
```
## Test coverage
The following test suites confirm the orchestration slice is intact:
- `tests/test_know_thy_father_pipeline.py` — pipeline plan structure, status snapshot, doc presence
- `tests/test_know_thy_father_index.py` — Phase 1 media indexing logic
- `tests/test_know_thy_father_synthesis.py` — Phase 3 kernel synthesis
- `tests/test_know_thy_father_crossref.py` — Phase 4 cross-reference audit
- `tests/twitter_archive/test_ktf_tracker.py` — Phase 5 processing tracker
- `tests/twitter_archive/test_analyze_media.py` — Phase 2 multimodal analysis
Run all with:
```bash
python3 -m pytest tests/test_know_thy_father_pipeline.py tests/test_know_thy_father_index.py tests/test_know_thy_father_synthesis.py tests/test_know_thy_father_crossref.py tests/twitter_archive/test_ktf_tracker.py tests/twitter_archive/test_analyze_media.py -q
```
## Why Refs #582, not Closes #582
The **repo-side orchestration slice** is fully implemented on `main`. However, the
parent epic itself remains open because:
1. The local Twitter archive has not been fully consumed through all five phases.
2. Downstream memory/fact-store integration is not yet wired end-to-end.
3. The processing log (`PROCESSING_LOG.md`) reflects halted progress that has not resumed.
This PR adds durable verification evidence without overstating closure.
## Historical trail
- Parent-epic PR that landed the orchestration slice: [closed on main]
- This verification document: added by #789, superseded by this PR #790.
## Linked issues
- Refs #582 (parent epic — remains open)
- Closes #789 (verification task — closed by this PR)

View File

@@ -0,0 +1,267 @@
#!/usr/bin/env python3
"""Prepare a field-ready install packet for LAB-003 truck battery disconnect work."""
from __future__ import annotations
import argparse
import json
from pathlib import Path
from typing import Any
CANDIDATE_STORES = [
"AutoZone — Newport or Claremont",
"Advance Auto Parts — Newport or Claremont",
"O'Reilly Auto Parts — Newport or Claremont",
]
REQUIRED_ITEMS = [
"battery terminal disconnect switch",
"terminal shim/post riser if needed",
]
SELECTION_CRITERIA = [
"Fits the truck battery post without forcing the clamp",
"Mounts on the negative battery terminal",
"Physically secure once tightened",
"no special tools required to operate",
]
INSTALL_CHECKLIST = [
"Verify the truck is off and keys are removed before touching the battery",
"Confirm the disconnect fits the negative battery terminal before final tightening",
"Install the disconnect on the negative battery terminal",
"Tighten until physically secure with no terminal wobble",
"Verify the disconnect can be opened and closed by hand",
]
VALIDATION_CHECKLIST = [
"Leave the truck parked with the disconnect opened for at least 24 hours",
"Reconnect the switch by hand the next day",
"Truck starts reliably after sitting 24+ hours with switch disconnected",
"Receipt or photo of installed switch uploaded to this issue",
]
BATTERY_REPLACEMENT_FOLLOWUP = (
"If the truck still fails the overnight test after the disconnect install, "
"replace battery and re-run the 24-hour validation."
)
def _as_bool(value: Any) -> bool | None:
if value is None:
return None
if isinstance(value, bool):
return value
text = str(value).strip().lower()
if text in {"1", "true", "yes", "y"}:
return True
if text in {"0", "false", "no", "n"}:
return False
return None
def build_packet(details: dict[str, Any]) -> dict[str, Any]:
store_selected = (details.get("store_selected") or "").strip()
part_name = (details.get("part_name") or "").strip()
receipt_or_photo_path = (details.get("receipt_or_photo_path") or "").strip()
install_completed = _as_bool(details.get("install_completed"))
physically_secure = _as_bool(details.get("physically_secure"))
truck_started = _as_bool(details.get("truck_started_after_disconnect"))
replacement_needed = _as_bool(details.get("replacement_battery_needed"))
overnight_test_hours = details.get("overnight_test_hours")
part_cost_usd = details.get("part_cost_usd")
try:
overnight_test_hours = int(overnight_test_hours) if overnight_test_hours is not None else None
except (TypeError, ValueError):
overnight_test_hours = None
try:
part_cost_usd = float(part_cost_usd) if part_cost_usd is not None else None
except (TypeError, ValueError):
part_cost_usd = None
missing_fields: list[str] = []
if not store_selected:
missing_fields.append("store_selected")
if not part_name:
missing_fields.append("part_name")
if install_completed is not True:
missing_fields.append("install_completed")
if physically_secure is not True:
missing_fields.append("physically_secure")
if overnight_test_hours is None:
missing_fields.append("overnight_test_hours")
if truck_started is None:
missing_fields.append("truck_started_after_disconnect")
if not receipt_or_photo_path:
missing_fields.append("receipt_or_photo_path")
ready_to_operate_without_tools = True
if replacement_needed is True or truck_started is False:
status = "battery_replace_candidate"
elif not store_selected or not part_name:
status = "pending_parts_run"
elif install_completed is not True:
status = "pending_install"
elif physically_secure is not True or overnight_test_hours is None or truck_started is None or not receipt_or_photo_path:
status = "overnight_validation"
elif overnight_test_hours >= 24 and truck_started is True:
status = "verified"
else:
status = "overnight_validation"
return {
"candidate_stores": list(CANDIDATE_STORES),
"required_items": list(REQUIRED_ITEMS),
"selection_criteria": list(SELECTION_CRITERIA),
"install_target": "negative battery terminal",
"install_checklist": list(INSTALL_CHECKLIST),
"validation_checklist": list(VALIDATION_CHECKLIST),
"store_selected": store_selected,
"part_name": part_name,
"part_cost_usd": part_cost_usd,
"install_completed": install_completed,
"physically_secure": physically_secure,
"overnight_test_hours": overnight_test_hours,
"truck_started_after_disconnect": truck_started,
"receipt_or_photo_path": receipt_or_photo_path,
"ready_to_operate_without_tools": ready_to_operate_without_tools,
"missing_fields": missing_fields,
"battery_replacement_followup": BATTERY_REPLACEMENT_FOLLOWUP,
"status": status,
}
def render_markdown(packet: dict[str, Any]) -> str:
part_cost = packet["part_cost_usd"]
cost_line = f"${part_cost:.2f}" if isinstance(part_cost, (int, float)) else "pending purchase"
overnight = packet["overnight_test_hours"]
overnight_line = f"{overnight} hours" if overnight is not None else "pending"
started = packet["truck_started_after_disconnect"]
if started is True:
started_line = "yes"
elif started is False:
started_line = "no"
else:
started_line = "pending"
lines = [
"# LAB-003 — Truck Battery Disconnect Install Packet",
"",
"No battery disconnect switch has been purchased or installed yet.",
"This packet turns the issue into a field-ready purchase / install / validation checklist while preserving what still requires live work.",
"",
"## Candidate Store Run",
"",
]
lines.extend(f"- {store}" for store in packet["candidate_stores"])
lines.extend([
"",
"## Required Items",
"",
])
lines.extend(f"- {item}" for item in packet["required_items"])
lines.extend([
"",
"## Selection Criteria",
"",
])
lines.extend(f"- {item}" for item in packet["selection_criteria"])
lines.extend([
"",
"## Live Purchase State",
"",
f"- Store selected: {packet['store_selected'] or 'pending'}",
f"- Part selected: {packet['part_name'] or 'pending'}",
f"- Part cost: {cost_line}",
"",
"## Installation Target",
"",
f"- Install location: {packet['install_target']}",
f"- Ready to operate without tools: {'yes' if packet['ready_to_operate_without_tools'] else 'no'}",
"",
"## Install Checklist",
"",
])
lines.extend(f"- [ ] {item}" for item in packet["install_checklist"])
lines.extend([
"",
"## Validation Checklist",
"",
])
lines.extend(f"- [ ] {item}" for item in packet["validation_checklist"])
lines.extend([
"",
"## Overnight Verification Log",
"",
f"- Install completed: {packet['install_completed'] if packet['install_completed'] is not None else 'pending'}",
f"- Physically secure: {packet['physically_secure'] if packet['physically_secure'] is not None else 'pending'}",
f"- Overnight disconnect duration: {overnight_line}",
f"- Truck started after disconnect: {started_line}",
f"- Receipt / photo path: {packet['receipt_or_photo_path'] or 'pending'}",
"",
"## Battery Replacement Fallback",
"",
packet['battery_replacement_followup'],
"",
"## Missing Live Fields",
"",
])
if packet["missing_fields"]:
lines.extend(f"- {field}" for field in packet["missing_fields"])
else:
lines.append("- none")
lines.extend([
"",
"## Honest next step",
"",
"Buy the disconnect switch, install it on the negative battery terminal, leave the truck disconnected for 24+ hours, and only close the issue after receipt/photo evidence and the overnight start result are attached.",
"",
])
return "\n".join(lines)
def main() -> None:
parser = argparse.ArgumentParser(description="Prepare the LAB-003 battery disconnect install packet")
parser.add_argument("--store-selected", default="")
parser.add_argument("--part-name", default="")
parser.add_argument("--part-cost-usd", type=float, default=None)
parser.add_argument("--install-completed", action="store_true")
parser.add_argument("--physically-secure", action="store_true")
parser.add_argument("--overnight-test-hours", type=int, default=None)
parser.add_argument("--truck-started-after-disconnect", choices=["yes", "no"], default=None)
parser.add_argument("--receipt-or-photo-path", default="")
parser.add_argument("--replacement-battery-needed", action="store_true")
parser.add_argument("--output", default=None)
parser.add_argument("--json", action="store_true")
args = parser.parse_args()
packet = build_packet(
{
"store_selected": args.store_selected,
"part_name": args.part_name,
"part_cost_usd": args.part_cost_usd,
"install_completed": args.install_completed,
"physically_secure": args.physically_secure,
"overnight_test_hours": args.overnight_test_hours,
"truck_started_after_disconnect": args.truck_started_after_disconnect,
"receipt_or_photo_path": args.receipt_or_photo_path,
"replacement_battery_needed": args.replacement_battery_needed,
}
)
rendered = json.dumps(packet, indent=2) if args.json else render_markdown(packet)
if args.output:
output_path = Path(args.output).expanduser()
output_path.parent.mkdir(parents=True, exist_ok=True)
output_path.write_text(rendered, encoding="utf-8")
print(f"Battery disconnect packet written to {output_path}")
else:
print(rendered)
if __name__ == "__main__":
main()

View File

@@ -1,146 +0,0 @@
"""Durable verification that the Issue #582 parent-epic orchestration slice exists on main.
These tests confirm:
1. The epic pipeline runner script is present and importable.
2. The pipeline documentation is committed.
3. All five phase scripts exist at their expected paths.
4. The pipeline plan exposes the correct five phases in order.
5. Each plan step references the correct underlying script.
6. The status snapshot reports script_exists=True for all phases.
7. The status snapshot includes expected artifact output paths.
8. The runner can produce a JSON-serialisable plan.
9. The runner can produce a JSON-serialisable status snapshot.
10. The verification document itself is present.
Refs #582. Closes #789.
"""
import importlib.util
import json
import unittest
from pathlib import Path
ROOT = Path(__file__).resolve().parent.parent
EPIC_PIPELINE = ROOT / "scripts" / "know_thy_father" / "epic_pipeline.py"
PIPELINE_DOC = ROOT / "docs" / "KNOW_THY_FATHER_MULTIMODAL_PIPELINE.md"
VERIFICATION_DOC = ROOT / "docs" / "issue-582-verification.md"
EXPECTED_PHASES = [
"phase1_media_indexing",
"phase2_multimodal_analysis",
"phase3_holographic_synthesis",
"phase4_cross_reference_audit",
"phase5_processing_log",
]
EXPECTED_SCRIPTS = {
"phase1_media_indexing": "scripts/know_thy_father/index_media.py",
"phase2_multimodal_analysis": "scripts/twitter_archive/analyze_media.py",
"phase3_holographic_synthesis": "scripts/know_thy_father/synthesize_kernels.py",
"phase4_cross_reference_audit": "scripts/know_thy_father/crossref_audit.py",
"phase5_processing_log": "twitter-archive/know-thy-father/tracker.py",
}
EXPECTED_OUTPUTS = {
"phase1_media_indexing": ["twitter-archive/know-thy-father/media_manifest.jsonl"],
"phase3_holographic_synthesis": ["twitter-archive/knowledge/fathers_ledger.jsonl"],
"phase5_processing_log": ["twitter-archive/know-thy-father/REPORT.md"],
}
def _load_epic_module():
spec = importlib.util.spec_from_file_location("ktf_epic_pipeline", EPIC_PIPELINE)
assert spec and spec.loader, "Cannot load epic_pipeline module spec"
mod = importlib.util.module_from_spec(spec)
spec.loader.exec_module(mod)
return mod
class TestIssue582Verification(unittest.TestCase):
"""10-test suite proving the #582 orchestration slice is on main."""
# -- existence checks --------------------------------------------------
def test_01_epic_pipeline_script_exists(self):
"""The orchestration runner is committed."""
self.assertTrue(EPIC_PIPELINE.exists(), f"missing {EPIC_PIPELINE.relative_to(ROOT)}")
def test_02_pipeline_documentation_exists(self):
"""The multimodal pipeline doc is committed."""
self.assertTrue(PIPELINE_DOC.exists(), "missing KNOW_THY_FATHER_MULTIMODAL_PIPELINE.md")
def test_03_all_phase_scripts_exist_on_disk(self):
"""Every script referenced by the pipeline exists in the repo."""
for phase_id, script_rel in EXPECTED_SCRIPTS.items():
path = ROOT / script_rel
self.assertTrue(path.exists(), f"{phase_id}: missing {script_rel}")
# -- plan structure ----------------------------------------------------
def test_04_pipeline_plan_has_five_phases_in_order(self):
mod = _load_epic_module()
plan = mod.build_pipeline_plan(batch_size=10)
ids = [step["id"] for step in plan]
self.assertEqual(ids, EXPECTED_PHASES)
def test_05_plan_commands_reference_correct_scripts(self):
mod = _load_epic_module()
plan = mod.build_pipeline_plan(batch_size=10)
for step in plan:
expected_script = EXPECTED_SCRIPTS[step["id"]]
self.assertIn(
expected_script,
step["command"],
f"{step['id']} command missing {expected_script}",
)
# -- status snapshot ---------------------------------------------------
def test_06_status_snapshot_all_scripts_exist(self):
mod = _load_epic_module()
status = mod.build_status_snapshot(ROOT)
for phase_id in EXPECTED_PHASES:
self.assertIn(phase_id, status)
self.assertTrue(
status[phase_id]["script_exists"],
f"{phase_id} script_exists should be True",
)
def test_07_status_snapshot_reports_expected_outputs(self):
mod = _load_epic_module()
status = mod.build_status_snapshot(ROOT)
for phase_id, expected_paths in EXPECTED_OUTPUTS.items():
actual_paths = [o["path"] for o in status[phase_id]["outputs"]]
for p in expected_paths:
self.assertIn(p, actual_paths, f"{phase_id} missing output path {p}")
# -- JSON serialisation ------------------------------------------------
def test_08_plan_is_json_serialisable(self):
mod = _load_epic_module()
plan = mod.build_pipeline_plan(batch_size=10)
dumped = json.dumps(plan)
restored = json.loads(dumped)
self.assertEqual(len(restored), 5)
def test_09_status_snapshot_is_json_serialisable(self):
mod = _load_epic_module()
status = mod.build_status_snapshot(ROOT)
dumped = json.dumps(status)
restored = json.loads(dumped)
for phase_id in EXPECTED_PHASES:
self.assertIn(phase_id, restored)
# -- verification doc --------------------------------------------------
def test_10_verification_document_exists(self):
"""This verification trail is committed."""
self.assertTrue(
VERIFICATION_DOC.exists(),
"missing docs/issue-582-verification.md",
)
if __name__ == "__main__":
unittest.main()

View File

@@ -0,0 +1,88 @@
from pathlib import Path
import importlib.util
import unittest
ROOT = Path(__file__).resolve().parent.parent
SCRIPT_PATH = ROOT / "scripts" / "lab_003_battery_disconnect_packet.py"
DOC_PATH = ROOT / "docs" / "LAB_003_BATTERY_DISCONNECT_PACKET.md"
def load_module(path: Path, name: str):
assert path.exists(), f"missing {path.relative_to(ROOT)}"
spec = importlib.util.spec_from_file_location(name, path)
assert spec and spec.loader
module = importlib.util.module_from_spec(spec)
spec.loader.exec_module(module)
return module
class TestLab003BatteryDisconnectPacket(unittest.TestCase):
def test_packet_defaults_to_parts_run_and_tracks_issue_specific_requirements(self):
mod = load_module(SCRIPT_PATH, "lab_003_battery_disconnect_packet")
packet = mod.build_packet({})
self.assertEqual(packet["status"], "pending_parts_run")
self.assertEqual(packet["install_target"], "negative battery terminal")
self.assertIn("battery terminal disconnect switch", packet["required_items"])
self.assertIn("terminal shim/post riser if needed", packet["required_items"])
self.assertIn("AutoZone", packet["candidate_stores"][0])
self.assertIn("no special tools required to operate", packet["selection_criteria"])
self.assertIn("overnight_test_hours", packet["missing_fields"])
self.assertIn("receipt_or_photo_path", packet["missing_fields"])
def test_packet_marks_verified_after_successful_24h_validation_with_proof(self):
mod = load_module(SCRIPT_PATH, "lab_003_battery_disconnect_packet")
packet = mod.build_packet(
{
"store_selected": "AutoZone - Newport",
"part_name": "Knob-style battery disconnect switch",
"part_cost_usd": 24.99,
"install_completed": True,
"physically_secure": True,
"overnight_test_hours": 26,
"truck_started_after_disconnect": True,
"receipt_or_photo_path": "evidence/lab-003-installed-switch.jpg",
}
)
self.assertEqual(packet["status"], "verified")
self.assertEqual(packet["missing_fields"], [])
self.assertTrue(packet["ready_to_operate_without_tools"])
def test_packet_flags_battery_replace_candidate_when_overnight_test_fails(self):
mod = load_module(SCRIPT_PATH, "lab_003_battery_disconnect_packet")
packet = mod.build_packet(
{
"store_selected": "O'Reilly - Claremont",
"part_name": "Knob-style battery disconnect switch",
"install_completed": True,
"physically_secure": True,
"overnight_test_hours": 24,
"truck_started_after_disconnect": False,
}
)
self.assertEqual(packet["status"], "battery_replace_candidate")
self.assertIn("battery_replacement_followup", packet)
self.assertIn("replace battery", packet["battery_replacement_followup"].lower())
def test_repo_contains_grounded_lab_003_packet_doc(self):
self.assertTrue(DOC_PATH.exists(), "missing committed LAB-003 packet doc")
text = DOC_PATH.read_text(encoding="utf-8")
for snippet in (
"# LAB-003 — Truck Battery Disconnect Install Packet",
"No battery disconnect switch has been purchased or installed yet.",
"negative battery terminal",
"AutoZone",
"Advance",
"O'Reilly",
"terminal shim/post riser if needed",
"Truck starts reliably after sitting 24+ hours with switch disconnected",
"Receipt or photo of installed switch uploaded to this issue",
):
self.assertIn(snippet, text)
if __name__ == "__main__":
unittest.main()