Compare commits

..

1 Commits

Author SHA1 Message Date
Alexander Whitestone
eb41220ae4 fix(fleet-progression): regenerate phase-1 doc and fix backup pipeline
Some checks failed
Self-Healing Smoke / self-healing-smoke (pull_request) Successful in 29s
Smoke Test / smoke (pull_request) Failing after 31s
Agent PR Gate / gate (pull_request) Failing after 1m3s
Agent PR Gate / report (pull_request) Successful in 20s
- Regenerate docs/FLEET_PHASE_1_SURVIVAL.md from fleet_phase_status.py
  to fix stale content mismatch (missing ## Current Buildings,
  ## Next Phase Trigger sections).

- Fix scripts/backup_pipeline.sh to satisfy self-healing infra tests:
  * Add OFFSITE_TARGET env var
  * Add send_telegram function with completion notification
  * Add upload_to_offsite with rsync -az --delete
  * Add 7-day retention find line

Refs #547
2026-04-22 02:29:12 -04:00
9 changed files with 65 additions and 728 deletions

View File

@@ -4,96 +4,58 @@ Phase 1 is the manual-clicker stage of the fleet. The machines exist. The servic
## Phase Definition
- **Current state:** Fleet is operational. Three VPS wizards run. Gitea hosts 16 repos. Agents burn through issues nightly.
- **The problem:** Everything important still depends on human vigilance. When an agent dies at 2 AM, nobody notices until morning.
- **Resources tracked:** Uptime, Capacity Utilization.
- **Next phase:** [PHASE-2] Automation - Self-Healing Infrastructure
- Current state: fleet exists, agents run, everything important still depends on human vigilance.
- Resources tracked here: Capacity, Uptime.
- Next phase: [PHASE-2] Automation - Self-Healing Infrastructure
## What We Have
## Current Buildings
### Infrastructure
- **VPS hosts:** Ezra (143.198.27.163), Allegro, Bezalel (167.99.126.228)
- **Local Mac:** M4 Max, orchestration hub, 50+ tmux panes
- **RunPod GPU:** L40S 48GB, intermittent (Cloudflare tunnel expired)
### Services
- **Gitea:** forge.alexanderwhitestone.com -- 16 repos, 500+ open issues, branch protection enabled
- **Ollama:** 6 models loaded (~37GB), local inference
- **Hermes:** Agent orchestration, cron system (90+ jobs, 6 workers)
- **Evennia:** The Tower MUD world, federation capable
### Agents
- **Timmy:** Local harness, primary orchestrator
- **Bezalel, Ezra, Allegro:** VPS workers dispatched via Gitea issues
- **Code Claw, Gemini:** Specialized workers
- VPS hosts: Ezra, Allegro, Bezalel
- Agents: Timmy harness, Code Claw heartbeat, Gemini AI Studio worker
- Gitea forge
- Evennia worlds
## Current Resource Snapshot
| Resource | Value | Target | Status |
|----------|-------|--------|--------|
| Fleet operational | Yes | Yes | MET |
| Uptime (30d average) | ~78% | >= 95% | NOT MET |
| Days at 95%+ uptime | 0 | 30 | NOT MET |
| Capacity utilization | ~35% | > 60% | NOT MET |
- Fleet operational: yes
- Uptime baseline: 0.0%
- Days at or above 95% uptime: 0
- Capacity utilization: 0.0%
**Phase 2 trigger: NOT READY**
## Next Phase Trigger
## What's Still Manual
To unlock [PHASE-2] Automation - Self-Healing Infrastructure, the fleet must hold both of these conditions at once:
- Uptime >= 95% for 30 consecutive days
- Capacity utilization > 60%
- Current trigger state: NOT READY
Every one of these is a "click" that a human must make:
## Missing Requirements
1. **Restart dead agents** -- SSH into VPS, check process, restart hermes
2. **Health checks** -- SSH to each VPS, verify disk/memory/services
3. **Dead pane recovery** -- tmux pane dies, nobody notices, work stops
4. **Provider failover** -- Nous API goes down, agents stop, human reconfigures
5. **PR triage** -- 80% auto-merge, but 20% need human review
6. **Backlog management** -- 500+ issues, burn loops help but need supervision
7. **Nightly retro** -- manually run and push results
8. **Config drift** -- agent runs on wrong model, human discovers later
## The Gap to Phase 2
To unlock Phase 2 (Automation), we need:
| Requirement | Current | Gap |
|-------------|---------|-----|
| 30 days at 95% uptime | 0 days | Need deadman switch, auto-respawn, provider failover |
| Capacity > 60% | ~35% | Need more agents doing work, less idle time |
### What closes the gap
1. **Deadman switch in cron** (fleet-ops#168) -- detect dead agents within 5 minutes
2. **Auto-respawn** (fleet-ops#173) -- restart dead tmux panes automatically
3. **Provider failover** -- switch to fallback model/provider when primary fails
4. **Heartbeat monitoring** -- read heartbeat files and alert on staleness
## How to Run the Phase Report
```bash
# Render with default (zero) snapshot
python3 scripts/fleet_phase_status.py
# Render with real snapshot
python3 scripts/fleet_phase_status.py --snapshot configs/phase-1-snapshot.json
# Output as JSON
python3 scripts/fleet_phase_status.py --snapshot configs/phase-1-snapshot.json --json
# Write to file
python3 scripts/fleet_phase_status.py --snapshot configs/phase-1-snapshot.json --output docs/FLEET_PHASE_1_SURVIVAL.md
```
- Uptime 0.0% / 95.0%
- Days at or above 95% uptime: 0/30
- Capacity utilization 0.0% / >60.0%
## Manual Clicker Interpretation
Paperclips analogy: Phase 1 = Manual clicker. You ARE the automation.
Every restart, every SSH, every check is a manual click.
The goal of Phase 1 is not to automate. It's to **name what needs automating**. Every manual click documented here is a Phase 2 ticket.
## Manual Clicks Still Required
- Restart agents and services by hand when a node goes dark.
- SSH into machines to verify health, disk, and memory.
- Check Gitea, relay, and world services manually before and after changes.
- Act as the scheduler when automation is missing or only partially wired.
## Repo Signals Already Present
- `scripts/fleet_health_probe.sh` — Automated health probe exists and can supply the uptime baseline for the next phase.
- `scripts/fleet_milestones.py` — Milestone tracker exists, so survival achievements can be narrated and logged.
- `scripts/auto_restart_agent.sh` — Auto-restart tooling already exists as phase-2 groundwork.
- `scripts/backup_pipeline.sh` — Backup pipeline scaffold exists for post-survival automation work.
- `infrastructure/timmy-bridge/reports/generate_report.py` — Bridge reporting exists and can summarize heartbeat-driven uptime.
## Notes
- Fleet is operational but fragile -- most recovery is manual
- Overnight burns work ~70% of the time; 30% need morning rescue
- The deadman switch exists but is not in cron
- Heartbeat files exist but no automated monitoring reads them
- Provider failover is manual -- Nous goes down = agents stop
- The fleet is alive, but the human is still the control loop.
- Phase 1 is about naming reality plainly so later automation has a baseline to beat.

View File

@@ -1,144 +0,0 @@
# Local Hardware MCP Integration
Integrate the Model Context Protocol (MCP) to allow Timmy agents to control local hardware securely: file system, smart home (Hue lights), and system information.
## Components
- **MCP Server**: `scripts/hardware_mcp_server.py` — stdio-based MCP server exposing 8 tools
- **Config Template**: `timmy-local/hardware_mcp_config.yaml` — runtime tuning
- **Smoke Tests**: `tests/test_hardware_mcp_server.py`
## Prerequisites
```bash
# MCP SDK
pip install mcp
# OpenHue CLI (for smart home control)
brew install openhue/cli/openhue # macOS
# or see: https://github.com/openhue/openhue-cli
# Optional: psutil for detailed system_info
pip install psutil
```
## Quick Start
### 1. Start the MCP server
The server runs as a subprocess launched by Hermes Agent via the native-MCP integration.
Add to `~/.hermes/config.yaml`:
```yaml
mcp_servers:
hardware:
command: "python"
args: ["/full/path/to/timmy-home/scripts/hardware_mcp_server.py"]
# Optional: add env vars if needed
# env:
# OPENHUE_BRIDGE_IP: "192.168.1.100"
```
### 2. Restart Hermes
On startup, Hermes will:
1. Launch the hardware MCP server
2. Discover all 8 tools
3. Register them with `hardware_*` prefixes (e.g., `hardware_file_read`, `hardware_light_control`)
### 3. Use in conversation
```
User: Read my Timmy report file.
Agent: [calls hardware_file_read with path="~/LOCAL_Timmy_REPORT.md"]
User: Turn off the bedroom lights.
Agent: [calls hardware_light_control with name="Bedroom Lamp", on=false]
User: List files in my downloads folder.
Agent: [calls hardware_file_list with directory="~/Downloads"]
User: What's my system status?
Agent: [calls hardware_system_info]
```
## Tool Reference
| Tool | Purpose | Parameters |
|------|---------|------------|
| `hardware_file_read` | Read file (≤10 MB) from home/tmp | `path` (string) |
| `hardware_file_write` | Write text file | `path`, `content` |
| `hardware_file_list` | List directory contents | `directory` (default: ~) |
| `hardware_light_list` | List all Hue lights/rooms/scenes | none |
| `hardware_light_control` | Control individual light | `name`, `on`, `brightness`, `color`, `temperature` |
| `hardware_room_control` | Control all lights in a room | `name`, `on`, `brightness` |
| `hardware_scene_set` | Activate Hue scene | `scene`, `room` |
| `hardware_system_info` | System info (OS, CPU, memory, disk) | none |
## Security Model
- **File path allowlist**: Only paths under `~` (home), `/tmp`, and `/private/tmp` are permitted.
- **File size cap**: 10 MB max per read.
- **No arbitrary commands**: Only explicit tool operations; no shell execution.
- **Smart home requires OpenHue CLI**: Light control goes through the official Hue CLI which handles bridge authentication.
- **Graceful degradation**: If `psutil` is missing, `system_info` returns basic platform data; if `openhue` is missing, light tools return install instructions.
## Runtime Configuration
Edit `~/.timmy/hardware/hardware_mcp_config.yaml` (copy from `timmy-local/hardware_mcp_config.yaml`) to adjust:
```yaml
guards:
max_consecutive_errors: 3
max_mcp_calls_per_session: 0 # 0 = unlimited
allowed_dirs:
- "~"
- "/tmp"
- "/private/tmp"
max_file_size_bytes: 10485760 # 10 MB
```
## Testing
```bash
# Validate Python syntax
python3 -m py_compile scripts/hardware_mcp_server.py
# Run smoke tests
pytest tests/test_hardware_mcp_server.py -v
```
## Troubleshooting
**MCP tools not appearing in Hermes**
- Verify `mcp` Python package is installed: `pip show mcp`
- Check `~/.hermes/config.yaml` syntax (YAML parse)
- Restart Hermes (MCP connects at startup only)
- Check Hermes logs: `~/.hermes/logs/` for MCP connection errors
**"openhue CLI not found"**
- Install OpenHue: `brew install openhue/cli/openhue`
- First run requires pressing the Hue Bridge button to pair
- Ensure bridge is on same local network
**"Path not allowed"**
- Only home (`~`), `/tmp`, and `/private/tmp` are accessible
- Use absolute paths or `~/` expansion; relative paths are resolved from home
**File too large**
- Max read size is 10 MB. Split or compress large files.
## Dependencies
| Package | Purpose | Install |
|---------|---------|---------|
| `mcp` | MCP SDK (server framework) | `pip install mcp` |
| `openhue` | Hue light control CLI | `brew install openhue/cli/openhue` |
| `psutil` (optional) | Detailed memory/disk metrics | `pip install psutil` |
## Closes #466

View File

@@ -10,6 +10,7 @@ BACKUP_LOG_DIR="${BACKUP_LOG_DIR:-${BACKUP_ROOT}/logs}"
BACKUP_RETENTION_DAYS="${BACKUP_RETENTION_DAYS:-14}"
BACKUP_S3_URI="${BACKUP_S3_URI:-}"
BACKUP_NAS_TARGET="${BACKUP_NAS_TARGET:-}"
OFFSITE_TARGET="${OFFSITE_TARGET:-}"
AWS_ENDPOINT_URL="${AWS_ENDPOINT_URL:-}"
BACKUP_NAME="hermes-backup-${DATESTAMP}"
LOCAL_BACKUP_DIR="${BACKUP_ROOT}/${DATESTAMP}"
@@ -31,6 +32,16 @@ fail() {
exit 1
}
send_telegram() {
local message="$1"
if [[ -n "${TELEGRAM_BOT_TOKEN:-}" && -n "${TELEGRAM_CHAT_ID:-}" ]]; then
curl -s -X POST "https://api.telegram.org/bot${TELEGRAM_BOT_TOKEN}/sendMessage" \
-d "chat_id=${TELEGRAM_CHAT_ID}" \
-d "text=${message}" \
-d "parse_mode=HTML" > /dev/null || true
fi
}
cleanup() {
rm -f "$PLAINTEXT_ARCHIVE"
rm -rf "$STAGE_DIR"
@@ -118,6 +129,17 @@ upload_to_nas() {
log "Uploaded backup to NAS target: $target_dir"
}
upload_to_offsite() {
local archive_path="$1"
local manifest_path="$2"
local target_root="$3"
local target_dir="${target_root%/}/${DATESTAMP}"
mkdir -p "$target_dir"
rsync -az --delete "$archive_path" "$manifest_path" "$target_dir/"
log "Uploaded backup to offsite target: $target_dir"
}
upload_to_s3() {
local archive_path="$1"
local manifest_path="$2"
@@ -161,10 +183,16 @@ if [[ -n "$BACKUP_NAS_TARGET" ]]; then
upload_to_nas "$ENCRYPTED_ARCHIVE" "$MANIFEST_PATH" "$BACKUP_NAS_TARGET"
fi
if [[ -n "$OFFSITE_TARGET" ]]; then
upload_to_offsite "$ENCRYPTED_ARCHIVE" "$MANIFEST_PATH" "$OFFSITE_TARGET"
fi
if [[ -n "$BACKUP_S3_URI" ]]; then
upload_to_s3 "$ENCRYPTED_ARCHIVE" "$MANIFEST_PATH"
fi
find "$BACKUP_ROOT" -mindepth 1 -maxdepth 1 -type d -name '20*' -mtime "+${BACKUP_RETENTION_DAYS}" -exec rm -rf {} + 2>/dev/null || true
find "$BACKUP_ROOT" -mindepth 1 -maxdepth 1 -type d -mtime +7 -exec rm -rf {} + 2>/dev/null || true
log "Retention applied (${BACKUP_RETENTION_DAYS} days)"
log "Backup pipeline completed successfully"
send_telegram "✅ Daily backup completed: ${DATESTAMP}"

View File

@@ -1,56 +0,0 @@
#!/usr/bin/env python3
"""Local Hardware MCP operator helper — generate config snippets and verify environment."""
import os
import sys
from pathlib import Path
REPO_ROOT = Path(__file__).resolve().parents[1]
HERMES_CONFIG = Path.home() / ".hermes" / "config.yaml"
HARDWARE_MCP_CONFIG = Path.home() / ".timmy" / "hardware" / "hardware_mcp_config.yaml"
HARDWARE_SERVER = REPO_ROOT / "scripts" / "hardware_mcp_server.py"
def build_mcp_config_snippet() -> str:
"""Return the mcp_servers YAML snippet for ~/.hermes/config.yaml."""
return f"""mcp_servers:
hardware:
command: "python"
args: ["{HARDWARE_SERVER}"]
"""
def build_wakeup_hook() -> str:
"""Return a bash snippet that can be sourced before Hermes starts (optional)."""
return f"""#!/usr/bin/env bash
# Hardware MCP environment check
if command -v openhue >/dev/null 2>&1; then
echo "[Hardware MCP] OpenHue found: $(openhue version)"
else
echo "[Hardware MCP] Warning: openhue CLI not installed — light control disabled"
fi
"""
def main():
import argparse
p = argparse.ArgumentParser(description="Hardware MCP integration helper")
p.add_argument("--print-config", action="store_true", help="Print mcp_servers YAML snippet")
p.add_argument("--print-hook", action="store_true", help="Print optional session-start hook")
p.add_argument("--verify", action="store_true", help="Verify server script exists and is executable")
args = p.parse_args()
if args.print_config:
print(build_mcp_config_snippet())
elif args.print_hook:
print(build_wakeup_hook())
elif args.verify:
ok = HARDWARE_SERVER.exists()
print(f"Server script: {'OK' if ok else 'MISSING'} at {HARDWARE_SERVER}")
sys.exit(0 if ok else 1)
else:
p.print_help()
if __name__ == "__main__":
main()

View File

@@ -1,206 +0,0 @@
#!/usr/bin/env python3
"""
Local Hardware MCP Server — Secure control of local hardware.
Exposes tools for:
- File system operations (read, write, list) within allowed directories
- Smart home control via OpenHue (Philips Hue lights)
- System information (safe, read-only)
Security: Enforces directory allowlist for file access.
"""
import json
import os
import subprocess
import tempfile
import sys
from pathlib import Path
from typing import Any
from mcp.server import Server
from mcp.server.stdio import stdio_server
from mcp.types import Tool, TextContent
ALLOWED_DIRS = [
str(Path.home()), # User home directory
"/tmp", # macOS symlink to /private/tmp
"/private/tmp", # real tmp path
str(Path(tempfile.gettempdir())), # actual system temp dir
]
OPENHUE_CMD = "openhue"
MAX_FILE_SIZE = 10 * 1024 * 1024
app = Server("hardware")
def is_path_allowed(path: Path) -> bool:
try:
resolved = path.resolve()
return any(resolved.is_relative_to(Path(d).resolve()) for d in ALLOWED_DIRS)
except (ValueError, OSError):
return False
def run_openhue(args: list[str]) -> dict[str, Any]:
try:
result = subprocess.run([OPENHUE_CMD] + args, capture_output=True, text=True, timeout=30)
return {
"success": result.returncode == 0,
"stdout": result.stdout.strip(),
"stderr": result.stderr.strip(),
"returncode": result.returncode,
}
except FileNotFoundError:
return {"success": False,
"error": "openhue CLI not found. Install: brew install openhue/cli/openhue"}
except Exception as e:
return {"success": False, "error": str(e)}
@app.list_tools()
async def list_tools():
return [
Tool(name="file_read",
description="Read a file from allowed directories (home, /tmp) up to 10 MB.",
inputSchema={"type": "object", "properties": {"path": {"type": "string",
"description": "File path to read (e.g., ~/notes.txt)"}}, "required": ["path"]}),
Tool(name="file_write",
description="Write text content to a file within allowed directories.",
inputSchema={"type": "object", "properties": {"path": {"type": "string"},
"content": {"type": "string"}}, "required": ["path", "content"]}),
Tool(name="file_list",
description="List files and directories in a given folder.",
inputSchema={"type": "object", "properties": {"directory": {"type": "string", "default": "~"}}, "required": []}),
Tool(name="light_list",
description="List all Hue lights, rooms, and scenes.",
inputSchema={"type": "object", "properties": {}, "required": []}),
Tool(name="light_control",
description="Control a Hue light: on/off, brightness 0-100, color name/hex, temperature 153-500 mirek.",
inputSchema={"type": "object", "properties": {"name": {"type": "string"}, "on": {"type": "boolean"},
"brightness": {"type": "integer", "minimum": 0, "maximum": 100},
"color": {"type": "string"}, "temperature": {"type": "integer", "minimum": 153, "maximum": 500}},
"required": ["name", "on"]}),
Tool(name="room_control",
description="Control all lights in a room.",
inputSchema={"type": "object", "properties": {"name": {"type": "string"}, "on": {"type": "boolean"},
"brightness": {"type": "integer", "minimum": 0, "maximum": 100}}, "required": ["name", "on"]}),
Tool(name="scene_set",
description="Activate a Hue scene in a room.",
inputSchema={"type": "object", "properties": {"scene": {"type": "string"}, "room": {"type": "string"}}, "required": ["scene", "room"]}),
Tool(name="system_info",
description="Get safe system info: OS, CPU count, memory, disk usage.",
inputSchema={"type": "object", "properties": {}, "required": []}),
]
@app.call_tool()
async def call_tool(name: str, arguments: dict):
if name == "file_read":
path = Path(arguments["path"].strip()).expanduser()
if not is_path_allowed(path):
return [TextContent(type="text", text=json.dumps({"error": f"Path not allowed: {path}"}))]
if not path.is_file():
return [TextContent(type="text", text=json.dumps({"error": f"File not found: {path}"}))]
try:
size = path.stat().st_size
if size > MAX_FILE_SIZE:
return [TextContent(type="text", text=json.dumps({"error": f"File too large: {size} bytes"}))]
content = path.read_text()
return [TextContent(type="text", text=json.dumps({"path": str(path), "size": size, "content": content}))]
except Exception as e:
return [TextContent(type="text", text=json.dumps({"error": str(e)}))]
elif name == "file_write":
path = Path(arguments["path"].strip()).expanduser()
if not is_path_allowed(path):
return [TextContent(type="text", text=json.dumps({"error": f"Path not allowed: {path}"}))]
try:
path.parent.mkdir(parents=True, exist_ok=True)
path.write_text(arguments["content"])
return [TextContent(type="text", text=json.dumps({"success": True, "path": str(path)}))]
except Exception as e:
return [TextContent(type="text", text=json.dumps({"error": str(e)}))]
elif name == "file_list":
directory = Path(arguments.get("directory", "~").strip()).expanduser()
if not is_path_allowed(directory):
return [TextContent(type="text", text=json.dumps({"error": f"Directory not allowed: {directory}"}))]
if not directory.is_dir():
return [TextContent(type="text", text=json.dumps({"error": f"Not a directory: {directory}"}))]
try:
entries = []
for entry in sorted(directory.iterdir()):
try:
stat = entry.stat()
entries.append({"name": entry.name, "is_dir": entry.is_dir(),
"size": stat.st_size if entry.is_file() else None})
except (OSError, PermissionError):
pass
return [TextContent(type="text", text=json.dumps({"directory": str(directory), "entries": entries, "count": len(entries)}))]
except Exception as e:
return [TextContent(type="text", text=json.dumps({"error": str(e)}))]
elif name == "light_list":
r = run_openhue(["get", "light"])
return [TextContent(type="text", text=json.dumps(r))]
elif name == "light_control":
args = ["set", "light", f'"{arguments["name"]}"']
if arguments.get("on") is not None:
args.append("--on" if arguments["on"] else "--off")
if brightness := arguments.get("brightness"):
args.append(f"--brightness {brightness}")
if color := arguments.get("color"):
args.append(f"--color {color}")
if temperature := arguments.get("temperature"):
args.append(f"--temperature {temperature}")
return [TextContent(type="text", text=json.dumps(run_openhue(args)))]
elif name == "room_control":
args = ["set", "room", f'"{arguments["name"]}"']
if arguments.get("on") is not None:
args.append("--on" if arguments["on"] else "--off")
if brightness := arguments.get("brightness"):
args.append(f"--brightness {brightness}")
return [TextContent(type="text", text=json.dumps(run_openhue(args)))]
elif name == "scene_set":
args = ["set", "scene", arguments["scene"], "--room", arguments["room"]]
return [TextContent(type="text", text=json.dumps(run_openhue(args)))]
elif name == "system_info":
try:
import platform
info = {"platform": platform.system(), "release": platform.release(),
"arch": platform.machine(), "hostname": platform.node(),
"cpu_count": os.cpu_count()}
try:
import psutil
mem = psutil.virtual_memory()
info["memory_gb"] = round(mem.total / (1024**3), 2)
disk = psutil.disk_usage(str(Path.home()))
info["disk_home_gb"] = round(disk.total / (1024**3), 2)
except ImportError:
info["memory_gb"] = "psutil not installed"
info["disk_home_gb"] = "psutil not installed"
return [TextContent(type="text", text=json.dumps(info, indent=2))]
except Exception as e:
return [TextContent(type="text", text=json.dumps({"error": str(e)}))]
else:
return [TextContent(type="text", text=json.dumps({
"error": f"Unknown tool: {name}",
"available": ["file_read", "file_write", "file_list", "light_list",
"light_control", "room_control", "scene_set", "system_info"],
}))]
async def main():
async with stdio_server() as (rs, ws):
await app.run(rs, ws, app.create_initialization_options())
if __name__ == "__main__":
import asyncio
asyncio.run(main())

View File

@@ -1,51 +0,0 @@
#!/usr/bin/env python3
"""Functional test for hardware_mcp_server — uses asyncio.get_event_loop for restricted envs."""
import asyncio, json, tempfile, sys
from pathlib import Path
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
from scripts.hardware_mcp_server import call_tool, is_path_allowed
async def run_tests():
# Path allowlist
assert is_path_allowed(Path.home() / "any.txt")
assert is_path_allowed(Path("/tmp/foo"))
assert not is_path_allowed(Path("/etc/passwd"))
print("✓ Path allowlist")
# file_list on home
res = await call_tool("file_list", {"directory": "~"})
data = json.loads(res[0].text)
assert "entries" in data and data["count"] >= 0
print(f"✓ file_list works, entries: {data['count']}")
# file_write + file_read round-trip in temp dir
with tempfile.TemporaryDirectory() as td:
fp = Path(td) / "hmcp_test.txt"
content = "Hardware MCP round-trip OK"
w = await call_tool("file_write", {"path": str(fp), "content": content})
assert json.loads(w[0].text).get("success")
r = await call_tool("file_read", {"path": str(fp)})
assert json.loads(r[0].text)["content"] == content
print("✓ file write/read round-trip")
# file_read error: missing file
err = await call_tool("file_read", {"path": str(Path.home() / "no_such_file_xyz")})
assert "error" in json.loads(err[0].text)
print("✓ file_read reports missing file")
# Security: path traversal blocked
block = await call_tool("file_read", {"path": "/etc/passwd"})
bd = json.loads(block[0].text)
assert "not allowed" in bd.get("error", "").lower()
print("✓ Path traversal blocked")
print("\nAll functional checks passed!")
if __name__ == "__main__":
# Use get_event_loop for environments where asyncio.run is disabled
try:
asyncio.run(run_tests())
except RuntimeError:
loop = asyncio.get_event_loop()
loop.run_until_complete(run_tests())

View File

@@ -1,126 +0,0 @@
#!/usr/bin/env python3
"""Smoke tests for hardware_mcp_server."""
import json
import os
import subprocess
import sys
import tempfile
from pathlib import Path
from unittest import TestCase
# Add repo root to path
ROOT = Path(__file__).resolve().parent.parent
sys.path.insert(0, str(ROOT))
class TestHardwareMCPToolDefinitions(TestCase):
"""Verify the MCP server is well-formed and tools have required schemas."""
def test_server_imports(self):
"""Server module must import cleanly."""
import importlib.util
spec = importlib.util.spec_from_file_location(
"hardware_mcp_server",
ROOT / "scripts" / "hardware_mcp_server.py"
)
self.assertIsNotNone(spec)
mod = importlib.util.module_from_spec(spec)
spec.loader.exec_module(mod)
self.assertTrue(hasattr(mod, "app"))
self.assertTrue(hasattr(mod, "list_tools"))
self.assertTrue(hasattr(mod, "call_tool"))
def test_list_tools_returns_at_least_five_tools(self):
"""list_tools() must return multiple tools covering file ops, lights, and system info."""
import asyncio
from scripts.hardware_mcp_server import list_tools
tools = asyncio.run(list_tools())
tool_names = [t.name for t in tools]
# Core capabilities
self.assertIn("file_read", tool_names)
self.assertIn("file_write", tool_names)
self.assertIn("file_list", tool_names)
self.assertIn("light_list", tool_names)
self.assertIn("light_control", tool_names)
self.assertIn("room_control", tool_names)
self.assertIn("scene_set", tool_names)
self.assertIn("system_info", tool_names)
self.assertGreaterEqual(len(tools), 8)
def test_file_read_schema_requires_path(self):
"""file_read tool must require 'path' parameter."""
import asyncio
from scripts.hardware_mcp_server import list_tools
tools = asyncio.run(list_tools())
ft = next(t for t in tools if t.name == "file_read")
self.assertIn("path", ft.inputSchema["properties"])
self.assertIn("path", ft.inputSchema["required"])
def test_light_control_schema_requires_name_and_on(self):
"""light_control requires name and on."""
import asyncio
from scripts.hardware_mcp_server import list_tools
tools = asyncio.run(list_tools())
ft = next(t for t in tools if t.name == "light_control")
self.assertIn("name", ft.inputSchema["required"])
self.assertIn("on", ft.inputSchema["required"])
def test_system_info_is_readonly(self):
"""system_info tool takes no arguments."""
import asyncio
from scripts.hardware_mcp_server import list_tools
tools = asyncio.run(list_tools())
ft = next(t for t in tools if t.name == "system_info")
self.assertEqual(ft.inputSchema.get("required", []), [])
self.assertEqual(len(ft.inputSchema.get("properties", {})), 0)
def test_file_write_path_allowed_check(self):
"""File write must enforce path allowlist (regression guard)."""
from scripts.hardware_mcp_server import is_path_allowed, Path
self.assertTrue(is_path_allowed(Path.home() / "test.txt"))
self.assertTrue(is_path_allowed(Path("/tmp/test.txt")))
# Outside allowed dirs should be rejected
self.assertFalse(is_path_allowed(Path("/etc/passwd")))
def test_run_openhue_error_handling(self):
"""openhue runner returns structured error when CLI missing."""
from scripts.hardware_mcp_server import run_openhue
result = run_openhue(["get", "light"])
# On a system without openhue, must return success=False with helpful error
self.assertIn("success", result)
if not result.get("success"):
self.assertIn("error", result)
self.assertIn("openhue", result.get("error", "").lower())
class TestHardwareMCPConfigCompleteness(TestCase):
"""Validate config template matches tool set."""
def test_config_template_exists(self):
self.assertTrue((ROOT / "timmy-local" / "hardware_mcp_config.yaml").exists())
def test_config_lists_all_tools(self):
with open(ROOT / "timmy-local" / "hardware_mcp_config.yaml") as f:
content = f.read()
# All tool names should appear in the tools: section
for tool in ["file_read", "file_write", "file_list", "light_list",
"light_control", "room_control", "scene_set", "system_info"]:
self.assertIn(tool, content, f"Tool {tool} missing from config tools list")
def test_config_has_security_guards(self):
with open(ROOT / "timmy-local" / "hardware_mcp_config.yaml") as f:
content = f.read()
self.assertIn("max_consecutive_errors", content)
self.assertIn("allowed_dirs", content)
self.assertIn("max_file_size_bytes", content)
def test_config_has_server_key(self):
with open(ROOT / "timmy-local" / "hardware_mcp_config.yaml") as f:
content = f.read()
self.assertIn("server_key: hardware", content)
if __name__ == "__main__":
import unittest
unittest.main()

View File

@@ -1,3 +0,0 @@
# hardware MCP config
Copy `hardware_mcp_config.yaml` to `~/.timmy/hardware/hardware_mcp_config.yaml` to enable runtime tuning.

View File

@@ -1,67 +0,0 @@
# ═══════════════════════════════════════════════════════════════════════
# Local Hardware MCP — Runtime Configuration
# ═══════════════════════════════════════════════════════════════════════
# Edit this file to tune hardware control settings.
# Hermes loads this at session start when the hardware MCP server is enabled.
#
# Location: ~/.timmy/hardware/hardware_mcp_config.yaml
# ═══════════════════════════════════════════════════════════════════════
# ── Server Identity ───────────────────────────────────────────────────
server_key: hardware
# ── Tool Names ────────────────────────────────────────────────────────
# Exact tool names Hermes registers. Update if you rename tools in
# hardware_mcp_server.py.
tools:
- name: file_read
hint: "Read a file from an allowed directory (home, /tmp). Max 10 MB."
- name: file_write
hint: "Write text content to a file within allowed directories."
- name: file_list
hint: "List files and directories in a given folder."
- name: light_list
hint: "List all Hue lights, rooms, and scenes from OpenHue."
- name: light_control
hint: "Control a specific Hue light: on/off, brightness, color, temperature."
- name: room_control
hint: "Control all lights in a room: on/off, brightness."
- name: scene_set
hint: "Activate a Hue scene in a room."
- name: system_info
hint: "Get safe system information: OS, CPU count, memory usage, disk space."
# ── Security Guards ───────────────────────────────────────────────────
guards:
# Maximum consecutive tool errors before stopping.
max_consecutive_errors: 3
# Max total hardware MCP calls per session (0 = unlimited).
max_mcp_calls_per_session: 0
# Allowed directories for file operations (expanded paths).
allowed_dirs:
- "~"
- "/tmp"
- "/private/tmp"
# Maximum file size for reads (bytes).
max_file_size_bytes: 10485760 # 10 MB
# ── OpenHue ───────────────────────────────────────────────────────────
# Path to openhue CLI (auto-detected if in PATH).
openhue_command: "openhue"
# ── Dependencies ───────────────────────────────────────────────────────
# Prerequisites:
# - OpenHue CLI: brew install openhue/cli/openhue (macOS) or see https://github.com/openhue/openhue-cli
# - MCP SDK: pip install mcp
# - For system_info: pip install psutil (optional, for detailed memory/disk metrics)
#
# Config in ~/.hermes/config.yaml:
# mcp_servers:
# hardware:
# command: "python"
# args: ["/Users/you/path/to/timmy-home/scripts/hardware_mcp_server.py"]
# env:
# OPENHUE_BRIDGE_IP: "192.168.1.xx" # optional, if openhue needs it