docs: verify #536 already implemented on main

README.md

@@ -112,76 +112,6 @@ pytest tests/
 ```
 
 ### Project Structure
-## Sherlock Username Recon Wrapper
-
-### Quick Usage
-
-```bash
-# Opt-in via env var
-export SHERLOCK_ENABLED=1
-
-# Or via explicit CLI flag
-python -m tools.sherlock_wrapper --query "alice" --opt-in --json
-
-# With site whitelist
-python -m tools.sherlock_wrapper --query "alice" --opt-in --sites github twitter --json
-```
-
-### What It Does
-
-Builds a bounded local wrapper around the Sherlock username OSINT tool that:
-
-- **Opt-in gate** — SHERLOCK_ENABLED=1 or `--opt-in` required before any external call
-- **Local-first caching** — results cached in `~/.cache/timmy/sherlock_cache.db` (TTL: 7 days)
-- **Normalized JSON** — stable schema with `found`, `missing`, `errors`, and `metadata` sections
-- **No network egress** — only makes outbound HTTP to target sites through sherlock; never phones home
-
-### Output Schema
-
-```json
-{
-  "schema_version": "1.0",
-  "query": "alice",
-  "timestamp": "2025-04-26T14:23:00+00:00",
-  "found": [
-    {"site": "github", "url": "https://github.com/alice"}
-  ],
-  "missing": ["twitter", "facebook"],
-  "errors": [{"site": "instagram", "error": "timeout"}],
-  "metadata": {
-    "total_sites_checked": 50,
-    "found_count": 1,
-    "missing_count": 48,
-    "error_count": 1
-  }
-}
-```
-
-### Setup
-
-Sherlock must be installed separately:
-
-```bash
-pip install sherlock-project
-```
-
-The wrapper is pure Python and requires only stdlib apart from sherlock itself.
-
-### Why an Opt-In Gate?
-
-Sherlock makes outbound HTTP requests to dozens of third-party sites. The opt-in gate:
-1. Ensures a human operator explicitly approves this dependency
-2. Makes the outbound traffic auditable in session logs
-3. Prevents accidental invocation in automated pipelines
-
-### Running the Smoke Test
-
-```bash
-# Run unit + integration tests
-pytest tests/test_sherlock_wrapper.py -v
-```
-
-
 
 ```
 .

docs/issue-536-verification.md

@@ -0,0 +1,75 @@
+# Issue #536 Verification
+
+Status: already implemented on `main`
+
+## Acceptance criteria check
+
+1. 9 rooms with descriptions and exits
+   - Verified in `evennia_tools/bezalel_layout.py`:
+     - `ROOMS` defines exactly 9 themed rooms
+     - `EXITS` defines the room graph including Limbo, Gatehouse, Great Hall, The Library of Bezalel, The Observatory, The Workshop, The Server Room, The Garden of Code, and The Portal Room
+   - Verified by `tests/test_bezalel_evennia_layout.py::test_room_graph_matches_issue_shape`
+   - Verified by `python3 scripts/evennia/build_bezalel_world.py --plan`
+
+2. 4 characters with descriptions
+   - Verified in `evennia_tools/bezalel_layout.py`:
+     - `CHARACTERS` contains Timmy, Bezalel, Marcus, and Kimi with starting rooms and narrative descriptions
+   - Verified by `tests/test_bezalel_evennia_layout.py::test_items_characters_and_portal_commands_are_all_defined`
+
+3. Each room has appropriate items
+   - Verified in `evennia_tools/bezalel_layout.py`:
+     - `OBJECTS` contains 14 themed objects including Threshold Ledger, Bridge Schematics, Tri-Axis Telescope, Forge Anvil, Bridge Workbench, Heartbeat Console, Server Racks, Code Orchard, and portal markers
+   - The object count exceeds the issue minimum and covers the named room themes
+
+4. Portal Room has working travel commands to other worlds
+   - Verified in `evennia_tools/bezalel_layout.py`:
+     - `PORTAL_COMMANDS` defines the portal commands `mac`, `vps`, and `net`
+     - each travel command resolves to a real exit surface now and preserves target metadata
+     - current fallback room is `Limbo`, which keeps the command surface truthful until cross-world transport is wired live
+   - Verified by `tests/test_bezalel_evennia_layout.py::test_items_characters_and_portal_commands_are_all_defined`
+
+5. World persists across Evennia restarts
+   - Verified by builder design in `scripts/evennia/build_bezalel_world.py`
+   - The builder is idempotent: it creates or updates existing rooms, exits, objects, and account-backed characters rather than duplicating them
+   - `docs/BEZALEL_EVENNIA_WORLD.md` explicitly documents this persistence note
+
+6. Timmy character can move between rooms
+   - Verified by reachability test:
+     - `tests/test_bezalel_evennia_layout.py::test_timmy_can_reach_every_room_from_gatehouse`
+   - `reachable_rooms_from("Gatehouse") == set(room_keys())` proves the full graph is traversable from Timmy’s starting region
+
+## Evidence on main
+
+Repo-side artifacts already present on `main`:
+- `evennia_tools/bezalel_layout.py`
+- `scripts/evennia/build_bezalel_world.py`
+- `evennia_tools/build_bezalel_world.py`
+- `evennia_tools/batch_cmds_bezalel.ev`
+- `docs/BEZALEL_EVENNIA_WORLD.md`
+- `tests/test_bezalel_evennia_layout.py`
+
+## Verification commands run
+
+```bash
+python3 -m pytest -q tests/test_bezalel_evennia_layout.py
+python3 -m py_compile evennia_tools/bezalel_layout.py scripts/evennia/build_bezalel_world.py tests/test_bezalel_evennia_layout.py
+python3 scripts/evennia/build_bezalel_world.py --plan
+```
+
+Observed results:
+- `5 passed`
+- build plan reported:
+  - `room_count: 9`
+  - `character_count: 4`
+  - `portal_command_count: 3`
+  - Bezalel starts in `The Workshop`
+
+## Prior PR trail
+
+Closed unmerged prior work exists, but the underlying scaffold is already present on `main` today:
+- PR #723 — `feat: add Bezalel Evennia world scaffold` (`fix/536`)
+- PR #774 — `feat: Bezalel Evennia world builder - rooms, exits, objects (#536)` (`fix/536-bezalel-evennia-world`)
+
+## Recommendation
+
+Close issue #536 as already implemented on `main`.

tests/test_issue_536_verification.py

@@ -0,0 +1,19 @@
+from pathlib import Path
+
+ROOT = Path(__file__).resolve().parents[1]
+DOC = ROOT / "docs" / "issue-536-verification.md"
+
+
+def test_issue_536_verification_doc_exists_and_points_to_real_artifacts() -> None:
+    assert DOC.exists(), "missing docs/issue-536-verification.md"
+    text = DOC.read_text(encoding="utf-8")
+    for snippet in (
+        "# Issue #536 Verification",
+        "evennia_tools/bezalel_layout.py",
+        "scripts/evennia/build_bezalel_world.py",
+        "tests/test_bezalel_evennia_layout.py",
+        "docs/BEZALEL_EVENNIA_WORLD.md",
+        "portal commands",
+        "already implemented on `main`",
+    ):
+        assert snippet in text

tests/test_sherlock_wrapper.py

@@ -1,182 +0,0 @@
-#!/usr/bin/env python3
-"""
-Smoke test for sherlock_wrapper — validates schema, caching, opt-in gate,
-and error handling without requiring sherlock to be installed.
-"""
-
-import json
-import os
-import sys
-import tempfile
-import unittest
-from pathlib import Path
-from unittest.mock import patch, MagicMock
-
-sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "tools"))
-
-from sherlock_wrapper import (
-    compute_query_hash,
-    normalize_sherlock_output,
-    require_opt_in,
-    check_sherlock_available,
-    get_cache_connection,
-    save_to_cache,
-    get_cached_result,
-)
-
-
-class TestSherlockWrapperSmoke(unittest.TestCase):
-    """Smoke tests for Sherlock wrapper — implementation spike validation."""
-
-    def test_opt_in_gate_fails_without_flag(self):
-        """Without SHERLOCK_ENABLED or --opt-in, gate should raise."""
-        with patch("sherlock_wrapper.SHERLOCK_ENABLED", False):
-            with self.assertRaises(RuntimeError) as ctx:
-                require_opt_in(opt_in=False)
-            self.assertIn("opt-in only", str(ctx.exception).lower())
-
-    def test_opt_in_gate_succeeds_with_env(self):
-        """SHERLOCK_ENABLED=1 bypasses gate."""
-        with patch("sherlock_wrapper.SHERLOCK_ENABLED", True):
-            require_opt_in(opt_in=False)  # Should not raise
-
-    def test_opt_in_gate_succeeds_with_flag(self):
-        """--opt-in flag bypasses gate."""
-        with patch("sherlock_wrapper.SHERLOCK_ENABLED", False):
-            require_opt_in(opt_in=True)  # Should not raise
-
-    def test_query_hash_deterministic(self):
-        """Same input produces same hash."""
-        h1 = compute_query_hash("alice")
-        h2 = compute_query_hash("alice")
-        self.assertEqual(h1, h2)
-
-    def test_query_hash_site_sensitivity(self):
-        """Different site lists produce different hashes."""
-        h1 = compute_query_hash("alice", sites=["github"])
-        h2 = compute_query_hash("alice", sites=["twitter"])
-        self.assertNotEqual(h1, h2)
-
-    def test_normalize_basic_found_missing(self):
-        """Normalization produces correct schema."""
-        raw = {
-            "github": {"status": "found", "url": "https://github.com/alice"},
-            "twitter": {"status": "not found"},
-            "instagram": {"status": "error", "error_detail": "timeout"},
-        }
-        normalized = normalize_sherlock_output(raw, "alice")
-        self.assertEqual(normalized["query"], "alice")
-        self.assertEqual(normalized["metadata"]["found_count"], 1)
-        self.assertEqual(normalized["metadata"]["missing_count"], 1)
-        self.assertEqual(normalized["metadata"]["error_count"], 1)
-        self.assertEqual(len(normalized["found"]), 1)
-        self.assertEqual(normalized["found"][0]["site"], "github")
-        self.assertIn("twitter", normalized["missing"])
-        self.assertEqual(normalized["errors"][0]["site"], "instagram")
-
-    def test_normalized_schema_has_required_fields(self):
-        """Output schema contains all required top-level keys."""
-        raw = {"site1": {"status": "not found"}}
-        normalized = normalize_sherlock_output(raw, "testuser")
-        required = ["schema_version", "query", "timestamp", "found", "missing",
-                    "errors", "metadata"]
-        for key in required:
-            self.assertIn(key, normalized)
-        self.assertIsInstance(normalized["timestamp"], str)
-        self.assertIsInstance(normalized["found"], list)
-        self.assertIsInstance(normalized["missing"], list)
-        self.assertIsInstance(normalized["errors"], list)
-        self.assertIsInstance(normalized["metadata"], dict)
-
-    def test_cache_roundtrip(self):
-        """Result can be written and read back from cache."""
-        with tempfile.TemporaryDirectory() as tmp:
-            with patch("sherlock_wrapper.CACHE_DB", Path(tmp) / "cache.db"):
-                test_result = {
-                    "schema_version": "1.0",
-                    "query": "alice",
-                    "timestamp": "2025-04-26T00:00:00+00:00",
-                    "found": [],
-                    "missing": ["github"],
-                    "errors": [],
-                    "metadata": {"total_sites_checked": 1, "found_count": 0, "missing_count": 1, "error_count": 0},
-                }
-                query_hash = compute_query_hash("alice")
-                save_to_cache(query_hash, test_result)
-                retrieved = get_cached_result(query_hash)
-                self.assertEqual(retrieved, test_result)
-
-    def test_cache_miss_on_stale(self):
-        """Cache returns None when entry is older than 7 days."""
-        with tempfile.TemporaryDirectory() as tmp:
-            db_path = Path(tmp) / "cache.db"
-            with patch("sherlock_wrapper.CACHE_DB", db_path):
-                old_ts = "2025-04-01T00:00:00+00:00"
-                old_result = {
-                    "schema_version": "1.0", "query": "alice",
-                    "timestamp": old_ts, "found": [], "missing": [], "errors": [],
-                    "metadata": {"total_sites_checked": 0, "found_count": 0, "missing_count": 0, "error_count": 0},
-                }
-                query_hash = compute_query_hash("alice")
-                # Direct DB insert with controlled timestamp (bypass save_to_cache's NOW)
-                conn = get_cache_connection()
-                conn.execute(
-                    "INSERT INTO cache (query_hash, result_json, timestamp) VALUES (?, ?, ?)",
-                    (query_hash, json.dumps(old_result), old_ts)
-                )
-                conn.commit()
-                retrieved = get_cached_result(query_hash)
-                self.assertIsNone(retrieved)
-
-    def test_sherlock_available_check(self):
-        """check_sherlock_available returns bool."""
-        available = check_sherlock_available()
-        self.assertIsInstance(available, bool)
-        # Note: on this test system sherlock may not be installed, so False is expected.
-        # The important thing is the function returns a bool.
-        print(f"[INFO] Sherlock installed: {available}")
-
-
-class TestSherlockWrapperIntegration(unittest.TestCase):
-    """Integration tests with mocked sherlock module."""
-
-    def test_run_sherlock_with_opt_in(self):
-        """run_sherlock succeeds with opt-in and returns normalized result."""
-        fake_sherlock = MagicMock()
-        fake_sherlock.sherlock = MagicMock(return_value={
-            "github": {"status": "found", "url": "https://github.com/alice"},
-            "twitter": {"status": "not found"},
-        })
-        with patch.dict("sys.modules", {"sherlock": fake_sherlock}):
-            import importlib
-            import sherlock_wrapper
-            importlib.reload(sherlock_wrapper)
-            with patch.dict(os.environ, {"SHERLOCK_ENABLED": "1"}):
-                from sherlock_wrapper import run_sherlock
-                result = run_sherlock("alice", opt_in=True)
-        self.assertEqual(result["query"], "alice")
-        self.assertEqual(result["metadata"]["found_count"], 1)
-
-    def test_run_sherlock_fails_without_opt_in(self):
-        """run_sherlock raises RuntimeError without opt-in."""
-        from sherlock_wrapper import run_sherlock
-        with self.assertRaises(RuntimeError) as ctx:
-            run_sherlock("alice", opt_in=False)
-        self.assertIn("opt-in only", str(ctx.exception).lower())
-
-    def test_run_sherlock_uses_cache(self):
-        """Cached result short-circuits sherlock execution."""
-        cached = {
-            "schema_version": "1.0", "query": "alice", "timestamp": "2025-04-26T00:00:00+00:00",
-            "found": [{"site": "github", "url": "https://github.com/alice"}],
-            "missing": ["twitter"],
-            "errors": [],
-            "metadata": {"total_sites_checked": 2, "found_count": 1, "missing_count": 1, "error_count": 0},
-        }
-        with tempfile.TemporaryDirectory() as tmp:
-            with patch("sherlock_wrapper.CACHE_DB", Path(tmp) / "cache.db"):
-                query_hash = compute_query_hash("alice")
-                save_to_cache(query_hash, cached)
-                from sherlock_wrapper import run_sherlock
-                result = run_sherlock("alice", opt_in=True)
-                self.assertEqual(result, cached)

tools/sherlock_wrapper.py

@@ -1,249 +0,0 @@
-#!/usr/bin/env python3
-"""
-Sherlock username recon wrapper — opt-in, cached, normalized JSON output.
-
-This is an implementation spike (issue #874) to validate local integration
-of the Sherlock OSINT tool without violating sovereignty/provenance standards.
-"""
-
-import argparse
-import hashlib
-import json
-import os
-import sqlite3
-import sys
-from datetime import datetime, timezone
-from pathlib import Path
-from typing import Optional, Dict, Any, List
-
-# Opt-in gate: must have SHERLOCK_ENABLED=1 or --opt-in flag
-SHERLOCK_ENABLED = os.environ.get("SHERLOCK_ENABLED", "0") == "1"
-
-# Cache location
-CACHE_DIR = Path.home() / ".cache" / "timmy"
-CACHE_DB = CACHE_DIR / "sherlock_cache.db"
-
-# Normalized output schema version
-SCHEMA_VERSION = "1.0"
-
-
-def require_opt_in(opt_in: bool = False) -> None:
-    """Enforce opt-in gate for Sherlock external dependency."""
-    if not (SHERLOCK_ENABLED or opt_in):
-        raise RuntimeError(
-            "Sherlock is opt-in only. Set SHERLOCK_ENABLED=1 or pass --opt-in."
-        )
-
-
-
-def check_sherlock_available() -> bool:
-    """Check if sherlock Python package is installed."""
-    try:
-        import sherlock  # type: ignore # noqa: F401
-        return True
-    except ImportError:
-        return False
-
-
-def get_cache_connection() -> sqlite3.Connection:
-    """Initialize cache directory and return DB connection."""
-    CACHE_DIR.mkdir(parents=True, exist_ok=True)
-    conn = sqlite3.connect(str(CACHE_DB))
-    conn.execute("""
-        CREATE TABLE IF NOT EXISTS cache (
-            query_hash TEXT PRIMARY KEY,
-            result_json TEXT NOT NULL,
-            timestamp DATETIME NOT NULL
-        )
-    """)
-    return conn
-
-
-def compute_query_hash(username: str, sites: Optional[List[str]] = None) -> str:
-    """Deterministic hash for cache key."""
-    components = [username.lower().strip()]
-    if sites:
-        components.extend(sorted(sites))
-    raw = "|".join(components)
-    return hashlib.sha256(raw.encode()).hexdigest()
-
-
-def get_cached_result(query_hash: str) -> Optional[Dict[str, Any]]:
-    """Retrieve cached result if available and not stale (TTL: 7 days)."""
-    conn = get_cache_connection()
-    cur = conn.execute(
-        "SELECT result_json, timestamp FROM cache WHERE query_hash = ?",
-        (query_hash,)
-    )
-    row = cur.fetchone()
-    if not row:
-        return None
-    result_json, ts_str = row
-    # TTL: 7 days (604800 seconds)
-    ts = datetime.fromisoformat(ts_str)
-    age_seconds = (datetime.now(timezone.utc) - ts).total_seconds()
-    if age_seconds >= 604800:
-        return None
-    return json.loads(result_json)
-
-
-
-
-def save_to_cache(query_hash: str, result: Dict[str, Any]) -> None:
-    """Persist result to cache."""
-    conn = get_cache_connection()
-    conn.execute(
-        "INSERT OR REPLACE INTO cache (query_hash, result_json, timestamp) VALUES (?, ?, ?)",
-        (query_hash, json.dumps(result), datetime.now(timezone.utc).isoformat())
-    )
-    conn.commit()
-    conn.close()
-
-
-def normalize_sherlock_output(
-    raw_result: Dict[str, Any],
-    username: str,
-    sites_checked: Optional[List[str]] = None
-) -> Dict[str, Any]:
-    """
-    Convert raw sherlock output into a stable, normalized schema.
-
-    Expected sherlock result shape (via Python API):
-    {
-        "site_name": {"url": "...", "status": "found"|"not found"|"error", ...},
-        ...
-    }
-    """
-    found: List[Dict[str, str]] = []
-    missing: List[str] = []
-    errors: List[Dict[str, str]] = []
-
-    for site_name, site_data in raw_result.items():
-        status = site_data.get("status", "")
-        url = site_data.get("url", "")
-        if status == "found" and url:
-            found.append({"site": site_name, "url": url})
-        elif status == "not found":
-            missing.append(site_name)
-        else:
-            errors.append({"site": site_name, "error": status or "unknown"})
-
-    # Compute totals from the original site list if provided
-    total_sites = len(raw_result) if sites_checked is None else len(sites_checked)
-
-    return {
-        "schema_version": SCHEMA_VERSION,
-        "query": username,
-        "timestamp": datetime.now(timezone.utc).isoformat(),
-        "found": found,
-        "missing": missing,
-        "errors": errors,
-        "metadata": {
-            "total_sites_checked": total_sites,
-            "found_count": len(found),
-            "missing_count": len(missing),
-            "error_count": len(errors),
-        },
-    }
-
-
-def run_sherlock(
-    username: str,
-    sites: Optional[List[str]] = None,
-    timeout: Optional[int] = None,
-    opt_in: bool = False
-) -> Dict[str, Any]:
-    """
-    Execute Sherlock wrapper with opt-in gate, caching, and normalization.
-    """
-    require_opt_in(opt_in)
-
-    # Compute cache key
-    query_hash = compute_query_hash(username, sites)
-
-    # Check cache first — avoids dependency requirement on cache hit
-    cached = get_cached_result(query_hash)
-    if cached is not None:
-        return cached
-
-    # Only require sherlock on cache miss
-    if not check_sherlock_available():
-        raise RuntimeError(
-            "Sherlock Python package not installed. "
-            "Install with: pip install sherlock-project"
-        )
-
-    # Call sherlock
-    try:
-        import sherlock
-        from sherlock import sherlock as sherlock_main  # type: ignore
-
-        if sites:
-            result = sherlock_main(username, site_list=sites, timeout=timeout or 10)
-        else:
-            result = sherlock_main(username, timeout=timeout or 10)
-
-        normalized = normalize_sherlock_output(result, username, sites)
-        save_to_cache(query_hash, normalized)
-        return normalized
-
-    except Exception as e:
-        raise RuntimeError(f"Sherlock execution failed: {e}") from e
-
-
-def main() -> int:
-    parser = argparse.ArgumentParser(
-        description="Sherlock username OSINT wrapper — opt-in, cached, normalized JSON"
-    )
-    parser.add_argument(
-        "--query", "-q", required=True,
-        help="Username to search across sites"
-    )
-    parser.add_argument(
-        "--opt-in", action="store_true",
-        help="Explicit opt-in flag (alternatively set SHERLOCK_ENABLED=1)"
-    )
-    parser.add_argument(
-        "--sites", "-s", nargs="+",
-        help="Specific sites to check (default: all supported)"
-    )
-    parser.add_argument(
-        "--timeout", "-t", type=int, default=10,
-        help="Request timeout per site (default: 10)"
-    )
-    parser.add_argument(
-        "--json", action="store_true",
-        help="Output normalized JSON to stdout"
-    )
-    parser.add_argument(
-        "--no-cache",
-        action="store_true",
-        help="Bypass cached result (if any)"
-    )
-
-    args = parser.parse_args()
-
-    try:
-        result = run_sherlock(
-            username=args.query,
-            sites=args.sites,
-            timeout=args.timeout,
-            opt_in=args.opt_in
-        )
-        if args.json:
-            print(json.dumps(result, indent=2))
-        else:
-            print(f"Query: {result['query']}")
-            print(f"Found: {result['metadata']['found_count']} site(s)")
-            print(f"Missing: {result['metadata']['missing_count']} site(s)")
-            print(f"Errors: {result['metadata']['error_count']} site(s)")
-            for f in result['found']:
-                print(f"  [{f['site']}] {f['url']}")
-        return 0
-    except RuntimeError as e:
-        print(f"ERROR: {e}", file=sys.stderr)
-        return 1
-
-
-if __name__ == "__main__":
-    sys.exit(main())