Timmy_Foundation/timmy-home
15
0
Fork 0
Code Issues 224 Pull Requests 120 Actions Packages Projects Releases Wiki Activity

feat: add tower world-changing items (#514) #861

Open
Rockachopa wants to merge 2 commits from fix/514 into main
pull from: fix/514
merge into: Timmy_Foundation:main
Conversation 5 Commits 2 Files Changed 2 +203 -2
Rockachopa commented 2026-04-22 06:56:14 +00:00
Owner
Copy Link

Closes #514

Summary:

  • seed 10+ discoverable Tower-world items across the five rooms
  • add take:<item> and use:<item> actions so exploration affects world state
  • make items visibly change the world: garden growth, bridge repairs, tower power/cache, threshold markings, and forge fire
  • mark the foraged key as a quest item and let it unlock a hidden Tower cache

Verification:

  • python3 -m pytest tests/test_tower_game_items.py tests/test_evennia_local_world_game.py -q
  • python3 -m py_compile evennia/timmy_world/game.py tests/test_tower_game_items.py

Acceptance criteria checked:

  • 10+ unique items
  • items have effects
  • at least one quest item
Closes #514 Summary: - seed 10+ discoverable Tower-world items across the five rooms - add `take:<item>` and `use:<item>` actions so exploration affects world state - make items visibly change the world: garden growth, bridge repairs, tower power/cache, threshold markings, and forge fire - mark the `foraged key` as a quest item and let it unlock a hidden Tower cache Verification: - `python3 -m pytest tests/test_tower_game_items.py tests/test_evennia_local_world_game.py -q` - `python3 -m py_compile evennia/timmy_world/game.py tests/test_tower_game_items.py` Acceptance criteria checked: - 10+ unique items - items have effects - at least one quest item
Rockachopa added 2 commits 2026-04-22 06:56:14 +00:00
test: define tower world items for #514 5ce4fa6cb8
feat: add tower world-changing items for #514
Some checks failed
Agent PR Gate / gate (pull_request) Failing after 58s
Details
Self-Healing Smoke / self-healing-smoke (pull_request) Failing after 26s
Details
Agent PR Gate / report (pull_request) Successful in 23s
Details
Smoke Test / smoke (pull_request) Failing after 27s
Details
06a6b53a37
gitea-actionsbot commented 2026-04-22 06:57:38 +00:00
Copy Link

Agent PR Gate

Check Status
Syntax / parse failure
Test suite failure
PR criteria success
Risk level high

Failure details

  • syntax reported failure. Inspect the workflow logs for that step.
  • tests reported failure. Inspect the workflow logs for that step.

Recommendation: human review.
Low-risk documentation/test-only PRs may be auto-merged. Operational changes stay in human review.

## Agent PR Gate | Check | Status | |-------|--------| | Syntax / parse | failure | | Test suite | failure | | PR criteria | success | | Risk level | high | ### Failure details - syntax reported failure. Inspect the workflow logs for that step. - tests reported failure. Inspect the workflow logs for that step. Recommendation: human review. Low-risk documentation/test-only PRs may be auto-merged. Operational changes stay in human review.
Rockachopa reviewed 2026-04-22 13:48:01 +00:00
Rockachopa left a comment
Author
Owner
Copy Link

Review: APPROVED (with note)

Solid feature addition. 12 items with effects, quest flags, consumable vs persistent distinction, room-specific discoverables, and world-state mutations. Tests verify both item discovery and state mutation.

Note: WORLD_DIR on line 12 still has the hardcoded /Users/apayne path. This is the exact bug PRs #843 and #863 are fixing. Merge #843 first or apply the env var pattern here.

**Review: APPROVED (with note)** Solid feature addition. 12 items with effects, quest flags, consumable vs persistent distinction, room-specific discoverables, and world-state mutations. Tests verify both item discovery and state mutation. Note: WORLD_DIR on line 12 still has the hardcoded `/Users/apayne` path. This is the exact bug PRs #843 and #863 are fixing. Merge #843 first or apply the env var pattern here.
Rockachopa reviewed 2026-04-22 14:12:30 +00:00
Rockachopa left a comment
Author
Owner
Copy Link

VERDICT: APPROVE with note

Adds a world items system to the Evennia game with 12 discoverable items (foraged key, seed packet, notebook, cloth, oil can, etc.), room-specific discoverables mapping, and state flags for tracking item usage effects (bridge_patched, bridge_secured, tower_cache_unlocked, etc.). The room descriptions dynamically update based on item usage state, which is a nice touch. The item data structure is clean with effect, quest_item, consumable, and effect_text fields.

One note: the file still has a hardcoded path on line 12: WORLD_DIR = Path("/Users/apayne/.timmy/evennia/timmy_world"). Given the env-var refactoring in PRs 862/863, this should be updated to use TIMMY_HOME as well. Not blocking since this is a pre-existing issue.

VERDICT: APPROVE with note Adds a world items system to the Evennia game with 12 discoverable items (foraged key, seed packet, notebook, cloth, oil can, etc.), room-specific discoverables mapping, and state flags for tracking item usage effects (bridge_patched, bridge_secured, tower_cache_unlocked, etc.). The room descriptions dynamically update based on item usage state, which is a nice touch. The item data structure is clean with effect, quest_item, consumable, and effect_text fields. One note: the file still has a hardcoded path on line 12: WORLD_DIR = Path("/Users/apayne/.timmy/evennia/timmy_world"). Given the env-var refactoring in PRs 862/863, this should be updated to use TIMMY_HOME as well. Not blocking since this is a pre-existing issue.
claude approved these changes 2026-04-22 16:11:35 +00:00
claude left a comment
Member
Copy Link

Good feature addition. 12 discoverable items with room-specific placement, world-state flags for persistent effects (bridge_patched, tower_cache_unlocked, etc.), and room descriptions that reflect applied items. The item data structure with effect, quest_item, consumable, and effect_text fields is clean.

Note: WORLD_DIR still uses the hardcoded /Users/apayne path at the top of the file. PR #843 fixes this same file. These two PRs will conflict on merge — coordinate ordering.

APPROVED.

Good feature addition. 12 discoverable items with room-specific placement, world-state flags for persistent effects (bridge_patched, tower_cache_unlocked, etc.), and room descriptions that reflect applied items. The item data structure with effect, quest_item, consumable, and effect_text fields is clean. Note: WORLD_DIR still uses the hardcoded /Users/apayne path at the top of the file. PR #843 fixes this same file. These two PRs will conflict on merge — coordinate ordering. APPROVED.
Rockachopa commented 2026-04-30 23:37:20 +00:00
Author
Owner
Copy Link

STEP35 FREE BURN Sweep #876 (timmy-home) — PRESERVE\n\nReason: Active work item: adding tower world-changing items (#514) — core tower functionality.\n\nIssue preserved as active backlog item. Not a candidate for closure at this time.

## STEP35 FREE BURN Sweep #876 (timmy-home) — PRESERVE\n\n**Reason:** Active work item: adding tower world-changing items (#514) — core tower functionality.\n\nIssue preserved as active backlog item. Not a candidate for closure at this time.
Some checks failed
Agent PR Gate / gate (pull_request) Failing after 58s
Details
Self-Healing Smoke / self-healing-smoke (pull_request) Failing after 26s
Details
Agent PR Gate / report (pull_request) Successful in 23s
Details
Smoke Test / smoke (pull_request) Failing after 27s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/514:fix/514
git checkout fix/514
Sign in to join this conversation.
Reviewers
No Reviewers
Rockachopa
claude
Labels
Clear labels
alembic
The Alchemical Vessel - Kimi-powered transformation
 architecture
Auto-created architecture label
 assigned-claw-code
Queued for Code Claw (qwen/openrouter)
 assigned-kimi
Dispatched to Kimi via OpenClaw
 assigned-sonnet
auth-needed
auth-needed
 batch-pipeline
Token masterplan batch pipeline
 bizzalo
bizzalo
 blocker
blocker
 building
business-dev
AUTO: business-dev label for fleet epics
 claw
Claw Code runtime (Rust)
 claw-code-done
Code Claw completed this task
 claw-code-in-progress
Code Claw is actively working
 deadline-7am
deadline-7am
 documentation
AUTO: documentation label for fleet epics
 epic
Parent tracking issue
 fleet
formal-methods
golden_bilbo
Bilbo at peak performance - max churn, fast responses
 gtm
AUTO: gtm label for fleet epics
 harness-engineering
Auto-created harness-engineering label
 hiring
AUTO: hiring label for fleet epics
 human-review
incentives
AUTO: incentives label for fleet epics
 intel
Competitive intelligence
 kimi-done
Kimi completed this task
 kimi-in-progress
Kimi is actively working on this
 marketing
AUTO: marketing label for fleet epics
 mathematics
milestone
morning-report
morning-report
 onboarding
AUTO: onboarding label for fleet epics
 partner-program
AUTO: partner-program label for fleet epics
 phase-1
phase-2
phase-3
phase-4
phase-5
phase-6
pricing
AUTO: pricing label for fleet epics
 progression
project
proof
publication
research
resource
runtime
Runtime abstraction layer
 saiyah
Auto-created saiyah label
 sales
AUTO: sales label for fleet epics
 sonnet-ready
study
Learning from external source code
 substratum
The dissolution engine - runtime layer
 substratum:invoke
Trigger Substratum execution
 tension
throughput-10x
throughput-10x label
 token-masterplan
token-masterplan label
 urgent
urgent
 velocity-engine
Auto-generated by velocity engine
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
KimiClaw Rockachopa Timmy allegro antigravity bezalel claude claw-code codex-agent ezra gemini google grok hermes kimi manus perplexity sonnet
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/timmy-home#861
Delete Branch "fix/514"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?