Compare commits
1 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
44b27eeffe |
@@ -1,75 +0,0 @@
|
||||
# Issue #536 Verification
|
||||
|
||||
Status: already implemented on `main`
|
||||
|
||||
## Acceptance criteria check
|
||||
|
||||
1. 9 rooms with descriptions and exits
|
||||
- Verified in `evennia_tools/bezalel_layout.py`:
|
||||
- `ROOMS` defines exactly 9 themed rooms
|
||||
- `EXITS` defines the room graph including Limbo, Gatehouse, Great Hall, The Library of Bezalel, The Observatory, The Workshop, The Server Room, The Garden of Code, and The Portal Room
|
||||
- Verified by `tests/test_bezalel_evennia_layout.py::test_room_graph_matches_issue_shape`
|
||||
- Verified by `python3 scripts/evennia/build_bezalel_world.py --plan`
|
||||
|
||||
2. 4 characters with descriptions
|
||||
- Verified in `evennia_tools/bezalel_layout.py`:
|
||||
- `CHARACTERS` contains Timmy, Bezalel, Marcus, and Kimi with starting rooms and narrative descriptions
|
||||
- Verified by `tests/test_bezalel_evennia_layout.py::test_items_characters_and_portal_commands_are_all_defined`
|
||||
|
||||
3. Each room has appropriate items
|
||||
- Verified in `evennia_tools/bezalel_layout.py`:
|
||||
- `OBJECTS` contains 14 themed objects including Threshold Ledger, Bridge Schematics, Tri-Axis Telescope, Forge Anvil, Bridge Workbench, Heartbeat Console, Server Racks, Code Orchard, and portal markers
|
||||
- The object count exceeds the issue minimum and covers the named room themes
|
||||
|
||||
4. Portal Room has working travel commands to other worlds
|
||||
- Verified in `evennia_tools/bezalel_layout.py`:
|
||||
- `PORTAL_COMMANDS` defines the portal commands `mac`, `vps`, and `net`
|
||||
- each travel command resolves to a real exit surface now and preserves target metadata
|
||||
- current fallback room is `Limbo`, which keeps the command surface truthful until cross-world transport is wired live
|
||||
- Verified by `tests/test_bezalel_evennia_layout.py::test_items_characters_and_portal_commands_are_all_defined`
|
||||
|
||||
5. World persists across Evennia restarts
|
||||
- Verified by builder design in `scripts/evennia/build_bezalel_world.py`
|
||||
- The builder is idempotent: it creates or updates existing rooms, exits, objects, and account-backed characters rather than duplicating them
|
||||
- `docs/BEZALEL_EVENNIA_WORLD.md` explicitly documents this persistence note
|
||||
|
||||
6. Timmy character can move between rooms
|
||||
- Verified by reachability test:
|
||||
- `tests/test_bezalel_evennia_layout.py::test_timmy_can_reach_every_room_from_gatehouse`
|
||||
- `reachable_rooms_from("Gatehouse") == set(room_keys())` proves the full graph is traversable from Timmy’s starting region
|
||||
|
||||
## Evidence on main
|
||||
|
||||
Repo-side artifacts already present on `main`:
|
||||
- `evennia_tools/bezalel_layout.py`
|
||||
- `scripts/evennia/build_bezalel_world.py`
|
||||
- `evennia_tools/build_bezalel_world.py`
|
||||
- `evennia_tools/batch_cmds_bezalel.ev`
|
||||
- `docs/BEZALEL_EVENNIA_WORLD.md`
|
||||
- `tests/test_bezalel_evennia_layout.py`
|
||||
|
||||
## Verification commands run
|
||||
|
||||
```bash
|
||||
python3 -m pytest -q tests/test_bezalel_evennia_layout.py
|
||||
python3 -m py_compile evennia_tools/bezalel_layout.py scripts/evennia/build_bezalel_world.py tests/test_bezalel_evennia_layout.py
|
||||
python3 scripts/evennia/build_bezalel_world.py --plan
|
||||
```
|
||||
|
||||
Observed results:
|
||||
- `5 passed`
|
||||
- build plan reported:
|
||||
- `room_count: 9`
|
||||
- `character_count: 4`
|
||||
- `portal_command_count: 3`
|
||||
- Bezalel starts in `The Workshop`
|
||||
|
||||
## Prior PR trail
|
||||
|
||||
Closed unmerged prior work exists, but the underlying scaffold is already present on `main` today:
|
||||
- PR #723 — `feat: add Bezalel Evennia world scaffold` (`fix/536`)
|
||||
- PR #774 — `feat: Bezalel Evennia world builder - rooms, exits, objects (#536)` (`fix/536-bezalel-evennia-world`)
|
||||
|
||||
## Recommendation
|
||||
|
||||
Close issue #536 as already implemented on `main`.
|
||||
65
specs/math-review-gate.md
Normal file
65
specs/math-review-gate.md
Normal file
@@ -0,0 +1,65 @@
|
||||
# MATH-006: Independent Math Review Gate
|
||||
*Prevents Timmy from publicly claiming mathematical novelty before human/formal verification.*
|
||||
|
||||
## Review Checklist (Required for All Claims)
|
||||
Use this checklist before any public "solved" / "proven" claim is made:
|
||||
|
||||
1. **Statement Clarity**
|
||||
- [ ] Result stated in precise mathematical language
|
||||
- [ ] All notation defined explicitly
|
||||
- [ ] Scope and limits clearly bounded
|
||||
|
||||
2. **Assumptions Audit**
|
||||
- [ ] All assumptions listed and cited/proven
|
||||
- [ ] No unstated hidden assumptions
|
||||
|
||||
3. **Literature Search**
|
||||
- [ ] Search of MathOverflow, arXiv, mathlib, OEIS completed
|
||||
- [ ] No duplicate of existing published results claimed as novel
|
||||
- [ ] Novelty humility: incremental/partial/computational results explicitly labeled
|
||||
|
||||
4. **Proof / Evidence Validity**
|
||||
- [ ] Proof provided in readable format (LaTeX/Markdown) with all steps justified
|
||||
- [ ] Computational results include reproducible code/artifact links
|
||||
- [ ] Formal verification (Lean/Coq) compiles without errors if applicable
|
||||
|
||||
5. **Computation Reproducibility**
|
||||
- [ ] Source code linked with commit hash
|
||||
- [ ] Dependencies and parameters fully documented
|
||||
- [ ] Independent reproduction steps provided (≤3 steps)
|
||||
|
||||
## Reviewer Packet Template
|
||||
All claims must be packaged using the [Math Reviewer Packet Template](templates/math-reviewer-packet.md) before submission to any review channel.
|
||||
|
||||
## Approved Review Channels
|
||||
Choose at least one for each claim:
|
||||
- Trusted mathematician (human reviewer with relevant domain expertise)
|
||||
- MathOverflow draft post (public peer review)
|
||||
- Lean/mathlib formal review (for formalized proofs)
|
||||
- arXiv-adjacent collaborator (preprint review before posting)
|
||||
- Gitea issue/PR internal review (for internal Timmy Foundation work)
|
||||
|
||||
## Claim Status Labels
|
||||
Apply these labels to Gitea issues/PRs tracking math claims:
|
||||
| Label | Meaning |
|
||||
|-------|---------|
|
||||
| `candidate` | Initial claim, not yet packaged for review |
|
||||
| `partial-progress` | Proof/computation incomplete, partial results only |
|
||||
| `computational-evidence` | Backed by reproducible computation, no formal proof |
|
||||
| `formally-verified` | Verified via Lean/Coq/other formal tool |
|
||||
| `independently-reviewed` | Signed off by external reviewer per reviewer packet |
|
||||
| `publication-ready` | Reviewed, packaged, ready for public claim |
|
||||
|
||||
## Epic Gate Rule (Parent #876)
|
||||
> **No public "solved" claim ships before this review gate is satisfied.**
|
||||
> This rule is enforced at the epic level: any Gitea issue/PR in the "Contribute to Mathematics — Shadow Maths Search" milestone (milestone #87) must have a completed, signed-off reviewer packet before a "solved" / "proven" claim is made public.
|
||||
|
||||
## Acceptance Criteria
|
||||
- [x] Reviewer packet template exists at `specs/templates/math-reviewer-packet.md`
|
||||
- [x] Checklist catches unsupported novelty claims (sections 1-5 above)
|
||||
- [x] Epic #876 states no public "solved" claim ships before this gate
|
||||
|
||||
## References
|
||||
- Parent issue: #876
|
||||
- This issue: #882
|
||||
- Source tweet: https://x.com/rockachopa/status/2048170592759652597
|
||||
60
specs/templates/math-reviewer-packet.md
Normal file
60
specs/templates/math-reviewer-packet.md
Normal file
@@ -0,0 +1,60 @@
|
||||
# Math Reviewer Packet Template
|
||||
*Use this template to package any claimed mathematical result for independent review before public "solved" claims are made.*
|
||||
|
||||
## 1. Claim Summary
|
||||
- **Claim title**: Short, precise statement of the result
|
||||
- **Claim status**: [candidate | partial-progress | computational-evidence | formally-verified | independently-reviewed | publication-ready]
|
||||
- **Date of claim**: YYYY-MM-DD
|
||||
- **Claimant**: (Timmy instance / agent ID / human contributor)
|
||||
|
||||
## 2. Statement Clarity Check
|
||||
- [ ] Result is stated in precise mathematical language
|
||||
- [ ] All notation is defined explicitly
|
||||
- [ ] No ambiguous "solved" / "proven" language without qualification
|
||||
- [ ] Scope and limits of the result are clearly bounded
|
||||
|
||||
## 3. Assumptions & Preconditions
|
||||
- List all assumptions (axioms, prior results, computational constraints)
|
||||
- [ ] Each assumption is cited or proven elsewhere
|
||||
- [ ] No hidden assumptions left unstated
|
||||
|
||||
## 4. Literature Search
|
||||
- [ ] Prior work search conducted (MathOverflow, arXiv, mathlib, OEIS, relevant textbooks)
|
||||
- [ ] No duplicate of existing published results claimed as novel
|
||||
- [ ] Novelty humility: acknowledges if result is incremental, partial, or computational
|
||||
|
||||
## 5. Proof / Evidence Validity
|
||||
### For Proof-Based Results
|
||||
- [ ] Full proof provided in machine-readable format (LaTeX / Markdown)
|
||||
- [ ] Each step is logically justified
|
||||
- [ ] No gaps longer than 2 sentences without explicit citation or lemma
|
||||
|
||||
### For Computational Results
|
||||
- [ ] Code/artifact link provided (reproducible environment)
|
||||
- [ ] Random seeds / parameters fully documented
|
||||
- [ ] Output verified by independent script (if applicable)
|
||||
|
||||
### For Formal Verification
|
||||
- [ ] Lean / Coq / other formal proof assistant file linked
|
||||
- [ ] Compiles without errors on standard toolchain
|
||||
|
||||
## 6. Reproducibility Package
|
||||
- [ ] All source code used is linked (repo commit hash / Gitea issue/PR reference)
|
||||
- [ ] Dependencies listed with versions
|
||||
- [ ] Minimal reproduction steps provided (3 steps or fewer)
|
||||
|
||||
## 7. Review Channel & Sign-off
|
||||
- **Selected review channel**: (trusted mathematician / MathOverflow draft / Lean/mathlib review / arXiv-adjacent collaborator / other)
|
||||
- **Reviewer identity**: (handle / name / affiliation)
|
||||
- **Review date**: YYYY-MM-DD
|
||||
- **Review outcome**: [APPROVED | REVISION REQUIRED | REJECTED]
|
||||
- **Reviewer notes**: (free text)
|
||||
|
||||
## 8. Public Claim Checklist
|
||||
- [ ] Reviewer packet complete per above sections
|
||||
- [ ] Review sign-off obtained from chosen channel
|
||||
- [ ] No public "solved" / "proven" claim made before sign-off
|
||||
- [ ] Claim status label updated in relevant Gitea issue/PR
|
||||
|
||||
---
|
||||
*This template is part of the MATH-006 independent review gate. No public novelty claim ships without a completed, signed-off packet.*
|
||||
@@ -1,19 +0,0 @@
|
||||
from pathlib import Path
|
||||
|
||||
ROOT = Path(__file__).resolve().parents[1]
|
||||
DOC = ROOT / "docs" / "issue-536-verification.md"
|
||||
|
||||
|
||||
def test_issue_536_verification_doc_exists_and_points_to_real_artifacts() -> None:
|
||||
assert DOC.exists(), "missing docs/issue-536-verification.md"
|
||||
text = DOC.read_text(encoding="utf-8")
|
||||
for snippet in (
|
||||
"# Issue #536 Verification",
|
||||
"evennia_tools/bezalel_layout.py",
|
||||
"scripts/evennia/build_bezalel_world.py",
|
||||
"tests/test_bezalel_evennia_layout.py",
|
||||
"docs/BEZALEL_EVENNIA_WORLD.md",
|
||||
"portal commands",
|
||||
"already implemented on `main`",
|
||||
):
|
||||
assert snippet in text
|
||||
Reference in New Issue
Block a user