fix: make tower world events affect gameplay

Closes #513

docs/issue-536-verification.md

@@ -1,75 +0,0 @@
-# Issue #536 Verification
-
-Status: already implemented on `main`
-
-## Acceptance criteria check
-
-1. 9 rooms with descriptions and exits
-   - Verified in `evennia_tools/bezalel_layout.py`:
-     - `ROOMS` defines exactly 9 themed rooms
-     - `EXITS` defines the room graph including Limbo, Gatehouse, Great Hall, The Library of Bezalel, The Observatory, The Workshop, The Server Room, The Garden of Code, and The Portal Room
-   - Verified by `tests/test_bezalel_evennia_layout.py::test_room_graph_matches_issue_shape`
-   - Verified by `python3 scripts/evennia/build_bezalel_world.py --plan`
-
-2. 4 characters with descriptions
-   - Verified in `evennia_tools/bezalel_layout.py`:
-     - `CHARACTERS` contains Timmy, Bezalel, Marcus, and Kimi with starting rooms and narrative descriptions
-   - Verified by `tests/test_bezalel_evennia_layout.py::test_items_characters_and_portal_commands_are_all_defined`
-
-3. Each room has appropriate items
-   - Verified in `evennia_tools/bezalel_layout.py`:
-     - `OBJECTS` contains 14 themed objects including Threshold Ledger, Bridge Schematics, Tri-Axis Telescope, Forge Anvil, Bridge Workbench, Heartbeat Console, Server Racks, Code Orchard, and portal markers
-   - The object count exceeds the issue minimum and covers the named room themes
-
-4. Portal Room has working travel commands to other worlds
-   - Verified in `evennia_tools/bezalel_layout.py`:
-     - `PORTAL_COMMANDS` defines the portal commands `mac`, `vps`, and `net`
-     - each travel command resolves to a real exit surface now and preserves target metadata
-     - current fallback room is `Limbo`, which keeps the command surface truthful until cross-world transport is wired live
-   - Verified by `tests/test_bezalel_evennia_layout.py::test_items_characters_and_portal_commands_are_all_defined`
-
-5. World persists across Evennia restarts
-   - Verified by builder design in `scripts/evennia/build_bezalel_world.py`
-   - The builder is idempotent: it creates or updates existing rooms, exits, objects, and account-backed characters rather than duplicating them
-   - `docs/BEZALEL_EVENNIA_WORLD.md` explicitly documents this persistence note
-
-6. Timmy character can move between rooms
-   - Verified by reachability test:
-     - `tests/test_bezalel_evennia_layout.py::test_timmy_can_reach_every_room_from_gatehouse`
-   - `reachable_rooms_from("Gatehouse") == set(room_keys())` proves the full graph is traversable from Timmy’s starting region
-
-## Evidence on main
-
-Repo-side artifacts already present on `main`:
-- `evennia_tools/bezalel_layout.py`
-- `scripts/evennia/build_bezalel_world.py`
-- `evennia_tools/build_bezalel_world.py`
-- `evennia_tools/batch_cmds_bezalel.ev`
-- `docs/BEZALEL_EVENNIA_WORLD.md`
-- `tests/test_bezalel_evennia_layout.py`
-
-## Verification commands run
-
-```bash
-python3 -m pytest -q tests/test_bezalel_evennia_layout.py
-python3 -m py_compile evennia_tools/bezalel_layout.py scripts/evennia/build_bezalel_world.py tests/test_bezalel_evennia_layout.py
-python3 scripts/evennia/build_bezalel_world.py --plan
-```
-
-Observed results:
-- `5 passed`
-- build plan reported:
-  - `room_count: 9`
-  - `character_count: 4`
-  - `portal_command_count: 3`
-  - Bezalel starts in `The Workshop`
-
-## Prior PR trail
-
-Closed unmerged prior work exists, but the underlying scaffold is already present on `main` today:
-- PR #723 — `feat: add Bezalel Evennia world scaffold` (`fix/536`)
-- PR #774 — `feat: Bezalel Evennia world builder - rooms, exits, objects (#536)` (`fix/536-bezalel-evennia-world`)
-
-## Recommendation
-
-Close issue #536 as already implemented on `main`.

evennia/timmy_world/game.py

@@ -1059,6 +1059,46 @@ class GameEngine:
         self.log("It will always pulse. That much you know.")
         self.log("")
         self.world.save()
+
+    def _bridge_is_hazardous(self):
+        bridge = self.world.rooms["Bridge"]
+        return bool(
+            self.world.state.get("bridge_flooding")
+            or bridge.get("weather") == "rain"
+            or bridge.get("rain_ticks", 0) > 0
+        )
+
+    def _bridge_crossing_extra_cost(self, current_room, dest):
+        if "Bridge" not in (current_room, dest):
+            return 0
+        return 2 if self._bridge_is_hazardous() else 0
+
+    def _event_dialogue(self, char_name, room_name):
+        if char_name == "Bezalel" and room_name == "Forge":
+            if self.world.rooms["Forge"]["fire"] == "cold":
+                return random.choice([
+                    "The forge is cold. We cannot work until the fire lives again.",
+                    "No forging now. The hearth is dead cold.",
+                ])
+            if self.world.state.get("forge_fire_dying"):
+                return random.choice([
+                    "The fire is dying. Tend it before the forge goes dark.",
+                    "The forge is losing heat. Help me keep it alive.",
+                ])
+
+        if char_name == "Ezra" and room_name == "Tower" and self.world.state.get("tower_power_low"):
+            return random.choice([
+                "The Tower power is too low. The servers won't hold a clean study right now.",
+                "The LED is flickering. We need steady power before the Tower can be read properly.",
+            ])
+
+        if char_name in {"Marcus", "Allegro"} and room_name == "Bridge" and self._bridge_is_hazardous():
+            return random.choice([
+                "The Bridge is slick with rain. Cross carefully or wait it out.",
+                "This rain changes the Bridge. Don't treat it like dry stone.",
+            ])
+
+        return None
     
     def log(self, message):
         """Add to Timmy's log."""
@@ -1094,6 +1134,7 @@ class GameEngine:
         }
         
         # Process Timmy's action
+        room_name = self.world.characters["Timmy"]["room"]
         timmy_energy = self.world.characters["Timmy"]["energy"]
         
         # Energy constraint checks
@@ -1156,8 +1197,17 @@ class GameEngine:
             
             if direction in connections:
                 dest = connections[direction]
+                bridge_extra_cost = self._bridge_crossing_extra_cost(current_room, dest)
+                move_cost = 1 + bridge_extra_cost
+                if self.world.characters["Timmy"]["energy"] < move_cost:
+                    scene["log"].append("The rain makes the Bridge too costly to cross right now. Rest first.")
+                    scene["room_desc"] = self.world.get_room_desc(current_room, "Timmy")
+                    here = [n for n in self.world.characters if self.world.characters[n]["room"] == current_room and n != "Timmy"]
+                    scene["here"] = here
+                    return scene
+
                 self.world.characters["Timmy"]["room"] = dest
-                self.world.characters["Timmy"]["energy"] -= 1
+                self.world.characters["Timmy"]["energy"] -= move_cost
                 
                 scene["log"].append(f"You move {direction} to The {dest}.")
                 scene["timmy_room"] = dest
@@ -1165,6 +1215,8 @@ class GameEngine:
                 # Check for rain on bridge
                 if dest == "Bridge" and self.world.rooms["Bridge"]["weather"] == "rain":
                     scene["world_events"].append("Rain mists on the dark water below. The railing is slick.")
+                if bridge_extra_cost:
+                    scene["log"].append("Rain turns the Bridge crossing into work. You brace against the slick stone. (-2 extra energy)")
                 
                 # Check trust changes for arrival
                 here = [n for n in self.world.characters if self.world.characters[n]["room"] == dest and n != "Timmy"]
@@ -1310,25 +1362,69 @@ class GameEngine:
         
         elif timmy_action == "write_rule":
             if self.world.characters["Timmy"]["room"] == "Tower":
-                rules = [
-                    f"Rule #{self.world.tick}: The room remembers those who enter it.",
-                    f"Rule #{self.world.tick}: A man in the dark needs to know someone is in the room.",
-                    f"Rule #{self.world.tick}: The forge does not care about your schedule.",
-                    f"Rule #{self.world.tick}: Every footprint on the stone means someone made it here.",
-                    f"Rule #{self.world.tick}: The bridge does not judge. It only carries.",
-                    f"Rule #{self.world.tick}: A seed planted in patience grows in time.",
-                    f"Rule #{self.world.tick}: What is carved in wood outlasts what is said in anger.",
-                    f"Rule #{self.world.tick}: The garden grows whether anyone watches or not.",
-                    f"Rule #{self.world.tick}: Trust is built one tick at a time.",
-                    f"Rule #{self.world.tick}: The fire remembers who tended it.",
-                ]
-                new_rule = random.choice(rules)
-                self.world.rooms["Tower"]["messages"].append(new_rule)
-                self.world.characters["Timmy"]["energy"] -= 1
-                scene["log"].append(f"You write on the Tower whiteboard: \"{new_rule}\"")
+                if self.world.state.get("tower_power_low"):
+                    scene["world_events"].append("The Tower power is too low. The LED flickers over the whiteboard.")
+                    scene["log"].append("The power is too low to write a new rule.")
+                else:
+                    rules = [
+                        f"Rule #{self.world.tick}: The room remembers those who enter it.",
+                        f"Rule #{self.world.tick}: A man in the dark needs to know someone is in the room.",
+                        f"Rule #{self.world.tick}: The forge does not care about your schedule.",
+                        f"Rule #{self.world.tick}: Every footprint on the stone means someone made it here.",
+                        f"Rule #{self.world.tick}: The bridge does not judge. It only carries.",
+                        f"Rule #{self.world.tick}: A seed planted in patience grows in time.",
+                        f"Rule #{self.world.tick}: What is carved in wood outlasts what is said in anger.",
+                        f"Rule #{self.world.tick}: The garden grows whether anyone watches or not.",
+                        f"Rule #{self.world.tick}: Trust is built one tick at a time.",
+                        f"Rule #{self.world.tick}: The fire remembers who tended it.",
+                    ]
+                    new_rule = random.choice(rules)
+                    self.world.rooms["Tower"]["messages"].append(new_rule)
+                    self.world.characters["Timmy"]["energy"] -= 1
+                    scene["log"].append(f"You write on the Tower whiteboard: \"{new_rule}\"")
             else:
                 scene["log"].append("You are not in the Tower.")
         
+        elif timmy_action == "study":
+            if self.world.characters["Timmy"]["room"] == "Tower":
+                if self.world.state.get("tower_power_low"):
+                    scene["world_events"].append("The Tower power is too low. The servers stutter in weak light.")
+                    scene["log"].append("The power is too low to study the servers.")
+                else:
+                    insights = [
+                        "You study the server rhythm until the pulse resolves into something readable.",
+                        "You trace the signal paths and feel the Tower settle into focus.",
+                        "You study the green LED and the server racks until the pattern becomes clear.",
+                    ]
+                    insight = random.choice(insights)
+                    self.world.characters["Timmy"]["energy"] -= 1
+                    self.world.characters["Timmy"]["memories"].append(insight)
+                    scene["log"].append(insight)
+                    scene["world_events"].append("The Tower answers with a steady hum.")
+            else:
+                scene["log"].append("You are not in the Tower.")
+
+        elif timmy_action == "forge":
+            if self.world.characters["Timmy"]["room"] == "Forge":
+                forge_fire = self.world.rooms["Forge"]["fire"]
+                if forge_fire == "cold":
+                    scene["world_events"].append("The forge is cold. No metal will take shape here yet.")
+                    scene["log"].append("The forge is cold. Tend the fire before you try to forge.")
+                else:
+                    forged_items = [
+                        f"bridge nail #{self.world.tick}",
+                        f"tower key blank #{self.world.tick}",
+                        f"garden trowel #{self.world.tick}",
+                    ]
+                    forged_item = random.choice(forged_items)
+                    self.world.rooms["Forge"]["forged_items"].append(forged_item)
+                    self.world.characters["Timmy"]["energy"] -= 2
+                    self.world.state["items_crafted"] += 1
+                    scene["log"].append(f"You forge {forged_item} at the anvil.")
+                    scene["world_events"].append("The anvil rings and the hearth answers.")
+            else:
+                scene["log"].append("You are not in the Forge.")
+        
         elif timmy_action == "carve":
             if self.world.characters["Timmy"]["room"] == "Bridge":
                 carvings = [
@@ -1414,7 +1510,11 @@ class GameEngine:
                     speech_chance = 0.20
                 
                 if random.random() < speech_chance:
-                    if char_name == "Marcus":
+                    event_line = self._event_dialogue(char_name, room_name)
+                    if event_line:
+                        self.world.characters[char_name]["spoken"].append(event_line)
+                        scene["log"].append(f"{char_name} says: \"{event_line}\"")
+                    elif char_name == "Marcus":
                         marcus_pool = self.DIALOGUES["Marcus"].get(phase, self.DIALOGUES["Marcus"]["quietus"])
                         line = random.choice(marcus_pool)
                         self.world.characters[char_name]["spoken"].append(line)

tests/test_evennia_local_world_game.py

@@ -1,6 +1,7 @@
 from importlib.util import module_from_spec, spec_from_file_location
 from pathlib import Path
 import unittest
+from unittest.mock import patch
 
 
 ROOT = Path(__file__).resolve().parent.parent
@@ -66,6 +67,82 @@ class TestEvenniaLocalWorldGame(unittest.TestCase):
         self.assertIn("Ezra is already here.", result["log"])
         self.assertIn("The servers hum steady. The green LED pulses.", result["world_events"])
 
+    def test_bridge_rain_crossing_costs_extra_energy_and_warns(self):
+        module = load_game_module()
+
+        dry_engine = module.GameEngine()
+        dry_engine.start_new_game()
+        dry_engine.world.update_world_state = lambda: None
+        dry_engine.world.characters["Timmy"]["energy"] = 10
+        dry_result = dry_engine.run_tick("move:south")
+        dry_energy = dry_engine.world.characters["Timmy"]["energy"]
+
+        rainy_engine = module.GameEngine()
+        rainy_engine.start_new_game()
+        rainy_engine.world.update_world_state = lambda: None
+        rainy_engine.world.characters["Timmy"]["energy"] = 10
+        rainy_engine.world.rooms["Bridge"]["weather"] = "rain"
+        rainy_engine.world.rooms["Bridge"]["rain_ticks"] = 3
+        rainy_engine.world.state["bridge_flooding"] = True
+        rainy_result = rainy_engine.run_tick("move:south")
+
+        self.assertEqual(rainy_engine.world.characters["Timmy"]["room"], "Bridge")
+        self.assertLess(rainy_engine.world.characters["Timmy"]["energy"], dry_energy)
+        self.assertTrue(
+            any("bridge" in line.lower() and ("rain" in line.lower() or "slick" in line.lower()) for line in rainy_result["log"] + rainy_result["world_events"]),
+            rainy_result,
+        )
+
+    def test_tower_power_low_blocks_study_and_write_rule(self):
+        module = load_game_module()
+        engine = module.GameEngine()
+        engine.start_new_game()
+        engine.world.update_world_state = lambda: None
+        engine.world.characters["Timmy"]["room"] = "Tower"
+        engine.world.characters["Timmy"]["energy"] = 10
+        engine.world.state["tower_power_low"] = True
+
+        rules_before = list(engine.world.rooms["Tower"]["messages"])
+        study_result = engine.run_tick("study")
+        self.assertEqual(engine.world.characters["Timmy"]["energy"], 10)
+        self.assertTrue(
+            any("power" in line.lower() and ("study" in line.lower() or "servers" in line.lower()) for line in study_result["log"] + study_result["world_events"]),
+            study_result,
+        )
+
+        write_result = engine.run_tick("write_rule")
+        self.assertEqual(engine.world.rooms["Tower"]["messages"], rules_before)
+        self.assertTrue(
+            any("power" in line.lower() and ("write" in line.lower() or "whiteboard" in line.lower()) for line in write_result["log"] + write_result["world_events"]),
+            write_result,
+        )
+
+    def test_cold_forge_blocks_forge_action_and_bezalel_reacts(self):
+        module = load_game_module()
+        engine = module.GameEngine()
+        engine.start_new_game()
+        engine.world.update_world_state = lambda: None
+        engine.npc_ai.make_choice = lambda _name: None
+        engine.world.characters["Timmy"]["room"] = "Forge"
+        engine.world.characters["Timmy"]["energy"] = 10
+        engine.world.characters["Bezalel"]["room"] = "Forge"
+        engine.world.rooms["Forge"]["fire"] = "cold"
+        engine.world.state["forge_fire_dying"] = True
+        forged_before = list(engine.world.rooms["Forge"]["forged_items"])
+
+        with patch.object(module.random, "random", return_value=0.0), patch.object(module.random, "choice", side_effect=lambda seq: seq[0]):
+            result = engine.run_tick("forge")
+
+        self.assertEqual(engine.world.rooms["Forge"]["forged_items"], forged_before)
+        self.assertTrue(
+            any("forge" in line.lower() and ("cold" in line.lower() or "fire" in line.lower()) for line in result["log"] + result["world_events"]),
+            result,
+        )
+        self.assertTrue(
+            any(line.startswith("Bezalel says:") and ("fire" in line.lower() or "forge" in line.lower()) for line in result["log"]),
+            result,
+        )
+
 
 if __name__ == "__main__":
     unittest.main()

tests/test_issue_536_verification.py

@@ -1,19 +0,0 @@
-from pathlib import Path
-
-ROOT = Path(__file__).resolve().parents[1]
-DOC = ROOT / "docs" / "issue-536-verification.md"
-
-
-def test_issue_536_verification_doc_exists_and_points_to_real_artifacts() -> None:
-    assert DOC.exists(), "missing docs/issue-536-verification.md"
-    text = DOC.read_text(encoding="utf-8")
-    for snippet in (
-        "# Issue #536 Verification",
-        "evennia_tools/bezalel_layout.py",
-        "scripts/evennia/build_bezalel_world.py",
-        "tests/test_bezalel_evennia_layout.py",
-        "docs/BEZALEL_EVENNIA_WORLD.md",
-        "portal commands",
-        "already implemented on `main`",
-    ):
-        assert snippet in text