Compare commits

..

2 Commits

Author SHA1 Message Date
Alexander Whitestone
a091a5c9bf fix: give tower NPC room movement purposeful goals (#517)
Some checks failed
Self-Healing Smoke / self-healing-smoke (pull_request) Failing after 26s
Smoke Test / smoke (pull_request) Failing after 27s
Agent PR Gate / gate (pull_request) Failing after 37s
Agent PR Gate / report (pull_request) Successful in 8s
2026-04-22 11:51:47 -04:00
Alexander Whitestone
4afde6da78 test: add tower NPC movement acceptance coverage (#517) 2026-04-22 11:47:21 -04:00
12 changed files with 209 additions and 342 deletions

View File

@@ -1,22 +0,0 @@
---
# ansible/playbooks/deploy_mempalace.yml — Deploy MemPalace v3.0.0 to fleet wizards.
#
# Usage:
# ansible-playbook -i inventory/hosts.ini playbooks/deploy_mempalace.yml --limit ezra
# ansible-playbook -i inventory/hosts.ini playbooks/deploy_mempalace.yml
#
# Refs: Issue #570
- name: Deploy MemPalace v3.0.0 to wizard hosts
hosts: fleet
become: false
gather_facts: false
vars:
mempalace_hermes_home: "{{ ansible_env.HOME }}/.hermes"
mempalace_sessions_dir: "{{ mempalace_hermes_home }}/sessions"
mempalace_palace_path: "{{ ansible_env.HOME }}/.mempalace/palace"
mempalace_wing: "{{ inventory_hostname }}_home"
roles:
- role: ../roles/mempalace
vars:
mempalace_venv_path: "{{ ansible_env.HOME }}/.mempalace-venv"

View File

@@ -1,16 +0,0 @@
---
# MemPalace role defaults
mempalace_package_spec: "mempalace==3.0.0"
mempalace_hermes_home: "{{ ansible_env.HOME }}/.hermes"
mempalace_sessions_dir: "{{ mempalace_hermes_home }}/sessions"
mempalace_palace_path: "{{ ansible_env.HOME }}/.mempalace/palace"
mempalace_wing: "{{ inventory_hostname }}_home"
mempalace_wakeup_dir: "{{ mempalace_hermes_home }}/wakeups"
mempalace_wakeup_file: "{{ mempalace_wakeup_dir }}/{{ mempalace_wing }}.txt"
mempalace_venv_path: "{{ ansible_env.HOME }}/.mempalace-venv"
mempalace_config_path: "{{ mempalace_hermes_home }}/mempalace.yaml"
mempalace_mcp_config_path: "{{ mempalace_hermes_home }}/hermes-mcp-mempalace.yaml"
mempalace_session_hook_path: "{{ mempalace_hermes_home }}/session-start-mempalace.sh"
mempalace_run_mining: true
mempalace_run_search_test: true
mempalace_run_wake_up: true

View File

@@ -1,2 +0,0 @@
---
dependencies: []

View File

@@ -1,119 +0,0 @@
---
# MemPalace v3.0.0 deployment role for fleet wizards.
# Refs: Issue #570
- name: Ensure mempalace venv directory exists
ansible.builtin.file:
path: "{{ mempalace_venv_path }}"
state: directory
mode: '0750'
- name: Create mempalace virtual environment
ansible.builtin.command:
cmd: "python3 -m venv {{ mempalace_venv_path }}"
creates: "{{ mempalace_venv_path }}/bin/python"
- name: Install mempalace package
ansible.builtin.pip:
name: "{{ mempalace_package_spec }}"
virtualenv: "{{ mempalace_venv_path }}"
virtualenv_command: "{{ mempalace_venv_path }}/bin/python -m venv"
- name: Ensure Hermes home directory exists
ansible.builtin.file:
path: "{{ mempalace_hermes_home }}"
state: directory
mode: '0750'
- name: Ensure sessions directory exists
ansible.builtin.file:
path: "{{ mempalace_sessions_dir }}"
state: directory
mode: '0750'
- name: Ensure wakeup directory exists
ansible.builtin.file:
path: "{{ mempalace_wakeup_dir }}"
state: directory
mode: '0750'
- name: Ensure palace directory exists
ansible.builtin.file:
path: "{{ mempalace_palace_path }}"
state: directory
mode: '0750'
- name: Deploy mempalace.yaml configuration
ansible.builtin.template:
src: mempalace.yaml.j2
dest: "{{ mempalace_config_path }}"
mode: '0640'
- name: Deploy Hermes MCP mempalace config
ansible.builtin.template:
src: hermes-mcp-mempalace.yaml.j2
dest: "{{ mempalace_mcp_config_path }}"
mode: '0640'
- name: Deploy session-start wake-up hook
ansible.builtin.template:
src: session-start-mempalace.sh.j2
dest: "{{ mempalace_session_hook_path }}"
mode: '0750'
- name: Mine Hermes home directory
ansible.builtin.shell: |
set -euo pipefail
echo "" | {{ mempalace_venv_path }}/bin/mempalace mine {{ mempalace_hermes_home }} --config {{ mempalace_config_path }}
args:
executable: /bin/bash
when: mempalace_run_mining | bool
register: mine_home_result
changed_when: mine_home_result.rc == 0
- name: Mine session history
ansible.builtin.shell: |
set -euo pipefail
echo "" | {{ mempalace_venv_path }}/bin/mempalace mine {{ mempalace_sessions_dir }} --mode convos --config {{ mempalace_config_path }}
args:
executable: /bin/bash
when: mempalace_run_mining | bool
register: mine_sessions_result
changed_when: mine_sessions_result.rc == 0
- name: Run search test
ansible.builtin.shell: |
set -euo pipefail
{{ mempalace_venv_path }}/bin/mempalace search "common queries" --config {{ mempalace_config_path }} | head -20
args:
executable: /bin/bash
when: mempalace_run_search_test | bool
register: search_test_result
changed_when: false
- name: Generate wake-up context
ansible.builtin.shell: |
set -euo pipefail
{{ mempalace_venv_path }}/bin/mempalace wake-up --config {{ mempalace_config_path }} > {{ mempalace_wakeup_file }}
export HERMES_MEMPALACE_WAKEUP_FILE="{{ mempalace_wakeup_file }}"
printf '[MemPalace] wake-up context refreshed: %s\n' "$HERMES_MEMPALACE_WAKEUP_FILE"
args:
executable: /bin/bash
when: mempalace_run_wake_up | bool
register: wake_up_result
changed_when: wake_up_result.rc == 0
- name: Report MemPalace deployment summary
ansible.builtin.debug:
msg:
- "MemPalace deployed for {{ inventory_hostname }}"
- "Package: {{ mempalace_package_spec }}"
- "Config: {{ mempalace_config_path }}"
- "Palace: {{ mempalace_palace_path }}"
- "Wake-up: {{ mempalace_wakeup_file }}"
- "MCP config: {{ mempalace_mcp_config_path }}"
- "Session hook: {{ mempalace_session_hook_path }}"
- "Home mine: {{ 'OK' if mine_home_result.rc | default(1) == 0 else 'SKIPPED' }}"
- "Sessions mine: {{ 'OK' if mine_sessions_result.rc | default(1) == 0 else 'SKIPPED' }}"
- "Search test: {{ 'OK' if search_test_result.rc | default(1) == 0 else 'SKIPPED' }}"
- "Wake-up: {{ 'OK' if wake_up_result.rc | default(1) == 0 else 'SKIPPED' }}"

View File

@@ -1,6 +0,0 @@
mcp_servers:
mempalace:
command: "{{ mempalace_venv_path }}/bin/python"
args:
- -m
- mempalace.mcp_server

View File

@@ -1,21 +0,0 @@
wing: {{ mempalace_wing }}
palace: {{ mempalace_palace_path }}
rooms:
- name: sessions
description: Conversation history and durable agent transcripts
globs:
- "*.json"
- "*.jsonl"
- name: config
description: Hermes configuration and runtime settings
globs:
- "*.yaml"
- "*.yml"
- "*.toml"
- name: docs
description: Notes, markdown docs, and operating reports
globs:
- "*.md"
- "*.txt"
people: []
projects: []

View File

@@ -1,9 +0,0 @@
#!/usr/bin/env bash
set -euo pipefail
if command -v {{ mempalace_venv_path }}/bin/mempalace >/dev/null 2>&1; then
mkdir -p "{{ mempalace_wakeup_dir }}"
{{ mempalace_venv_path }}/bin/mempalace wake-up --config {{ mempalace_config_path }} > "{{ mempalace_wakeup_file }}"
export HERMES_MEMPALACE_WAKEUP_FILE="{{ mempalace_wakeup_file }}"
printf '[MemPalace] wake-up context refreshed: %s\n' "$HERMES_MEMPALACE_WAKEUP_FILE"
fi

View File

@@ -146,23 +146,6 @@ That bundle writes:
- `session-start-mempalace.sh`
- `issue-568-comment-template.md`
## Fleet Ansible deployment
Deploy MemPalace to Ezra (or the whole fleet) with the Ansible playbook:
```bash
ansible-playbook -i ansible/inventory/hosts.ini ansible/playbooks/deploy_mempalace.yml --limit ezra
```
This playbook:
1. Creates a dedicated venv and installs `mempalace==3.0.0`
2. Deploys `mempalace.yaml`, MCP config, and session-start hook
3. Mines the Hermes home and sessions directories
4. Runs a search smoke test
5. Generates the wake-up context file
Set `mempalace_run_mining=false` to skip mining on hosts where the corpus is already populated.
## Why this shape
- `wing: ezra_home` matches the issue's Ezra-specific integration target.

View File

@@ -454,23 +454,112 @@ class TimmyAI:
class NPCAI:
"""AI for non-player characters. They make choices based on goals."""
GOAL_ROOM_TARGETS = {
"Marcus": {
"sit": "Garden",
"speak_truth": "Threshold",
"remember": "Bridge",
},
"Bezalel": {
"forge": "Forge",
"tend_fire": "Forge",
"create_key": "Forge",
},
"Allegro": {
"oversee": "Threshold",
"keep_time": "Tower",
"check_tunnel": "Bridge",
},
"Ezra": {
"study": "Tower",
"read_whiteboard": "Tower",
"find_pattern": "Tower",
},
"Gemini": {
"observe": "Threshold",
"tend_garden": "Garden",
"listen": "Garden",
},
"Claude": {
"inspect": "Threshold",
"organize": "Tower",
"enforce_order": "Bridge",
},
"ClawCode": {
"forge": "Forge",
"test_edge": "Bridge",
"build_weapon": "Forge",
},
"Kimi": {
"contemplate": "Garden",
"read": "Tower",
"remember": "Bridge",
},
}
GOAL_CYCLES = {
"Marcus": ("sit", "speak_truth", "remember"),
"Allegro": ("oversee", "keep_time", "check_tunnel"),
"Claude": ("inspect", "organize", "enforce_order"),
"ClawCode": ("test_edge", "forge", "build_weapon"),
"Kimi": ("contemplate", "read", "remember"),
}
def __init__(self, world):
self.world = world
def _available_targets(self, available, prefix):
return [a.split(":", 1)[1] for a in available if a.startswith(f"{prefix}:")]
def _target_room_for(self, char_name, goal):
return self.GOAL_ROOM_TARGETS.get(char_name, {}).get(goal)
def _next_direction_toward(self, current_room, target_room):
if current_room == target_room:
return None
frontier = [(current_room, [])]
seen = {current_room}
while frontier:
room, path = frontier.pop(0)
if room == target_room:
return path[0] if path else None
for direction, dest in self.world.rooms[room].get("connections", {}).items():
if dest not in seen:
seen.add(dest)
frontier.append((dest, path + [direction]))
return None
def _move_toward_goal(self, room, target_room):
direction = self._next_direction_toward(room, target_room)
return f"move:{direction}" if direction else None
def _advance_goal_cycle(self, char_name, char):
cycle = self.GOAL_CYCLES.get(char_name)
if not cycle or self.world.tick <= 0:
return
goal = char.get("active_goal")
if goal not in cycle:
return
target_room = self._target_room_for(char_name, goal)
if char.get("room") != target_room:
return
if self.world.tick % 12 != 0:
return
index = cycle.index(goal)
char["active_goal"] = cycle[(index + 1) % len(cycle)]
def make_choice(self, char_name):
"""Make a choice for this NPC this tick."""
char = self.world.characters[char_name]
self._advance_goal_cycle(char_name, char)
room = char["room"]
available = ActionSystem.get_available_actions(char_name, self.world)
# If low energy, rest
if char["energy"] <= 1:
return "rest"
# Goal-driven behavior
goal = char["active_goal"]
if char_name == "Marcus":
return self._marcus_choice(char, room, available)
elif char_name == "Bezalel":
@@ -487,66 +576,96 @@ class NPCAI:
return self._clawcode_choice(char, room, available)
elif char_name == "Kimi":
return self._kimi_choice(char, room, available)
return "rest"
def _marcus_choice(self, char, room, available):
goal = char.get("active_goal", "sit")
target_room = self._target_room_for("Marcus", goal)
if room != target_room:
return self._move_toward_goal(room, target_room) or "rest"
others = self._available_targets(available, "speak")
if goal == "speak_truth" and others:
return f"speak:{random.choice(others)}"
if goal == "remember" and room == "Bridge":
return random.choice(["examine", "rest"])
if room == "Garden" and random.random() < 0.7:
return "rest"
if room != "Garden":
return "move:west"
# Speak to someone if possible
others = [a.split(":")[1] for a in available if a.startswith("speak:")]
if others and random.random() < 0.4:
return f"speak:{random.choice(others)}"
return "rest"
def _bezalel_choice(self, char, room, available):
target_room = self._target_room_for("Bezalel", char.get("active_goal", "forge"))
if room != target_room:
return self._move_toward_goal(room, target_room) or "rest"
if room == "Forge" and self.world.rooms["Forge"]["fire"] == "glowing":
return random.choice(["forge", "rest"] if char["energy"] > 2 else ["rest"])
if room != "Forge":
return "move:west"
if random.random() < 0.3:
return "tend_fire"
return "forge"
def _kimi_choice(self, char, room, available):
others = [a.split(":")[1] for a in available if a.startswith("speak:")]
goal = char.get("active_goal", "contemplate")
target_room = self._target_room_for("Kimi", goal)
if room != target_room:
return self._move_toward_goal(room, target_room) or "rest"
others = self._available_targets(available, "speak")
if goal == "read" and room == "Tower":
return "study" if char["energy"] > 2 else "rest"
if room == "Garden" and others and random.random() < 0.3:
return f"speak:{random.choice(others)}"
if room == "Tower":
return "study" if char["energy"] > 2 else "rest"
return "move:east" # Head back toward Garden
if room == "Bridge":
return random.choice(["examine", "rest"])
return "rest"
def _gemini_choice(self, char, room, available):
others = [a.split(":")[1] for a in available if a.startswith("listen:")]
if room == "Garden" and others and random.random() < 0.4:
return f"listen:{random.choice(others)}"
return random.choice(["plant", "rest"] if room == "Garden" else ["move:west"])
goal = char.get("active_goal", "observe")
target_room = self._target_room_for("Gemini", goal)
if room != target_room:
return self._move_toward_goal(room, target_room) or "rest"
listeners = self._available_targets(available, "listen")
if room == "Garden" and listeners and random.random() < 0.4:
return f"listen:{random.choice(listeners)}"
return random.choice(["plant", "rest"] if room == "Garden" else ["examine", "rest"])
def _ezra_choice(self, char, room, available):
goal = char.get("active_goal", "study")
target_room = self._target_room_for("Ezra", goal)
if room != target_room:
return self._move_toward_goal(room, target_room) or "rest"
if room == "Tower" and char["energy"] > 2:
return random.choice(["study", "write_rule", "help:Timmy"])
if room != "Tower":
return "move:south"
return "rest"
def _claude_choice(self, char, room, available):
others = [a.split(":")[1] for a in available if a.startswith("confront:")]
goal = char.get("active_goal", "inspect")
target_room = self._target_room_for("Claude", goal)
if room != target_room:
return self._move_toward_goal(room, target_room) or "rest"
others = self._available_targets(available, "confront")
if others and random.random() < 0.2:
return f"confront:{random.choice(others)}"
return random.choice(["examine", "rest"])
def _clawcode_choice(self, char, room, available):
goal = char.get("active_goal", "test_edge")
target_room = self._target_room_for("ClawCode", goal)
if room != target_room:
return self._move_toward_goal(room, target_room) or "rest"
if room == "Forge" and char["energy"] > 2:
return "forge"
return random.choice(["move:east", "forge", "rest"])
return random.choice(["examine", "rest"])
def _allegro_choice(self, char, room, available):
others = [a.split(":")[1] for a in available if a.startswith("speak:")]
goal = char.get("active_goal", "oversee")
target_room = self._target_room_for("Allegro", goal)
if room != target_room:
return self._move_toward_goal(room, target_room) or "rest"
others = self._available_targets(available, "speak")
if others and random.random() < 0.3:
return f"speak:{random.choice(others)}"
return random.choice(["move:north", "move:south", "examine"])
return random.choice(["examine", "rest"])
class DialogueSystem:

View File

@@ -1,92 +0,0 @@
from pathlib import Path
import unittest
ROOT = Path(__file__).resolve().parent.parent
ROLE_PATH = ROOT / "ansible" / "roles" / "mempalace"
PLAYBOOK_PATH = ROOT / "ansible" / "playbooks" / "deploy_mempalace.yml"
class TestMempalaceAnsibleRole(unittest.TestCase):
def test_role_directory_structure_exists(self):
self.assertTrue(ROLE_PATH.exists(), "mempalace role directory missing")
for subdir in ["tasks", "templates", "defaults", "meta"]:
self.assertTrue(
(ROLE_PATH / subdir).exists(),
f"mempalace role subdir missing: {subdir}",
)
def test_role_defaults_contains_required_variables(self):
defaults_path = ROLE_PATH / "defaults" / "main.yml"
self.assertTrue(defaults_path.exists())
text = defaults_path.read_text(encoding="utf-8")
required_vars = [
"mempalace_package_spec",
"mempalace_hermes_home",
"mempalace_sessions_dir",
"mempalace_palace_path",
"mempalace_wing",
"mempalace_wakeup_dir",
"mempalace_wakeup_file",
"mempalace_venv_path",
"mempalace_config_path",
"mempalace_mcp_config_path",
"mempalace_session_hook_path",
"mempalace_run_mining",
"mempalace_run_search_test",
"mempalace_run_wake_up",
]
for var in required_vars:
self.assertIn(var, text, f"missing default var: {var}")
def test_role_tasks_contain_required_steps(self):
tasks_path = ROLE_PATH / "tasks" / "main.yml"
self.assertTrue(tasks_path.exists())
text = tasks_path.read_text(encoding="utf-8")
required_steps = [
"Create mempalace virtual environment",
"Install mempalace package",
"Deploy mempalace.yaml configuration",
"Deploy Hermes MCP mempalace config",
"Deploy session-start wake-up hook",
"Mine Hermes home directory",
"Mine session history",
"Run search test",
"Generate wake-up context",
]
for step in required_steps:
self.assertIn(step, text, f"missing task: {step}")
def test_role_templates_are_valid(self):
yaml_template = ROLE_PATH / "templates" / "mempalace.yaml.j2"
mcp_template = ROLE_PATH / "templates" / "hermes-mcp-mempalace.yaml.j2"
hook_template = ROLE_PATH / "templates" / "session-start-mempalace.sh.j2"
self.assertTrue(yaml_template.exists())
self.assertTrue(mcp_template.exists())
self.assertTrue(hook_template.exists())
yaml_text = yaml_template.read_text(encoding="utf-8")
self.assertIn("wing: {{ mempalace_wing }}", yaml_text)
self.assertIn("palace: {{ mempalace_palace_path }}", yaml_text)
self.assertIn("rooms:", yaml_text)
mcp_text = mcp_template.read_text(encoding="utf-8")
self.assertIn("mcp_servers:", mcp_text)
self.assertIn("mempalace:", mcp_text)
self.assertIn("mempalace.mcp_server", mcp_text)
hook_text = hook_template.read_text(encoding="utf-8")
self.assertIn("mempalace wake-up", hook_text)
self.assertIn("HERMES_MEMPALACE_WAKEUP_FILE", hook_text)
def test_playbook_exists_and_targets_fleet(self):
self.assertTrue(PLAYBOOK_PATH.exists(), "deploy_mempalace.yml playbook missing")
text = PLAYBOOK_PATH.read_text(encoding="utf-8")
self.assertIn("hosts: fleet", text)
self.assertIn("../roles/mempalace", text)
self.assertIn("mempalace_venv_path", text)
if __name__ == "__main__":
unittest.main()

View File

@@ -85,8 +85,6 @@ class TestMempalaceEzraIntegration(unittest.TestCase):
"mcp_servers:",
"HERMES_MEMPALACE_WAKEUP_FILE",
"Metrics reply for #568",
"Fleet Ansible deployment",
"ansible-playbook",
]
for snippet in required:
self.assertIn(snippet, text)

View File

@@ -0,0 +1,54 @@
from importlib.util import module_from_spec, spec_from_file_location
from pathlib import Path
ROOT = Path(__file__).resolve().parent.parent
GAME_PATH = ROOT / "evennia" / "timmy_world" / "world" / "game.py"
def load_game_module():
spec = spec_from_file_location("tower_world_game", GAME_PATH)
module = module_from_spec(spec)
assert spec.loader is not None
spec.loader.exec_module(module)
module.random.seed(0)
return module
def _visitor_sets_after_ticks(module, ticks=100):
engine = module.GameEngine()
engine.start_new_game()
visitors = {room: set() for room in engine.world.rooms}
for _ in range(ticks):
engine.run_tick("rest")
for name, char in engine.world.characters.items():
if name == "Timmy":
continue
visitors[char["room"]].add(name)
return visitors
class TestTowerGameNpcPurpose:
def test_goal_driven_room_targets(self):
module = load_game_module()
world = module.World()
npc_ai = module.NPCAI(world)
world.characters["Marcus"]["room"] = "Threshold"
world.characters["Marcus"]["active_goal"] = "sit"
assert npc_ai.make_choice("Marcus") == "move:east"
world.characters["Ezra"]["room"] = "Threshold"
world.characters["Ezra"]["active_goal"] = "study"
assert npc_ai.make_choice("Ezra") == "move:north"
world.characters["Claude"]["room"] = "Threshold"
world.characters["Claude"]["active_goal"] = "enforce_order"
assert npc_ai.make_choice("Claude") == "move:south"
def test_every_room_gets_multiple_npc_visitors_over_100_ticks(self):
module = load_game_module()
visitors = _visitor_sets_after_ticks(module, ticks=100)
assert all(len(names) >= 2 for names in visitors.values()), visitors
assert len(visitors["Bridge"]) >= 3, visitors["Bridge"]